velocity-python 0.1.113__tar.gz → 0.1.114__tar.gz

{velocity_python-0.1.113/src/velocity_python.egg-info → velocity_python-0.1.114}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: velocity-python
-Version: 0.1.113
+Version: 0.1.114
 Summary: A rapid application development library for interfacing with data storage
 Author-email: Velocity Team <info@codeclubs.org>
 License-Expression: MIT

{velocity_python-0.1.113 → velocity_python-0.1.114}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "velocity-python"
-version = "0.1.113"
+version = "0.1.114"
 authors = [
   { name="Velocity Team", email="info@codeclubs.org" },
 ]

{velocity_python-0.1.113 → velocity_python-0.1.114}/src/velocity/__init__.py

@@ -1,4 +1,4 @@
-__version__ = version = "0.1.113"
+__version__ = version = "0.1.114"
 
 import importlib as _importlib
 

{velocity_python-0.1.113 → velocity_python-0.1.114}/src/velocity/db/core/result.py

@@ -81,10 +81,19 @@ class Result:
         if self._first_row_fetched or not self._cursor:
             return
 
-        # Don't try to fetch from INSERT/UPDATE/DELETE operations
-        # These operations don't return rows, only rowcount
-        if self.__sql and self.__sql.strip().upper().startswith(
-            ("INSERT", "UPDATE", "DELETE", "TRUNCATE")
+        # A write returns rows exactly when the driver describes a result set:
+        # INSERT/UPDATE/DELETE ... RETURNING (PostgreSQL), OUTPUT (SQL Server).
+        # Judging by the verb alone marked EVERY write as row-less, so
+        # `UPDATE ... RETURNING sys_id` silently reported nothing — a claim taken
+        # that way looked refused forever (tenspace.gmail, 2026-09-17). A write
+        # with no described columns has only a rowcount, and fetchone() on it
+        # raises on most drivers, so that case is still short-circuited.
+        if (
+            self.__sql
+            and self.__sql.strip()
+            .upper()
+            .startswith(("INSERT", "UPDATE", "DELETE", "TRUNCATE"))
+            and not self._headers
         ):
             self._exhausted = True
             self._first_row_fetched = True

{velocity_python-0.1.113 → velocity_python-0.1.114/src/velocity_python.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: velocity-python
-Version: 0.1.113
+Version: 0.1.114
 Summary: A rapid application development library for interfacing with data storage
 Author-email: Velocity Team <info@codeclubs.org>
 License-Expression: MIT

{velocity_python-0.1.113 → velocity_python-0.1.114}/src/velocity_python.egg-info/SOURCES.txt

@@ -273,6 +273,7 @@ tests/test_query_missing_table_unlocked.py
 tests/test_read_cache.py
 tests/test_response.py
 tests/test_restricted_direct_tables.py
+tests/test_result_returning.py
 tests/test_retry_side_effect_guard.py
 tests/test_return_default_safety.py
 tests/test_row_batch_update.py

velocity_python-0.1.114/tests/test_result_returning.py

@@ -0,0 +1,70 @@
+"""A write that describes a result set (INSERT/UPDATE/DELETE ... RETURNING)
+yields its rows through Result; a write without one is row-less and its
+cursor is never fetched; SELECT is unchanged.
+
+Regression: Result used to mark every statement starting with a write verb
+as exhausted, so `UPDATE ... RETURNING sys_id` reported no rows and a claim
+taken that way looked refused forever."""
+
+from velocity.db.core.result import Result
+
+
+class FakeCursor:
+    def __init__(self, description, rows):
+        self.description = description
+        self._rows = list(rows)
+        self.fetches = 0
+
+    def fetchone(self):
+        self.fetches += 1
+        return self._rows.pop(0) if self._rows else None
+
+
+class NoResultSetCursor(FakeCursor):
+    """What a driver does after a write without RETURNING."""
+
+    def __init__(self):
+        super().__init__(None, [])
+
+    def fetchone(self):
+        self.fetches += 1
+        raise RuntimeError("the last operation didn't produce a result")
+
+
+UPDATE_RETURNING = (
+    "update gmail_account set sync_claimed_at = %s where sys_id = %s returning sys_id"
+)
+
+
+def test_update_returning_yields_its_rows():
+    result = Result(FakeCursor([("sys_id",)], [(7,)]), None, UPDATE_RETURNING, [])
+    assert bool(result) is True
+    assert list(result.as_dict()) == [{"sys_id": 7}]
+
+
+def test_update_returning_nothing_is_empty():
+    result = Result(FakeCursor([("sys_id",)], []), None, UPDATE_RETURNING, [])
+    assert bool(result) is False
+    assert list(result.as_dict()) == []
+
+
+def test_insert_and_delete_returning_too():
+    for sql in (
+        "INSERT INTO t (a) VALUES (%s) RETURNING sys_id, a",
+        "  delete from t where a = %s returning sys_id, a",
+    ):
+        result = Result(FakeCursor([("sys_id",), ("a",)], [(1, "x"), (2, "y")]), None, sql, [])
+        assert result.as_dict().all() == [{"sys_id": 1, "a": "x"}, {"sys_id": 2, "a": "y"}]
+
+
+def test_write_without_a_result_set_is_rowless_and_never_fetched():
+    cursor = NoResultSetCursor()
+    result = Result(cursor, None, "UPDATE t SET a = %s WHERE sys_id = %s", [])
+    assert bool(result) is False
+    assert list(result) == []
+    assert cursor.fetches == 0  # fetchone() would raise on a real driver
+
+
+def test_select_is_unchanged():
+    result = Result(FakeCursor([("a",)], [(1,), (2,)]), None, "select a from t", [])
+    assert [row["a"] for row in result.as_dict()] == [1, 2]