vellum-workflow-server 1.7.0__tar.gz → 1.7.0.post2__tar.gz

{vellum_workflow_server-1.7.0 → vellum_workflow_server-1.7.0.post2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: vellum-workflow-server
-Version: 1.7.0
+Version: 1.7.0.post2
 Summary: 
 License: AGPL
 Requires-Python: >=3.9.0,<4

{vellum_workflow_server-1.7.0 → vellum_workflow_server-1.7.0.post2}/pyproject.toml

@@ -3,7 +3,7 @@ name = "vellum-workflow-server"
 
 [tool.poetry]
 name = "vellum-workflow-server"
-version = "1.7.0"
+version = "1.7.0.post2"
 description = ""
 readme = "README.md"
 authors = []

{vellum_workflow_server-1.7.0 → vellum_workflow_server-1.7.0.post2}/src/workflow_server/api/tests/test_workflow_view.py

@@ -429,7 +429,7 @@ class BrokenNode(BaseNode)  # Missing colon
     with flask_app.test_client() as test_client:
         response = test_client.post("/workflow/serialize", json={"files": {"broken_node.py": invalid_content}})
 
-    # THEN we should get a 4xx response
+    # THEN we should get a 400 response
     assert response.status_code == 400
 
     # AND the response should contain an error message
@@ -729,3 +729,45 @@ class Workflow(BaseWorkflow):
     assert events[0]["name"] == "vembda.execution.initiated"
     assert events[1]["name"] == "vembda.execution.fulfilled"
     assert len(events) == 2
+
+
+def test_serialize_route__with_invalid_nested_set_graph():
+    """
+    Tests that a workflow with an invalid nested set graph structure raises a clear user-facing exception.
+    """
+    # GIVEN a Flask application
+    flask_app = create_app()
+
+    invalid_workflow_content = """
+from vellum.workflows import BaseWorkflow
+from vellum.workflows.nodes import BaseNode
+
+class TestNode(BaseNode):
+    class Outputs(BaseNode.Outputs):
+        value = "test"
+
+class InvalidWorkflow(BaseWorkflow):
+    graph = {TestNode, {TestNode}}
+
+    class Outputs(BaseWorkflow.Outputs):
+        result = TestNode.Outputs.value
+"""
+
+    workflow_files = {
+        "__init__.py": "",
+        "workflow.py": invalid_workflow_content,
+    }
+
+    # WHEN we make a request to the serialize route
+    with flask_app.test_client() as test_client:
+        response = test_client.post("/workflow/serialize", json={"files": workflow_files})
+
+    # THEN we should get a 400 response
+    assert response.status_code == 400
+
+    # AND the response should contain a user-friendly error message
+    assert "detail" in response.json
+    error_detail = response.json["detail"]
+    assert "Serialization failed" in error_detail
+    assert "Invalid graph structure detected" in error_detail
+    assert "contact Vellum support" in error_detail

{vellum_workflow_server-1.7.0 → vellum_workflow_server-1.7.0.post2}/src/workflow_server/api/workflow_view.py

@@ -23,7 +23,6 @@ from vellum_ee.workflows.display.types import WorkflowDisplayContext
 from vellum_ee.workflows.display.workflows import BaseWorkflowDisplay
 from vellum_ee.workflows.server.virtual_file_loader import VirtualFileFinder
 
-from vellum.workflows import BaseWorkflow
 from vellum.workflows.exceptions import WorkflowInitializationException
 from vellum.workflows.nodes import BaseNode
 from workflow_server.config import ENABLE_PROCESS_WRAPPER, MEMORY_LIMIT_MB
@@ -432,37 +431,20 @@ def serialize_route() -> Response:
             content_type="application/json",
         )
 
-    try:
-        client = None
-        if workspace_api_key:
-            try:
-                client = create_vellum_client(api_key=workspace_api_key)
-            except Exception as e:
-                logger.warning(f"Failed to create VellumClient with provided workspace_api_key: {str(e)}")
+    client = create_vellum_client(api_key=workspace_api_key)
 
-        # Generate a unique namespace for this serialization request
-        namespace = "".join(random.choice(string.ascii_letters + string.digits) for i in range(14))
-        virtual_finder = VirtualFileFinder(files, namespace)
-
-        try:
-            sys.meta_path.append(virtual_finder)
-            try:
-                result = BaseWorkflowDisplay.serialize_module(namespace, client=client)
-            except Exception as e:
-                raise WorkflowInitializationException(
-                    message=str(e),
-                    workflow_definition=BaseWorkflow,
-                ) from e
-
-            return Response(
-                json.dumps(result.model_dump()),
-                status=200,
-                content_type="application/json",
-            )
+    # Generate a unique namespace for this serialization request
+    namespace = "".join(random.choice(string.ascii_letters + string.digits) for i in range(14))
+    virtual_finder = VirtualFileFinder(files, namespace)
+    try:
+        sys.meta_path.append(virtual_finder)
+        result = BaseWorkflowDisplay.serialize_module(namespace, client=client, dry_run=True)
 
-        finally:
-            if virtual_finder in sys.meta_path:
-                sys.meta_path.remove(virtual_finder)
+        return Response(
+            json.dumps(result.model_dump()),
+            status=200,
+            content_type="application/json",
+        )
 
     except WorkflowInitializationException as e:
         error_message = f"Serialization failed: {str(e)}"
@@ -481,6 +463,10 @@ def serialize_route() -> Response:
             content_type="application/json",
         )
 
+    finally:
+        if virtual_finder in sys.meta_path:
+            sys.meta_path.remove(virtual_finder)
+
 
 @bp.route("/version", methods=["GET"])
 def get_version_route() -> tuple[dict, int]: