unifi-cli 0.3.3__tar.gz → 0.3.4__tar.gz

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/CHANGELOG.md

@@ -2,6 +2,31 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.3.4](https://github.com/rvben/unifi-cli/compare/v0.3.3...v0.3.4) - 2026-08-11
+
+### Breaking Changes
+
+- **protect**: wrap the camera list in the standard items envelope ([e7b77bf](https://github.com/rvben/unifi-cli/commit/e7b77bf06dc64def4de1312bd3a5d6a207e60262))
+
+### Added
+
+- **protect**: wrap the camera list in the standard items envelope ([e7b77bf](https://github.com/rvben/unifi-cli/commit/e7b77bf06dc64def4de1312bd3a5d6a207e60262))
+
+### Fixed
+
+- **devices**: emit the firmware field devices show declares ([0f007c1](https://github.com/rvben/unifi-cli/commit/0f007c186a285b7250d5a539cebc1b561ba2be80))
+- **system**: report an unchecked update state as unknown, not up to date ([38492bb](https://github.com/rvben/unifi-cli/commit/38492bb6ff45f62e234bcc7409180b683f9a64c0))
+- **protect**: make the remaining reported-flag defaults tri-state ([4decf08](https://github.com/rvben/unifi-cli/commit/4decf08b38a7ed1ef31cfa792d492f3bfc5df76e))
+- **clients**: rank and print unknown traffic as unknown, not zero ([cbe0b66](https://github.com/rvben/unifi-cli/commit/cbe0b663fd9529c918c40a91f27e1b504e674984))
+- **schema**: publish the fields that say an rtsps create was partial ([9eb083e](https://github.com/rvben/unifi-cli/commit/9eb083e2031e192fceec6bbb1aa09c2fac5a3055))
+- **protect**: stop turning absent camera data into confident values ([29cf091](https://github.com/rvben/unifi-cli/commit/29cf091955b5452814957961b066ff4ddc41a8e0))
+- **tui**: let a throughput measurement expire instead of standing forever ([d7ca1f8](https://github.com/rvben/unifi-cli/commit/d7ca1f8499461990d6390427cdffa071716ecec8))
+- **tui**: stop reporting throughput for a port whose link has gone down ([00a18d8](https://github.com/rvben/unifi-cli/commit/00a18d811e969697b78e7260e5515715c336df3e))
+- **tui**: measure port throughput over the window the counters actually changed ([b2ae602](https://github.com/rvben/unifi-cli/commit/b2ae60228f1d8be44a2ae158a4b8a840d371d8fd))
+- **cli**: exit quietly when the output pipe closes early ([518fd96](https://github.com/rvben/unifi-cli/commit/518fd963f9c6eaf21b994ec6439ffa16cb6097a9))
+- **tui**: aim overlay actions at the entity the panel was opened on ([43fdd32](https://github.com/rvben/unifi-cli/commit/43fdd32abfa71fe1a1e7810e87af9c1033deb224))
+- **events**: report an absent event surface as unsupported, not a rejected request ([b3be651](https://github.com/rvben/unifi-cli/commit/b3be65186c65dd0d5849c47f388da63d5eb3a347))
+
 ## [0.3.3](https://github.com/rvben/unifi-cli/compare/v0.3.2...v0.3.3) - 2026-08-10
 
 ### Fixed

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/Cargo.lock

@@ -2786,13 +2786,14 @@ checksum = "ebc1c04c71510c7f702b52b7c350734c9ff1295c464a03335b00bb84fc54f853"
 
 [[package]]
 name = "unifi-cli"
-version = "0.3.3"
+version = "0.3.4"
 dependencies = [
  "clap",
  "clap_complete",
  "crossterm",
  "dirs",
  "jsonschema",
+ "libc",
  "owo-colors",
  "ratatui",
  "reqwest",

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "unifi-cli"
-version = "0.3.3"
+version = "0.3.4"
 edition = "2024"
 rust-version = "1.90"
 description = "CLI for UniFi Network controller"
@@ -33,6 +33,9 @@ ratatui = "0.30"
 crossterm = "0.29"
 rpassword = "7.4.0"
 
+[target.'cfg(unix)'.dependencies]
+libc = "0.2"
+
 [dev-dependencies]
 tempfile = "3"
 wiremock = "0.6"

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: unifi-cli
-Version: 0.3.3
+Version: 0.3.4
 Classifier: Development Status :: 3 - Alpha
 Classifier: Environment :: Console
 Classifier: Intended Audience :: System Administrators
@@ -357,7 +357,7 @@ unifi schema    # Dumps all commands, arguments, output fields as JSON
 | 2 | `confirmation_required` | A destructive command ran without `--yes` and without a TTY |
 | 3 | `auth_error` | Authentication error (401/403) |
 | 4 | `not_found` | Not found (404) |
-| 4 | `unsupported` | The controller does not serve this API at all (it answered a JSON endpoint with HTML, which is how UniFi OS reports an application it does not have); unlike `not_found` there is no other identifier worth trying |
+| 4 | `unsupported` | The controller does not serve this endpoint at all: it answered a JSON endpoint with HTML (how UniFi OS reports an application it does not have) or rejected the endpoint itself (how UniFi Network reports one the firmware has dropped); unlike `not_found` there is no other identifier or parameter worth trying |
 | 5 | `client_error` | The controller rejected the request itself (4xx other than 401/403/404/408/429); retrying it unchanged cannot help |
 | 5 | `retry_later` | The controller invited a retry (429 rate limited, 408 request timeout); back off and send the same request again |
 | 5 | `api_error` | The controller failed to serve the request (5xx); may be transient |

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/README.md

@@ -336,7 +336,7 @@ unifi schema    # Dumps all commands, arguments, output fields as JSON
 | 2 | `confirmation_required` | A destructive command ran without `--yes` and without a TTY |
 | 3 | `auth_error` | Authentication error (401/403) |
 | 4 | `not_found` | Not found (404) |
-| 4 | `unsupported` | The controller does not serve this API at all (it answered a JSON endpoint with HTML, which is how UniFi OS reports an application it does not have); unlike `not_found` there is no other identifier worth trying |
+| 4 | `unsupported` | The controller does not serve this endpoint at all: it answered a JSON endpoint with HTML (how UniFi OS reports an application it does not have) or rejected the endpoint itself (how UniFi Network reports one the firmware has dropped); unlike `not_found` there is no other identifier or parameter worth trying |
 | 5 | `client_error` | The controller rejected the request itself (4xx other than 401/403/404/408/429); retrying it unchanged cannot help |
 | 5 | `retry_later` | The controller invited a retry (429 rate limited, 408 request timeout); back off and send the same request again |
 | 5 | `api_error` | The controller failed to serve the request (5xx); may be transient |

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/src/api/client.rs

@@ -11,6 +11,29 @@ pub fn error_for_status(status: u16, message: String) -> ApiError {
     }
 }
 
+/// True when a legacy API error means the endpoint itself is not there.
+///
+/// UniFi Network answers an unknown `stat/` path with 404 `api.err.NotFound`
+/// and an unknown `rest/` resource with 400 `api.err.InvalidObject`, verified
+/// against a UniFi OS 9 controller by control: a nonsense resource and
+/// `rest/alarm` produce byte-identical 400s while `rest/networkconf` returns
+/// records.
+///
+/// A 400 alone does not carry that meaning, since the same status reports a
+/// genuinely malformed request, so the marker string is required too and this
+/// is only consulted for a request that carries no caller-supplied body or
+/// parameters that could be the invalid object.
+fn is_absent_legacy_endpoint(err: &ApiError) -> bool {
+    match err {
+        ApiError::NotFound(_) => true,
+        ApiError::Api {
+            status: 400,
+            message,
+        } => message.contains("api.err.InvalidObject"),
+        _ => false,
+    }
+}
+
 /// Decode a successful response as JSON, naming what answered when it is not.
 ///
 /// UniFi OS answers a request for an application the controller does not have
@@ -48,7 +71,7 @@ async fn json_or_unsupported<T: DeserializeOwned>(
             };
             Err(ApiError::Unsupported {
                 endpoint: endpoint.to_string(),
-                content_type,
+                reason: UnsupportedReason::NotJson { content_type },
             })
         }
     }
@@ -430,21 +453,30 @@ impl UnifiClient {
     // `Event` shape, so fall back to it. (The full live event stream on newer
     // controllers is only exposed over the events WebSocket, which this REST
     // client does not consume.)
+    //
+    // Some UniFi Network 9 builds serve neither. Reporting the fallback's own
+    // rejection verbatim would tell a caller that its request was malformed and
+    // invite it to retry with different parameters, when in truth the whole
+    // event surface is gone and nothing it can send would work.
     pub async fn list_events(&self, limit: usize) -> Result<Vec<Event>, ApiError> {
-        match self
-            .get_legacy::<Event>(&format!("/stat/event?_limit={limit}"))
-            .await
-        {
+        let events_path = format!("/stat/event?_limit={limit}");
+        match self.get_legacy::<Event>(&events_path).await {
             Ok(events) => Ok(events),
-            Err(ApiError::NotFound(_)) => {
-                let mut alarms: Vec<Event> = self.get_legacy("/rest/alarm").await?;
+            Err(ApiError::NotFound(_)) => match self.get_legacy::<Event>("/rest/alarm").await {
                 // `rest/alarm` is neither time-ordered nor limited server-side;
                 // present the most recent `limit` records to match the
                 // semantics `stat/event?_limit=` provided on older controllers.
-                alarms.sort_by_key(|e| std::cmp::Reverse(e.time));
-                alarms.truncate(limit);
-                Ok(alarms)
-            }
+                Ok(mut alarms) => {
+                    alarms.sort_by_key(|e| std::cmp::Reverse(e.time));
+                    alarms.truncate(limit);
+                    Ok(alarms)
+                }
+                Err(e) if is_absent_legacy_endpoint(&e) => Err(ApiError::Unsupported {
+                    endpoint: format!("/proxy/network/api/s/default{events_path}"),
+                    reason: UnsupportedReason::Removed,
+                }),
+                Err(e) => Err(e),
+            },
             Err(e) => Err(e),
         }
     }
@@ -551,6 +583,11 @@ impl UnifiClient {
     /// Resolve a camera identifier (ID or name) to a camera ID.
     /// If the input is a 24-char hex string, treats it as an ID.
     /// Otherwise, searches by name (case-insensitive).
+    ///
+    /// A name that fits more than one camera is an error rather than a choice
+    /// made silently: the caller may be about to delete that camera's streams,
+    /// and picking whichever the controller happened to list first would act on
+    /// a different camera than the one the user was asked to confirm.
     pub async fn resolve_camera_id(&self, id_or_name: &str) -> Result<String, ApiError> {
         // If it looks like a Protect camera ID (24 hex chars), use it directly
         if id_or_name.len() == 24 && id_or_name.chars().all(|c| c.is_ascii_hexdigit()) {
@@ -559,15 +596,30 @@ impl UnifiClient {
         // Otherwise, search by name
         let cameras = self.list_protect_cameras().await?;
         let needle = id_or_name.to_lowercase();
-        cameras
+        let mut matches: Vec<ProtectCamera> = cameras
             .into_iter()
-            .find(|c| {
+            .filter(|c| {
                 c.name
                     .as_deref()
                     .is_some_and(|n| n.trim().to_lowercase() == needle)
             })
-            .map(|c| c.id)
-            .ok_or_else(|| ApiError::NotFound(format!("Camera '{id_or_name}'")))
+            .collect();
+
+        match matches.len() {
+            0 => Err(ApiError::NotFound(format!("Camera '{id_or_name}'"))),
+            1 => Ok(matches.pop().expect("checked len == 1 above").id),
+            _ => {
+                let list = matches
+                    .iter()
+                    .map(|c| c.id.as_str())
+                    .collect::<Vec<_>>()
+                    .join(", ");
+                Err(ApiError::Conflict(format!(
+                    "'{id_or_name}' matches {} cameras: {list}. Use the ID.",
+                    matches.len()
+                )))
+            }
+        }
     }
 
     // System

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/src/api/mod.rs

@@ -7,6 +7,6 @@ pub use client::UnifiClient;
 pub use client::error_for_status;
 pub use types::{
     ApiError, Client, Device, DeviceWithPorts, Event, HealthSubsystem, HostSystem, LastConnection,
-    LegacyClient, LegacyDevice, LegacyResponse, Network, PortEntry, SysInfo, format_bytes,
-    format_mac, format_uptime, normalize_mac,
+    LegacyClient, LegacyDevice, LegacyResponse, Network, PortEntry, SysInfo, UnsupportedReason,
+    format_bytes, format_mac, format_uptime, normalize_mac,
 };

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/src/api/tests.rs

@@ -650,7 +650,7 @@ fn legacy_device_upgradable_false_explicit() {
 fn host_system_update_available() {
     let json = r#"{"deviceState": "updateAvailable", "name": "UCG Ultra"}"#;
     let host: HostSystem = serde_json::from_str(json).unwrap();
-    assert!(host.update_available());
+    assert_eq!(host.update_available(), Some(true));
     assert_eq!(host.name.as_deref(), Some("UCG Ultra"));
 }
 
@@ -658,14 +658,18 @@ fn host_system_update_available() {
 fn host_system_no_update() {
     let json = r#"{"deviceState": "online"}"#;
     let host: HostSystem = serde_json::from_str(json).unwrap();
-    assert!(!host.update_available());
+    assert_eq!(host.update_available(), Some(false));
 }
 
 #[test]
-fn host_system_missing_state() {
+fn host_system_missing_state_is_unknown_not_up_to_date() {
     let json = r#"{}"#;
     let host: HostSystem = serde_json::from_str(json).unwrap();
-    assert!(!host.update_available());
+    assert_eq!(
+        host.update_available(),
+        None,
+        "a host that reported no device state has not reported an up-to-date one"
+    );
 }
 
 // --- strip_mac_suffix ---

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/src/api/types.rs

@@ -196,8 +196,15 @@ pub struct HostSystem {
 }
 
 impl HostSystem {
-    pub fn update_available(&self) -> bool {
-        self.device_state.as_deref() == Some("updateAvailable")
+    /// Whether a firmware update is waiting, or `None` when the host did not say.
+    ///
+    /// A host that reported no device state has not reported an up-to-date one,
+    /// so the answer is unknown rather than negative. Only a state the host did
+    /// report settles the question, either way.
+    pub fn update_available(&self) -> Option<bool> {
+        self.device_state
+            .as_deref()
+            .map(|state| state == "updateAvailable")
     }
 }
 
@@ -384,8 +391,7 @@ pub struct ProtectCamera {
     pub mac: Option<String>,
     pub state: Option<String>,
     pub model_key: Option<String>,
-    #[serde(default)]
-    pub is_mic_enabled: bool,
+    pub is_mic_enabled: Option<bool>,
     pub video_mode: Option<String>,
     pub feature_flags: Option<ProtectFeatureFlags>,
 }
@@ -425,19 +431,17 @@ pub struct ProtectCameraFull {
     pub uptime: Option<u64>,
     pub up_since: Option<u64>,
     pub last_seen: Option<u64>,
-    #[serde(default)]
-    pub is_recording: bool,
-    #[serde(default)]
-    pub is_motion_detected: bool,
-    #[serde(default)]
-    pub is_dark: bool,
+    pub is_recording: Option<bool>,
+    /// Tri-state for the same reason as `is_recording`: a camera that did not
+    /// report motion has not reported stillness.
+    pub is_motion_detected: Option<bool>,
+    pub is_dark: Option<bool>,
     pub video_codec: Option<String>,
     pub current_resolution: Option<String>,
     pub video_mode: Option<String>,
     pub hdr_type: Option<String>,
     pub phy_rate: Option<f64>,
-    #[serde(default)]
-    pub is_mic_enabled: bool,
+    pub is_mic_enabled: Option<bool>,
     #[serde(default)]
     pub is_poor_network: bool,
     pub last_motion: Option<u64>,
@@ -457,14 +461,14 @@ pub struct ProtectCameraFull {
 pub struct CameraChannel {
     pub id: u32,
     pub name: Option<String>,
-    #[serde(default)]
-    pub enabled: bool,
+    /// Tri-state like `is_rtsp_enabled` below: a channel whose state the camera
+    /// did not report is not a channel reported as switched off.
+    pub enabled: Option<bool>,
     pub width: Option<u32>,
     pub height: Option<u32>,
     pub fps: Option<u32>,
     pub bitrate: Option<u64>,
-    #[serde(default)]
-    pub is_rtsp_enabled: bool,
+    pub is_rtsp_enabled: Option<bool>,
     pub rtsp_alias: Option<String>,
 }
 
@@ -507,8 +511,9 @@ pub struct WifiConnectionState {
 #[serde(rename_all = "camelCase")]
 pub struct RecordingSettings {
     pub mode: Option<String>,
-    #[serde(default)]
-    pub enable_motion_detection: bool,
+    /// Tri-state: settings that did not mention motion detection have not said
+    /// it is switched off.
+    pub enable_motion_detection: Option<bool>,
 }
 
 /// RTSPS stream URLs keyed by quality level
@@ -528,18 +533,35 @@ pub enum ApiError {
     /// rejected locally before any HTTP call. Published by `unifi schema`
     /// as kind `conflict`, exit code 6.
     Conflict(String),
-    /// The controller answered a JSON endpoint with something else, which is
-    /// how UniFi OS reports an application it does not have: the request is
-    /// proxied to the web UI and returns 200 with an HTML page. Distinct from
+    /// The controller does not serve this endpoint at all. Distinct from
     /// `NotFound` because the whole API is absent, not one record, so there is
     /// no other identifier worth trying. Published as kind `unsupported`.
     Unsupported {
         endpoint: String,
-        content_type: String,
+        reason: UnsupportedReason,
     },
     Other(String),
 }
 
+/// How the controller revealed that an endpoint is absent.
+///
+/// Both forms mean the same thing to a caller, so they share one error kind.
+/// They are kept apart because the message has to say what actually happened:
+/// guessing at the wrong one sends the reader looking for a fault that is not
+/// there.
+#[derive(Debug)]
+pub enum UnsupportedReason {
+    /// The endpoint answered with something other than JSON. UniFi OS proxies
+    /// a request for an application it does not have to its own web UI, so the
+    /// call returns 200 with an HTML page.
+    NotJson { content_type: String },
+    /// The controller rejected the endpoint itself rather than the request.
+    /// UniFi Network answers an unknown legacy resource this way, so a
+    /// firmware that has dropped an endpoint is indistinguishable from one
+    /// that never had it, and neither is worth retrying.
+    Removed,
+}
+
 /// Scan a single error string for TLS certificate failure markers. rustls
 /// reports these as "invalid peer certificate: <reason>", so "certificate" is
 /// the reliable marker; "self-signed" is matched defensively.
@@ -620,21 +642,32 @@ impl fmt::Display for ApiError {
                 )
             }
             ApiError::Conflict(msg) => write!(f, "{msg}"),
-            ApiError::Unsupported {
-                endpoint,
-                content_type,
-            } => {
-                write!(
-                    f,
-                    "This controller does not serve {endpoint}: it answered with {content_type} \
-                     instead of JSON"
-                )?;
+            ApiError::Unsupported { endpoint, reason } => {
+                match reason {
+                    UnsupportedReason::NotJson { content_type } => write!(
+                        f,
+                        "This controller does not serve {endpoint}: it answered with \
+                         {content_type} instead of JSON"
+                    )?,
+                    UnsupportedReason::Removed => write!(
+                        f,
+                        "This controller does not serve {endpoint}: it rejected the endpoint \
+                         itself, so no parameter or identifier would change the result"
+                    )?,
+                }
                 if endpoint.contains("/protect/") {
                     write!(
                         f,
                         "\n  Hint: UniFi OS proxies the request to its web UI when the Protect \
                          application is not installed on the controller"
                     )?;
+                } else if endpoint.contains("/stat/event") {
+                    write!(
+                        f,
+                        "\n  Hint: UniFi Network 9 removed the REST event log, and this \
+                         controller does not serve /rest/alarm either. The remaining event \
+                         stream is the events WebSocket, which this CLI does not consume"
+                    )?;
                 }
                 Ok(())
             }

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/src/commands/clients.rs

@@ -387,8 +387,13 @@ pub async fn kick(
     Ok(())
 }
 
-pub(crate) fn total_bytes(c: &LegacyClient) -> u64 {
-    c.tx_bytes.unwrap_or(0) + c.rx_bytes.unwrap_or(0)
+/// Total traffic, or `None` when the controller did not report the counters.
+///
+/// A counter the controller did not report is not a counter of zero: a client
+/// whose traffic is unknown is not an idle client. Both halves are needed for a
+/// total, since one alone is only part of the number the column claims to show.
+pub(crate) fn total_bytes(c: &LegacyClient) -> Option<u64> {
+    c.tx_bytes.zip(c.rx_bytes).map(|(tx, rx)| tx + rx)
 }
 
 pub async fn top(
@@ -397,7 +402,13 @@ pub async fn top(
     limit: usize,
 ) -> Result<(), Box<dyn std::error::Error>> {
     let mut clients = client.list_clients_legacy().await?;
-    clients.sort_by_key(|c| std::cmp::Reverse(total_bytes(c)));
+    // A client the controller published no counters for cannot be placed in a
+    // ranking by traffic, so it sits after everything that can, rather than
+    // being ranked as though it had transferred nothing.
+    clients.sort_by_key(|c| {
+        let total = total_bytes(c);
+        (total.is_none(), std::cmp::Reverse(total.unwrap_or(0)))
+    });
     let top_clients: Vec<&LegacyClient> = clients.iter().take(limit).collect();
 
     if out.is_json() {
@@ -443,9 +454,10 @@ pub async fn top(
                 .map(|m| format_mac(&normalize_mac(m)))
                 .unwrap_or_else(|| "-".into());
             let ip = c.ip.as_deref().unwrap_or("-");
-            let tx = format_bytes(c.tx_bytes.unwrap_or(0));
-            let rx = format_bytes(c.rx_bytes.unwrap_or(0));
-            let total = format_bytes(total_bytes(c));
+            let bytes = |v: Option<u64>| v.map(format_bytes).unwrap_or_else(|| "-".into());
+            let tx = bytes(c.tx_bytes);
+            let rx = bytes(c.rx_bytes);
+            let total = bytes(total_bytes(c));
             let pad = name_w - 1;
 
             if color {
@@ -627,19 +639,36 @@ mod tests {
     fn total_bytes_both_present() {
         let c: LegacyClient =
             serde_json::from_str(r#"{"_id": "x", "tx_bytes": 100, "rx_bytes": 200}"#).unwrap();
-        assert_eq!(total_bytes(&c), 300);
+        assert_eq!(total_bytes(&c), Some(300));
+    }
+
+    /// A client that really did transfer nothing is a measurement, and stays
+    /// distinguishable from one the controller said nothing about.
+    #[test]
+    fn total_bytes_measured_zero() {
+        let c: LegacyClient =
+            serde_json::from_str(r#"{"_id": "x", "tx_bytes": 0, "rx_bytes": 0}"#).unwrap();
+        assert_eq!(total_bytes(&c), Some(0));
     }
 
     #[test]
     fn total_bytes_none_values() {
         let c: LegacyClient = serde_json::from_str(r#"{"_id": "x"}"#).unwrap();
-        assert_eq!(total_bytes(&c), 0);
+        assert_eq!(
+            total_bytes(&c),
+            None,
+            "counters the controller never sent are unknown, not zero"
+        );
     }
 
     #[test]
     fn total_bytes_partial() {
         let c: LegacyClient = serde_json::from_str(r#"{"_id": "x", "tx_bytes": 500}"#).unwrap();
-        assert_eq!(total_bytes(&c), 500);
+        assert_eq!(
+            total_bytes(&c),
+            None,
+            "half a total is not a total: 500 would claim rx was measured at zero"
+        );
     }
 
     // --- apply_filter ---

{unifi_cli-0.3.3 → unifi_cli-0.3.4}/src/commands/devices.rs

@@ -185,6 +185,7 @@ pub async fn show(
             "mac": d.mac,
             "ip": d.ip,
             "state": d.state_str(),
+            "firmware": d.version,
             "version": d.version,
             "uptime": d.uptime,
             "num_sta": d.num_sta,