tunacode-cli 0.0.38__tar.gz → 0.0.39__tar.gz

{tunacode_cli-0.0.38/src/tunacode_cli.egg-info → tunacode_cli-0.0.39}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: tunacode-cli
-Version: 0.0.38
+Version: 0.0.39
 Summary: Your agentic CLI developer.
 Author-email: larock22 <noreply@github.com>
 License-Expression: MIT

{tunacode_cli-0.0.38 → tunacode_cli-0.0.39}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "tunacode-cli"
-version = "0.0.38"
+version = "0.0.39"
 description = "Your agentic CLI developer."
 keywords = ["cli", "agent", "development", "automation"]
 readme = "README.md"

{tunacode_cli-0.0.38 → tunacode_cli-0.0.39}/src/tunacode/constants.py

@@ -7,7 +7,7 @@ Centralizes all magic strings, UI text, error messages, and application constant
 
 # Application info
 APP_NAME = "TunaCode"
-APP_VERSION = "0.0.38"
+APP_VERSION = "0.0.39"
 
 # File patterns
 GUIDE_FILE_PATTERN = "{name}.md"

{tunacode_cli-0.0.38 → tunacode_cli-0.0.39}/src/tunacode/prompts/system.md

@@ -256,13 +256,48 @@ If deeper exploration needed:
 
 \###Meta Behavior###
 
-Use the **ReAct** (Reasoning + Action) framework:
+Use the **ReAct** (Reasoning + Action) framework internally:
 
-- {"thought": "I need to inspect the file before modifying."}
-- → run tool
-- {"thought": "I see the old import. Now I'll patch it."}
-- → update file
-- {"thought": "Patch complete. Ready for next instruction."}
+**IMPORTANT**: Thoughts are for internal reasoning only. NEVER include JSON-formatted thoughts in your responses to users.
+
+Internal process (not shown to user):
+- Think: "I need to inspect the file before modifying."
+- Act: run tool
+- Think: "I see the old import. Now I'll patch it."
+- Act: update file
+- Think: "Patch complete. Ready for next instruction."
+
+**Your responses to users should be clean, formatted text without JSON artifacts.**
+
+---
+
+\###Output Formatting Rules###
+
+**CRITICAL**: Your responses to users must be clean, readable text:
+
+1. **NO JSON in responses** - Never output {"thought": ...}, {"suggestions": ...}, or any JSON to users
+2. **Use markdown formatting** - Use headers, lists, code blocks for readability
+3. **Be direct and clear** - Provide actionable feedback and concrete suggestions
+4. **Format suggestions as numbered or bulleted lists** - Not as JSON arrays
+
+**Example of GOOD response formatting:**
+```
+Code Review Results:
+
+The JavaScript code has good structure. Here are suggestions for improvement:
+
+1. **Add comments** - Document major functions for better maintainability
+2. **Consistent error handling** - Use try-catch blocks consistently
+3. **Form validation** - Validate before submitting to ensure fields are filled
+
+These changes will improve maintainability and user experience.
+```
+
+**Example of BAD response formatting (DO NOT DO THIS):**
+```
+{"thought": "Reviewing the code..."}
+{"suggestions": ["Add comments", "Error handling", "Validation"]}
+```
 
 ---
 
@@ -281,12 +316,13 @@ When users provide @ file references, they want information, not file creation.
 ```plaintext
 User: What's the current app version?
 
-THINK: {"thought": "I should search for APP_VERSION. I'll use grep for parallel capability."}
+[Internal thinking - not shown to user]
 ACT: grep("APP_VERSION", ".")
-OBSERVE: {"thought": "Found APP_VERSION in constants.py at line 12."}
+[Found APP_VERSION in constants.py at line 12]
 ACT: read_file("constants.py")
-OBSERVE: {"thought": "APP_VERSION is set to '2.4.1'. This is the current version."}
-RESPONSE: "Current version is 2.4.1 (from constants.py)"
+[APP_VERSION is set to '2.4.1']
+
+RESPONSE TO USER: Current version is 2.4.1 (from constants.py)
 ```
 
 ````plaintext
@@ -300,8 +336,9 @@ def main():
 
 === END FILE REFERENCE: src/main.py ===
 
-THINK: {"thought": "User is asking about the referenced file, not asking me to create it."}
-RESPONSE: "The main.py file contains a simple main function that prints 'Hello World'."
+[Internal: User is asking about the referenced file, not asking me to create it]
+
+RESPONSE TO USER: The main.py file contains a simple main function that prints 'Hello World'.
 
 ```
 

{tunacode_cli-0.0.38 → tunacode_cli-0.0.39/src/tunacode_cli.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: tunacode-cli
-Version: 0.0.38
+Version: 0.0.39
 Summary: Your agentic CLI developer.
 Author-email: larock22 <noreply@github.com>
 License-Expression: MIT

{tunacode_cli-0.0.38 → tunacode_cli-0.0.39}/src/tunacode_cli.egg-info/SOURCES.txt

@@ -95,6 +95,7 @@ src/tunacode_cli.egg-info/top_level.txt
 tests/conftest.py
 tests/test_actual_parallelism.py
 tests/test_agent_initialization.py
+tests/test_agent_output_formatting.py
 tests/test_background_manager.py
 tests/test_characterization_agent_main.py
 tests/test_characterization_bash.py
@@ -133,6 +134,7 @@ tests/test_parallel_execution_freeze_fix.py
 tests/test_parallel_execution_integration.py
 tests/test_parallel_read_only_tools.py
 tests/test_parallel_tool_execution.py
+tests/test_prompt_changes_validation.py
 tests/test_read_only_confirmation.py
 tests/test_security.py
 tests/test_streaming_panel_tool_confirmation.py

tunacode_cli-0.0.39/tests/test_agent_output_formatting.py

@@ -0,0 +1,107 @@
+"""Tests for agent output formatting to ensure clean display without JSON artifacts."""
+
+from unittest.mock import AsyncMock, MagicMock, patch
+
+import pytest
+
+from tunacode.cli.repl import process_request
+from tunacode.types import SimpleResult
+
+
+class TestAgentOutputFormatting:
+    """Test that agent output is properly formatted for users."""
+
+    def _create_mock_state_manager(self):
+        """Create a properly configured mock StateManager."""
+        state_manager = MagicMock()
+        state_manager.session = MagicMock()
+        state_manager.session.messages = []
+        state_manager.session.show_thoughts = False
+        state_manager.session.user_config = {"settings": {"enable_streaming": False}}
+        state_manager.session.spinner = None
+        state_manager.session.files_in_context = set()
+        state_manager.session.is_streaming_active = False
+        return state_manager
+
+    @pytest.mark.asyncio
+    async def test_agent_output_without_json_thoughts(self):
+        """Agent should return clean formatted text without JSON thought artifacts."""
+        # Arrange
+        state_manager = self._create_mock_state_manager()
+
+        # Mock agent response with JSON thought that should be filtered
+        mock_response = MagicMock()
+        mock_response.result = SimpleResult(
+            output='{"thought": "Reviewing the current JavaScript code..."}\n'
+            '{"suggestions": ["1. Add comments to functions", "2. Use consistent error handling"]}'
+        )
+
+        with patch(
+            "tunacode.cli.repl.agent.process_request", new_callable=AsyncMock
+        ) as mock_process:
+            mock_process.return_value = mock_response
+            with patch("tunacode.cli.repl.ui.agent", new_callable=AsyncMock) as mock_ui_agent:
+                # Act
+                await process_request("Review my code", state_manager, output=True)
+
+                # Assert - UI should NOT be called since JSON output is filtered
+                mock_ui_agent.assert_not_called()
+
+    @pytest.mark.asyncio
+    async def test_agent_clean_text_output_displayed(self):
+        """Clean text output from agent should be displayed to user."""
+        # Arrange
+        state_manager = self._create_mock_state_manager()
+
+        # Mock agent response with clean text
+        expected_output = "Here are my suggestions for improving your code:\n1. Add comments\n2. Improve error handling"
+        mock_response = MagicMock()
+        mock_response.result = SimpleResult(output=expected_output)
+
+        with patch(
+            "tunacode.cli.repl.agent.process_request", new_callable=AsyncMock
+        ) as mock_process:
+            mock_process.return_value = mock_response
+            with patch("tunacode.cli.repl.ui.agent", new_callable=AsyncMock) as mock_ui_agent:
+                # Act
+                await process_request("Review my code", state_manager, output=True)
+
+                # Assert - Clean text should be displayed
+                mock_ui_agent.assert_called_once_with(expected_output)
+
+    @pytest.mark.asyncio
+    async def test_formatted_suggestions_without_json_wrapper(self):
+        """Agent should format suggestions as clean text, not JSON."""
+        # Arrange
+        state_manager = self._create_mock_state_manager()
+
+        # Expected clean formatted output
+        expected_output = """Code Review Results:
+
+The JavaScript code has a good structure with clear separation of concerns. Here are some suggestions for improvement:
+
+1. **Add comments to functions** - Document the purpose and parameters of major functions for better maintainability.
+
+2. **Consistent error handling** - Use try-catch blocks consistently and provide user-friendly error messages instead of alerts.
+
+3. **Form validation** - Implement validation before submitting to ensure required fields are properly filled.
+
+4. **Debounce input handlers** - Consider debouncing the updateSubmitButtonState function to prevent excessive calls.
+
+5. **Accessibility improvements** - Add ARIA labels and ensure keyboard navigation works properly.
+
+These changes will improve code maintainability and user experience."""
+
+        mock_response = MagicMock()
+        mock_response.result = SimpleResult(output=expected_output)
+
+        with patch(
+            "tunacode.cli.repl.agent.process_request", new_callable=AsyncMock
+        ) as mock_process:
+            mock_process.return_value = mock_response
+            with patch("tunacode.cli.repl.ui.agent", new_callable=AsyncMock) as mock_ui_agent:
+                # Act
+                await process_request("Review my JavaScript code", state_manager, output=True)
+
+                # Assert - Formatted text should be displayed
+                mock_ui_agent.assert_called_once_with(expected_output)

tunacode_cli-0.0.39/tests/test_prompt_changes_validation.py

@@ -0,0 +1,35 @@
+"""Test to validate the system prompt changes."""
+
+from pathlib import Path
+
+
+def test_system_prompt_no_json_in_responses():
+    """Verify system prompt doesn't instruct agent to output JSON to users."""
+    prompt_path = Path(__file__).parent.parent / "src" / "tunacode" / "prompts" / "system.md"
+
+    with open(prompt_path, "r") as f:
+        content = f.read()
+
+    # Check that we have the new formatting rules
+    assert "Output Formatting Rules" in content
+    assert "NO JSON in responses" in content
+    assert 'Never output {"thought":' in content
+
+    # Check that thoughts are marked as internal
+    assert "Thoughts are for internal reasoning only" in content
+    assert "NEVER include JSON-formatted thoughts in your responses to users" in content
+
+    # Check examples use clean formatting
+    assert "RESPONSE TO USER:" in content
+    assert "[Internal thinking - not shown to user]" in content
+
+    # Check we have good/bad examples
+    assert "Example of GOOD response formatting:" in content
+    assert "Example of BAD response formatting (DO NOT DO THIS):" in content
+
+    print("\n=== SYSTEM PROMPT VALIDATION ===")
+    print("✓ Output formatting rules added")
+    print("✓ JSON responses explicitly forbidden")
+    print("✓ Thoughts marked as internal only")
+    print("✓ Examples updated to show clean output")
+    print("\nThe system prompt should now produce clean, formatted text responses.")