truefoundry 0.4.8__tar.gz → 0.4.9__tar.gz

{truefoundry-0.4.8 → truefoundry-0.4.9}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: truefoundry
-Version: 0.4.8
+Version: 0.4.9
 Summary: Truefoundry CLI
 Author: Abhishek Choudhary
 Author-email: abhishek@truefoundry.com
@@ -37,7 +37,7 @@ Requires-Dist: python-dateutil (>=2.8.2,<3.0.0)
 Requires-Dist: python-dotenv (>=1.0.1,<2.0.0)
 Requires-Dist: python-socketio[client] (>=5.5.2,<6.0.0)
 Requires-Dist: questionary (>=1.10.0,<2.0.0)
-Requires-Dist: requests (>=2.31.0,<3.0.0)
+Requires-Dist: requests (>=2.18.0,<3.0.0)
 Requires-Dist: requirements-parser (>=0.11.0,<0.12.0)
 Requires-Dist: rich (>=13.7.1,<14.0.0)
 Requires-Dist: rich-click (>=1.2.1,<2.0.0)

{truefoundry-0.4.8 → truefoundry-0.4.9}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "truefoundry"
-version = "0.4.8"
+version = "0.4.9"
 description = "Truefoundry CLI"
 authors = ["Abhishek Choudhary <abhishek@truefoundry.com>"]
 readme = "README.md"
@@ -29,7 +29,7 @@ python-dotenv = ">=1.0.1,<2.0.0"
 python-socketio = { version = ">=5.5.2,<6.0.0", extras = ["client"] }
 PyYAML = ">=6.0.0,<7.0.0"
 questionary = ">=1.10.0,<2.0.0"
-requests = ">=2.31.0,<3.0.0"
+requests = ">=2.18.0,<3.0.0"
 requirements-parser = ">=0.11.0,<0.12.0"
 rich = ">=13.7.1,<14.0.0"
 rich-click = ">=1.2.1,<2.0.0"

{truefoundry-0.4.8 → truefoundry-0.4.9}/truefoundry/ml/artifact/truefoundry_artifact_repo.py

@@ -897,6 +897,9 @@ class MlFoundryArtifactsRepository:
             page_token = page.next_page_token
 
     def _is_directory(self, artifact_path):
+        # TODO: Ideally server should return a flag to indicate if it is a directory
+        # For now we can rely on list_artifacts because generally in cloud buckets
+        # directories are not stored as separate entities - empty directories ideally do not exist
         for _ in self.list_artifacts(artifact_path, page_size=3):
             return True
         return False
@@ -1014,7 +1017,9 @@ class MlFoundryArtifactsRepository:
 
     def _get_file_paths_recur(self, src_artifact_dir_path, dst_local_dir_path):
         local_dir = os.path.join(dst_local_dir_path, src_artifact_dir_path)
-        dir_content = [  # prevent infinite loop, sometimes the dir is recursively included
+        # prevent infinite loop, sometimes the dir is recursively included
+        # TODO (chiragjn): Check why and when this happens
+        dir_content = [
             file_info
             for file_info in self.list_artifacts(src_artifact_dir_path)
             if file_info.path != "." and file_info.path != src_artifact_dir_path
@@ -1099,8 +1104,8 @@ class MlFoundryArtifactsRepository:
 
         try:
             progress_bar.start()
-            # Check if the artifacts points to a directory
-            if self._is_directory(artifact_path):
+            # empty string is treated as root directory
+            if not artifact_path or self._is_directory(artifact_path):
                 futures: List[Future] = []
                 file_paths: List[Tuple[str, str]] = []
                 abort_event = Event()