trigger 2.2.2__tar.gz → 2.2.4__tar.gz

{trigger-2.2.2/trigger.egg-info → trigger-2.2.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: trigger
-Version: 2.2.2
+Version: 2.2.4
 Summary: Network automation toolkit for managing network devices
 Author-email: Jathan McCollum <jathan@gmail.com>
 License-Expression: BSD-3-Clause
@@ -33,12 +33,14 @@ Requires-Dist: pytest>=7.4.0; extra == "dev"
 Requires-Dist: pytest-twisted>=1.14.0; extra == "dev"
 Requires-Dist: ruff>=0.1.0; extra == "dev"
 Requires-Dist: python-semantic-release>=9.0.0; extra == "dev"
+Provides-Extra: docs
+Requires-Dist: sphinx>=7.0; extra == "docs"
+Requires-Dist: sphinx_rtd_theme>=2.0; extra == "docs"
 Dynamic: license-file
 
 # What is Trigger?
 
-[![Tests](https://github.com/trigger/trigger/workflows/Tests/badge.svg)](https://github.com/trigger/trigger/actions)
-[![Join the chat at https://gitter.im/trigger/trigger](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/trigger/trigger?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+[![CI](https://github.com/trigger/trigger/workflows/CI/badge.svg)](https://github.com/trigger/trigger/actions/workflows/ci.yml)
 
 Trigger is a robust network automation toolkit written in Python that was
 designed for interfacing with network devices and managing network
@@ -79,16 +81,9 @@ network devices with ease. Here are some of things that make Trigger tick:
 + Flexible access-list & firewall policy parser that can test access if access
   is permitted, or easily convert ACLs from one format to another.
 + Detailed support for timezones and maintenance windows.
++ Import your metadata from an existing [RANCID](http://shrubbery.net/rancid/) installation or a CSV file to get up-and-running quickly.
 + A suite of tools for simplifying many common tasks.
 
-New in version 1.2:
-
-+ Import your metadata from an existing [RANCID](http://shrubbery.net/rancid/) installation to get up-and-running quickly!
-
-New in version 1.3:
-
-+ Import your metadata from a CSV file and get up-and-running even quicker!
-
 ## Getting Started
 
 The best way to get started is to read the documentation hosted by [Read the
@@ -142,21 +137,13 @@ See the [Migration Guide](https://trigger.readthedocs.io/en/latest/migration.htm
 
 ### Before you begin
 
-+ The [develop](https://github.com/trigger/trigger/tree/develop) branch is
-  the default branch that will be active when you clone this repository. While
-  it is generally stable this branch is not considered production-ready. Use at
-  your own risk!
-+ The [master](https://github.com/trigger/trigger/tree/master) branch is
-  the stable branch, and will reflect the latest production-ready changes. It
-  is recommended that this is the branch you use if you are installing Trigger
-  for the first time.
-+ Each point release of Trigger is maintained as a [tag branch](https://github.com/trigger/trigger/tags). If you require a
++ The [main](https://github.com/trigger/trigger/tree/main) branch is the
+  primary branch for all development and releases. All pull requests target
+  `main`.
++ Each point release of Trigger is maintained as a [tag](https://github.com/trigger/trigger/tags). If you require a
   specific Trigger version, please refer to these.
 
 ### Get in touch!
 
-If you run into any snags, have questions, feedback, or just want to talk shop:
-[contact us](https://trigger.readthedocs.io/en/latest/#getting-help)!
-
-**Pro tip**: Find us on IRC at `#trigger` on Freenode
-([irc://irc.freenode.net/trigger](irc://irc.freenode.net/trigger)).
+If you run into any snags, have questions, feedback, or just want to talk shop,
+please open an issue on [GitHub Issues](https://github.com/trigger/trigger/issues).

{trigger-2.2.2 → trigger-2.2.4}/README.md

@@ -1,7 +1,6 @@
 # What is Trigger?
 
-[![Tests](https://github.com/trigger/trigger/workflows/Tests/badge.svg)](https://github.com/trigger/trigger/actions)
-[![Join the chat at https://gitter.im/trigger/trigger](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/trigger/trigger?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+[![CI](https://github.com/trigger/trigger/workflows/CI/badge.svg)](https://github.com/trigger/trigger/actions/workflows/ci.yml)
 
 Trigger is a robust network automation toolkit written in Python that was
 designed for interfacing with network devices and managing network
@@ -42,16 +41,9 @@ network devices with ease. Here are some of things that make Trigger tick:
 + Flexible access-list & firewall policy parser that can test access if access
   is permitted, or easily convert ACLs from one format to another.
 + Detailed support for timezones and maintenance windows.
++ Import your metadata from an existing [RANCID](http://shrubbery.net/rancid/) installation or a CSV file to get up-and-running quickly.
 + A suite of tools for simplifying many common tasks.
 
-New in version 1.2:
-
-+ Import your metadata from an existing [RANCID](http://shrubbery.net/rancid/) installation to get up-and-running quickly!
-
-New in version 1.3:
-
-+ Import your metadata from a CSV file and get up-and-running even quicker!
-
 ## Getting Started
 
 The best way to get started is to read the documentation hosted by [Read the
@@ -105,21 +97,13 @@ See the [Migration Guide](https://trigger.readthedocs.io/en/latest/migration.htm
 
 ### Before you begin
 
-+ The [develop](https://github.com/trigger/trigger/tree/develop) branch is
-  the default branch that will be active when you clone this repository. While
-  it is generally stable this branch is not considered production-ready. Use at
-  your own risk!
-+ The [master](https://github.com/trigger/trigger/tree/master) branch is
-  the stable branch, and will reflect the latest production-ready changes. It
-  is recommended that this is the branch you use if you are installing Trigger
-  for the first time.
-+ Each point release of Trigger is maintained as a [tag branch](https://github.com/trigger/trigger/tags). If you require a
++ The [main](https://github.com/trigger/trigger/tree/main) branch is the
+  primary branch for all development and releases. All pull requests target
+  `main`.
++ Each point release of Trigger is maintained as a [tag](https://github.com/trigger/trigger/tags). If you require a
   specific Trigger version, please refer to these.
 
 ### Get in touch!
 
-If you run into any snags, have questions, feedback, or just want to talk shop:
-[contact us](https://trigger.readthedocs.io/en/latest/#getting-help)!
-
-**Pro tip**: Find us on IRC at `#trigger` on Freenode
-([irc://irc.freenode.net/trigger](irc://irc.freenode.net/trigger)).
+If you run into any snags, have questions, feedback, or just want to talk shop,
+please open an issue on [GitHub Issues](https://github.com/trigger/trigger/issues).

{trigger-2.2.2 → trigger-2.2.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "trigger"
-version = "2.2.2"
+version = "2.2.4"
 description = "Network automation toolkit for managing network devices"
 readme = "README.md"
 license = "BSD-3-Clause"
@@ -42,6 +42,10 @@ dev = [
     "ruff>=0.1.0",
     "python-semantic-release>=9.0.0",
 ]
+docs = [
+    "sphinx>=7.0",
+    "sphinx_rtd_theme>=2.0",
+]
 
 [project.scripts]
 acl = "trigger.bin.acl:main"
@@ -106,69 +110,15 @@ select = [
     "UP",     # pyupgrade - Python 3 modernization
     "W",      # pycodestyle warnings
 ]
+extend-select = [
+    "D401",   # non-imperative-mood (not in google convention, enabled explicitly)
+]
 ignore = [
     # --- Formatter conflicts ---
     "COM812",   # trailing-comma-missing (handled by ruff formatter)
 
     # --- Kept from v2.0.0 baseline ---
-    "E402",     # module-import-not-at-top-of-file
     "E501",     # line-too-long (handled by formatter)
-    "E721",     # type-comparison (existing code style)
-    "E722",     # bare-except (intentional in many places)
-    "E741",     # ambiguous-variable-name (existing code style)
-    "F401",     # unused-import (may be used dynamically)
-    "F402",     # import-shadowed-by-loop-var
-    "F403",     # undefined-local-with-import-star
-    "F405",     # undefined-local-with-import-star-usage
-    "F523",     # string-dot-format-extra-positional-arguments
-    "F811",     # redefined-while-unused
-    "F821",     # undefined-name
-    "UP031",    # printf-string-formatting
-
-    # --- Bugbear exceptions ---
-    "B016",     # raise-literal (used intentionally in tests)
-    "B018",     # useless-expression (test assertions)
-
-    # --- Pre-commit specific ignores ---
-    "PLW1641",  # __hash__ implementation (false positive, requires __eq__ impl)
-    "PT028",    # pytest parameter defaults (false positive, not pytest functions)
-
-    # --- Docstring exceptions (not enforcing coverage/style) ---
-    "D100",     # undocumented-public-module
-    "D101",     # undocumented-public-class
-    "D102",     # undocumented-public-method
-    "D103",     # undocumented-public-function
-    "D104",     # undocumented-public-package
-    "D105",     # undocumented-magic-method
-    "D107",     # undocumented-public-init
-    "D200",     # unnecessary-multiline-docstring
-    "D205",     # missing-blank-line-after-summary
-    "D401",     # non-imperative-mood
-    "D402",     # signature-in-docstring
-    "D404",     # docstring-starts-with-this
-
-    # --- Complexity (deep refactoring territory) ---
-    "PLR0911",  # too-many-return-statements
-    "PLR0912",  # too-many-branches
-    "PLR0913",  # too-many-arguments
-    "PLR0915",  # too-many-statements
-    "PLR2004",  # magic-value-comparison
-    "PLW0603",  # global-statement (parser pattern)
-
-    # --- Security false positives for network toolkit ---
-    "S101",     # assert (used in tests)
-    "S105",     # hardcoded-password-string (false positives)
-    "S110",     # try-except-pass
-    "S112",     # try-except-continue
-    "S314",     # suspicious-xml-element-tree-usage
-    "S603",     # subprocess-without-shell-equals-true
-    "S605",     # start-process-with-a-shell (fix manually)
-    "S606",     # start-process-with-no-shell
-    "S608",     # hardcoded-sql-expression
-
-    # --- Other ---
-    "RUF012",   # mutable-class-default (too many in device metadata)
-    "SLF001",   # private-member-access (common in Twisted patterns)
 ]
 
 [tool.ruff.lint.pydocstyle]
@@ -233,6 +183,8 @@ minor_tags = ["feat"]
 patch_tags = ["fix", "perf"]
 
 [tool.semantic_release.changelog]
+
+[tool.semantic_release.changelog.default_templates]
 changelog_file = "CHANGELOG.md"
 
 [tool.semantic_release.branches.main]

{trigger-2.2.2 → trigger-2.2.4}/tests/test_acl.py

@@ -1,10 +1,5 @@
 #!/usr/bin/python
 
-__author__ = "Jathan McCollum, Michael Shields"
-__maintainer__ = "Jathan McCollum"
-__copyright__ = "Copyright 2005-2011 AOL Inc.; 2013 Salesforce.com"
-__version__ = "2.0"
-
 import contextlib
 import unittest
 from io import StringIO
@@ -72,7 +67,7 @@ class CheckRangeList(unittest.TestCase):
         """Check RangeList behavior as a container type."""
         r = acl.RangeList([1, (3, 6)])
         self.assertTrue(1 in r)
-        self.assertTrue(5 in r)
+        self.assertTrue(5 in r)  # noqa: PLR2004
         self.assertTrue(0 not in r)
         r = acl.RangeList([acl.TIP("10/8"), acl.TIP("172.16/12")])
         self.assertTrue(acl.TIP("10.1.1.1") in r)
@@ -695,7 +690,7 @@ class CheckMiscIOS(unittest.TestCase):
         # Python 3: map() returns an iterator, convert to list for comparison
         self.assertEqual(
             t.output_ios(),
-            list(map(lambda x: "permit icmp any any %d" % x, types)),
+            list(map(lambda x: "permit icmp any any %d" % x, types)),  # noqa: UP031
         )
 
     def testCounterSuppression(self):
@@ -748,8 +743,8 @@ class CheckTriggerIP(unittest.TestCase):
         # Until we fix inactive testing, this is legit
         self.assertTrue(obj in self.test_net)
 
-    def testInactive(self):
-        """Test an inactive IP object"""
+    def testInactiveAndNegated(self):
+        """Test an inactive and negated IP object"""
         test = "inactive: 1.2.3.4/32 except"
         obj = acl.TIP(test)
         self.assertEqual(str(obj), test)

{trigger-2.2.2 → trigger-2.2.4}/tests/test_acl_queue.py

@@ -6,7 +6,7 @@ Test the functionality of `~trigger.acl.queue` (aka task queue)
 Only tests SQLite for now.
 """
 
-import os
+import os  # noqa: F401
 import tempfile
 from pathlib import Path
 

{trigger-2.2.2 → trigger-2.2.4}/tests/test_changemgmt.py

@@ -4,13 +4,6 @@
 Tests for bounce windows and the stuff that goes with them.
 """
 
-__author__ = "Jathan McCollum, Michael Shields"
-__maintainer__ = "Jathan McCollum"
-__email__ = "jmccollum@salesforce.com"
-__copyright__ = "Copyright 2013 Salesforce.com"
-__version__ = "2.0"
-
-
 # Make sure we load the mock redis library
 from utils import mock_redis
 

{trigger-2.2.2 → trigger-2.2.4}/tests/test_except.py

@@ -1,5 +1,5 @@
 # a test for except processing
-import os
+import os  # noqa: F401
 import sys
 from pathlib import Path
 

{trigger-2.2.2 → trigger-2.2.4}/tests/test_netdevices.py

@@ -7,11 +7,6 @@ This uses the mockups of netdevices.xml, acls.db, and autoacls.py in
 tests/data.
 """
 
-__author__ = "Jathan McCollum, Michael Shields"
-__maintainer__ = "Jathan McCollum"
-__copyright__ = "Copyright 2005-2011 AOL Inc.; 2013 Salesforce.com"
-__version__ = "2.0"
-
 import unittest
 
 # Make sure we load the mock redis library

{trigger-2.2.2 → trigger-2.2.4}/tests/test_scripts.py

@@ -2,11 +2,6 @@
 
 # tests/scripts.py
 
-__author__ = "Michael Shields"
-__maintainer__ = "Jathan McCollum"
-__copyright__ = "Copyright 2005-2011 AOL Inc."
-__version__ = "1.1"
-
 import os
 import subprocess
 import unittest

{trigger-2.2.2 → trigger-2.2.4}/tests/test_tacacsrc.py

@@ -1,11 +1,5 @@
 #!/usr/bin/env python
 
-__author__ = "Jathan McCollum, Michael Shields"
-__maintainer__ = "Jathan McCollum"
-__copyright__ = "Copyright 2005-2011 AOL Inc.; 2013 Salesforce.com"
-__version__ = "2.0.1"
-
-
 import os
 import tempfile
 import unittest
@@ -13,7 +7,7 @@ from pathlib import Path
 from unittest.mock import patch
 
 from trigger.conf import settings
-from trigger.tacacsrc import Credentials, Tacacsrc
+from trigger.tacacsrc import Credentials, Tacacsrc, convert_tacacsrc
 
 # Constants
 aol = Credentials("jschmoe", "abc123", "aol")
@@ -147,6 +141,31 @@ class TacacsrcTest(unittest.TestCase):
         new_perms = self._get_perms(fname)
         self.assertNotEqual(new_perms, RIGHT_PERMS)
 
+    def test_convert_tacacsrc(self):
+        """Test that convert_tacacsrc reads old creds and writes via GPG."""
+        captured = {}
+
+        def spy_encrypt_and_write(self):
+            captured["creds"] = dict(self.creds)
+            captured["use_gpg"] = self.use_gpg
+            captured["file_name"] = self.file_name
+
+        with (
+            patch("trigger.tacacsrc.Tacacsrc", MockTacacsrc),
+            patch.object(MockTacacsrc, "_encrypt_and_write", spy_encrypt_and_write),
+            patch.object(MockTacacsrc, "_update_perms"),
+        ):
+            convert_tacacsrc()
+
+        # GPG write path should have been reached
+        self.assertIn("creds", captured)
+        # All original credentials should be preserved
+        for name, value in ALL_CREDS:
+            self.assertEqual(captured["creds"][name], value)
+        # Should be in GPG mode targeting the .gpg file
+        self.assertTrue(captured["use_gpg"])
+        self.assertEqual(captured["file_name"], settings.TACACSRC + ".gpg")
+
 
 if __name__ == "__main__":
     unittest.main()

{trigger-2.2.2 → trigger-2.2.4}/tests/test_templates.py

@@ -3,7 +3,7 @@ from io import StringIO
 
 from trigger.cmds import Commando
 from trigger.netdevices import NetDevices
-from trigger.utils.templates import *
+from trigger.utils.templates import *  # noqa: F403
 
 # Constants
 DEVICE_NAME = "test1-abc.net.aol.com"
@@ -112,12 +112,12 @@ class CheckTemplates(unittest.TestCase):
 
     def testTemplatePath(self):
         """Test that template path is correct."""
-        t_path = get_template_path("show clock", dev_type="cisco_ios")
+        t_path = get_template_path("show clock", dev_type="cisco_ios")  # noqa: F405
         self.assertTrue("vendor/ntc_templates/cisco_ios_show_clock.template" in t_path)
 
     def testGetTextFsmObject(self):
         """Test that we get structured data back from cli output."""
-        data = get_textfsm_object(self.re_table, cli_data)
+        data = get_textfsm_object(self.re_table, cli_data)  # noqa: F405
         self.assertTrue(isinstance(data, dict))
         keys = ["dayweek", "time", "timezone", "year", "day", "month"]
         # Python 3: dict.has_key() removed, use 'in' operator

trigger-2.2.4/tests/test_twister.py

@@ -0,0 +1,255 @@
+import re
+
+import pytest
+
+from trigger.conf import settings
+from trigger.twister import compile_prompt_pattern, prompt_match_start
+
+
+def test_ioslike_prompt_pattern_enabled():
+    """Test enabled that IOS-like prompt patterns match correctly."""
+    pat = settings.IOSLIKE_PROMPT_PAT
+
+    prompt_tests = [
+        "foo-bar1#",
+        "foo-bar1# ",
+        "foo-bar1(config)# ",
+        "\rfoo-bar01(config)# \x08 ",  # "Bonus" backspace in there
+        "foo-bar01(config) \r#",  # "Bonus" '\s\r' in there
+    ]
+
+    for prompt in prompt_tests:
+        assert re.search(pat, prompt) is not None
+
+
+def test_ioslike_prompt_pattern_nonenabled():
+    """Test non-enabled that IOS-like prompt patterns match correctly."""
+    pat = settings.IOSLIKE_ENABLE_PAT
+
+    prompt_tests = [
+        "foo-bar1>",
+        "foo-bar1> ",
+        "\rfoo-bar01)> \x08 ",  # "Bonus" backspace in there
+        "foo-bar01) \r>",  # "Bonus" '\s\r' in there
+    ]
+
+    for prompt in prompt_tests:
+        assert re.search(pat, prompt) is not None
+
+
+# =============================================================================
+# False-positive prevention tests (Issue #317)
+# =============================================================================
+
+
+class TestFalsePositivePrevention:
+    """Verify that command output containing '>' or '#' is NOT matched as a prompt."""
+
+    def test_juniper_rsync_flag_not_matched(self):
+        """Juniper 'Flags: <Sync RSync>' must not match as a prompt (issue #317)."""
+        pat = compile_prompt_pattern(settings.PROMPT_PATTERNS["juniper"])
+        buffer = "Flags: <Sync RSync>\r\n"
+        assert pat.search(buffer) is None
+
+    def test_ioslike_comment_not_matched(self):
+        """A '# comment' line must not match IOS-like prompt pattern."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_PROMPT_PAT)
+        buffer = "some output\r\n# This is a comment in output\r\n"
+        assert pat.search(buffer) is None
+
+    def test_enable_angle_bracket_not_matched(self):
+        """A '>' inside command output must not match the enable pattern."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_ENABLE_PAT)
+        buffer = "Description: Traffic >1Gbps\r\nMore output here\r\n"
+        assert pat.search(buffer) is None
+
+    def test_ioslike_prompt_mid_line_not_matched(self):
+        """IOS-like prompt pattern should not match '#' in the middle of a line."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_PROMPT_PAT)
+        buffer = "some leading text device-name# "
+        assert pat.search(buffer) is None
+
+    def test_juniper_xml_angle_bracket_not_matched(self):
+        """Juniper XML output with '>' should not match as prompt."""
+        pat = compile_prompt_pattern(settings.PROMPT_PATTERNS["juniper"])
+        buffer = '<rpc-reply xmlns:junos="http://xml.juniper.net">\r\n'
+        assert pat.search(buffer) is None
+
+
+# =============================================================================
+# Valid prompt regression tests
+# =============================================================================
+
+
+class TestValidPromptMatching:
+    """Verify that real prompts still match correctly after the anchoring fix."""
+
+    def test_first_prompt_no_preceding_newline(self):
+        """A prompt at the very start of the buffer (no preceding newline) must match."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_PROMPT_PAT)
+        buffer = "router1# "
+        m = pat.search(buffer)
+        assert m is not None
+
+    def test_prompt_after_newline(self):
+        """A prompt after \\n must match."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_PROMPT_PAT)
+        buffer = "some output\nrouter1# "
+        m = pat.search(buffer)
+        assert m is not None
+        assert prompt_match_start(m) == len("some output\n")
+
+    def test_prompt_after_crlf(self):
+        """A prompt after \\r\\n must match."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_PROMPT_PAT)
+        buffer = "some output\r\nrouter1# "
+        m = pat.search(buffer)
+        assert m is not None
+        assert prompt_match_start(m) == len("some output\r\n")
+
+    def test_juniper_prompt_after_master_banner(self):
+        """Juniper prompt after {master} banner must match."""
+        pat = compile_prompt_pattern(settings.PROMPT_PATTERNS["juniper"])
+        buffer = "{master}\nuser@router> "
+        m = pat.search(buffer)
+        assert m is not None
+
+    def test_ioslike_config_mode_prompt(self):
+        """IOS config mode prompt must match."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_PROMPT_PAT)
+        buffer = "output line\nswitch1(config)# "
+        m = pat.search(buffer)
+        assert m is not None
+
+    def test_enable_prompt_at_start(self):
+        """Enable prompt at start of buffer must match."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_ENABLE_PAT)
+        buffer = "router1> "
+        m = pat.search(buffer)
+        assert m is not None
+        assert prompt_match_start(m) == 0
+
+    def test_paloalto_prompt_with_crlf(self):
+        """Palo Alto prompt with \\r\\n prefix must match."""
+        pat = compile_prompt_pattern(settings.PROMPT_PATTERNS["paloalto"])
+        buffer = "output\r\nadmin@fw1> "
+        m = pat.search(buffer)
+        assert m is not None
+
+
+# =============================================================================
+# prompt_match_start correctness tests
+# =============================================================================
+
+
+class TestPromptMatchStart:
+    """Verify prompt_match_start returns the correct index."""
+
+    def test_match_at_buffer_start(self):
+        """Match at buffer start returns 0."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_PROMPT_PAT)
+        buffer = "router1# "
+        m = pat.search(buffer)
+        assert m is not None
+        assert prompt_match_start(m) == 0
+
+    def test_match_after_lf(self):
+        """Match after \\n skips the newline character."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_PROMPT_PAT)
+        buffer = "output\nrouter1# "
+        m = pat.search(buffer)
+        assert m is not None
+        # The \n is at index 6, prompt starts at index 7
+        assert prompt_match_start(m) == 7  # noqa: PLR2004
+
+    def test_match_after_crlf(self):
+        """Match after \\r\\n skips both characters."""
+        pat = compile_prompt_pattern(settings.IOSLIKE_PROMPT_PAT)
+        buffer = "output\r\nrouter1# "
+        m = pat.search(buffer)
+        assert m is not None
+        # \r at 6, \n at 7, prompt starts at 8
+        assert prompt_match_start(m) == 8  # noqa: PLR2004
+
+
+# =============================================================================
+# compile_prompt_pattern behavior tests
+# =============================================================================
+
+
+class TestCompilePromptPattern:
+    """Verify compile_prompt_pattern handles various inputs correctly."""
+
+    def test_already_compiled_pattern_returned_unchanged(self):
+        """An already-compiled re.Pattern should be returned as-is."""
+        compiled = re.compile(r"foo#\s?$")
+        result = compile_prompt_pattern(compiled)
+        assert result is compiled
+
+    def test_pattern_starting_with_caret_not_double_anchored(self):
+        """A pattern starting with ^ should not get a redundant prefix."""
+        pat = compile_prompt_pattern(r"^\S+#\s?$")
+        assert pat.search("router1# ") is not None
+        # Verify no double-anchor by checking pattern string
+        assert not pat.pattern.startswith(r"(?:^|\r?\n)^")
+
+    def test_pattern_starting_with_backslash_r_not_prefixed(self):
+        """A pattern starting with \\r should not get a prefix (e.g. paloalto)."""
+        pat = compile_prompt_pattern(r"\r\n\S+(?:\>|#)\s?$")
+        # Pattern should still work
+        assert pat.search("\r\nadmin@fw1> ") is not None
+        # Verify no prefix added
+        assert not pat.pattern.startswith(r"(?:^|\r?\n)\r")
+
+    def test_pattern_starting_with_backslash_n_not_prefixed(self):
+        """A pattern starting with \\n should not get a prefix."""
+        pat = compile_prompt_pattern(r"\n\S+#\s?$")
+        assert not pat.pattern.startswith(r"(?:^|\r?\n)\n")
+
+    def test_multiline_flag_is_set(self):
+        """The compiled pattern should have re.MULTILINE enabled."""
+        pat = compile_prompt_pattern(r"\S+#\s?$")
+        assert pat.flags & re.MULTILINE
+
+
+# =============================================================================
+# Parametrized vendor pattern tests
+# =============================================================================
+
+
+# Map each vendor pattern to a sample prompt that should match on its own line
+VENDOR_PROMPT_SAMPLES = {
+    "aruba": "(Aruba7010) #",
+    "avocent": "admin-0->",
+    "citrix": " Done\n",
+    "cumulus": "cumulus@switch# ",
+    "f5": "admin@(bigip1)(cfg-sync Standalone)(Active)(/Common)(tmos)# ",
+    "juniper": "user@router> ",
+    "mrv": "\r\nMRV OptiSwitch 1 >>",
+    "netscreen": "fw1-> ",
+    "paloalto": "\r\nadmin@fw1> ",
+    "pica8": "admin@switch> ",
+}
+
+
+@pytest.mark.parametrize(
+    ("vendor", "sample_prompt"),
+    list(VENDOR_PROMPT_SAMPLES.items()),
+    ids=list(VENDOR_PROMPT_SAMPLES.keys()),
+)
+def test_vendor_pattern_matches_sample_prompt(vendor, sample_prompt):
+    """Each vendor pattern must match its expected sample prompt."""
+    pat = compile_prompt_pattern(settings.PROMPT_PATTERNS[vendor])
+    assert pat.search(sample_prompt) is not None, (
+        f"Vendor {vendor!r} pattern failed to match sample prompt {sample_prompt!r}"
+    )
+
+
+@pytest.mark.parametrize(
+    "vendor",
+    list(settings.PROMPT_PATTERNS.keys()),
+)
+def test_vendor_pattern_compiles_without_error(vendor):
+    """Every vendor pattern in PROMPT_PATTERNS must compile successfully."""
+    pat = compile_prompt_pattern(settings.PROMPT_PATTERNS[vendor])
+    assert isinstance(pat, re.Pattern)

{trigger-2.2.2 → trigger-2.2.4}/tests/test_twister2.py

@@ -7,10 +7,4 @@ This uses the mockups of netdevices.xml in
 tests/data.
 """
 
-__author__ = "Thomas Cuthbert, Jathan McCollum"
-__maintainer__ = "Jathan McCollum"
-__copyright__ = "Copyright 2005-2011 AOL Inc.; 2013 Salesforce.com.; 2016 Dropbox"
-__version__ = "1.0"
-
-
 # TODO: see http://twistedmatrix.com/trac/wiki/TwistedTrial