trcc-linux 8.3.4__tar.gz → 8.3.6__tar.gz

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: trcc-linux
-Version: 8.3.4
+Version: 8.3.6
 Summary: Linux implementation of Thermalright LCD Control Center
 Project-URL: Homepage, https://github.com/Lexonight1/thermalright-trcc-linux
 Project-URL: Documentation, https://github.com/Lexonight1/thermalright-trcc-linux#readme
@@ -108,7 +108,7 @@ Description-Content-Type: text/markdown
 
 Native Linux port of the Thermalright LCD Control Center (Windows TRCC 2.1.2). Control and customize the LCD displays and LED segment displays on Thermalright CPU coolers, AIO pump heads, and fan hubs — entirely from Linux.
 
-> **This project wouldn't exist without our testers.** I only own one device. Every supported device in this list works because someone plugged it in, ran `trcc report`, and told me what broke. 29 testers helped us go from "SCSI only" to full C# feature parity with 6 USB protocols, 16 FBL resolutions, and 12 LED styles. Open source at its best — see [Contributors](#contributors) below.
+> **This project wouldn't exist without our testers.** I only own one device. Every supported device in this list works because someone plugged it in, ran `trcc report`, and told me what broke. 32 testers helped us go from "SCSI only" to full C# feature parity with 6 USB protocols, 16 FBL resolutions, and 12 LED styles. Open source at its best — see [Contributors](#contributors) below.
 
 > Unofficial community project, not affiliated with Thermalright. Built with [Claude](https://claude.ai) (AI) for protocol reverse engineering and code generation, guided by human architecture decisions and logical assessment.
 
@@ -186,13 +186,13 @@ Pre-built packages are available for every major distro. No pip, no venv, no PEP
 
 **Fedora / openSUSE / Nobara:**
 ```bash
-sudo dnf install https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux-8.3.4-1.fc43.noarch.rpm
+sudo dnf install https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux-8.3.6-1.fc43.noarch.rpm
 ```
 
 **Ubuntu 24.04+ / Debian 13+ / Mint 22+ / Pop!_OS 24.04+ / Zorin 17+:**
 ```bash
-curl -LO https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux_8.3.4-1_all.deb
-sudo dpkg -i trcc-linux_8.3.4-1_all.deb
+curl -LO https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux_8.3.6-1_all.deb
+sudo dpkg -i trcc-linux_8.3.6-1_all.deb
 sudo apt-get install -f    # pulls in any missing dependencies
 ```
 
@@ -200,8 +200,8 @@ sudo apt-get install -f    # pulls in any missing dependencies
 
 **Arch / CachyOS / Manjaro / EndeavourOS / Garuda:**
 ```bash
-curl -LO https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux-8.3.4-1-any.pkg.tar.zst
-sudo pacman -U trcc-linux-8.3.4-1-any.pkg.tar.zst
+curl -LO https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux-8.3.6-1-any.pkg.tar.zst
+sudo pacman -U trcc-linux-8.3.6-1-any.pkg.tar.zst
 ```
 
 **NixOS** — add to your `flake.nix` inputs:
@@ -414,12 +414,15 @@ A big thanks to everyone who has contributed invaluable reports to this project:
 - **[jezzaw007](https://github.com/jezzaw007)** — Preview rotation & overlay resume bug reports
 - **[Pewful2021](https://github.com/Pewful2021)** — PA120 LED troubleshooting
 - **[lallemandgianni-boop](https://github.com/lallemandgianni-boop)** — PA120 DIGITAL LCD PID investigation
+- **[sleeper14200](https://github.com/sleeper14200)** — Linux Mint .deb compatibility bug report
+- **[riodevelop](https://github.com/riodevelop)** — Frozen Warframe 240 HID color bug report
+- **[wobbegongus](https://github.com/wobbegongus)** — Frozen Warframe 240 HID color bug report
 
 ## Stargazers
 
 Thanks to everyone who took a moment to star this project — it means the world.
 
-**[alessa-lara](https://github.com/alessa-lara)** · **[ArcaneCoder404](https://github.com/ArcaneCoder404)** · **[betolink](https://github.com/betolink)** · **[bive242](https://github.com/bive242)** · **[BrunoLeguizamon05](https://github.com/BrunoLeguizamon05)** · **[cancos1](https://github.com/cancos1)** · **[codeflitting](https://github.com/codeflitting)** · **[dabombUSA](https://github.com/dabombUSA)** · **[damachine](https://github.com/damachine)** · **[DasFlogetier](https://github.com/DasFlogetier)** · **[emaspa](https://github.com/emaspa)** · **[honjow](https://github.com/honjow)** · **[jezzaw007](https://github.com/jezzaw007)** · **[jhlasnik](https://github.com/jhlasnik)** · **[jmo808](https://github.com/jmo808)** · **[knappstar](https://github.com/knappstar)** · **[mgaruccio](https://github.com/mgaruccio)** · **[michael-spinelli](https://github.com/michael-spinelli)** · **[mkogut](https://github.com/mkogut)** · **[nathanielhernandez](https://github.com/nathanielhernandez)** · **[oddajpierscien](https://github.com/oddajpierscien)** · **[Pewful2021](https://github.com/Pewful2021)** · **[Pikarz](https://github.com/Pikarz)** · **[Rehaell](https://github.com/Rehaell)** · **[rslater](https://github.com/rslater)** · **[Smokemic](https://github.com/Smokemic)** · **[spiritofjon](https://github.com/spiritofjon)** · **[Vydon](https://github.com/Vydon)** · **[Xentrino](https://github.com/Xentrino)** · **[Ziusz](https://github.com/Ziusz)**
+**[alessa-lara](https://github.com/alessa-lara)** · **[ArcaneCoder404](https://github.com/ArcaneCoder404)** · **[betolink](https://github.com/betolink)** · **[bive242](https://github.com/bive242)** · **[BrunoLeguizamon05](https://github.com/BrunoLeguizamon05)** · **[cancos1](https://github.com/cancos1)** · **[codeflitting](https://github.com/codeflitting)** · **[dabombUSA](https://github.com/dabombUSA)** · **[damachine](https://github.com/damachine)** · **[DasFlogetier](https://github.com/DasFlogetier)** · **[emaspa](https://github.com/emaspa)** · **[honjow](https://github.com/honjow)** · **[jezzaw007](https://github.com/jezzaw007)** · **[jhlasnik](https://github.com/jhlasnik)** · **[jmo808](https://github.com/jmo808)** · **[knappstar](https://github.com/knappstar)** · **[mgaruccio](https://github.com/mgaruccio)** · **[michael-spinelli](https://github.com/michael-spinelli)** · **[mkogut](https://github.com/mkogut)** · **[nathanielhernandez](https://github.com/nathanielhernandez)** · **[oddajpierscien](https://github.com/oddajpierscien)** · **[Pewful2021](https://github.com/Pewful2021)** · **[Pikarz](https://github.com/Pikarz)** · **[qussaif10](https://github.com/qussaif10)** · **[Rehaell](https://github.com/Rehaell)** · **[rslater](https://github.com/rslater)** · **[shadowepaxeor-glitch](https://github.com/shadowepaxeor-glitch)** · **[Smokemic](https://github.com/Smokemic)** · **[spiritofjon](https://github.com/spiritofjon)** · **[Vydon](https://github.com/Vydon)** · **[Xentrino](https://github.com/Xentrino)** · **[Ziusz](https://github.com/Ziusz)**
 
 ## Faulkers
 

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/README.md

@@ -44,7 +44,7 @@
 
 Native Linux port of the Thermalright LCD Control Center (Windows TRCC 2.1.2). Control and customize the LCD displays and LED segment displays on Thermalright CPU coolers, AIO pump heads, and fan hubs — entirely from Linux.
 
-> **This project wouldn't exist without our testers.** I only own one device. Every supported device in this list works because someone plugged it in, ran `trcc report`, and told me what broke. 29 testers helped us go from "SCSI only" to full C# feature parity with 6 USB protocols, 16 FBL resolutions, and 12 LED styles. Open source at its best — see [Contributors](#contributors) below.
+> **This project wouldn't exist without our testers.** I only own one device. Every supported device in this list works because someone plugged it in, ran `trcc report`, and told me what broke. 32 testers helped us go from "SCSI only" to full C# feature parity with 6 USB protocols, 16 FBL resolutions, and 12 LED styles. Open source at its best — see [Contributors](#contributors) below.
 
 > Unofficial community project, not affiliated with Thermalright. Built with [Claude](https://claude.ai) (AI) for protocol reverse engineering and code generation, guided by human architecture decisions and logical assessment.
 
@@ -122,13 +122,13 @@ Pre-built packages are available for every major distro. No pip, no venv, no PEP
 
 **Fedora / openSUSE / Nobara:**
 ```bash
-sudo dnf install https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux-8.3.4-1.fc43.noarch.rpm
+sudo dnf install https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux-8.3.6-1.fc43.noarch.rpm
 ```
 
 **Ubuntu 24.04+ / Debian 13+ / Mint 22+ / Pop!_OS 24.04+ / Zorin 17+:**
 ```bash
-curl -LO https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux_8.3.4-1_all.deb
-sudo dpkg -i trcc-linux_8.3.4-1_all.deb
+curl -LO https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux_8.3.6-1_all.deb
+sudo dpkg -i trcc-linux_8.3.6-1_all.deb
 sudo apt-get install -f    # pulls in any missing dependencies
 ```
 
@@ -136,8 +136,8 @@ sudo apt-get install -f    # pulls in any missing dependencies
 
 **Arch / CachyOS / Manjaro / EndeavourOS / Garuda:**
 ```bash
-curl -LO https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux-8.3.4-1-any.pkg.tar.zst
-sudo pacman -U trcc-linux-8.3.4-1-any.pkg.tar.zst
+curl -LO https://github.com/Lexonight1/thermalright-trcc-linux/releases/latest/download/trcc-linux-8.3.6-1-any.pkg.tar.zst
+sudo pacman -U trcc-linux-8.3.6-1-any.pkg.tar.zst
 ```
 
 **NixOS** — add to your `flake.nix` inputs:
@@ -350,12 +350,15 @@ A big thanks to everyone who has contributed invaluable reports to this project:
 - **[jezzaw007](https://github.com/jezzaw007)** — Preview rotation & overlay resume bug reports
 - **[Pewful2021](https://github.com/Pewful2021)** — PA120 LED troubleshooting
 - **[lallemandgianni-boop](https://github.com/lallemandgianni-boop)** — PA120 DIGITAL LCD PID investigation
+- **[sleeper14200](https://github.com/sleeper14200)** — Linux Mint .deb compatibility bug report
+- **[riodevelop](https://github.com/riodevelop)** — Frozen Warframe 240 HID color bug report
+- **[wobbegongus](https://github.com/wobbegongus)** — Frozen Warframe 240 HID color bug report
 
 ## Stargazers
 
 Thanks to everyone who took a moment to star this project — it means the world.
 
-**[alessa-lara](https://github.com/alessa-lara)** · **[ArcaneCoder404](https://github.com/ArcaneCoder404)** · **[betolink](https://github.com/betolink)** · **[bive242](https://github.com/bive242)** · **[BrunoLeguizamon05](https://github.com/BrunoLeguizamon05)** · **[cancos1](https://github.com/cancos1)** · **[codeflitting](https://github.com/codeflitting)** · **[dabombUSA](https://github.com/dabombUSA)** · **[damachine](https://github.com/damachine)** · **[DasFlogetier](https://github.com/DasFlogetier)** · **[emaspa](https://github.com/emaspa)** · **[honjow](https://github.com/honjow)** · **[jezzaw007](https://github.com/jezzaw007)** · **[jhlasnik](https://github.com/jhlasnik)** · **[jmo808](https://github.com/jmo808)** · **[knappstar](https://github.com/knappstar)** · **[mgaruccio](https://github.com/mgaruccio)** · **[michael-spinelli](https://github.com/michael-spinelli)** · **[mkogut](https://github.com/mkogut)** · **[nathanielhernandez](https://github.com/nathanielhernandez)** · **[oddajpierscien](https://github.com/oddajpierscien)** · **[Pewful2021](https://github.com/Pewful2021)** · **[Pikarz](https://github.com/Pikarz)** · **[Rehaell](https://github.com/Rehaell)** · **[rslater](https://github.com/rslater)** · **[Smokemic](https://github.com/Smokemic)** · **[spiritofjon](https://github.com/spiritofjon)** · **[Vydon](https://github.com/Vydon)** · **[Xentrino](https://github.com/Xentrino)** · **[Ziusz](https://github.com/Ziusz)**
+**[alessa-lara](https://github.com/alessa-lara)** · **[ArcaneCoder404](https://github.com/ArcaneCoder404)** · **[betolink](https://github.com/betolink)** · **[bive242](https://github.com/bive242)** · **[BrunoLeguizamon05](https://github.com/BrunoLeguizamon05)** · **[cancos1](https://github.com/cancos1)** · **[codeflitting](https://github.com/codeflitting)** · **[dabombUSA](https://github.com/dabombUSA)** · **[damachine](https://github.com/damachine)** · **[DasFlogetier](https://github.com/DasFlogetier)** · **[emaspa](https://github.com/emaspa)** · **[honjow](https://github.com/honjow)** · **[jezzaw007](https://github.com/jezzaw007)** · **[jhlasnik](https://github.com/jhlasnik)** · **[jmo808](https://github.com/jmo808)** · **[knappstar](https://github.com/knappstar)** · **[mgaruccio](https://github.com/mgaruccio)** · **[michael-spinelli](https://github.com/michael-spinelli)** · **[mkogut](https://github.com/mkogut)** · **[nathanielhernandez](https://github.com/nathanielhernandez)** · **[oddajpierscien](https://github.com/oddajpierscien)** · **[Pewful2021](https://github.com/Pewful2021)** · **[Pikarz](https://github.com/Pikarz)** · **[qussaif10](https://github.com/qussaif10)** · **[Rehaell](https://github.com/Rehaell)** · **[rslater](https://github.com/rslater)** · **[shadowepaxeor-glitch](https://github.com/shadowepaxeor-glitch)** · **[Smokemic](https://github.com/Smokemic)** · **[spiritofjon](https://github.com/spiritofjon)** · **[Vydon](https://github.com/Vydon)** · **[Xentrino](https://github.com/Xentrino)** · **[Ziusz](https://github.com/Ziusz)**
 
 ## Faulkers
 

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "trcc-linux"
-version = "8.3.4"
+version = "8.3.6"
 description = "Linux implementation of Thermalright LCD Control Center"
 readme = "README.md"
 license = "GPL-3.0-or-later"

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/src/trcc/__version__.py

@@ -1,4 +1,4 @@
 """TRCC Linux version information. History in doc/CHANGELOG.md."""
 
-__version__ = "8.3.4"
+__version__ = "8.3.6"
 __version_info__ = tuple(int(x) for x in __version__.split("."))

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/src/trcc/core/models.py

@@ -1384,8 +1384,8 @@ FBL_PROFILES: dict[int, DeviceProfile] = {
     36:  DeviceProfile(240,  240),
     37:  DeviceProfile(240,  240),
     50:  DeviceProfile(320,  240,  rotate=True),
-    51:  DeviceProfile(320,  240,  big_endian=True, rotate=True),   # SPIMode=2
-    53:  DeviceProfile(320,  240,  big_endian=True, rotate=True),   # SPIMode=2
+    51:  DeviceProfile(320,  240,  rotate=True),                     # HID Type 2 → SPIMode=1
+    53:  DeviceProfile(320,  240,  rotate=True),                     # HID Type 2 → SPIMode=1
     54:  DeviceProfile(360,  360,  jpeg=True),
     58:  DeviceProfile(320,  240,  rotate=True),
     64:  DeviceProfile(640,  480,  rotate=True),

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/src/trcc/qt_components/color_and_add_panels.py

@@ -8,20 +8,16 @@ from __future__ import annotations
 from PySide6.QtCore import Qt, Signal
 from PySide6.QtGui import QColor, QFont, QIcon
 from PySide6.QtWidgets import (
-    QComboBox,
     QFrame,
-    QLabel,
     QLineEdit,
     QPushButton,
     QSpinBox,
-    QVBoxLayout,
 )
 
 from ..core.models import OverlayElementConfig, OverlayMode
 from .assets import Assets
 from .base import set_background_pixmap
 from .constants import Colors, Layout, Sizes, Styles
-from .overlay_element import CATEGORY_COLORS, CATEGORY_NAMES, SUB_METRICS
 
 
 class ColorPickerPanel(QFrame):
@@ -242,6 +238,7 @@ class AddElementPanel(QFrame):
     """Add new overlay element panel (matches UCXiTongXianShiAdd 230x430)."""
 
     element_added = Signal(object)  # OverlayElementConfig
+    hardware_requested = Signal()   # Show activity sidebar for hardware pick
 
     ELEMENT_TYPES = [
         ("Hardware Data", OverlayMode.HARDWARE),
@@ -271,63 +268,12 @@ class AddElementPanel(QFrame):
             btn.clicked.connect(lambda checked, m=mode: self._on_type_clicked(m))
             y += Layout.ADD_BTN_DY
 
-        # Hardware category combo
-        self.hw_frame = QFrame(self)
-        self.hw_frame.setGeometry(Layout.ADD_BTN_X, y + 10, Layout.ADD_BTN_W, 100)
-        self.hw_frame.setStyleSheet("background: transparent;")
-
-        hw_layout = QVBoxLayout(self.hw_frame)
-        hw_layout.setContentsMargins(0, 0, 0, 0)
-
-        hw_label = QLabel("Category:")
-        hw_label.setStyleSheet(f"color: {Colors.STATUS_TEXT}; font-size: 10px; background: transparent;")
-        hw_layout.addWidget(hw_label)
-
-        self.hw_combo = QComboBox()
-        self.hw_combo.addItems(list(CATEGORY_NAMES.values()))
-        self.hw_combo.setToolTip("Hardware category")
-        self.hw_combo.setStyleSheet("""
-            QComboBox {
-                background-color: rgba(51, 51, 51, 180);
-                color: white; border: 1px solid #555; padding: 5px;
-            }
-        """)
-        hw_layout.addWidget(self.hw_combo)
-
-        metric_label = QLabel("Metric:")
-        metric_label.setStyleSheet(f"color: {Colors.STATUS_TEXT}; font-size: 10px; background: transparent;")
-        hw_layout.addWidget(metric_label)
-
-        self.metric_combo = QComboBox()
-        self.metric_combo.setToolTip("Sensor metric")
-        self.metric_combo.setStyleSheet("""
-            QComboBox {
-                background-color: rgba(51, 51, 51, 180);
-                color: white; border: 1px solid #555; padding: 5px;
-            }
-        """)
-        hw_layout.addWidget(self.metric_combo)
-
-        self.hw_combo.currentIndexChanged.connect(self._on_category_changed)
-        self._on_category_changed(0)
-
-        self.hw_frame.setVisible(False)
-
-    def _on_category_changed(self, idx):
-        self.metric_combo.clear()
-        metrics = SUB_METRICS.get(idx, {})
-        self.metric_combo.addItems(list(metrics.values()))
-
     def _on_type_clicked(self, mode: OverlayMode):
-        cfg = OverlayElementConfig(mode=mode)
-
         if mode == OverlayMode.HARDWARE:
-            self.hw_frame.setVisible(True)
-            cat_idx = self.hw_combo.currentIndex()
-            cfg.main_count = cat_idx
-            cfg.sub_count = self.metric_combo.currentIndex() + 1
-            cfg.color = CATEGORY_COLORS.get(cat_idx, '#FFFFFF')
-        else:
-            self.hw_frame.setVisible(False)
+            # Show activity sidebar for hardware sensor selection
+            # (Windows: hardware metrics listed as separate section in add panel)
+            self.hardware_requested.emit()
+            return
 
+        cfg = OverlayElementConfig(mode=mode)
         self.element_added.emit(cfg)

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/src/trcc/qt_components/lcd_handler.py

@@ -159,7 +159,11 @@ class LCDHandler:
                     break
 
     def _restore_mask(self, cfg: dict) -> None:
-        """Restore mask overlay from saved config (applied on top of theme)."""
+        """Restore mask overlay from saved config (applied on top of theme).
+
+        Skips if the theme already loaded this mask via its config.json
+        reference — avoids invalidating the pre-built video cache.
+        """
         mask_path = cfg.get('mask_path')
         if not mask_path:
             return
@@ -167,6 +171,14 @@ class LCDHandler:
         if not mask_dir.exists():
             log.warning("Saved mask path not found: %s", mask_path)
             return
+        # Reference-based themes embed mask path in config.json — the theme
+        # loader already loaded it and built the video cache with it.
+        # Re-loading here would invalidate that cache (display_svc._cache=None)
+        # causing mask-less frames until the fallback renderer catches up.
+        svc = self._lcd._display_svc
+        if svc and svc._mask_source_dir == mask_dir:
+            log.debug("Mask %s already loaded by theme reference, skipping", mask_dir)
+            return
         log.info("Restoring saved mask: %s", mask_dir)
         result = self._lcd.load_mask_standalone(str(mask_dir))
         image = result.get('image')

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/src/trcc/qt_components/trcc_app.py

@@ -887,12 +887,16 @@ class TRCCApp(QMainWindow):
         active_btn = panel_to_button.get(index, 0)
         for i, btn in enumerate(self.mode_buttons):
             btn.setChecked(i == active_btn)
+        # Hide activity sidebar when leaving settings tab (index 2)
+        if index != 2:
+            self.uc_activity_sidebar.setVisible(False)
 
     def _show_view(self, view: str):
         self.form_container.setVisible(view == 'form')
         self.uc_about.setVisible(view == 'about')
         self.uc_system_info.setVisible(view == 'sysinfo')
         self.uc_led_control.setVisible(view == 'led')
+        self.uc_activity_sidebar.setVisible(False)
 
         show_form1_btns = (view == 'sysinfo')
         self.form1_close_btn.setVisible(show_form1_btns)
@@ -943,8 +947,10 @@ class TRCCApp(QMainWindow):
         self.uc_theme_setting.background_changed.connect(self._on_background_toggle)
         self.uc_theme_setting.screencast_changed.connect(self._on_screencast_toggle)
         self.uc_theme_setting.delegate.connect(self._on_settings_delegate)
-        self.uc_theme_setting.overlay_grid.add_requested.connect(
+        self.uc_theme_setting.add_panel.hardware_requested.connect(
             self._on_overlay_add_requested)
+        self.uc_theme_setting.add_panel.element_added.connect(
+            lambda _: self.uc_activity_sidebar.setVisible(False))
         self.uc_theme_setting.overlay_grid.toggle_changed.connect(
             self._on_overlay_toggle)
         self.uc_theme_setting.overlay_grid.element_selected.connect(

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/tests/core/test_encoding.py

@@ -21,12 +21,13 @@ class TestByteOrderFor(unittest.TestCase):
     def test_fbl_102_big_endian(self):
         self.assertEqual(byte_order_for('scsi', (320, 320), fbl=102), '>')
 
-    def test_fbl_51_big_endian(self):
-        """FBL 51 SPIMode=2 → big-endian."""
-        self.assertEqual(byte_order_for('scsi', (320, 240), fbl=51), '>')
+    def test_fbl_51_little_endian(self):
+        """FBL 51 HID Type 2 → little-endian (SPIMode=2 only for SPI mode 1)."""
+        self.assertEqual(byte_order_for('scsi', (320, 240), fbl=51), '<')
 
-    def test_fbl_53_big_endian(self):
-        self.assertEqual(byte_order_for('scsi', (320, 240), fbl=53), '>')
+    def test_fbl_53_little_endian(self):
+        """FBL 53 HID Type 2 → little-endian."""
+        self.assertEqual(byte_order_for('scsi', (320, 240), fbl=53), '<')
 
     def test_fbl_36_little_endian(self):
         """FBL 36 (240x240) → little-endian."""
@@ -69,13 +70,13 @@ class TestByteOrderFor(unittest.TestCase):
 
     def test_all_big_endian_fbls(self):
         """Every big-endian FBL returns '>'."""
-        for fbl in (51, 53, 100, 101, 102):
+        for fbl in (100, 101, 102):
             with self.subTest(fbl=fbl):
                 self.assertEqual(byte_order_for('hid', (0, 0), fbl=fbl), '>')
 
     def test_all_little_endian_fbls(self):
         """Every non-BE, non-JPEG FBL returns '<'."""
-        for fbl in (36, 37, 50, 58, 64, 72, 129):
+        for fbl in (36, 37, 50, 51, 53, 58, 64, 72, 129):
             with self.subTest(fbl=fbl):
                 self.assertEqual(byte_order_for('hid', (0, 0), fbl=fbl), '<')
 

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/tests/core/test_models.py

@@ -292,7 +292,7 @@ class TestDeviceProfileCompleteness(unittest.TestCase):
     def test_big_endian_fbls(self):
         """Only big-endian FBLs are flagged as big-endian."""
         be_fbls = {fbl for fbl, p in FBL_PROFILES.items() if p.big_endian}
-        self.assertEqual(be_fbls, {51, 53, 100, 101, 102})
+        self.assertEqual(be_fbls, {100, 101, 102})
 
     def test_rotate_fbls(self):
         """Only portrait/landscape-rotated FBLs are flagged."""
@@ -352,20 +352,20 @@ class TestDeviceProfilePerFbl(unittest.TestCase):
         self.assertFalse(p.big_endian)
         self.assertTrue(p.rotate)
 
-    def test_fbl_51_320x240_rgb565_be_spimode2(self):
-        """FBL 51 SPIMode=2 — big-endian RGB565."""
+    def test_fbl_51_320x240_rgb565_le(self):
+        """FBL 51 HID Type 2 — little-endian RGB565 (SPIMode=2 only for SPI mode 1)."""
         p = get_profile(51)
         self.assertEqual(p.resolution, (320, 240))
         self.assertFalse(p.jpeg)
-        self.assertTrue(p.big_endian)
+        self.assertFalse(p.big_endian)
         self.assertTrue(p.rotate)
 
-    def test_fbl_53_320x240_rgb565_be_spimode2(self):
-        """FBL 53 SPIMode=2 — big-endian RGB565."""
+    def test_fbl_53_320x240_rgb565_le(self):
+        """FBL 53 HID Type 2 — little-endian RGB565."""
         p = get_profile(53)
         self.assertEqual(p.resolution, (320, 240))
         self.assertFalse(p.jpeg)
-        self.assertTrue(p.big_endian)
+        self.assertFalse(p.big_endian)
         self.assertTrue(p.rotate)
 
     def test_fbl_54_360x360_jpeg(self):

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/tests/qt_components/test_lcd_handler.py

@@ -316,6 +316,62 @@ class TestMask:
         h.apply_mask(mask_info)
         h._w['preview'].set_status.assert_called_once()
 
+    def test_restore_mask_skips_when_theme_already_loaded(self, tmp_path):
+        """Mask restore skips if theme reference already loaded the same mask.
+
+        Prevents video cache invalidation on startup when a saved custom
+        theme has an embedded mask reference AND per-device config also
+        records the same mask_path.
+        """
+        mask_dir = tmp_path / 'zt320320' / '015c'
+        mask_dir.mkdir(parents=True)
+        (mask_dir / '01.png').touch()
+
+        h = _make_handler()
+        # Simulate theme loader already set mask_source_dir
+        h._lcd._display_svc._mask_source_dir = mask_dir
+        cfg = {'mask_path': str(mask_dir)}
+
+        h._restore_mask(cfg)
+
+        # load_mask_standalone should NOT be called — theme already loaded it
+        h._lcd.load_mask_standalone.assert_not_called()
+
+    def test_restore_mask_loads_when_different_from_theme(self, tmp_path):
+        """Mask restore proceeds when per-device mask differs from theme's."""
+        theme_mask = tmp_path / 'zt320320' / '010'
+        theme_mask.mkdir(parents=True)
+        device_mask = tmp_path / 'zt320320' / '015c'
+        device_mask.mkdir(parents=True)
+        (device_mask / '01.png').touch()
+
+        h = _make_handler()
+        h._lcd._display_svc._mask_source_dir = theme_mask
+        h._lcd.load_mask_standalone.return_value = {
+            'success': True, 'image': MagicMock()}
+        cfg = {'mask_path': str(device_mask)}
+
+        h._restore_mask(cfg)
+
+        # Different mask → should load
+        h._lcd.load_mask_standalone.assert_called_once()
+
+    def test_restore_mask_loads_when_no_theme_mask(self, tmp_path):
+        """Mask restore proceeds when theme didn't load any mask."""
+        mask_dir = tmp_path / 'zt320320' / '015c'
+        mask_dir.mkdir(parents=True)
+        (mask_dir / '01.png').touch()
+
+        h = _make_handler()
+        h._lcd._display_svc._mask_source_dir = None
+        h._lcd.load_mask_standalone.return_value = {
+            'success': True, 'image': MagicMock()}
+        cfg = {'mask_path': str(mask_dir)}
+
+        h._restore_mask(cfg)
+
+        h._lcd.load_mask_standalone.assert_called_once()
+
 
 # =========================================================================
 # Video

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/tests/qt_components/test_theme_setting.py

@@ -585,54 +585,60 @@ class TestAddElementPanel:
 
     def test_construction(self, qapp):
         panel = AddElementPanel()
-        assert panel.hw_combo.count() == 6
+        assert len(panel.ELEMENT_TYPES) == 5
 
-    def test_category_change_updates_metrics(self, qapp):
+    def test_hardware_emits_hardware_requested(self, qapp):
+        """Hardware Data button emits hardware_requested, not element_added."""
         panel = AddElementPanel()
-        # CPU (index 0) should have 4 sub-metrics
-        panel.hw_combo.setCurrentIndex(0)
-        assert panel.metric_combo.count() == 4
-        # GPU (index 1)
-        panel.hw_combo.setCurrentIndex(1)
-        assert panel.metric_combo.count() == 4
-
-    def test_category_names_in_combo(self, qapp):
+        hw_received = []
+        elem_received = []
+        panel.hardware_requested.connect(lambda: hw_received.append(True))
+        panel.element_added.connect(elem_received.append)
+        panel._on_type_clicked(OverlayMode.HARDWARE)
+        assert len(hw_received) == 1
+        assert len(elem_received) == 0  # no element_added for hardware
+
+    def test_element_added_signal_time(self, qapp):
         panel = AddElementPanel()
-        items = [panel.hw_combo.itemText(i) for i in range(panel.hw_combo.count())]
-        assert items == list(CATEGORY_NAMES.values())
+        received = []
+        panel.element_added.connect(received.append)
+        panel._on_type_clicked(OverlayMode.TIME)
+        assert len(received) == 1
+        assert received[0].mode == OverlayMode.TIME
 
-    def test_element_added_signal_hardware(self, qapp):
+    def test_element_added_signal_weekday(self, qapp):
         panel = AddElementPanel()
         received = []
         panel.element_added.connect(received.append)
-        panel.hw_combo.setCurrentIndex(1)  # GPU
-        panel.metric_combo.setCurrentIndex(0)  # first metric
-        panel._on_type_clicked(OverlayMode.HARDWARE)
+        panel._on_type_clicked(OverlayMode.WEEKDAY)
         assert len(received) == 1
-        cfg = received[0]
-        assert cfg.mode == OverlayMode.HARDWARE
-        assert cfg.main_count == 1
-        assert cfg.sub_count == 1
+        assert received[0].mode == OverlayMode.WEEKDAY
 
-    def test_element_added_signal_time(self, qapp):
+    def test_element_added_signal_date(self, qapp):
         panel = AddElementPanel()
         received = []
         panel.element_added.connect(received.append)
-        panel._on_type_clicked(OverlayMode.TIME)
+        panel._on_type_clicked(OverlayMode.DATE)
         assert len(received) == 1
-        assert received[0].mode == OverlayMode.TIME
+        assert received[0].mode == OverlayMode.DATE
 
-    def test_hw_frame_visible_on_hardware(self, qapp):
+    def test_element_added_signal_custom(self, qapp):
         panel = AddElementPanel()
-        assert panel.hw_frame.isHidden() is True
-        panel._on_type_clicked(OverlayMode.HARDWARE)
-        assert panel.hw_frame.isHidden() is False
+        received = []
+        panel.element_added.connect(received.append)
+        panel._on_type_clicked(OverlayMode.CUSTOM)
+        assert len(received) == 1
+        assert received[0].mode == OverlayMode.CUSTOM
 
-    def test_hw_frame_hidden_on_non_hardware(self, qapp):
+    def test_non_hardware_does_not_emit_hardware_requested(self, qapp):
+        """Time/Date/Weekday/Custom should not trigger hardware sidebar."""
         panel = AddElementPanel()
-        panel._on_type_clicked(OverlayMode.HARDWARE)
-        panel._on_type_clicked(OverlayMode.TIME)
-        assert panel.hw_frame.isHidden() is True
+        hw_received = []
+        panel.hardware_requested.connect(lambda: hw_received.append(True))
+        for mode in (OverlayMode.TIME, OverlayMode.DATE,
+                     OverlayMode.WEEKDAY, OverlayMode.CUSTOM):
+            panel._on_type_clicked(mode)
+        assert len(hw_received) == 0
 
     def test_element_types_count(self, qapp):
         assert len(AddElementPanel.ELEMENT_TYPES) == 5

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/tests/qt_components/test_trcc_app.py

@@ -1464,6 +1464,7 @@ class TestViewSwitchLEDKeepsRunning:
             inst.uc_about = MagicMock()
             inst.uc_system_info = MagicMock()
             inst.uc_led_control = MagicMock()
+            inst.uc_activity_sidebar = MagicMock()
             inst.form1_close_btn = MagicMock()
             inst.form1_help_btn = MagicMock()
             yield inst

{trcc_linux-8.3.4 → trcc_linux-8.3.6}/tests/services/test_services.py

@@ -137,9 +137,9 @@ class TestImageServiceByteOrder(unittest.TestCase):
     def test_320x320_scsi_big_endian(self):
         self.assertEqual(ImageService.byte_order_for('scsi', (320, 320)), '>')
 
-    def test_320x240_scsi_fbl51_big_endian(self):
-        """SCSI 320x240 FBL 51 uses SPIMode=2 → big-endian."""
-        self.assertEqual(ImageService.byte_order_for('scsi', (320, 240), fbl=51), '>')
+    def test_320x240_scsi_fbl51_little_endian(self):
+        """HID Type 2 FBL 51 → little-endian (SPIMode=2 only for SPI mode 1)."""
+        self.assertEqual(ImageService.byte_order_for('scsi', (320, 240), fbl=51), '<')
 
     def test_320x240_scsi_fbl50_little_endian(self):
         """SCSI 320x240 FBL 50 does NOT trigger SPIMode=2 → little-endian."""