tina4-python 3.13.5__tar.gz → 3.13.7__tar.gz

{tina4_python-3.13.5 → tina4_python-3.13.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: tina4-python
-Version: 3.13.5
+Version: 3.13.7
 Summary: Tina4 Python v3 — Zero-dependency, lightweight web framework
 Author-email: Andre van Zuydam <andrevanzuydam@gmail.com>
 License: MIT

{tina4_python-3.13.5 → tina4_python-3.13.7}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "tina4-python"
-version = "3.13.5"
+version = "3.13.7"
 description = "Tina4 Python v3 — Zero-dependency, lightweight web framework"
 authors = [
     {name = "Andre van Zuydam", email = "andrevanzuydam@gmail.com"}

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/__init__.py

@@ -8,7 +8,7 @@ Tina4 Python v3.0 — Zero-dependency, lightweight web framework.
 
 One import, everything works.
 """
-__version__ = "3.13.5"
+__version__ = "3.13.7"
 
 # ── Route decorators ──
 from tina4_python.core.router import (  # noqa: E402, F401

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/core/server.py

@@ -1307,9 +1307,38 @@ def _handle_route_error(
     error: Exception, request: Request, response: Response,
     request_id: str, is_dev: bool,
 ) -> Response:
-    """Format an error response for a failed route handler."""
+    """Format an error response for a failed route handler.
+
+    Two contracts (v3.13.7):
+
+    1. Fire ``tina4.request.error`` before rendering, so observers
+       (centralised logging, APM, Sentry) see the failure even though
+       the framework caught it. Payload is a single dict ``{exception,
+       request}`` — the canonical shape mirrored by PHP/Ruby/Node.
+       Listener exceptions are swallowed so a broken listener can't
+       break the 500 page.
+
+    2. In non-debug mode, never put the stack trace in the response
+       body (CWE-209). The trace is still available via ``Log.error``
+       above and the dev-admin ``BrokenTracker`` in dev mode. The
+       framework's own 500.twig now guards the trace block with
+       ``{% if error_message %}``.
+    """
     Log.error(f"Route error: {error}", path=request.path)
     _write_broken(request, error)
+
+    try:
+        from tina4_python.core.events import emit as _emit
+        _emit("tina4.request.error", {"exception": error, "request": request})
+    except Exception as listener_err:
+        try:
+            Log.warning(
+                f"Listener for tina4.request.error raised: "
+                f"{type(listener_err).__name__}: {listener_err}"
+            )
+        except Exception:
+            pass
+
     if is_dev:
         try:
             import traceback as _tb
@@ -1324,9 +1353,9 @@ def _handle_route_error(
         overlay_html = render_error_overlay(error, request)
         response.status(500).html(overlay_html)
     else:
-        import traceback
-        tb = traceback.format_exc()
-        html = _render_error_page(500, request.path, request_id, tb)
+        # Production: NO traceback in the body. The trace is logged via
+        # Log.error above; clients only see the generic page + request_id.
+        html = _render_error_page(500, request.path, request_id, "")
         if html:
             response.status(500).html(html)
         else:

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/database/firebird.py

@@ -116,8 +116,10 @@ class FirebirdAdapter(DatabaseAdapter):
         """
         if _driver is None:
             raise ImportError(
-                "A Firebird driver is required. "
-                "Install: pip install firebird-driver  (or pip install fdb for legacy)"
+                "A Firebird driver is required. Install one of:\n"
+                "    uv add tina4-python[firebird]    # extra for projects using uv\n"
+                "    pip install firebird-driver      # bare driver (or 'fdb' for legacy)\n"
+                "    uv add tina4-python[all-db]      # all five database drivers"
             )
 
         parsed = urlparse(connection_string)

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/database/mongodb.py

@@ -348,8 +348,10 @@ class MongoDBAdapter(DatabaseAdapter):
             import pymongo
         except ImportError:
             raise ImportError(
-                "pymongo is required for MongoDB connections. "
-                "Install: pip install pymongo"
+                "pymongo is required for MongoDB connections. Install one of:\n"
+                "    uv add tina4-python[mongo]    # extra for projects using uv\n"
+                "    pip install pymongo           # bare driver\n"
+                "    uv add tina4-python[all-db]   # all five database drivers"
             )
 
         # Normalise the scheme so MongoClient accepts it

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/database/mssql.py

@@ -29,8 +29,10 @@ class MSSQLAdapter(DatabaseAdapter):
             import pymssql
         except ImportError:
             raise ImportError(
-                "pymssql is required for MSSQL connections. "
-                "Install: pip install pymssql"
+                "pymssql is required for MSSQL connections. Install one of:\n"
+                "    uv add tina4-python[mssql]    # extra for projects using uv\n"
+                "    pip install pymssql           # bare driver\n"
+                "    uv add tina4-python[all-db]   # all five database drivers"
             )
 
         parsed = urlparse(connection_string)

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/database/mysql.py

@@ -29,8 +29,10 @@ class MySQLAdapter(DatabaseAdapter):
             import mysql.connector
         except ImportError:
             raise ImportError(
-                "mysql-connector-python is required for MySQL connections. "
-                "Install: pip install mysql-connector-python"
+                "mysql-connector-python is required for MySQL connections. Install one of:\n"
+                "    uv add tina4-python[mysql]            # extra for projects using uv\n"
+                "    pip install mysql-connector-python    # bare driver\n"
+                "    uv add tina4-python[all-db]           # all five database drivers"
             )
 
         parsed = urlparse(connection_string)

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/database/odbc.py

@@ -31,7 +31,10 @@ class ODBCAdapter(DatabaseAdapter):
             import pyodbc
         except ImportError:
             raise ImportError(
-                "pyodbc is required for ODBC connections. Install: pip install pyodbc"
+                "pyodbc is required for ODBC connections. Install one of:\n"
+                "    uv add tina4-python[odbc]    # extra for projects using uv\n"
+                "    pip install pyodbc           # bare driver\n"
+                "    uv add tina4-python[all-db]  # all five database drivers"
             )
 
         # Strip URL prefix if present

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/database/postgres.py

@@ -19,6 +19,7 @@ class PostgreSQLAdapter(DatabaseAdapter):
         super().__init__()
         self._conn = None
         self._in_transaction: bool = False
+        self.last_error: str | None = None
 
     @staticmethod
     def _safe_execute(cursor, sql: str, params=None):
@@ -36,12 +37,76 @@ class PostgreSQLAdapter(DatabaseAdapter):
         Pass ``None`` (or omit the second arg) and psycopg2 skips the
         substitution pass entirely — literal ``%`` flows through
         untouched. So we route empty/None params through that path.
+
+        Kept static for direct unit-test access (a number of
+        regression tests in test_postgres_percent_substitution.py call
+        it with a fake cursor). For the error-aware variant that adds
+        logging + auto-rollback (issue #46), use the instance method
+        :meth:`_exec_with_handling`.
         """
         if params:
             cursor.execute(sql, params)
         else:
             cursor.execute(sql)
 
+    def _exec_with_handling(self, cursor, sql: str, params=None):
+        """Run a query through :meth:`_safe_execute` and surface failures.
+
+        Issue #46: psycopg2 keeps the connection in an
+        ``InFailedSqlTransaction`` state after any failed query — every
+        subsequent statement returns the cascade message ``current
+        transaction is aborted, commands ignored until end of transaction
+        block``, *far* from the actual cause. Without framework-side
+        logging, the original SQL + error never reach the user.
+
+        On failure this method:
+
+        1. Logs the original error via ``Log.error`` with SQL+params context
+        2. Stores it on ``self.last_error``
+        3. Auto-rollbacks when NOT inside an explicit transaction (so the
+           next caller gets a clean connection)
+        4. Re-raises so callers still see the failure
+
+        Inside an explicit transaction we do NOT rollback — the user owns
+        that transaction (could be running a SAVEPOINT/retry pattern). We
+        still log + store ``last_error`` so they can diagnose.
+        """
+        try:
+            self._safe_execute(cursor, sql, params)
+        except Exception as e:
+            self._on_query_error(e, sql, params)
+            raise
+
+    def _on_query_error(self, exc: Exception, sql: str, params=None):
+        """Handle a failed query: log, store, auto-rollback if implicit."""
+        # Lazy import — avoid circular import at module load and let the
+        # framework boot without Log if something exotic is happening.
+        try:
+            from tina4_python.debug import Log
+            preview = sql.strip().splitlines()[0][:200] if sql else "<no sql>"
+            Log.error(
+                f"PostgreSQL query failed: {exc.__class__.__name__}: {exc}",
+                sql=preview,
+                params=params,
+            )
+        except Exception:
+            pass
+
+        self.last_error = str(exc)
+
+        # If the query failed *outside* an explicit transaction block,
+        # rollback the implicit one so the connection becomes usable
+        # again. Without this, every subsequent query on this connection
+        # cascades into ``InFailedSqlTransaction`` until something else
+        # calls rollback. With it, the next caller sees a clean conn
+        # and the actual error from this call propagates as the cause.
+        if not self._in_transaction and self._conn is not None:
+            try:
+                self._conn.rollback()
+            except Exception:
+                # Don't mask the original error if rollback itself fails.
+                pass
+
     def connect(self, connection_string: str, username: str = "", password: str = "", **kwargs):
         """Connect to PostgreSQL.
 
@@ -53,8 +118,10 @@ class PostgreSQLAdapter(DatabaseAdapter):
             import psycopg2.extras
         except ImportError:
             raise ImportError(
-                "psycopg2 is required for PostgreSQL connections. "
-                "Install: pip install psycopg2-binary"
+                "psycopg2 is required for PostgreSQL connections. Install one of:\n"
+                "    uv add tina4-python[postgres]   # extra for projects using uv\n"
+                "    pip install psycopg2-binary    # bare driver\n"
+                "    uv add tina4-python[all-db]    # all five database drivers"
             )
 
         parsed = urlparse(connection_string)
@@ -85,7 +152,7 @@ class PostgreSQLAdapter(DatabaseAdapter):
         )
 
         cursor = self._conn.cursor(cursor_factory=psycopg2.extras.RealDictCursor)
-        self._safe_execute(cursor, sql, params)
+        self._exec_with_handling(cursor, sql, params)
 
         records = []
         last_id = None
@@ -151,10 +218,12 @@ class PostgreSQLAdapter(DatabaseAdapter):
         except Exception:
             total = 0
 
-        # Apply pagination
+        # Apply pagination — the real query, so use the error-handling
+        # wrapper. The count probe above is best-effort and stays on
+        # _safe_execute (a failed probe shouldn't taint last_error).
         paginated_sql = f"{sql} LIMIT %s OFFSET %s"
         paginated_params = (params or []) + [limit, offset]
-        self._safe_execute(cursor, paginated_sql, paginated_params)
+        self._exec_with_handling(cursor, paginated_sql, paginated_params)
         rows = [self._decode_blobs(dict(row)) for row in cursor.fetchall()]
 
         return DatabaseResult(records=rows, count=total, limit=limit, offset=offset, sql=sql, adapter=self)
@@ -164,7 +233,7 @@ class PostgreSQLAdapter(DatabaseAdapter):
 
         sql = self._translate_sql(sql)
         cursor = self._conn.cursor(cursor_factory=psycopg2.extras.RealDictCursor)
-        self._safe_execute(cursor, sql, params)
+        self._exec_with_handling(cursor, sql, params)
         row = cursor.fetchone()
         return self._decode_blobs(dict(row)) if row else None
 

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/queue_backends/mongo_backend.py

@@ -59,8 +59,10 @@ class MongoConnector:
             self._pymongo = pymongo
         except ImportError:
             raise ImportError(
-                "pymongo is required for the MongoDB queue backend. "
-                "Install it with: pip install pymongo"
+                "pymongo is required for the MongoDB queue backend. Install one of:\n"
+                "    uv add tina4-python[mongo]    # extra for projects using uv\n"
+                "    pip install pymongo           # bare driver\n"
+                "    uv add tina4-python[all-db]   # all five database drivers"
             )
 
     # ── Public Interface ─────────────────────────────────────────

{tina4_python-3.13.5 → tina4_python-3.13.7}/tina4_python/templates/errors/500.twig

@@ -27,7 +27,7 @@ body { font-family: system-ui, -apple-system, sans-serif; background: #0f172a; c
         <div class="error-title">Server Error</div>
     </div>
     <div class="error-msg">Something went wrong while processing your request.</div>
-    <pre class="error-trace">{{ error_message }}</pre>
+    {% if error_message %}<pre class="error-trace">{{ error_message }}</pre>{% endif %}
     <div class="error-footer">
         <span class="error-hint">Fix the error and save to auto-reload</span>
         <span class="error-id">{{ request_id }}</span>