threedi-modelchecker 2.18.19.dev0__tar.gz → 2.18.19.dev1__tar.gz

{threedi_modelchecker-2.18.19.dev0 → threedi_modelchecker-2.18.19.dev1}/CHANGES.rst

@@ -9,6 +9,7 @@ Changelog of threedi-modelchecker
 - Add check (E1028 and E1209) for matching time units for boundary conditions (nens/rana#3619)
 - Add check (W0220) that warns when the sum of the weights in MeasureMap for a single control are not 1+/-0.01 (nens/rana#3597)
 - Add check (W0058) that warns when a closed culvert or pipe is embedded (nens/threedi-modelchecker#408)
+- Fix bugs that could cause checks W0053, I0057, W0058 and W0098 to crash (nens/rana#3933)- 
 
 
 2.18.18 (2026-04-10)

{threedi_modelchecker-2.18.19.dev0/threedi_modelchecker.egg-info → threedi_modelchecker-2.18.19.dev1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: threedi-modelchecker
-Version: 2.18.19.dev0
+Version: 2.18.19.dev1
 Summary: Checks validity of a 3Di schematisation
 Author-email: Nelen & Schuurmans <info@nelen-schuurmans.nl>
 License: MIT

{threedi_modelchecker-2.18.19.dev0 → threedi_modelchecker-2.18.19.dev1}/threedi_modelchecker/__init__.py

@@ -1,5 +1,5 @@
 from .model_checks import *  # NOQA
 
 # fmt: off
-__version__ = '2.18.19.dev0'
+__version__ = '2.18.19.dev1'
 # fmt: on

{threedi_modelchecker-2.18.19.dev0 → threedi_modelchecker-2.18.19.dev1}/threedi_modelchecker/checks/cross_section_definitions.py

@@ -309,7 +309,10 @@ class CrossSectionYZIncreasingWidthIfOpenCheck(CrossSectionBaseCheck):
 
 
 def get_widths_heights_for_tabulated_record(record):
-    if not record.cross_section_shape.is_tabulated:
+    if (
+        record.cross_section_shape is None
+        or not record.cross_section_shape.is_tabulated
+    ):
         raise ValueError(
             "get_widths_heighs_for_tabulated_record cannot handle tabulated shaptes"
         )
@@ -331,6 +334,8 @@ def get_widths_heights_for_tabulated_record(record):
 
 
 def cross_section_configuration_for_record(record):
+    if record.cross_section_shape is None:
+        return None, None, None
     if record.cross_section_shape.is_tabulated:
         # Handle empty cross section table by returning all None to prevent issues in parsing
         # Note that CrossSectionNullCheck already checks for this

{threedi_modelchecker-2.18.19.dev0 → threedi_modelchecker-2.18.19.dev1}/threedi_modelchecker/checks/other.py

@@ -468,6 +468,13 @@ class OpenChannelsWithNestedNewton(BaseCheck):
                 invalids.append(record)
         return invalids
 
+    def to_check(self, session: Session):
+        return (
+            super()
+            .to_check(session)
+            .where(self.table.c.cross_section_shape.isnot(None))
+        )
+
     def description(self) -> str:
         return (
             f"{self.column_name} has a closed cross section definition while "

{threedi_modelchecker-2.18.19.dev0 → threedi_modelchecker-2.18.19.dev1}/threedi_modelchecker/tests/test_checks_cross_section_definitions.py

@@ -642,6 +642,11 @@ def test_cross_section_configuration_not_tabulated_raise():
             {"cross_section_table": ""},
             (None, None, None),
         ),
+        (
+            None,
+            {},
+            (None, None, None),
+        ),
     ],
 )
 def test_cross_section_configuration_for_record(session, shape, kwargs, expected):

{threedi_modelchecker-2.18.19.dev0 → threedi_modelchecker-2.18.19.dev1/threedi_modelchecker.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: threedi-modelchecker
-Version: 2.18.19.dev0
+Version: 2.18.19.dev1
 Summary: Checks validity of a 3Di schematisation
 Author-email: Nelen & Schuurmans <info@nelen-schuurmans.nl>
 License: MIT