threadkeeper 0.18.2__tar.gz → 0.18.3__tar.gz

{threadkeeper-0.18.2/threadkeeper.egg-info → threadkeeper-0.18.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: threadkeeper
-Version: 0.18.2
+Version: 0.18.3
 Summary: Multi-agent shared brain across Claude Code/Desktop, Codex, Antigravity CLI, Copilot, and VS Code. Cross-session memory, self-improving skill loops, inter-agent signaling — one local MCP server.
 Author: thread-keeper contributors
 License: MIT

{threadkeeper-0.18.2 → threadkeeper-0.18.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "threadkeeper"
-version = "0.18.2"
+version = "0.18.3"
 description = "Multi-agent shared brain across Claude Code/Desktop, Codex, Antigravity CLI, Copilot, and VS Code. Cross-session memory, self-improving skill loops, inter-agent signaling — one local MCP server."
 requires-python = ">=3.11"
 authors = [{ name = "thread-keeper contributors" }]

{threadkeeper-0.18.2 → threadkeeper-0.18.3}/tests/test_spawn_slim.py

@@ -9,7 +9,6 @@ from __future__ import annotations
 import json
 from pathlib import Path
 
-import pytest
 
 
 _FAKE_CID = "11112222-3333-4444-5555-666677778888"
@@ -265,18 +264,39 @@ def test_claude_large_prompt_uses_stdin_file(mp_with_cid, monkeypatch):
     assert mode == 0o600, f"expected 0600, got {oct(mode)}"
 
 
-def test_spawn_slim_falls_back_to_full_config_when_unable(tmp_path, monkeypatch):
-    """If _build_slim_mcp_config returns None (e.g. write error), spawn()
-    must NOT crash — it just runs without slim flags."""
-    # We unit-test by patching _build_slim_mcp_config to return None and
-    # then checking spawn doesn't append --mcp-config to the cmd. But the
-    # whole flow runs subprocess.Popen which we don't want in tests. Skip
-    # full integration — the conditional branch in spawn() is plain
-    # if-statement, no need for deep coverage.
-    pytest.skip(
-        "spawn() invokes claude CLI; slim-fallback path is covered by "
-        "inspection of the conditional branch"
+def test_spawn_refuses_when_the_slim_config_cannot_be_written(
+    mp_with_cid, monkeypatch,
+):
+    """A slim child whose MCP file cannot be written must not silently run
+    with the user's full MCP config (every configured server)."""
+    pkg = mp_with_cid(_FAKE_CID)
+    import threadkeeper.identity as identity
+    import threadkeeper.spawn_config as spawn_config
+    import threadkeeper.tools.spawn as spawn_mod
+
+    monkeypatch.setattr(spawn_mod, "_claude_bin", lambda: "/bin/true")
+    monkeypatch.setattr(identity, "_active_cli", "claude")
+    monkeypatch.setattr(
+        spawn_config, "resolve_agent", lambda role, active_cli=None: "claude"
     )
+    monkeypatch.setattr(spawn_mod, "_build_slim_mcp_config", lambda *a, **k: None)
+    launched = []
+    monkeypatch.setattr(
+        spawn_mod.subprocess, "Popen", lambda *a, **k: launched.append(a),
+    )
+
+    out = spawn_mod.spawn(
+        prompt="x", cwd=str(pkg["tmp"]), slim=True, visible=False,
+        capture_output=False,
+    )
+
+    assert out == "ERR slim_mcp_config_failed"
+    assert launched == []
+    conn = pkg["db"].get_db()
+    try:
+        assert conn.execute("SELECT COUNT(*) FROM tasks").fetchone()[0] == 0
+    finally:
+        conn.close()
 
 
 def test_review_thread_uses_slim_by_default(mp_with_cid, monkeypatch):

{threadkeeper-0.18.2 → threadkeeper-0.18.3}/threadkeeper/tools/spawn.py

@@ -456,8 +456,8 @@ def _build_slim_mcp_config(
     (matches their actual install). Fall back to a synthesized config
     based on the running Python interpreter and package location.
 
-    Returns the path to the slim config file, or None if neither path
-    can produce a valid entry (caller should fall back to full config).
+    Returns the path to the slim config file, or None if it cannot be
+    written; the caller then refuses the spawn rather than widen the child.
     """
     try:
         slim_dir = ensure_task_spool_dir(TASK_LOG_DIR)
@@ -946,9 +946,11 @@ def _spawn_impl(prompt: str, cwd: str = "", append_system: str = "",
         # API integrations).
         if slim:
             slim_cfg = _build_slim_mcp_config(task_id, mcp_env_overrides)
-            if slim_cfg is not None:
-                cmd += ["--mcp-config", str(slim_cfg),
-                        "--strict-mcp-config"]
+            if slim_cfg is None:
+                # Without the slim file the child would start every MCP server
+                # the user configured; refuse instead of widening it.
+                return "ERR slim_mcp_config_failed"
+            cmd += ["--mcp-config", str(slim_cfg), "--strict-mcp-config"]
     log_path: Optional[Path] = None
     try:
         task_log_dir = ensure_task_spool_dir(TASK_LOG_DIR)

{threadkeeper-0.18.2 → threadkeeper-0.18.3/threadkeeper.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: threadkeeper
-Version: 0.18.2
+Version: 0.18.3
 Summary: Multi-agent shared brain across Claude Code/Desktop, Codex, Antigravity CLI, Copilot, and VS Code. Cross-session memory, self-improving skill loops, inter-agent signaling — one local MCP server.
 Author: thread-keeper contributors
 License: MIT