teddy-cli 0.1.17.dev1368__tar.gz → 0.1.17.dev1370__tar.gz

{teddy_cli-0.1.17.dev1368 → teddy_cli-0.1.17.dev1370}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: teddy-cli
-Version: 0.1.17.dev1368
+Version: 0.1.17.dev1370
 Summary: The local-first, test-driven agentic engineering harness. Because you should own the means of development.
 Author: Raphael Atteritano
 License: AGPL-3.0-only

{teddy_cli-0.1.17.dev1368 → teddy_cli-0.1.17.dev1370}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "teddy-cli"
-version = "0.1.17.dev1368"
+version = "0.1.17.dev1370"
 description = "The local-first, test-driven agentic engineering harness. Because you should own the means of development."
 readme = "README.md"
 keywords = [

{teddy_cli-0.1.17.dev1368 → teddy_cli-0.1.17.dev1370}/src/teddy_executor/adapters/inbound/session_cli_handlers.py

@@ -3,7 +3,7 @@ import shutil
 import signal
 import subprocess  # nosec B404
 from pathlib import Path
-from typing import Any, Dict, Optional, Sequence
+from typing import Any, Callable, Dict, Optional, Sequence
 
 import typer
 from punq import Container
@@ -43,7 +43,9 @@ _HOOK_IMPL_FLAG = "hook-impl"
 _HOOK_CONFIG_FLAG = "--config=.pre-commit-config.yaml"
 
 
-def _resolve_hooks_dir() -> Optional[Path]:
+def _resolve_hooks_dir(
+    run_func: Optional[Callable[..., Any]] = None,
+) -> Optional[Path]:
     """Resolve the git hooks directory using git's own answer.
 
     Returns None when unresolvable (not a repository, git CLI failure,
@@ -52,12 +54,18 @@ def _resolve_hooks_dir() -> Optional[Path]:
     the same directory `pre-commit install` writes to. Relative output
     is anchored against the current working directory (git semantics).
     """
+    # Explicit decoding keeps a non-UTF-8 path byte from raising mid-read,
+    # which the guard would swallow as an unresolvable hooks directory.
+    # The runner defaults to subprocess.run at call time, so tests inject
+    # a replacement instead of patching the module global.
+    runner = run_func or subprocess.run
     try:
-        result = subprocess.run(  # nosec B603 B607
+        result = runner(  # nosec B603 B607
             ["git", "rev-parse", "--git-path", "hooks"],
             check=True,
             capture_output=True,
-            text=True,
+            encoding="utf-8",
+            errors="replace",
         )
     except (subprocess.CalledProcessError, OSError, ValueError):
         logger.debug("hooks directory resolution failed", exc_info=True)

{teddy_cli-0.1.17.dev1368 → teddy_cli-0.1.17.dev1370}/src/teddy_executor/adapters/outbound/shell_adapter.py

@@ -1,3 +1,4 @@
+import locale
 import os
 import subprocess  # nosec
 import sys
@@ -47,6 +48,27 @@ class ShellAdapter(IShellExecutor):
         text = re.sub(r"\x1b\[[0-9;?><\$]*[a-zA-Z]", "", text)
         return text
 
+    def _decode_stream(self, data: bytes | str | None) -> str:
+        """Decode one captured child stream to text without raising.
+
+        Text payloads from test doubles pass through untouched. Raw bytes
+        decode as UTF-8 first, so identical UTF-8 streams yield identical
+        text on every platform. A stream that is not valid UTF-8 falls back
+        to the locale codec with replacement, which keeps native Windows
+        child output readable and never kills a reader thread.
+        Universal-newline normalisation preserves the previous text-mode
+        contract.
+        """
+        if data is None:
+            return ""
+        if isinstance(data, str):
+            return data
+        try:
+            decoded = data.decode("utf-8")
+        except UnicodeDecodeError:
+            decoded = data.decode(locale.getpreferredencoding(False), errors="replace")
+        return decoded.replace("\r\n", "\n").replace("\r", "\n")
+
     def _validate_cwd(self, cwd: Optional[str]) -> str:
         """Validates and resolves the working directory."""
         project_root = os.path.realpath(os.getcwd())
@@ -125,7 +147,9 @@ class ShellAdapter(IShellExecutor):
             # Python 3.14.2's C-level initialization. The pipe is closed
             # immediately after Popen so children see EOF on reads.
             "stdin": subprocess.PIPE,
-            "text": True,
+            # Bytes mode: the pipes are drained undecoded, so no reader
+            # thread can die on a codec mismatch. Each stream is decoded
+            # explicitly by _decode_stream after the wait.
             "cwd": cwd,
             "env": env,
         }
@@ -171,9 +195,11 @@ class ShellAdapter(IShellExecutor):
 
         try:
             # Give the OS a moment to close pipes naturally after SIGKILL.
-            stdout, stderr = process.communicate(timeout=0.5)
+            raw_stdout, raw_stderr = process.communicate(timeout=0.5)
         except subprocess.TimeoutExpired:
-            stdout, stderr = "", ""
+            raw_stdout, raw_stderr = "", ""
+        stdout = self._decode_stream(raw_stdout)
+        stderr = self._decode_stream(raw_stderr)
 
         sanitized_stderr = self._sanitize_output(stderr) or ""
         if self._detect_interactive_prompt(sanitized_stderr, stdout):
@@ -228,8 +254,12 @@ class ShellAdapter(IShellExecutor):
         guard = self._interrupt_guard
         if guard is None:
             comm_res = process.communicate(timeout=timeout)
-            stdout, stderr = cast(tuple[str, str], comm_res)
-            return stdout, stderr, False
+            raw_stdout, raw_stderr = cast(tuple[bytes | str, bytes | str], comm_res)
+            return (
+                self._decode_stream(raw_stdout),
+                self._decode_stream(raw_stderr),
+                False,
+            )
 
         poll_interval = self._poll_interval_seconds
         deadline = None if timeout is None else time.monotonic() + timeout
@@ -238,10 +268,16 @@ class ShellAdapter(IShellExecutor):
                 self._terminate_process_group(process)
                 try:
                     comm_res = process.communicate(timeout=1.0)
-                    stdout, stderr = cast(tuple[str, str], comm_res)
+                    raw_stdout, raw_stderr = cast(
+                        tuple[bytes | str, bytes | str], comm_res
+                    )
                 except subprocess.TimeoutExpired:
-                    stdout, stderr = "", ""
-                return stdout, stderr, True
+                    raw_stdout, raw_stderr = "", ""
+                return (
+                    self._decode_stream(raw_stdout),
+                    self._decode_stream(raw_stderr),
+                    True,
+                )
             slice_timeout: float = poll_interval
             if deadline is not None:
                 remaining = deadline - time.monotonic()
@@ -250,8 +286,12 @@ class ShellAdapter(IShellExecutor):
                 slice_timeout = min(poll_interval, remaining)
             try:
                 comm_res = process.communicate(timeout=slice_timeout)
-                stdout, stderr = cast(tuple[str, str], comm_res)
-                return stdout, stderr, False
+                raw_stdout, raw_stderr = cast(tuple[bytes | str, bytes | str], comm_res)
+                return (
+                    self._decode_stream(raw_stdout),
+                    self._decode_stream(raw_stderr),
+                    False,
+                )
             except subprocess.TimeoutExpired:
                 continue
 
@@ -407,7 +447,7 @@ class ShellAdapter(IShellExecutor):
             }
 
     # jscpd:ignore-start
-    def execute(
+    def execute(  # noqa: PLR0913  # Signature fixed by the IShellExecutor port.
         self,
         command: str,
         cwd: Optional[str] = None,

{teddy_cli-0.1.17.dev1368 → teddy_cli-0.1.17.dev1370}/src/teddy_executor/adapters/outbound/system_environment_inspector.py

@@ -60,11 +60,14 @@ class SystemEnvironmentInspector(IEnvironmentInspector):
         """
         Gathers the current Git status of the working directory in porcelain format.
         """
+        # Explicit decoding keeps a non-UTF-8 path byte from raising mid-read
+        # or emptying the status, which would hide pending changes.
         try:
             result = self._run_func(  # nosec B603 B607
                 ["git", "status", "--porcelain", "-b"],
                 capture_output=True,
-                text=True,
+                encoding="utf-8",
+                errors="replace",
                 check=True,
                 stdin=subprocess.DEVNULL,
             )