taskflow 5.9.0__tar.gz → 5.10.0__tar.gz

{taskflow-5.9.0 → taskflow-5.10.0}/ChangeLog

@@ -1,6 +1,20 @@
 CHANGES
 =======
 
+5.10.0
+------
+
+* Add note about requirements lower bounds
+* Remove Python 3.8 support
+* Declare Python 3.12 support
+* Remove unused usage of pkg\_resources
+* Drop SQLALCHEMY\_WARN\_20
+* Update master for stable/2024.2
+
+5.9.1
+-----
+
+
 5.9.0
 -----
 
@@ -12,6 +26,7 @@ CHANGES
 -----
 
 * Python3.12: disable process\_executor, which depends on asyncore
+* Fix REVERT\_ALL with Retries in unordered Flows
 * Remove SQLAlchemy tips jobs
 * Remove old excludes
 * Remove assertRaisesRegex

{taskflow-5.9.0 → taskflow-5.10.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: taskflow
-Version: 5.9.0
+Version: 5.10.0
 Summary: Taskflow structured state management library.
 Home-page: https://docs.openstack.org/taskflow/latest/
 Author: OpenStack
@@ -91,15 +91,15 @@ Classifier: License :: OSI Approved :: Apache Software License
 Classifier: Operating System :: POSIX :: Linux
 Classifier: Programming Language :: Python
 Classifier: Programming Language :: Python :: 3
-Classifier: Programming Language :: Python :: 3.8
 Classifier: Programming Language :: Python :: 3.9
 Classifier: Programming Language :: Python :: 3.10
 Classifier: Programming Language :: Python :: 3.11
+Classifier: Programming Language :: Python :: 3.12
 Classifier: Programming Language :: Python :: 3 :: Only
 Classifier: Programming Language :: Python :: Implementation :: CPython
 Classifier: Topic :: Software Development :: Libraries
 Classifier: Topic :: System :: Distributed Computing
-Requires-Python: >=3.8
+Requires-Python: >=3.9
 Provides-Extra: database
 Provides-Extra: etcd
 Provides-Extra: eventlet

taskflow-5.10.0/releasenotes/notes/fix-revert-all-revert-a0310cd7beaa7409.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixed a bug when using retries with unordered flows, a REVERT_ALL triggered
+    by one of the subflow was overriden by an other subflow running in parallel,
+    leading to an incomplete revert of the flow.

taskflow-5.10.0/releasenotes/notes/remove-py38-15af791146f479e1.yaml

@@ -0,0 +1,5 @@
+---
+upgrade:
+  - |
+    Support for Python 3.8 has been removed. Now the minimum python version
+    supported is 3.9 .

taskflow-5.10.0/releasenotes/source/2024.2.rst

@@ -0,0 +1,6 @@
+===========================
+2024.2 Series Release Notes
+===========================
+
+.. release-notes::
+   :branch: stable/2024.2

{taskflow-5.9.0 → taskflow-5.10.0}/releasenotes/source/index.rst

@@ -6,6 +6,7 @@
    :maxdepth: 1
 
    unreleased
+   2024.2
    2024.1
    2023.2
    2023.1

{taskflow-5.9.0 → taskflow-5.10.0}/requirements.txt

@@ -1,3 +1,7 @@
+# Requirements lower bounds listed here are our best effort to keep them up to
+# date but we do not test them so no guarantee of having them all correct. If
+# you find any incorrect lower bounds, let us know or propose a fix.
+
 # See: https://bugs.launchpad.net/pbr/+bug/1384919 for why this is here...
 pbr>=2.0.0 # Apache-2.0
 

{taskflow-5.9.0 → taskflow-5.10.0}/setup.cfg

@@ -7,7 +7,7 @@ author = OpenStack
 author_email = openstack-discuss@lists.openstack.org
 home_page = https://docs.openstack.org/taskflow/latest/
 keywords = reliable,tasks,execution,parallel,dataflow,workflows,distributed
-python_requires = >=3.8
+python_requires = >=3.9
 classifier = 
 	Development Status :: 5 - Production/Stable
 	Environment :: OpenStack
@@ -17,10 +17,10 @@ classifier =
 	Operating System :: POSIX :: Linux
 	Programming Language :: Python
 	Programming Language :: Python :: 3
-	Programming Language :: Python :: 3.8
 	Programming Language :: Python :: 3.9
 	Programming Language :: Python :: 3.10
 	Programming Language :: Python :: 3.11
+	Programming Language :: Python :: 3.12
 	Programming Language :: Python :: 3 :: Only
 	Programming Language :: Python :: Implementation :: CPython
 	Topic :: Software Development :: Libraries

{taskflow-5.9.0 → taskflow-5.10.0}/taskflow/engines/action_engine/runtime.py

@@ -291,6 +291,18 @@ class Runtime(object):
         """Resets all the provided atoms to the given state and intention."""
         tweaked = []
         for atom in atoms:
+            cur_intention = self.storage.get_atom_intention(atom.name)
+            # Don't trigger a RETRY if the atom needs to be REVERTED.
+            # This is a workaround for a bug when REVERT_ALL is applied to
+            # unordered flows
+            # (https://bugs.launchpad.net/taskflow/+bug/2043808)
+            # A subflow may trigger a REVERT_ALL, all the atoms of all the
+            # related subflows are marked as REVERT but a task of a related
+            # flow may still be running in another thread. If this task
+            # triggers a RETRY, it overrides the previously set REVERT status,
+            # breaking the revert path of the flow.
+            if cur_intention == st.REVERT and intention == st.RETRY:
+                continue
             if state or intention:
                 tweaked.append((atom, state, intention))
             if state:

{taskflow-5.9.0 → taskflow-5.10.0}/taskflow/tests/unit/test_retries.py

@@ -15,8 +15,10 @@
 #    under the License.
 
 import testtools
+import time
 
 import taskflow.engines
+from taskflow.engines.action_engine import executor
 from taskflow import exceptions as exc
 from taskflow.patterns import graph_flow as gf
 from taskflow.patterns import linear_flow as lf
@@ -502,6 +504,56 @@ class RetryTest(utils.EngineTestBase):
         self.assertRaisesRegex(RuntimeError, '^Woot', engine.run)
         self.assertRaisesRegex(RuntimeError, '^Woot', engine.run)
 
+    def test_restart_reverted_unordered_flows_with_retries(self):
+        now = time.time()
+
+        # First flow of an unordered flow:
+        subflow1 = lf.Flow('subflow1')
+
+        # * a task that completes in 3 sec with a few retries
+        subsubflow1 = lf.Flow('subflow1.subsubflow1',
+                              retry=utils.RetryFiveTimes())
+        subsubflow1.add(utils.SuccessAfter3Sec('subflow1.fail1',
+                                               inject={'start_time': now}))
+        subflow1.add(subsubflow1)
+
+        # * a task that fails and triggers a revert after 5 retries
+        subsubflow2 = lf.Flow('subflow1.subsubflow2',
+                              retry=utils.RetryFiveTimes())
+        subsubflow2.add(utils.FailingTask('subflow1.fail2'))
+        subflow1.add(subsubflow2)
+
+        # Second flow of the unordered flow:
+        subflow2 = lf.Flow('subflow2')
+
+        # * a task that always fails and retries
+        subsubflow1 = lf.Flow('subflow2.subsubflow1',
+                              retry=utils.AlwaysRetry())
+        subsubflow1.add(utils.FailingTask('subflow2.fail1'))
+        subflow2.add(subsubflow1)
+
+        unordered_flow = uf.Flow('unordered_flow')
+        unordered_flow.add(subflow1, subflow2)
+
+        # Main flow, contains a simple task and an unordered flow
+        flow = lf.Flow('test')
+        flow.add(utils.NoopTask('task1'))
+        flow.add(unordered_flow)
+
+        engine = self._make_engine(flow)
+
+        # This test fails when using Green threads, skipping it for now
+        if isinstance(engine._task_executor,
+                      executor.ParallelGreenThreadTaskExecutor):
+            self.skipTest("Skipping this test when using green threads.")
+
+        with utils.CaptureListener(engine) as capturer:
+            self.assertRaisesRegex(exc.WrappedFailure,
+                                   '.*RuntimeError: Woot!',
+                                   engine.run)
+            # task1 should have been reverted
+            self.assertIn('task1.t REVERTED(None)', capturer.values)
+
     def test_run_just_retry(self):
         flow = utils.OneReturnRetry(provides='x')
         engine = self._make_engine(flow)

{taskflow-5.9.0 → taskflow-5.10.0}/taskflow/tests/utils.py

@@ -227,6 +227,32 @@ class FailingTask(ProgressingTask):
         raise RuntimeError('Woot!')
 
 
+class SimpleTask(task.Task):
+    def execute(self, time_sleep=0, **kwargs):
+        time.sleep(time_sleep)
+
+
+class SuccessAfter3Sec(task.Task):
+    def execute(self, start_time, **kwargs):
+        now = time.time()
+        if now - start_time >= 3:
+            return None
+        raise RuntimeError('Woot!')
+
+
+class RetryFiveTimes(retry.Times):
+    def on_failure(self, history, *args, **kwargs):
+        if len(history) < 5:
+            time.sleep(1)
+            return retry.RETRY
+        return retry.REVERT_ALL
+
+
+class AlwaysRetry(retry.Times):
+    def on_failure(self, history, *args, **kwargs):
+        return retry.RETRY
+
+
 class OptionalTask(task.Task):
     def execute(self, a, b=5):
         result = a * b

{taskflow-5.9.0 → taskflow-5.10.0}/taskflow/version.py

@@ -14,19 +14,14 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-import pkg_resources
+from pbr import version as pbr_version
 
 TASK_VENDOR = "OpenStack Foundation"
 TASK_PRODUCT = "OpenStack TaskFlow"
 TASK_PACKAGE = None  # OS distro package version suffix
 
-try:
-    from pbr import version as pbr_version
-    _version_info = pbr_version.VersionInfo('taskflow')
-    version_string = _version_info.version_string
-except ImportError:
-    _version_info = pkg_resources.get_distribution('taskflow')
-    version_string = lambda: _version_info.version
+_version_info = pbr_version.VersionInfo('taskflow')
+version_string = _version_info.version_string
 
 
 def version_string_with_package():

{taskflow-5.9.0 → taskflow-5.10.0}/taskflow.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: taskflow
-Version: 5.9.0
+Version: 5.10.0
 Summary: Taskflow structured state management library.
 Home-page: https://docs.openstack.org/taskflow/latest/
 Author: OpenStack
@@ -91,15 +91,15 @@ Classifier: License :: OSI Approved :: Apache Software License
 Classifier: Operating System :: POSIX :: Linux
 Classifier: Programming Language :: Python
 Classifier: Programming Language :: Python :: 3
-Classifier: Programming Language :: Python :: 3.8
 Classifier: Programming Language :: Python :: 3.9
 Classifier: Programming Language :: Python :: 3.10
 Classifier: Programming Language :: Python :: 3.11
+Classifier: Programming Language :: Python :: 3.12
 Classifier: Programming Language :: Python :: 3 :: Only
 Classifier: Programming Language :: Python :: Implementation :: CPython
 Classifier: Topic :: Software Development :: Libraries
 Classifier: Topic :: System :: Distributed Computing
-Requires-Python: >=3.8
+Requires-Python: >=3.9
 Provides-Extra: database
 Provides-Extra: etcd
 Provides-Extra: eventlet

{taskflow-5.9.0 → taskflow-5.10.0}/taskflow.egg-info/SOURCES.txt

@@ -70,9 +70,11 @@ releasenotes/notes/drop-python-2-7-73d3113c69d724d6.yaml
 releasenotes/notes/etcd-jobboard-backend-8a9fea2238fb0f12.yaml
 releasenotes/notes/fix-endless-loop-on-storage-error-dd4467f0bbc66abf.yaml
 releasenotes/notes/fix-endless-loop-on-storage-failures-b98b30f0c34d25e1.yaml
+releasenotes/notes/fix-revert-all-revert-a0310cd7beaa7409.yaml
 releasenotes/notes/fix-storage-failure-handling-5c115d92daa0eb82.yaml
 releasenotes/notes/fix-zookeeper-option-parsing-f9d37fbc39af47f4.yaml
 releasenotes/notes/redis-username-df0eb33869db09a2.yaml
+releasenotes/notes/remove-py38-15af791146f479e1.yaml
 releasenotes/notes/remove-strict-redis-f2a5a924b314de41.yaml
 releasenotes/notes/sentinel-fallbacks-6fe2ab0d68959cdf.yaml
 releasenotes/notes/sentinel-ssl-399c56ed7067d282.yaml
@@ -81,6 +83,7 @@ releasenotes/notes/zookeeper-ssl-support-b9abf24a39096b62.yaml
 releasenotes/source/2023.1.rst
 releasenotes/source/2023.2.rst
 releasenotes/source/2024.1.rst
+releasenotes/source/2024.2.rst
 releasenotes/source/conf.py
 releasenotes/source/index.rst
 releasenotes/source/ocata.rst

taskflow-5.10.0/taskflow.egg-info/pbr.json

@@ -0,0 +1 @@
+{"git_version": "ca0b7bbe", "is_release": true}

{taskflow-5.9.0 → taskflow-5.10.0}/tox.ini

@@ -3,9 +3,6 @@ minversion = 3.18.0
 envlist = cover,docs,pep8,py3,pylint,update-states
 
 [testenv]
-setenv =
-# TODO(stephenfin): Remove once we bump our upper-constraint to SQLAlchemy 2.0
-  SQLALCHEMY_WARN_20=1
 # We need to install a bit more than just `test' because those drivers have
 # custom tests that we always run
 deps =
@@ -52,7 +49,6 @@ deps =
   {[testenv]deps}
   coverage>=3.6
 setenv =
-   {[testenv]setenv}
    PYTHON=coverage run --source taskflow --parallel-mode
 commands =
    stestr run {posargs}

taskflow-5.9.0/taskflow.egg-info/pbr.json

@@ -1 +0,0 @@
-{"git_version": "fc14510a", "is_release": true}