taskfile 0.3.78__tar.gz → 0.3.80__tar.gz

{taskfile-0.3.78/src/taskfile.egg-info → taskfile-0.3.80}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: taskfile
-Version: 0.3.78
+Version: 0.3.80
 Summary: Universal Taskfile runner with multi-environment deploy support. CI/CD agnostic — run locally or from any pipeline.
 Author-email: Tom Sapletta <tom@sapletta.com>
 License-Expression: Apache-2.0
@@ -20,6 +20,7 @@ Requires-Dist: pyyaml>=6.0
 Requires-Dist: click>=8.0
 Requires-Dist: rich>=13.0
 Requires-Dist: clickmd>=1.1.1
+Requires-Dist: fixop>=0.1.0
 Provides-Extra: ssh
 Requires-Dist: paramiko>=3.0; extra == "ssh"
 Provides-Extra: api

{taskfile-0.3.78 → taskfile-0.3.80}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "taskfile"
-version = "0.3.78"
+version = "0.3.80"
 description = "Universal Taskfile runner with multi-environment deploy support. CI/CD agnostic — run locally or from any pipeline."
 readme = "README.md"
 license = "Apache-2.0"
@@ -25,6 +25,7 @@ dependencies = [
     "click>=8.0",
     "rich>=13.0",
     "clickmd>=1.1.1",
+    "fixop>=0.1.0",
 ]
 
 [project.optional-dependencies]

{taskfile-0.3.78 → taskfile-0.3.80}/src/taskfile/__init__.py

@@ -12,7 +12,7 @@ Features:
     - @remote SSH command execution
 """
 
-__version__ = "0.3.78"
+__version__ = "0.3.80"
 __author__ = "Softreck"
 
 from taskfile.runner import TaskfileRunner

{taskfile-0.3.78 → taskfile-0.3.80}/src/taskfile/api/app.py

@@ -555,6 +555,16 @@ def _register_doctor_routes(app: FastAPI) -> None:
         )
 
 
+# ── Category filter for doctor endpoint ──────────────────────────
+
+_CATEGORY_FILTER = {
+    "config": {"config_error", "taskfile_bug"},
+    "env": {"dependency_missing"},
+    "infra": {"external_error"},
+    "runtime": {"runtime_error"},
+}
+
+
 def _run_doctor(
     app: FastAPI,
     *,
@@ -567,37 +577,45 @@ def _run_doctor(
     from taskfile.diagnostics import ProjectDiagnostics
 
     diagnostics = ProjectDiagnostics()
-
     diagnostics.run_all_checks(verbose=verbose)
 
-    # Layer 4: Auto-fix
-    fixed_count = 0
+    fixed_count = _apply_layer4_fixes(diagnostics, fix)
+    llm_suggestions = _apply_layer5_llm(diagnostics, llm)
+    issues = _filter_issues_by_category(diagnostics._issues, category)
+    issue_infos, by_category = _build_issue_infos(issues)
+
+    return _build_doctor_response(issue_infos, by_category, fixed_count, llm_suggestions)
+
+
+def _apply_layer4_fixes(diagnostics, fix: bool) -> int:
+    """Layer 4: Apply auto-fixes if requested. Returns fixed count."""
     if fix and diagnostics.issues:
-        fixed_count = diagnostics.auto_fix()
+        return diagnostics.auto_fix()
+    return 0
 
-    # Layer 5: LLM assist
-    llm_suggestions: list[str] = []
+
+def _apply_layer5_llm(diagnostics, llm: bool) -> list[str]:
+    """Layer 5: Ask LLM for suggestions on unresolved issues."""
     if llm and diagnostics._issues:
         try:
-            llm_suggestions = diagnostics.llm_repair()
+            return diagnostics.llm_repair()
         except Exception:
             pass
+    return []
+
+
+def _filter_issues_by_category(issues, category: str):
+    """Filter issues by doctor category (config/env/infra/runtime/all)."""
+    if category == "all" or category not in _CATEGORY_FILTER:
+        return issues
+    allowed = _CATEGORY_FILTER[category]
+    return [i for i in issues if i.category.value in allowed]
 
-    # Filter by category if requested
-    CATEGORY_FILTER = {
-        "config": {"config_error", "taskfile_bug"},
-        "env": {"dependency_missing"},
-        "infra": {"external_error"},
-        "runtime": {"runtime_error"},
-    }
-    issues = diagnostics._issues
-    if category != "all" and category in CATEGORY_FILTER:
-        allowed = CATEGORY_FILTER[category]
-        issues = [i for i in issues if i.category.value in allowed]
-
-    # Build response
-    issue_infos = []
-    categories: dict[str, list[DoctorIssueInfo]] = {}
+
+def _build_issue_infos(issues) -> tuple[list[DoctorIssueInfo], dict[str, list[DoctorIssueInfo]]]:
+    """Convert Issue objects to API response models, grouped by category."""
+    infos: list[DoctorIssueInfo] = []
+    by_category: dict[str, list[DoctorIssueInfo]] = {}
     for iss in issues:
         info = DoctorIssueInfo(
             category=iss.category.value,
@@ -611,13 +629,22 @@ def _run_doctor(
             teach=iss.teach,
             context={k: v for k, v in iss.context.items() if not k.startswith("_")} if iss.context else None,
         )
-        issue_infos.append(info)
-        categories.setdefault(iss.category.value, []).append(info)
+        infos.append(info)
+        by_category.setdefault(iss.category.value, []).append(info)
+    return infos, by_category
+
 
-    error_count = sum(1 for i in issues if i.severity == "error")
-    warn_count = sum(1 for i in issues if i.severity == "warning")
-    info_count = sum(1 for i in issues if i.severity == "info")
-    fixable = sum(1 for i in issues if i.auto_fixable)
+def _build_doctor_response(
+    issue_infos: list[DoctorIssueInfo],
+    categories: dict[str, list[DoctorIssueInfo]],
+    fixed_count: int,
+    llm_suggestions: list[str],
+) -> DoctorResponse:
+    """Assemble the final DoctorResponse from computed parts."""
+    error_count = sum(1 for i in issue_infos if i.severity == "error")
+    warn_count = sum(1 for i in issue_infos if i.severity == "warning")
+    info_count = sum(1 for i in issue_infos if i.severity == "info")
+    fixable = sum(1 for i in issue_infos if i.auto_fixable)
 
     parts = []
     if error_count:

{taskfile-0.3.78 → taskfile-0.3.80}/src/taskfile/cli/interactive/wizards.py

@@ -263,13 +263,8 @@ curl -X POST http://localhost:8000/doctor -H "Content-Type: application/json" \
             border_style="blue"
         ))
 
-    with console.status("[bold green]Checking project...[/]" if not remote else "[bold green]Checking remote server...[/]") if not report else _nullcontext():
-        diagnostics.run_all_checks(verbose=verbose, remote=remote)
-        # Remote-only: extended remote diagnostics
-        if remote:
-            _run_remote_diagnostics(diagnostics)
+    _doctor_run_checks(diagnostics, verbose=verbose, remote=remote, report=report)
 
-    # Validate examples/ directory if requested
     if check_examples_flag:
         _run_examples_check(diagnostics, report)
 
@@ -278,19 +273,32 @@ curl -X POST http://localhost:8000/doctor -H "Content-Type: application/json" \
         sys.exit(1 if any(s == "error" for _, s, _ in diagnostics.issues) else 0)
 
     diagnostics.print_report(show_teach=teach)
+    _doctor_apply_fixes(diagnostics, fix=fix, llm=llm)
+    _doctor_print_summary(diagnostics)
+
+
+def _doctor_run_checks(diagnostics: ProjectDiagnostics, *, verbose: bool, remote: bool, report: bool) -> None:
+    """Layers 1-3: Run all diagnostic checks (with optional spinner)."""
+    with console.status("[bold green]Checking project...[/]" if not remote else "[bold green]Checking remote server...[/]") if not report else _nullcontext():
+        diagnostics.run_all_checks(verbose=verbose, remote=remote)
+        if remote:
+            _run_remote_diagnostics(diagnostics)
+
 
-    # Layer 4: Algorithmic fix
+def _doctor_apply_fixes(diagnostics: ProjectDiagnostics, *, fix: bool, llm: bool) -> None:
+    """Layers 4-5: Apply auto-fixes and optionally ask LLM for suggestions."""
     if fix and diagnostics.issues:
         console.print("\n[bold]Layer 4: Attempting auto-fix...[/]")
         fixed = diagnostics.auto_fix()
         if fixed > 0:
             console.print(f"[green]✓ Fixed {fixed} issue(s)[/]")
 
-    # Layer 5: LLM assist
     if llm and diagnostics._issues:
         _run_llm_assist(diagnostics)
 
-    # Summary
+
+def _doctor_print_summary(diagnostics: ProjectDiagnostics) -> None:
+    """Print final doctor summary with next-step guidance."""
     if not diagnostics.issues:
         console.print("\n[bold green]Your project is ready! 🚀[/]")
         console.print("\n[dim]Next steps:[/]")
@@ -406,6 +414,48 @@ def _collect_remote_envs(config, selected_env: str | None) -> list[tuple] | None
     return envs
 
 
+def _run_fixop_checks(env) -> None:
+    """Run extended fixop infrastructure checks on a remote environment.
+
+    Checks: DNS, container DNS, UFW forward policy, systemd-resolved, NAT masquerade.
+    Degrades gracefully when fixop is not installed.
+    """
+    try:
+        import fixop
+    except ImportError:
+        return  # fixop not installed — skip silently
+
+    ctx = fixop.HostContext(
+        host=env.ssh_host,
+        user=env.ssh_user or "root",
+        port=env.ssh_port or 22,
+        key=getattr(env, "ssh_key", None) or "~/.ssh/id_ed25519",
+    )
+
+    _CHECKS = [
+        ("DNS", fixop.check_host_dns),
+        ("systemd-resolved", fixop.check_systemd_resolved),
+        ("UFW forward policy", fixop.check_ufw_forward_policy),
+    ]
+
+    found = 0
+    for label, check_fn in _CHECKS:
+        try:
+            issues = check_fn(ctx)
+            for issue in issues:
+                sev = issue.severity.value
+                color = "red" if sev in ("error", "critical") else "yellow"
+                console.print(f"[{color}]  ⚠ [{label}] {issue.message}[/{color}]")
+                if issue.fix_command:
+                    console.print(f"[dim]    Fix: {issue.fix_command}[/]")
+                found += 1
+        except Exception:
+            pass  # individual check failure — skip
+
+    if found == 0:
+        console.print("[green]  ✓ Infrastructure checks passed (DNS, UFW, systemd-resolved)[/]")
+
+
 def _diagnose_single_remote_env(env_name, env, taskfile_dir) -> None:
     """Run all remote diagnostics for a single environment."""
     from taskfile.deploy_utils import test_ssh_connection
@@ -432,6 +482,9 @@ def _diagnose_single_remote_env(env_name, env, taskfile_dir) -> None:
     except Exception as e:
         console.print(f"[yellow]  Remote diagnostics error: {e}[/]")
 
+    # Extended infrastructure checks via fixop (DNS, UFW, TLS, systemd-resolved, NAT)
+    _run_fixop_checks(env)
+
 
 def _run_remote_diagnostics(diagnostics: ProjectDiagnostics) -> None:
     """Extended remote diagnostics — check containers, images, system status on remote server."""

{taskfile-0.3.78 → taskfile-0.3.80}/src/taskfile/cli/main.py

@@ -328,70 +328,14 @@ taskfile run deploy --teach
 ```
 """
     opts = ctx.obj
-    env_group = opts.get("env_group")
     tag_filter = [t.strip() for t in run_tags.split(",")] if run_tags else None
 
     try:
-        # --explain / --teach mode: analyze without running
         if explain or teach:
-            from taskfile.runner.resolver import TaskResolver
-            from taskfile.runner.explainer import (
-                TaskExplainer, print_explain_report, print_teach_report,
-            )
-            config = load_taskfile(opts["taskfile_path"])
-            resolver = TaskResolver(
-                config,
-                env_name=opts["env_name"],
-                platform_name=opts["platform_name"],
-                var_overrides=opts["var"],
-            )
-            task_list = list(tasks)
-            _check_unknown_tasks(task_list, config.tasks)
-            if tag_filter:
-                task_list = _filter_tasks_by_tags(config, task_list, tag_filter)
-                if not task_list:
-                    console.print(f"[yellow]No tasks match tags: {', '.join(tag_filter)}[/]")
-                    sys.exit(0)
-
-            explainer = TaskExplainer(resolver)
-            report = explainer.explain(task_list)
-
-            if teach:
-                print_teach_report(report, task_list, resolver.env_name, config)
-            else:
-                print_explain_report(report, task_list, resolver.env_name)
-
-            sys.exit(1 if report.has_errors else 0)
-
-        if env_group:
-            success = _run_env_group(
-                taskfile_path=opts["taskfile_path"],
-                env_group=env_group,
-                task_names=list(tasks),
-                platform_name=opts["platform_name"],
-                var_overrides=opts["var"],
-                dry_run=opts["dry_run"],
-                verbose=opts["verbose"],
-            )
+            _run_explain_mode(opts, list(tasks), tag_filter, teach=teach)
         else:
-            runner = TaskfileRunner(
-                taskfile_path=opts["taskfile_path"],
-                env_name=opts["env_name"],
-                platform_name=opts["platform_name"],
-                var_overrides=opts["var"],
-                dry_run=opts["dry_run"],
-                verbose=opts["verbose"],
-            )
-            task_list = list(tasks)
-            _check_unknown_tasks(task_list, runner.config.tasks)
-            
-            if tag_filter:
-                task_list = _filter_tasks_by_tags(runner.config, task_list, tag_filter)
-                if not task_list:
-                    console.print(f"[yellow]No tasks match tags: {', '.join(tag_filter)}[/]")
-                    sys.exit(0)
-            success = runner.run(task_list)
-        sys.exit(0 if success else 1)
+            success = _run_tasks(opts, list(tasks), tag_filter)
+            sys.exit(0 if success else 1)
     except (TaskfileNotFoundError, TaskfileParseError) as e:
         console.print(f"[red]Error:[/] {e}")
         if isinstance(e, TaskfileNotFoundError):
@@ -399,6 +343,69 @@ taskfile run deploy --teach
         sys.exit(1)
 
 
+def _run_explain_mode(opts: dict, task_list: list[str], tag_filter: list[str] | None, *, teach: bool) -> None:
+    """Handle --explain / --teach mode: analyze execution plan without running."""
+    from taskfile.runner.resolver import TaskResolver
+    from taskfile.runner.explainer import (
+        TaskExplainer, print_explain_report, print_teach_report,
+    )
+    config = load_taskfile(opts["taskfile_path"])
+    resolver = TaskResolver(
+        config,
+        env_name=opts["env_name"],
+        platform_name=opts["platform_name"],
+        var_overrides=opts["var"],
+    )
+    _check_unknown_tasks(task_list, config.tasks)
+    if tag_filter:
+        task_list = _filter_tasks_by_tags(config, task_list, tag_filter)
+        if not task_list:
+            console.print(f"[yellow]No tasks match tags: {', '.join(tag_filter)}[/]")
+            sys.exit(0)
+
+    explainer = TaskExplainer(resolver)
+    report = explainer.explain(task_list)
+
+    if teach:
+        print_teach_report(report, task_list, resolver.env_name, config)
+    else:
+        print_explain_report(report, task_list, resolver.env_name)
+
+    sys.exit(1 if report.has_errors else 0)
+
+
+def _run_tasks(opts: dict, task_list: list[str], tag_filter: list[str] | None) -> bool:
+    """Execute tasks normally, via env group or single runner. Returns success."""
+    env_group = opts.get("env_group")
+    if env_group:
+        return _run_env_group(
+            taskfile_path=opts["taskfile_path"],
+            env_group=env_group,
+            task_names=task_list,
+            platform_name=opts["platform_name"],
+            var_overrides=opts["var"],
+            dry_run=opts["dry_run"],
+            verbose=opts["verbose"],
+        )
+
+    runner = TaskfileRunner(
+        taskfile_path=opts["taskfile_path"],
+        env_name=opts["env_name"],
+        platform_name=opts["platform_name"],
+        var_overrides=opts["var"],
+        dry_run=opts["dry_run"],
+        verbose=opts["verbose"],
+    )
+    _check_unknown_tasks(task_list, runner.config.tasks)
+
+    if tag_filter:
+        task_list = _filter_tasks_by_tags(runner.config, task_list, tag_filter)
+        if not task_list:
+            console.print(f"[yellow]No tasks match tags: {', '.join(tag_filter)}[/]")
+            sys.exit(0)
+    return runner.run(task_list)
+
+
 def _filter_tasks_by_tags(config, task_names: list[str], tags: list[str]) -> list[str]:
     """Filter task names to only those whose tags overlap with the requested tags."""
     filtered = []

{taskfile-0.3.78 → taskfile-0.3.80}/src/taskfile/compose.py

@@ -74,7 +74,7 @@ def resolve_variables(text: str, variables: dict[str, str]) -> str:
         name = groups.get("n") or groups.get("name") or groups.get("simple")
         default = groups.get("default")
         if name and name in variables:
-            return variables[name]
+            return str(variables[name])
         if default is not None:
             return default
         # Keep unresolved vars as-is (useful for runtime vars)

{taskfile-0.3.78 → taskfile-0.3.80}/src/taskfile/deploy_recipes.py

@@ -40,13 +40,23 @@ def expand_deploy_recipe(deploy_section: dict[str, Any], variables: dict[str, st
     health_check = deploy_section.get("health_check", "/health")
     health_retries = deploy_section.get("health_retries", 5)
     health_delay = deploy_section.get("health_delay", 5)
-    rollback_mode = deploy_section.get("rollback", "manual")  # auto | manual
     restart_delay = deploy_section.get("restart_delay", 3)  # seconds between stop→start
     tag_var = "${TAG}"
 
     tasks: dict[str, dict] = {}
+    tasks.update(_build_tasks(images, registry, tag_var))
+    tasks.update(_push_tasks(images, registry, tag_var))
+    tasks["validate-deploy"] = _validate_task()
+    tasks["deploy"] = _deploy_task(strategy, images, registry, tag_var, restart_delay)
+    tasks.update(_health_tasks(images, health_check, health_retries, health_delay, registry, tag_var))
+    tasks.update(_rollback_tasks(images, registry, tag_var, restart_delay))
 
-    # ── Build tasks (one per image) ──
+    return tasks
+
+
+def _build_tasks(images: dict, registry: str, tag_var: str) -> dict[str, dict]:
+    """Generate build-<svc> and build-all tasks."""
+    tasks: dict[str, dict] = {}
     for svc_name, dockerfile in images.items():
         image_var = f"{registry}/{svc_name}:{tag_var}"
         tasks[f"build-{svc_name}"] = {
@@ -55,8 +65,6 @@ def expand_deploy_recipe(deploy_section: dict[str, Any], variables: dict[str, st
             "tags": ["ci", "build"],
             "cmds": [f"docker build -t {image_var} -f {dockerfile} ."],
         }
-
-    # ── build-all ──
     if len(images) > 1:
         tasks["build-all"] = {
             "desc": "Build all images",
@@ -65,8 +73,12 @@ def expand_deploy_recipe(deploy_section: dict[str, Any], variables: dict[str, st
             "tags": ["ci", "build"],
             "cmds": ["echo 'All images built'"],
         }
+    return tasks
 
-    # ── Push tasks ──
+
+def _push_tasks(images: dict, registry: str, tag_var: str) -> dict[str, dict]:
+    """Generate push-<svc> and push-all tasks."""
+    tasks: dict[str, dict] = {}
     for svc_name in images:
         image_var = f"{registry}/{svc_name}:{tag_var}"
         tasks[f"push-{svc_name}"] = {
@@ -76,7 +88,6 @@ def expand_deploy_recipe(deploy_section: dict[str, Any], variables: dict[str, st
             "tags": ["ci", "push"],
             "cmds": [f"docker push {image_var}"],
         }
-
     if len(images) > 1:
         tasks["push-all"] = {
             "desc": "Push all images to registry",
@@ -86,9 +97,12 @@ def expand_deploy_recipe(deploy_section: dict[str, Any], variables: dict[str, st
             "tags": ["ci", "push"],
             "cmds": [f"echo 'All images pushed to {registry}'"],
         }
+    return tasks
 
-    # ── Validate deploy artifacts (pre-deploy gate) ──
-    tasks["validate-deploy"] = {
+
+def _validate_task() -> dict:
+    """Generate the validate-deploy gate task."""
+    return {
         "desc": "Validate deploy artifacts — check for unresolved variables and placeholders",
         "tags": ["ci", "validate"],
         "silent": True,
@@ -103,60 +117,69 @@ def expand_deploy_recipe(deploy_section: dict[str, Any], variables: dict[str, st
         ],
     }
 
-    # ── Deploy task (strategy-specific) ──
+
+def _deploy_task(
+    strategy: str, images: dict, registry: str, tag_var: str, restart_delay: int,
+) -> dict:
+    """Generate the deploy task based on strategy. Dispatches to strategy-specific builders."""
     push_dep = "push-all" if len(images) > 1 else f"push-{list(images)[0]}" if images else None
     deploy_deps = ["validate-deploy"]
     if push_dep:
         deploy_deps.insert(0, push_dep)
 
-    if strategy == "compose":
-        tasks["deploy"] = _compose_deploy(deploy_deps)
-    elif strategy == "quadlet":
-        tasks["deploy"] = _quadlet_deploy(deploy_deps, images, registry, tag_var, restart_delay)
-    elif strategy == "ssh-push":
-        tasks["deploy"] = _ssh_push_deploy(deploy_deps, images, registry, tag_var, restart_delay)
-    else:
-        tasks["deploy"] = _compose_deploy(deploy_deps)
-
-    # ── Health check ──
-    tasks["health"] = {
-        "desc": "Check application health",
-        "tags": ["ops", "health"],
-        "silent": True,
-        "retries": health_retries,
-        "retry_delay": health_delay,
-        "cmds": [
-            f"curl -sf https://${{DOMAIN}}{health_check} && echo 'OK' || exit 1",
-        ],
+    _STRATEGY_DISPATCH = {
+        "compose": lambda: _compose_deploy(deploy_deps),
+        "quadlet": lambda: _quadlet_deploy(deploy_deps, images, registry, tag_var, restart_delay),
+        "ssh-push": lambda: _ssh_push_deploy(deploy_deps, images, registry, tag_var, restart_delay),
     }
+    builder = _STRATEGY_DISPATCH.get(strategy, _STRATEGY_DISPATCH["compose"])
+    return builder()
 
-    # ── Post-deploy health gate ──
-    tasks["post-deploy"] = {
-        "desc": "Post-deploy health gate — verify all services are healthy after deploy",
-        "tags": ["deploy", "health"],
-        "silent": True,
-        "retries": health_retries,
-        "retry_delay": health_delay,
-        "cmds": _post_deploy_health_cmds(images, health_check, registry, tag_var),
+
+def _health_tasks(
+    images: dict, health_check: str, health_retries: int, health_delay: int,
+    registry: str, tag_var: str,
+) -> dict[str, dict]:
+    """Generate health and post-deploy health gate tasks."""
+    return {
+        "health": {
+            "desc": "Check application health",
+            "tags": ["ops", "health"],
+            "silent": True,
+            "retries": health_retries,
+            "retry_delay": health_delay,
+            "cmds": [
+                f"curl -sf https://${{DOMAIN}}{health_check} && echo 'OK' || exit 1",
+            ],
+        },
+        "post-deploy": {
+            "desc": "Post-deploy health gate — verify all services are healthy after deploy",
+            "tags": ["deploy", "health"],
+            "silent": True,
+            "retries": health_retries,
+            "retry_delay": health_delay,
+            "cmds": _post_deploy_health_cmds(images, health_check, registry, tag_var),
+        },
     }
 
-    # ── Rollback ──
-    if images:
-        rollback_cmds = []
-        for svc_name in images:
-            image_var = f"{registry}/{svc_name}:{tag_var}"
-            rollback_cmds.append(f"@remote podman pull {image_var}")
-        for svc_name in images:
-            rollback_cmds.extend(
-                _graceful_restart_cmds(svc_name, restart_delay)
-            )
-        tasks["rollback"] = {
+
+def _rollback_tasks(images: dict, registry: str, tag_var: str, restart_delay: int) -> dict[str, dict]:
+    """Generate rollback task if images are defined."""
+    if not images:
+        return {}
+    rollback_cmds = []
+    for svc_name in images:
+        image_var = f"{registry}/{svc_name}:{tag_var}"
+        rollback_cmds.append(f"@remote podman pull {image_var}")
+    for svc_name in images:
+        rollback_cmds.extend(_graceful_restart_cmds(svc_name, restart_delay))
+    return {
+        "rollback": {
             "desc": "Rollback to specified version (--var TAG=<prev>)",
             "tags": ["deploy", "rollback"],
             "cmds": rollback_cmds,
-        }
-
-    return tasks
+        },
+    }
 
 
 def _graceful_restart_cmds(svc_name: str, restart_delay: int = 3) -> list[str]: