taskcluster-taskgraph 19.1.0__tar.gz → 19.2.0__tar.gz

{taskcluster_taskgraph-19.1.0 → taskcluster_taskgraph-19.2.0}/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Change Log
 
+## [19.2.0] - 2026-02-18
+
+### Fixed
+
+- Restore `payload_builder` wrapping for dict schemas
+- Make nested struct fields optional to match voluptuous defaults
+
 ## [19.1.0] - 2026-02-17
 
 ### Added

{taskcluster_taskgraph-19.1.0 → taskcluster_taskgraph-19.2.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: taskcluster-taskgraph
-Version: 19.1.0
+Version: 19.2.0
 Summary: Build taskcluster taskgraphs
 Project-URL: Repository, https://github.com/taskcluster/taskgraph
 Project-URL: Issues, https://github.com/taskcluster/taskgraph/issues

{taskcluster_taskgraph-19.1.0 → taskcluster_taskgraph-19.2.0}/pyproject.toml

@@ -1,7 +1,7 @@
 ### Project
 [project]
 name = "taskcluster-taskgraph"
-version = "19.1.0"
+version = "19.2.0"
 description = "Build taskcluster taskgraphs"
 readme = "README.rst"
 authors = [

{taskcluster_taskgraph-19.1.0 → taskcluster_taskgraph-19.2.0}/src/taskgraph/transforms/task.py

@@ -16,11 +16,14 @@ from copy import deepcopy
 from dataclasses import dataclass
 from typing import Callable, Literal, Optional, Union
 
+import voluptuous
+
 from taskgraph.transforms.base import TransformSequence
 from taskgraph.util.hash import hash_path
 from taskgraph.util.keyed_by import evaluate_keyed_by
 from taskgraph.util.schema import (
     IndexSchema,
+    LegacySchema,
     OptimizationType,
     Schema,
     TaskPriority,
@@ -194,6 +197,14 @@ class PayloadBuilder:
 
 
 def payload_builder(name, schema):
+    if isinstance(schema, dict):
+        schema = LegacySchema(
+            {
+                voluptuous.Required("implementation"): name,
+                voluptuous.Optional("os"): str,
+            }
+        ).extend(schema)
+
     def wrap(func):
         assert name not in payload_builders, f"duplicate payload builder name {name}"
         payload_builders[name] = PayloadBuilder(schema, func)
@@ -232,22 +243,22 @@ DockerImage = Union[str, dict[str, str]]
 
 class DockerWorkerCacheEntry(Schema):
     # only one type is supported by any of the workers right now
-    type: Literal["persistent"]
+    type: Literal["persistent"] = "persistent"
     # name of the cache, allowing reuse by subsequent tasks naming the same cache
-    name: str
+    name: Optional[str] = None
     # location in the task image where the cache will be mounted
-    mount_point: str
+    mount_point: Optional[str] = None
     # Whether the cache is not used in untrusted environments (like the Try repo).
     skip_untrusted: Optional[bool] = None
 
 
 class DockerWorkerArtifact(Schema):
     # type of artifact -- simple file, or recursive directory, or a volume mounted directory.
-    type: Literal["file", "directory", "volume"]
+    type: Optional[Literal["file", "directory", "volume"]] = None
     # task image path from which to read artifact
-    path: str
+    path: Optional[str] = None
     # name of the produced artifact (root of the names for type=directory)
-    name: str
+    name: Optional[str] = None
 
 
 class DockerWorkerPayloadSchema(Schema, forbid_unknown_fields=False, kw_only=True):
@@ -675,12 +686,12 @@ def build_generic_worker_payload(config, task, task_def):
 
 
 class ReleaseProperties(Schema):
-    app_name: str
-    app_version: str
-    branch: str
-    build_id: str
-    hash_type: str
-    platform: str
+    app_name: Optional[str] = None
+    app_version: Optional[str] = None
+    branch: Optional[str] = None
+    build_id: Optional[str] = None
+    hash_type: Optional[str] = None
+    platform: Optional[str] = None
 
 
 class UpstreamArtifact(Schema, rename="camel"):

{taskcluster_taskgraph-19.1.0 → taskcluster_taskgraph-19.2.0}/src/taskgraph/util/schema.py

@@ -48,6 +48,9 @@ def validate_schema(schema, obj, msg_prefix):
         # Handle plain Python types (e.g. str, int) via msgspec.convert
         elif isinstance(schema, type):
             msgspec.convert(obj, schema)
+        # Handle plain dict schemas (e.g. from downstream payload builders)
+        elif isinstance(schema, dict):
+            voluptuous.Schema(schema)(obj)
         else:
             raise TypeError(f"Unsupported schema type: {type(schema)}")
     except (
@@ -316,9 +319,9 @@ class Schema(
 
 class IndexSchema(Schema):
     # the name of the product this build produces
-    product: str
+    product: Optional[str] = None
     # the names to use for this task in the TaskCluster index
-    job_name: str
+    job_name: Optional[str] = None
     # Type of gecko v2 index to use
     type: str = "generic"
     # The rank that the task will receive in the TaskCluster

{taskcluster_taskgraph-19.1.0 → taskcluster_taskgraph-19.2.0}/test/test_transforms_task.py

@@ -7,6 +7,7 @@ from pathlib import Path
 from pprint import pprint
 
 import pytest
+import voluptuous
 from pytest_taskgraph import FakeParameters
 
 from taskgraph.transforms import task
@@ -966,3 +967,36 @@ def test_task_priority(run_transform, graph_config, test_task):
         assert task_dict["task"]["priority"] == priority
     else:
         assert task_dict["task"]["priority"] == graph_config["task-priority"]
+
+
+@pytest.fixture
+def dict_schema_builder():
+    @task.payload_builder("test-builder", schema={"command": [str]})
+    def _builder(config, task, task_def):
+        pass
+
+    yield task.payload_builders["test-builder"].schema
+    task.payload_builders.pop("test-builder", None)
+
+
+@pytest.mark.parametrize(
+    "payload",
+    (
+        {"implementation": "test-builder", "command": ["echo"]},
+        {"implementation": "test-builder", "command": ["echo"], "os": "linux"},
+    ),
+)
+def test_dict_schema_accepts_valid_payload(dict_schema_builder, payload):
+    dict_schema_builder(payload)
+
+
+@pytest.mark.parametrize(
+    "payload",
+    (
+        {"implementation": "wrong-name", "command": ["echo"]},
+        {"command": ["echo"]},
+    ),
+)
+def test_dict_schema_rejects_invalid_payload(dict_schema_builder, payload):
+    with pytest.raises(voluptuous.MultipleInvalid):
+        dict_schema_builder(payload)

{taskcluster_taskgraph-19.1.0 → taskcluster_taskgraph-19.2.0}/test/test_util_schema.py

@@ -9,6 +9,7 @@ import pytest
 
 import taskgraph
 from taskgraph.util.schema import (
+    IndexSchema,
     Schema,
     optionally_keyed_by,
     resolve_keyed_by,
@@ -241,6 +242,47 @@ class TestResolveKeyedBy(unittest.TestCase):
         )
 
 
+class TestNestedStructFieldsOptional(unittest.TestCase):
+    """Regression test: bare keys in nested voluptuous dict schemas were optional
+    by default. The msgspec migration must preserve this — nested struct fields
+    without defaults should not be required."""
+
+    def test_index_schema_accepts_partial_fields(self):
+        """IndexSchema should accept data with only 'type', omitting product/job-name."""
+
+        validate_schema(
+            IndexSchema,
+            {"type": "custom-index"},
+            "index schema",
+        )
+
+    def test_index_schema_accepts_all_fields(self):
+        """IndexSchema should still accept full data."""
+
+        validate_schema(
+            IndexSchema,
+            {
+                "type": "generic",
+                "product": "firefox",
+                "job-name": "build",
+                "rank": "by-tier",
+            },
+            "index schema",
+        )
+
+
+class TestValidateSchemaDictHandler(unittest.TestCase):
+    """validate_schema must accept plain dict schemas passed
+    by downstream payload builders without raising TypeError."""
+
+    def test_dict_schema_valid(self):
+        validate_schema({"name": str, "count": int}, {"name": "a", "count": 1}, "pfx")
+
+    def test_dict_schema_invalid(self):
+        with self.assertRaises(Exception):
+            validate_schema({"name": str}, {"name": 123}, "pfx")
+
+
 def test_optionally_keyed_by():
     typ = optionally_keyed_by("foo", str, use_msgspec=True)
     assert msgspec.convert("baz", typ) == "baz"

{taskcluster_taskgraph-19.1.0 → taskcluster_taskgraph-19.2.0}/uv.lock

@@ -2587,7 +2587,7 @@ wheels = [
 
 [[package]]
 name = "taskcluster-taskgraph"
-version = "19.1.0"
+version = "19.2.0"
 source = { editable = "." }
 dependencies = [
     { name = "appdirs" },