talks-reducer 0.3.0__tar.gz → 0.3.1__tar.gz

{talks_reducer-0.3.0/talks_reducer.egg-info → talks_reducer-0.3.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: talks-reducer
-Version: 0.3.0
+Version: 0.3.1
 Summary: CLI for speeding up long-form talks by removing silence
 Author: Talks Reducer Maintainers
 License-Expression: MIT
@@ -9,7 +9,7 @@ Description-Content-Type: text/markdown
 License-File: LICENSE
 Requires-Dist: audiotsm>=0.1.2
 Requires-Dist: scipy>=1.10.0
-Requires-Dist: numpy<2.0.0,>=1.22.0
+Requires-Dist: numpy>=1.22.0
 Requires-Dist: tqdm>=4.65.0
 Requires-Dist: tkinterdnd2>=0.3.0
 Requires-Dist: Pillow>=9.0.0
@@ -82,8 +82,9 @@ continues to work unchanged for local development.
   zone, hides the manual run controls and log, and automatically processes new
   files as soon as you drop them. Uncheck the box to return to the full layout
   with file pickers, the Run button, and detailed logging.
-- **Input drop zone** — drag files or folders from your desktop or add them via
-  the Explorer/Finder dialog; duplicates are ignored.
+- **Input drop zone** — drag files or folders from your desktop, click to open
+  the system file picker, or add them via the Explorer/Finder dialog; duplicates
+  are ignored.
 - **Small video** — toggles the `--small` preset used by the CLI.
 - **Open after convert** — controls whether the exported file is revealed in
   your system file manager as soon as each job finishes.

{talks_reducer-0.3.0 → talks_reducer-0.3.1}/README.md

@@ -57,8 +57,9 @@ continues to work unchanged for local development.
   zone, hides the manual run controls and log, and automatically processes new
   files as soon as you drop them. Uncheck the box to return to the full layout
   with file pickers, the Run button, and detailed logging.
-- **Input drop zone** — drag files or folders from your desktop or add them via
-  the Explorer/Finder dialog; duplicates are ignored.
+- **Input drop zone** — drag files or folders from your desktop, click to open
+  the system file picker, or add them via the Explorer/Finder dialog; duplicates
+  are ignored.
 - **Small video** — toggles the `--small` preset used by the CLI.
 - **Open after convert** — controls whether the exported file is revealed in
   your system file manager as soon as each job finishes.

{talks_reducer-0.3.0 → talks_reducer-0.3.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "talks-reducer"
-version = "0.3.0"
+version = "0.3.1"
 description = "CLI for speeding up long-form talks by removing silence"
 readme = "README.md"
 requires-python = ">=3.9"
@@ -15,7 +15,7 @@ authors = [
 dependencies = [
     "audiotsm>=0.1.2",
     "scipy>=1.10.0",
-    "numpy>=1.22.0,<2.0.0",
+    "numpy>=1.22.0",
     "tqdm>=4.65.0",
     "tkinterdnd2>=0.3.0",
     "Pillow>=9.0.0",

{talks_reducer-0.3.0 → talks_reducer-0.3.1}/talks_reducer/audio.py

@@ -11,6 +11,8 @@ import numpy as np
 from audiotsm import phasevocoder
 from audiotsm.io.array import ArrayReader, ArrayWriter
 
+from .ffmpeg import get_ffprobe_path
+
 
 def get_max_volume(samples: np.ndarray) -> float:
     """Return the maximum absolute volume in the provided sample array."""
@@ -21,8 +23,6 @@ def get_max_volume(samples: np.ndarray) -> float:
 def is_valid_input_file(filename: str) -> bool:
     """Check whether ``ffprobe`` recognises the input file and finds an audio stream."""
 
-    from .ffmpeg import get_ffprobe_path
-
     ffprobe_path = get_ffprobe_path()
     command = [
         ffprobe_path,
@@ -36,29 +36,31 @@ def is_valid_input_file(filename: str) -> bool:
         "-show_entries",
         "stream=codec_type",
     ]
-    
+
     # Hide console window on Windows
     creationflags = 0
     if sys.platform == "win32":
         # CREATE_NO_WINDOW = 0x08000000
         creationflags = 0x08000000
-    
-    process = subprocess.Popen(
-        command, 
-        stdout=subprocess.PIPE, 
-        stderr=subprocess.PIPE,
-        creationflags=creationflags
-    )
-    outs, errs = None, None
+
     try:
-        outs, errs = process.communicate(timeout=1)
+        result = subprocess.run(
+            command,
+            capture_output=True,
+            text=True,
+            timeout=5,
+            creationflags=creationflags,
+        )
     except subprocess.TimeoutExpired:
         print("Timeout while checking the input file. Aborting. Command:")
         print(" ".join(command))
-        process.kill()
-        outs, errs = process.communicate()
-    finally:
-        return len(errs) == 0 and len(outs) > 0
+        return False
+
+    if result.returncode != 0:
+        return False
+
+    stdout = result.stdout or ""
+    return "codec_type=audio" in stdout
 
 
 def process_audio_chunks(

{talks_reducer-0.3.0 → talks_reducer-0.3.1}/talks_reducer/gui.py

@@ -395,6 +395,10 @@ class TalksReducerGUI:
         input_frame.rowconfigure(1, weight=1)
         self._configure_drop_targets(self.drop_zone)
         self._configure_drop_targets(self.input_list)
+        self.drop_zone.configure(cursor="hand2", takefocus=1)
+        self.drop_zone.bind("<Button-1>", self._on_drop_zone_click)
+        self.drop_zone.bind("<Return>", self._on_drop_zone_click)
+        self.drop_zone.bind("<space>", self._on_drop_zone_click)
 
         self.add_files_button = self.ttk.Button(
             input_frame, text="Add files", command=self._add_files
@@ -420,23 +424,28 @@ class TalksReducerGUI:
         options.grid(row=2, column=0, pady=(16, 0), sticky="ew")
         options.columnconfigure(0, weight=1)
 
-        self.simple_mode_check = self.ttk.Checkbutton(
-            options,
-            text="Simple mode",
-            variable=self.simple_mode_var,
-            command=self._toggle_simple_mode,
-        )
-        self.simple_mode_check.grid(row=0, column=0, sticky="w")
+        checkbox_frame = self.ttk.Frame(options)
+        checkbox_frame.grid(row=0, column=0, columnspan=2, sticky="w")
 
-        self.ttk.Checkbutton(options, text="Small video", variable=self.small_var).grid(
-            row=1, column=0, sticky="w", pady=(8, 0)
-        )
+        self.ttk.Checkbutton(
+            checkbox_frame,
+            text="Small video",
+            variable=self.small_var,
+        ).grid(row=0, column=0, sticky="w")
 
         self.ttk.Checkbutton(
-            options,
+            checkbox_frame,
             text="Open after convert",
             variable=self.open_after_convert_var,
-        ).grid(row=2, column=0, sticky="w", pady=(8, 0))
+        ).grid(row=0, column=1, sticky="w", padx=(12, 0))
+
+        self.simple_mode_check = self.ttk.Checkbutton(
+            checkbox_frame,
+            text="Simple mode",
+            variable=self.simple_mode_var,
+            command=self._toggle_simple_mode,
+        )
+        self.simple_mode_check.grid(row=0, column=2, sticky="w", padx=(12, 0))
 
         self.advanced_visible = self.tk.BooleanVar(value=False)
         self.advanced_button = self.ttk.Button(
@@ -444,10 +453,10 @@ class TalksReducerGUI:
             text="Advanced",
             command=self._toggle_advanced,
         )
-        self.advanced_button.grid(row=0, column=1, sticky="e")
+        self.advanced_button.grid(row=1, column=1, sticky="e")
 
         self.advanced_frame = self.ttk.Frame(options, padding=self.PADDING)
-        self.advanced_frame.grid(row=3, column=0, columnspan=2, sticky="nsew")
+        self.advanced_frame.grid(row=2, column=0, columnspan=2, sticky="nsew")
         self.advanced_frame.columnconfigure(1, weight=1)
 
         self.output_var = self.tk.StringVar()
@@ -509,9 +518,10 @@ class TalksReducerGUI:
         status_frame.columnconfigure(1, weight=1)
         status_frame.columnconfigure(2, weight=0)
 
-        
         self.ttk.Label(status_frame, text="Status:").grid(row=0, column=0, sticky="w")
-        self.status_label = self.tk.Label(status_frame, textvariable=self.status_var, anchor="e")
+        self.status_label = self.tk.Label(
+            status_frame, textvariable=self.status_var, anchor="e"
+        )
         self.status_label.grid(row=0, column=1, sticky="e")
 
         # Progress bar
@@ -527,7 +537,9 @@ class TalksReducerGUI:
         self.stop_button = self.ttk.Button(
             status_frame, text="Stop", command=self._stop_processing
         )
-        self.stop_button.grid(row=2, column=0, columnspan=3, sticky="ew", pady=self.PADDING)
+        self.stop_button.grid(
+            row=2, column=0, columnspan=3, sticky="ew", pady=self.PADDING
+        )
         self.stop_button.grid_remove()  # Hidden by default
 
         self.open_button = self.ttk.Button(
@@ -536,7 +548,9 @@ class TalksReducerGUI:
             command=self._open_last_output,
             state=self.tk.DISABLED,
         )
-        self.open_button.grid(row=2, column=0, columnspan=3, sticky="ew", pady=self.PADDING)
+        self.open_button.grid(
+            row=2, column=0, columnspan=3, sticky="ew", pady=self.PADDING
+        )
         self.open_button.grid_remove()
 
         # Button shown when no other action buttons are visible
@@ -545,7 +559,9 @@ class TalksReducerGUI:
             text="Drop video to convert",
             state=self.tk.DISABLED,
         )
-        self.drop_hint_button.grid(row=2, column=0, columnspan=3, sticky="ew", pady=self.PADDING)
+        self.drop_hint_button.grid(
+            row=2, column=0, columnspan=3, sticky="ew", pady=self.PADDING
+        )
         self.drop_hint_button.grid_remove()  # Hidden by default
         self._configure_drop_targets(self.drop_hint_button)
 
@@ -607,11 +623,13 @@ class TalksReducerGUI:
             self.stop_button.grid_remove()
             self.advanced_button.grid_remove()
             self.advanced_frame.grid_remove()
-            if hasattr(self, 'status_frame'):
+            if hasattr(self, "status_frame"):
                 self.status_frame.grid_remove()
             self.run_after_drop_var.set(True)
             self._apply_window_size(simple=True)
-            if self.status_var.get().lower() == "success" and hasattr(self, 'status_frame'):
+            if self.status_var.get().lower() == "success" and hasattr(
+                self, "status_frame"
+            ):
                 self.status_frame.grid()
                 self.open_button.grid()
                 self.drop_hint_button.grid_remove()
@@ -619,7 +637,7 @@ class TalksReducerGUI:
             for widget in widgets:
                 widget.grid()
             self.log_frame.grid()
-            if hasattr(self, 'status_frame'):
+            if hasattr(self, "status_frame"):
                 self.status_frame.grid()
             self.advanced_button.grid()
             if self.advanced_visible.get():
@@ -841,14 +859,19 @@ class TalksReducerGUI:
         widget.dnd_bind("<<Drop>>", self._on_drop)  # type: ignore[attr-defined]
 
     # -------------------------------------------------------------- actions --
-    def _add_files(self) -> None:
-        files = self.filedialog.askopenfilenames(
+    def _ask_for_input_files(self) -> tuple[str, ...]:
+        """Prompt the user to select input files for processing."""
+
+        return self.filedialog.askopenfilenames(
             title="Select input files",
             filetypes=[
                 ("Video files", "*.mp4 *.mkv *.mov *.avi *.m4v"),
                 ("All", "*.*"),
             ],
         )
+
+    def _add_files(self) -> None:
+        files = self._ask_for_input_files()
         self._extend_inputs(files)
 
     def _add_directory(self) -> None:
@@ -888,6 +911,16 @@ class TalksReducerGUI:
         self.input_list.delete(0, self.tk.END)
         self._extend_inputs(cleaned, auto_run=True)
 
+    def _on_drop_zone_click(self, event: object) -> str | None:
+        """Open a file selection dialog when the drop zone is activated."""
+
+        files = self._ask_for_input_files()
+        if not files:
+            return "break"
+        self._clear_input_files()
+        self._extend_inputs(files, auto_run=True)
+        return "break"
+
     def _browse_path(
         self, variable, label: str
     ) -> None:  # type: (tk.StringVar, str) -> None
@@ -1012,9 +1045,11 @@ class TalksReducerGUI:
         """Hide Stop button."""
         self.stop_button.grid_remove()
         # Show drop hint when stop button is hidden and no other buttons are visible
-        if (not self.open_button.winfo_viewable() and 
-            hasattr(self, 'drop_hint_button') and
-            not self.drop_hint_button.winfo_viewable()):
+        if (
+            not self.open_button.winfo_viewable()
+            and hasattr(self, "drop_hint_button")
+            and not self.drop_hint_button.winfo_viewable()
+        ):
             self.drop_hint_button.grid()
 
     def _collect_arguments(self) -> dict[str, object]:
@@ -1168,13 +1203,13 @@ class TalksReducerGUI:
             if is_processing:
                 self._start_status_animation()
                 # Show stop button during processing
-                if hasattr(self, 'status_frame'):
+                if hasattr(self, "status_frame"):
                     self.status_frame.grid()
                 self.stop_button.grid()
                 self.drop_hint_button.grid_remove()
 
             if lowered == "success":
-                if self.simple_mode_var.get() and hasattr(self, 'status_frame'):
+                if self.simple_mode_var.get() and hasattr(self, "status_frame"):
                     self.status_frame.grid()
                     self.stop_button.grid_remove()
                 self.drop_hint_button.grid_remove()
@@ -1184,11 +1219,15 @@ class TalksReducerGUI:
             else:
                 self.open_button.grid_remove()
                 print("not success status")
-                if self.simple_mode_var.get() and not is_processing and hasattr(self, 'status_frame'):
+                if (
+                    self.simple_mode_var.get()
+                    and not is_processing
+                    and hasattr(self, "status_frame")
+                ):
                     self.status_frame.grid_remove()
                     self.stop_button.grid_remove()
                     # Show drop hint when no other buttons are visible
-                    if hasattr(self, 'drop_hint_button'):
+                    if hasattr(self, "drop_hint_button"):
                         self.drop_hint_button.grid()
 
         self.root.after(0, apply)
@@ -1219,11 +1258,11 @@ class TalksReducerGUI:
 
     def _calculate_gradient_color(self, percentage: int, darken: float = 1.0) -> str:
         """Calculate color gradient from red (0%) to green (100%).
-        
+
         Args:
             percentage: The position in the gradient (0-100)
             darken: Value between 0.0 (black) and 1.0 (original brightness)
-            
+
         Returns:
             Hex color code string
         """
@@ -1282,10 +1321,11 @@ class TalksReducerGUI:
 
             # Show stop button when progress < 100
             if percentage < 100:
-                if hasattr(self, 'status_frame'):
+                if hasattr(self, "status_frame"):
                     self.status_frame.grid()
                 self.stop_button.grid()
                 self.drop_hint_button.grid_remove()
+
         self.root.after(0, updater)
 
     def _set_progress_bar_style(self, status: str) -> None:

{talks_reducer-0.3.0 → talks_reducer-0.3.1/talks_reducer.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: talks-reducer
-Version: 0.3.0
+Version: 0.3.1
 Summary: CLI for speeding up long-form talks by removing silence
 Author: Talks Reducer Maintainers
 License-Expression: MIT
@@ -9,7 +9,7 @@ Description-Content-Type: text/markdown
 License-File: LICENSE
 Requires-Dist: audiotsm>=0.1.2
 Requires-Dist: scipy>=1.10.0
-Requires-Dist: numpy<2.0.0,>=1.22.0
+Requires-Dist: numpy>=1.22.0
 Requires-Dist: tqdm>=4.65.0
 Requires-Dist: tkinterdnd2>=0.3.0
 Requires-Dist: Pillow>=9.0.0
@@ -82,8 +82,9 @@ continues to work unchanged for local development.
   zone, hides the manual run controls and log, and automatically processes new
   files as soon as you drop them. Uncheck the box to return to the full layout
   with file pickers, the Run button, and detailed logging.
-- **Input drop zone** — drag files or folders from your desktop or add them via
-  the Explorer/Finder dialog; duplicates are ignored.
+- **Input drop zone** — drag files or folders from your desktop, click to open
+  the system file picker, or add them via the Explorer/Finder dialog; duplicates
+  are ignored.
 - **Small video** — toggles the `--small` preset used by the CLI.
 - **Open after convert** — controls whether the exported file is revealed in
   your system file manager as soon as each job finishes.

{talks_reducer-0.3.0 → talks_reducer-0.3.1}/talks_reducer.egg-info/SOURCES.txt

@@ -17,4 +17,5 @@ talks_reducer.egg-info/dependency_links.txt
 talks_reducer.egg-info/entry_points.txt
 talks_reducer.egg-info/requires.txt
 talks_reducer.egg-info/top_level.txt
+tests/test_audio.py
 tests/test_pipeline_service.py

{talks_reducer-0.3.0 → talks_reducer-0.3.1}/talks_reducer.egg-info/requires.txt

@@ -1,6 +1,6 @@
 audiotsm>=0.1.2
 scipy>=1.10.0
-numpy<2.0.0,>=1.22.0
+numpy>=1.22.0
 tqdm>=4.65.0
 tkinterdnd2>=0.3.0
 Pillow>=9.0.0

talks_reducer-0.3.1/tests/test_audio.py

@@ -0,0 +1,47 @@
+"""Tests for the audio helper utilities."""
+
+from __future__ import annotations
+
+import types
+
+from talks_reducer import audio
+
+
+def _make_completed_process(stdout: str = "", stderr: str = "", returncode: int = 0):
+    """Create a minimal object emulating :class:`subprocess.CompletedProcess`."""
+
+    completed = types.SimpleNamespace()
+    completed.stdout = stdout
+    completed.stderr = stderr
+    completed.returncode = returncode
+    return completed
+
+
+def test_is_valid_input_file_accepts_warnings(monkeypatch):
+    """A warning written to stderr should not invalidate a valid audio file."""
+
+    monkeypatch.setattr(audio, "get_ffprobe_path", lambda: "ffprobe")
+
+    def fake_run(*args, **kwargs):
+        return _make_completed_process(
+            stdout="[STREAM]\ncodec_type=audio\n[/STREAM]\n",
+            stderr="Configuration warning",
+            returncode=0,
+        )
+
+    monkeypatch.setattr(audio.subprocess, "run", fake_run)
+
+    assert audio.is_valid_input_file("example.mp4") is True
+
+
+def test_is_valid_input_file_requires_audio_stream(monkeypatch):
+    """Return ``False`` when ffprobe completes but finds no audio stream."""
+
+    monkeypatch.setattr(audio, "get_ffprobe_path", lambda: "ffprobe")
+
+    def fake_run(*args, **kwargs):
+        return _make_completed_process(stdout="", stderr="", returncode=0)
+
+    monkeypatch.setattr(audio.subprocess, "run", fake_run)
+
+    assert audio.is_valid_input_file("silent.mp4") is False