tab-cli 0.2.0__tar.gz → 0.2.1__tar.gz

{tab_cli-0.2.0 → tab_cli-0.2.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: tab-cli
-Version: 0.2.0
+Version: 0.2.1
 Summary: A CLI tool for tabular data
 Author-email: Tongfei Chen <tongfei@pm.me>
 License-File: LICENSE

{tab_cli-0.2.0 → tab_cli-0.2.1}/docs/cli-ref.md

@@ -100,5 +100,5 @@ Options:
 
 | Option                  | Description                                                                                                                  |
 |-------------------------|------------------------------------------------------------------------------------------------------------------------------|
-| `--az-url-authority-is-account` | Interpret az:// URL authority as storage account name instead of container name. See [azure.md](Azure) for more information. |
-| `--log-level`               | Log level from `{DEBUG, INFO, WARNING, ERROR, CRITICAL}`. If omitted, uses `log_level` from config.                         |
+| `--az-url-authority-is-account` | Interpret az:// URL authority as storage account name instead of container name. See [Cloud](cloud.md) for more information. |
+| `--log-level`               | Log level from `{DEBUG, INFO, WARNING, ERROR, CRITICAL}`. If omitted, uses `log_level` from config.                          |

tab_cli-0.2.1/docs/gen_assets.sh

@@ -0,0 +1,3 @@
+mkdir -p docs/assets
+uv run tab --log-level error view tests/assets/test.csv --table-svg 2> docs/assets/test.svg
+uv run tab --log-level error view --sql 'SELECT * FROM t WHERE Metric_A_Value > 80' tests/assets/test.csv --table-svg 2> docs/assets/test-where.svg

{tab_cli-0.2.0 → tab_cli-0.2.1}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "tab-cli"
-version = "0.2.0"
+version = "0.2.1"
 description = "A CLI tool for tabular data"
 authors = [{name = "Tongfei Chen", email = "tongfei@pm.me"}]
 readme = "README.md"

{tab_cli-0.2.0 → tab_cli-0.2.1}/src/tab_cli/cli.py

@@ -80,6 +80,28 @@ app = typer.Typer(
 )
 
 DEFAULT_VIEW_TRUNCATION_PROBE_ROWS = 1
+VALID_LOG_LEVELS = {"DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"}
+
+
+def _normalize_log_level(log_level: str) -> str:
+    normalized = log_level.upper()
+    if normalized not in VALID_LOG_LEVELS:
+        valid_levels = ", ".join(sorted(VALID_LOG_LEVELS))
+        raise typer.BadParameter(f"Invalid log level '{log_level}'. Expected one of: {valid_levels}")
+    return normalized
+
+
+def _configure_logger(level: str) -> None:
+    logger.remove()
+    logger.add(
+        RichHandler(
+            rich_tracebacks=True,
+            tracebacks_show_locals=True,
+            markup=True,
+        ),
+        format="{message}",
+        level=level,
+    )
 
 
 @app.callback()
@@ -100,23 +122,21 @@ def main_callback(
     ] = None,
 ) -> None:
     """Global options for tab_cli CLI."""
-    load_config_file()
-    effective_log_level = (
-        log_level.upper() if log_level is not None else config.config.log_level.upper()
-    )
     logger.remove()
-    logger.add(
-        RichHandler(
-            rich_tracebacks=True,
-            tracebacks_show_locals=True,
-            markup=True,
-        ),
-        format="{message}",
-        level=effective_log_level,
+    loaded_config = load_config_file()
+    effective_config = loaded_config
+
+    effective_config.log_level = (
+        _normalize_log_level(log_level)
+        if log_level is not None
+        else _normalize_log_level(effective_config.log_level)
     )
-    # CLI flags override config file values
+
     if az_url_authority_is_account:
-        config.config.az_url_authority_is_account = az_url_authority_is_account
+        effective_config.az_url_authority_is_account = az_url_authority_is_account
+
+    config.config = effective_config
+    _configure_logger(config.config.log_level)
 
 
 def _apply_sql(lf: pl.LazyFrame, sql: str | None) -> pl.LazyFrame:

{tab_cli-0.2.0 → tab_cli-0.2.1}/src/tab_cli/config.py

@@ -37,15 +37,16 @@ def _matches_type(value: Any, expected_type: Any) -> bool:
     return type(value) is expected_type
 
 
-def load_config_file(path: Path = CONFIG_FILE) -> None:
-    """Load settings from a JSON config file into the global config.
+def load_config_file(path: Path = CONFIG_FILE) -> Config:
+    """Load settings from a JSON config file into a fresh Config object.
 
     Unknown keys are logged and ignored. Type mismatches raise ValueError.
-    If the file does not exist, this is a no-op.
+    If the file does not exist, return built-in defaults.
     """
+    loaded_config = Config()
     if not path.is_file():
         logger.debug(f"No config file found at {path}; using built-in defaults")
-        return
+        return loaded_config
 
     text = path.read_text(encoding="utf-8")
     data = json.loads(text)
@@ -65,5 +66,6 @@ def load_config_file(path: Path = CONFIG_FILE) -> None:
             raise ValueError(
                 f"Config key '{key}' must be of type {expected_name}, got {type(value).__name__}"
             )
-        setattr(config, key, value)
+        setattr(loaded_config, key, value)
     logger.debug(f"Loaded config from {path}")
+    return loaded_config

{tab_cli-0.2.0 → tab_cli-0.2.1}/tests/test_config.py

@@ -13,13 +13,13 @@ class TestConfigFile:
         config_module.config = Config()
 
     def test_load_missing_file(self, tmp_path):
-        load_config_file(tmp_path / "nonexistent.json")
-        assert config_module.config.az_url_authority_is_account is False
-        assert config_module.config.default_num_view_rows == 20
-        assert config_module.config.log_level == "INFO"
-        assert config_module.config.max_cell_length is None
-        assert config_module.config.num_remote_workers == 8
-        assert config_module.config.sampling_size_for_schema_inference == 32
+        loaded = load_config_file(tmp_path / "nonexistent.json")
+        assert loaded.az_url_authority_is_account is False
+        assert loaded.default_num_view_rows == 20
+        assert loaded.log_level == "INFO"
+        assert loaded.max_cell_length is None
+        assert loaded.num_remote_workers == 8
+        assert loaded.sampling_size_for_schema_inference == 32
 
     def test_load_valid_config(self, tmp_path):
         cfg = tmp_path / "config.json"
@@ -35,13 +35,13 @@ class TestConfigFile:
                 }
             )
         )
-        load_config_file(cfg)
-        assert config_module.config.az_url_authority_is_account is True
-        assert config_module.config.default_num_view_rows == 10
-        assert config_module.config.log_level == "DEBUG"
-        assert config_module.config.max_cell_length == 12
-        assert config_module.config.num_remote_workers == 2
-        assert config_module.config.sampling_size_for_schema_inference == 64
+        loaded = load_config_file(cfg)
+        assert loaded.az_url_authority_is_account is True
+        assert loaded.default_num_view_rows == 10
+        assert loaded.log_level == "DEBUG"
+        assert loaded.max_cell_length == 12
+        assert loaded.num_remote_workers == 2
+        assert loaded.sampling_size_for_schema_inference == 64
 
     def test_load_partial_config(self, tmp_path):
         cfg = tmp_path / "config.json"
@@ -53,13 +53,13 @@ class TestConfigFile:
                 }
             )
         )
-        load_config_file(cfg)
-        assert config_module.config.az_url_authority_is_account is False
-        assert config_module.config.default_num_view_rows == 20
-        assert config_module.config.log_level == "INFO"
-        assert config_module.config.max_cell_length is None
-        assert config_module.config.num_remote_workers == 8
-        assert config_module.config.sampling_size_for_schema_inference == 128
+        loaded = load_config_file(cfg)
+        assert loaded.az_url_authority_is_account is False
+        assert loaded.default_num_view_rows == 20
+        assert loaded.log_level == "INFO"
+        assert loaded.max_cell_length is None
+        assert loaded.num_remote_workers == 8
+        assert loaded.sampling_size_for_schema_inference == 128
 
     def test_unknown_keys_ignored(self, tmp_path):
         cfg = tmp_path / "config.json"
@@ -68,9 +68,9 @@ class TestConfigFile:
                 {"unknown_key": "value", "sampling_size_for_schema_inference": 16}
             )
         )
-        load_config_file(cfg)
-        assert config_module.config.sampling_size_for_schema_inference == 16
-        assert not hasattr(config_module.config, "unknown_key")
+        loaded = load_config_file(cfg)
+        assert loaded.sampling_size_for_schema_inference == 16
+        assert not hasattr(loaded, "unknown_key")
 
     def test_invalid_json_raises(self, tmp_path):
         cfg = tmp_path / "config.json"
@@ -91,6 +91,38 @@ class TestConfigFile:
         except ValueError as exc:
             assert "num_remote_workers" in str(exc)
 
+    def test_invalid_log_level_in_config_is_rejected_by_cli(self, tmp_path):
+        cfg = tmp_path / "config.json"
+        cfg.write_text(json.dumps({"log_level": "NOPE"}))
+
+        with patch(
+            "tab_cli.cli.load_config_file", side_effect=lambda: load_config_file(cfg)
+        ):
+            result = runner.invoke(app, ["view", TEST_CSV])
+
+        assert result.exit_code != 0
+        assert "Invalid value" in result.output
+        assert "Invalid log level 'NOPE'" in result.output
+
+    def test_invalid_cli_log_level_has_friendly_error(self):
+        result = runner.invoke(app, ["--log-level", "NOPE", "view", TEST_CSV])
+
+        assert result.exit_code != 0
+        assert "Invalid value" in result.output
+        assert "Invalid log level 'NOPE'" in result.output
+
+    def test_missing_config_does_not_emit_debug_log_when_cli_log_level_is_error(self, tmp_path):
+        missing_cfg = tmp_path / "missing.json"
+
+        with patch(
+            "tab_cli.cli.load_config_file",
+            side_effect=lambda: load_config_file(missing_cfg),
+        ):
+            result = runner.invoke(app, ["--log-level", "ERROR", "view", TEST_CSV])
+
+        assert result.exit_code == 0
+        assert "No config file found" not in result.output
+
     def test_view_uses_default_max_cell_length_from_config(self, tmp_path):
         cfg = tmp_path / "config.json"
         cfg.write_text(json.dumps({"max_cell_length": 5}))
@@ -179,5 +211,5 @@ class TestConfigFile:
     def test_config_file_sets_num_remote_workers(self, tmp_path):
         cfg = tmp_path / "config.json"
         cfg.write_text(json.dumps({"num_remote_workers": 3}))
-        load_config_file(cfg)
-        assert config_module.config.num_remote_workers == 3
+        loaded = load_config_file(cfg)
+        assert loaded.num_remote_workers == 3

tab_cli-0.2.0/docs/gen_assets.sh

@@ -1,3 +0,0 @@
-mkdir -p docs/assets
-uv run tab view tests/assets/test.csv --table-svg 2> docs/assets/test.svg
-uv run tab view --sql 'SELECT * FROM t WHERE Metric_A_Value > 80' tests/assets/test.csv --table-svg 2> docs/assets/test-where.svg