synodic-client 0.0.1.dev57__tar.gz → 0.0.1.dev62__tar.gz

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: synodic_client
-Version: 0.0.1.dev57
+Version: 0.0.1.dev62
 Author-Email: Synodic Software <contact@synodic.software>
 License: LGPL-3.0-or-later
 Project-URL: homepage, https://github.com/synodic/synodic-client

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/pyproject.toml

@@ -15,7 +15,7 @@ dependencies = [
     "velopack>=0.0.1444.dev49733",
     "typer>=0.24.1",
 ]
-version = "0.0.1.dev57"
+version = "0.0.1.dev62"
 
 [project.license]
 text = "LGPL-3.0-or-later"

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/synodic_client/application/init.py

@@ -53,12 +53,16 @@ def run_startup_preamble(exe_path: str | None = None) -> None:
     # Seed user config from the build config (one-time propagation).
     seed_user_config_from_build()
 
-    register_protocol(exe_path)
+    frozen = getattr(sys, 'frozen', False)
+
+    if frozen:
+        register_protocol(exe_path)
 
     config = resolve_config()
-    if config.auto_start:
-        register_startup(exe_path)
-    else:
-        remove_startup()
+    if frozen:
+        if config.auto_start:
+            register_startup(exe_path)
+        else:
+            remove_startup()
 
-    logger.info('Startup preamble complete (auto_start=%s)', config.auto_start)
+    logger.info('Startup preamble complete (auto_start=%s, frozen=%s)', config.auto_start, frozen)

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/synodic_client/application/screen/screen.py

@@ -315,11 +315,10 @@ class ToolsView(QWidget):
             pkg_tasks: dict[str, asyncio.Task] = {}
             for plugin in updatable_plugins:
                 if plugin.name in runtime_probed:
-                    # Only gather venv/project packages (skip global)
-                    if directories:
-                        pkg_tasks[plugin.name] = tg.create_task(
-                            self._gather_packages(plugin.name, directories, skip_global=True),
-                        )
+                    # Runtime-probed plugins show only per-runtime
+                    # packages; venv/project packages belong in
+                    # ProjectsView and are intentionally skipped here.
+                    continue
                 else:
                     pkg_tasks[plugin.name] = tg.create_task(
                         self._gather_packages(
@@ -390,10 +389,6 @@ class ToolsView(QWidget):
             for plugin in kind_buckets[kind]:
                 if plugin.name in data.runtime_packages:
                     self._build_runtime_sections(plugin, data, auto_update_map)
-                    # Also emit venv packages (if any) as a separate
-                    # provider header without a runtime tag.
-                    if data.packages_map.get(plugin.name):
-                        self._build_plugin_section(plugin, data, auto_update_map)
                 else:
                     self._build_plugin_section(plugin, data, auto_update_map)
 

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/synodic_client/application/screen/settings.py

@@ -120,6 +120,7 @@ class SettingsWindow(QMainWindow):
 
         scroll.setWidget(container)
         self.setCentralWidget(scroll)
+        self._scroll_content = container
 
     def _build_updates_section(self) -> CardFrame:
         """Construct the *Updates* settings card."""
@@ -221,6 +222,9 @@ class SettingsWindow(QMainWindow):
         card = CardFrame('Startup')
         self._auto_start_check = QCheckBox('Start with Windows')
         self._auto_start_check.toggled.connect(self._on_auto_start_changed)
+        if not getattr(sys, 'frozen', False):
+            self._auto_start_check.setEnabled(False)
+            self._auto_start_check.setToolTip('Auto-start is only available for installed builds')
         card.content_layout.addWidget(self._auto_start_check)
         return card
 
@@ -301,6 +305,15 @@ class SettingsWindow(QMainWindow):
         """Re-enable the *Check for Updates* button after a check completes."""
         self._check_updates_btn.setEnabled(True)
 
+    def update_config(self, config: ResolvedConfig) -> None:
+        """Replace the internal config snapshot without emitting signals.
+
+        Called by controllers that persist timestamps so that the next
+        :meth:`sync_from_config` sees fresh data instead of the stale
+        snapshot captured at construction time.
+        """
+        self._config = config
+
     def set_last_checked(self, timestamp: str) -> None:
         """Update the *last updated* label from an ISO 8601 timestamp."""
         relative = _format_relative_time(timestamp)
@@ -314,8 +327,14 @@ class SettingsWindow(QMainWindow):
     def show(self) -> None:
         """Sync controls from config, size to content, then show the window."""
         self.sync_from_config()
-        # Let the layout determine the ideal size, clamped to the minimum.
-        self.adjustSize()
+        # QScrollArea doesn't propagate its content's sizeHint, so
+        # adjustSize() only reaches the minimum.  Compute the ideal
+        # height from the content widget directly.
+        content_hint = self._scroll_content.sizeHint()
+        margins = self._scroll_content.layout().contentsMargins()
+        ideal_w = max(content_hint.width() + margins.left() + margins.right(), self.minimumWidth())
+        ideal_h = max(content_hint.height() + margins.top() + margins.bottom(), self.minimumHeight())
+        self.resize(ideal_w, ideal_h)
         super().show()
         self.raise_()
         self.activateWindow()
@@ -388,10 +407,11 @@ class SettingsWindow(QMainWindow):
 
     def _on_auto_start_changed(self, checked: bool) -> None:
         self._config = update_user_config(auto_start=checked)
-        if checked:
-            register_startup(sys.executable)
-        else:
-            remove_startup()
+        if getattr(sys, 'frozen', False):
+            if checked:
+                register_startup(sys.executable)
+            else:
+                remove_startup()
         self.settings_changed.emit(self._config)
 
     def _on_debug_logging_changed(self, checked: bool) -> None:

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/synodic_client/application/screen/spinner.py

@@ -128,6 +128,7 @@ class SpinnerWidget(QWidget):
         # Auto-overlay: track parent geometry via event filter
         if parent is not None:
             self.setAutoFillBackground(True)
+            self.setStyleSheet('background: palette(window);')
             self.setSizePolicy(QSizePolicy.Policy.Expanding, QSizePolicy.Policy.Expanding)
             parent.installEventFilter(self)
             self.setGeometry(parent.rect())

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/synodic_client/application/screen/tool_update_controller.py

@@ -382,7 +382,12 @@ class ToolUpdateOrchestrator:
             for pkg_name in result.updated_packages:
                 key = f'{plugin_name}/{pkg_name}' if plugin_name else pkg_name
                 existing[key] = now
-            update_user_config(last_tool_updates=existing)
+            resolved = update_user_config(last_tool_updates=existing)
+            # Refresh the config on the tools view so the next rebuild
+            # picks up the updated timestamps instead of stale data.
+            tools_view_ref = self._window.tools_view
+            if tools_view_ref is not None:
+                tools_view_ref._config = resolved
 
         # Clear updating state on widgets
         tools_view = self._window.tools_view

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/synodic_client/application/update_controller.py

@@ -132,7 +132,8 @@ class UpdateController:
     def _persist_check_timestamp(self) -> None:
         """Persist the current time as *last_client_update* and refresh the label."""
         ts = datetime.now(UTC).isoformat()
-        update_user_config(last_client_update=ts)
+        resolved = update_user_config(last_client_update=ts)
+        self._settings_window.update_config(resolved)
         self._settings_window.set_last_checked(ts)
 
     def _report_error(self, message: str, *, silent: bool) -> None:
@@ -329,7 +330,9 @@ class UpdateController:
 
         # Persist the client-update timestamp (actual update downloaded)
         ts = datetime.now(UTC).isoformat()
-        update_user_config(last_client_update=ts)
+        resolved = update_user_config(last_client_update=ts)
+        self._settings_window.update_config(resolved)
+        self._settings_window.set_last_checked(ts)
 
         self._pending_version = version
 

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/synodic_client/logging.py

@@ -6,15 +6,14 @@ log-level switching via :func:`set_debug_level`.
 
 import logging
 import sys
-import tempfile
 from logging.handlers import RotatingFileHandler
 from pathlib import Path
 
-from synodic_client.config import is_dev_mode
+from synodic_client.config import config_dir, is_dev_mode
 
 _LOG_FILENAME = 'synodic.log'
 _LOG_FILENAME_DEV = 'synodic-dev.log'
-_MAX_BYTES = 5_242_880  # 5 MB
+_MAX_BYTES = 1_048_576  # 1 MB
 _BACKUP_COUNT = 3
 _FORMAT = '%(asctime)s [%(levelname)s] %(name)s: %(message)s'
 
@@ -24,13 +23,13 @@ _debug_active: bool = False
 def log_path() -> Path:
     """Return the path to the application log file.
 
-    The file lives in the system temp directory so it is cleaned up
-    automatically by the OS and avoids permission issues.
+    The file lives under ``config_dir() / 'logs'`` so that agents and
+    developers can find it at a deterministic, well-known location.
 
     Returns:
         Path to the log file.
     """
-    return Path(tempfile.gettempdir()) / (_LOG_FILENAME_DEV if is_dev_mode() else _LOG_FILENAME)
+    return config_dir() / 'logs' / (_LOG_FILENAME_DEV if is_dev_mode() else _LOG_FILENAME)
 
 
 class EagerRotatingFileHandler(RotatingFileHandler):
@@ -68,6 +67,8 @@ def configure_logging(*, debug: bool = False) -> None:
 
     logging.basicConfig(level=logging.INFO)
 
+    log_path().parent.mkdir(parents=True, exist_ok=True)
+
     handler = EagerRotatingFileHandler(
         str(log_path()),
         maxBytes=_MAX_BYTES,

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/tests/unit/qt/test_gather_packages.py

@@ -922,7 +922,6 @@ class TestRuntimePluginSupport:
 
 # Expected widget counts (avoids PLR2004)
 _EXPECTED_RUNTIME_PROVIDERS = 2
-_EXPECTED_RUNTIME_PROVIDERS_WITH_VENV = 3
 _EXPECTED_DEFAULT_RT_PACKAGES = 2
 _EXPECTED_NON_DEFAULT_RT_PACKAGES = 1
 
@@ -1050,8 +1049,8 @@ class TestPerRuntimeDisplay:
         assert len(non_default_rows) == _EXPECTED_NON_DEFAULT_RT_PACKAGES
         assert non_default_rows[0]._package_name == 'django'
 
-    def test_venv_packages_separate_from_runtime(self) -> None:
-        """Venv packages appear in a separate section without runtime tag."""
+    def test_venv_packages_excluded_for_runtime_probed_plugin(self) -> None:
+        """Venv packages must not appear in ToolsView for runtime-probed plugins."""
         view = ToolsView(_make_porringer(), _make_config())
         default_exe = Path('C:/Python314/python.exe')
         plugin = self._pip_plugin()
@@ -1078,13 +1077,8 @@ class TestPerRuntimeDisplay:
         view._build_widget_tree(data)
 
         providers = [w for w in view._section_widgets if isinstance(w, PluginProviderHeader)]
-        # 2 runtime providers + 1 venv provider = 3
-        assert len(providers) == _EXPECTED_RUNTIME_PROVIDERS_WITH_VENV
-
-        # The last provider should NOT have a runtime tag
-        last_provider = providers[-1]
-        runtime_tags = [w for w in last_provider.findChildren(QLabel) if 'Python' in w.text()]
-        assert len(runtime_tags) == 0, 'Venv provider should not have a runtime tag'
+        # Only the 2 runtime providers — no extra venv provider
+        assert len(providers) == _EXPECTED_RUNTIME_PROVIDERS
 
     def test_runtime_tag_uses_default_style(self) -> None:
         """The default runtime tag uses the green highlight style."""

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/tests/unit/qt/test_logging.py

@@ -2,12 +2,11 @@
 
 import logging
 import sys
-import tempfile
 from pathlib import Path
 from unittest.mock import patch
 
 from synodic_client.application.screen.settings import SettingsWindow
-from synodic_client.config import set_dev_mode
+from synodic_client.config import config_dir, set_dev_mode
 from synodic_client.logging import (
     EagerRotatingFileHandler,
     configure_logging,
@@ -19,10 +18,10 @@ class TestLogPath:
     """Tests for log_path()."""
 
     @staticmethod
-    def test_returns_path_in_temp_dir() -> None:
-        """log_path() should resolve inside the system temp directory."""
+    def test_returns_path_in_config_logs_dir() -> None:
+        """log_path() should resolve inside config_dir() / 'logs'."""
         path = log_path()
-        assert path.parent == Path(tempfile.gettempdir())
+        assert path.parent == config_dir() / 'logs'
 
     @staticmethod
     def test_filename() -> None:

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/tests/unit/qt/test_settings.py

@@ -272,8 +272,8 @@ class TestSettingsCallbacks:
         signal_spy.assert_called_once_with(new_config)
 
     @staticmethod
-    def test_auto_start_registers_startup() -> None:
-        """Enabling auto-start calls register_startup."""
+    def test_auto_start_registers_startup_when_frozen() -> None:
+        """Enabling auto-start calls register_startup in frozen builds."""
         config = _make_config()
         window = _make_window(config)
 
@@ -282,14 +282,15 @@ class TestSettingsCallbacks:
             patch('synodic_client.application.screen.settings.update_user_config', return_value=new_config),
             patch('synodic_client.application.screen.settings.register_startup') as mock_register,
             patch('synodic_client.application.screen.settings.is_startup_registered', return_value=False),
+            patch('synodic_client.application.screen.settings.getattr', return_value=True),
         ):
             window._auto_start_check.setChecked(True)
 
         mock_register.assert_called_once()
 
     @staticmethod
-    def test_auto_start_removes_startup() -> None:
-        """Disabling auto-start calls remove_startup."""
+    def test_auto_start_removes_startup_when_frozen() -> None:
+        """Disabling auto-start calls remove_startup in frozen builds."""
         config = _make_config(auto_start=True)
         window = _make_window(config)
         # Manually set initial state without triggering signals
@@ -301,11 +302,31 @@ class TestSettingsCallbacks:
         with (
             patch('synodic_client.application.screen.settings.update_user_config', return_value=new_config),
             patch('synodic_client.application.screen.settings.remove_startup') as mock_remove,
+            patch('synodic_client.application.screen.settings.getattr', return_value=True),
         ):
             window._auto_start_check.setChecked(False)
 
         mock_remove.assert_called_once()
 
+    @staticmethod
+    def test_auto_start_skips_registry_when_not_frozen() -> None:
+        """Auto-start toggle persists config but skips registry in non-frozen builds."""
+        config = _make_config()
+        window = _make_window(config)
+
+        new_config = _make_config(auto_start=True)
+        with (
+            patch('synodic_client.application.screen.settings.update_user_config', return_value=new_config),
+            patch('synodic_client.application.screen.settings.register_startup') as mock_register,
+            patch('synodic_client.application.screen.settings.remove_startup') as mock_remove,
+            patch('synodic_client.application.screen.settings.is_startup_registered', return_value=False),
+            patch('synodic_client.application.screen.settings.getattr', return_value=False),
+        ):
+            window._auto_start_check.setChecked(True)
+
+        mock_register.assert_not_called()
+        mock_remove.assert_not_called()
+
 
 # ---------------------------------------------------------------------------
 # sync_from_config does not emit signals
@@ -383,3 +404,46 @@ class TestCheckForUpdatesButton:
         window.set_checking()
         assert window._check_updates_btn.isEnabled() is False
         assert window._update_status_label.text() == 'Checking\u2026'
+
+
+# ---------------------------------------------------------------------------
+# update_config — silent config refresh
+# ---------------------------------------------------------------------------
+
+
+class TestUpdateConfig:
+    """Verify that update_config refreshes _config without emitting signals."""
+
+    @staticmethod
+    def test_update_config_replaces_internal_config() -> None:
+        """update_config should replace _config with the new snapshot."""
+        window = _make_window(_make_config(last_client_update=None))
+        new_config = _make_config(last_client_update='2026-03-09T12:00:00+00:00')
+
+        window.update_config(new_config)
+
+        assert window._config is new_config
+        assert window._config.last_client_update == '2026-03-09T12:00:00+00:00'
+
+    @staticmethod
+    def test_update_config_does_not_emit_settings_changed() -> None:
+        """update_config must NOT emit settings_changed to avoid circular reinit."""
+        window = _make_window()
+        signal_spy = MagicMock()
+        window.settings_changed.connect(signal_spy)
+
+        window.update_config(_make_config(update_channel='dev'))
+
+        signal_spy.assert_not_called()
+
+    @staticmethod
+    def test_sync_after_update_config_uses_new_timestamp() -> None:
+        """sync_from_config after update_config should display the refreshed timestamp."""
+        window = _make_window(_make_config(last_client_update=None))
+        assert window._last_client_update_label.text() == ''
+
+        new_config = _make_config(last_client_update='2026-03-09T12:00:00+00:00')
+        window.update_config(new_config)
+        window.sync_from_config()
+
+        assert 'Last updated:' in window._last_client_update_label.text()

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/tests/unit/qt/test_update_controller.py

@@ -414,3 +414,57 @@ class TestCheckError:
         ctrl._on_check_error('timeout', silent=True)
 
         assert banner.state.name == 'HIDDEN'
+
+
+# ---------------------------------------------------------------------------
+# Timestamp sync — _persist_check_timestamp updates config
+# ---------------------------------------------------------------------------
+
+
+class TestPersistCheckTimestamp:
+    """Verify _persist_check_timestamp syncs the settings config."""
+
+    @staticmethod
+    def test_persist_updates_settings_config() -> None:
+        """_persist_check_timestamp should call update_config on the settings window."""
+        ctrl, _app, _client, _banner, settings = _make_controller()
+
+        fake_resolved = _make_config(last_client_update='2026-03-09T00:00:00+00:00')
+        with patch(
+            'synodic_client.application.update_controller.update_user_config',
+            return_value=fake_resolved,
+        ):
+            ctrl._persist_check_timestamp()
+
+        settings.update_config.assert_called_once_with(fake_resolved)
+        settings.set_last_checked.assert_called_once()
+
+    @staticmethod
+    def test_on_check_finished_success_syncs_config() -> None:
+        """A successful check should persist timestamp AND sync settings config."""
+        ctrl, _app, _client, _banner, settings = _make_controller()
+        result = UpdateInfo(available=False, current_version=Version('1.0.0'))
+
+        fake_resolved = _make_config(last_client_update='2026-03-09T00:00:00+00:00')
+        with patch(
+            'synodic_client.application.update_controller.update_user_config',
+            return_value=fake_resolved,
+        ):
+            ctrl._on_check_finished(result, silent=True)
+
+        settings.update_config.assert_called_once_with(fake_resolved)
+
+    @staticmethod
+    def test_download_finished_syncs_config_and_label() -> None:
+        """_on_download_finished should sync config and update the label."""
+        ctrl, _app, _client, _banner, settings = _make_controller(auto_apply=False)
+
+        fake_resolved = _make_config(last_client_update='2026-03-09T00:00:00+00:00')
+        with patch(
+            'synodic_client.application.update_controller.update_user_config',
+            return_value=fake_resolved,
+        ):
+            ctrl._on_download_finished(True, '2.0.0')
+
+        settings.update_config.assert_called_once_with(fake_resolved)
+        settings.set_last_checked.assert_called_once()

{synodic_client-0.0.1.dev57 → synodic_client-0.0.1.dev62}/tests/unit/test_init.py

@@ -28,6 +28,7 @@ class TestRunStartupPreamble:
             patch(f'{_MODULE}.resolve_config') as mock_resolve,
             patch(f'{_MODULE}.register_startup'),
             patch(f'{_MODULE}.remove_startup'),
+            patch(f'{_MODULE}.getattr', return_value=True),
         ):
             mock_resolve.return_value = MagicMock(auto_start=True)
             run_startup_preamble(r'C:\app\synodic.exe')
@@ -38,13 +39,14 @@ class TestRunStartupPreamble:
 
     @staticmethod
     def test_registers_startup_when_auto_start_true() -> None:
-        """register_startup is called when auto_start is True."""
+        """register_startup is called when auto_start is True and frozen."""
         with (
             patch(f'{_MODULE}.seed_user_config_from_build'),
             patch(f'{_MODULE}.register_protocol'),
             patch(f'{_MODULE}.resolve_config') as mock_resolve,
             patch(f'{_MODULE}.register_startup') as mock_register,
             patch(f'{_MODULE}.remove_startup') as mock_remove,
+            patch(f'{_MODULE}.getattr', return_value=True),
         ):
             mock_resolve.return_value = MagicMock(auto_start=True)
             run_startup_preamble(r'C:\app\synodic.exe')
@@ -54,13 +56,14 @@ class TestRunStartupPreamble:
 
     @staticmethod
     def test_removes_startup_when_auto_start_false() -> None:
-        """remove_startup is called when auto_start is False."""
+        """remove_startup is called when auto_start is False and frozen."""
         with (
             patch(f'{_MODULE}.seed_user_config_from_build'),
             patch(f'{_MODULE}.register_protocol'),
             patch(f'{_MODULE}.resolve_config') as mock_resolve,
             patch(f'{_MODULE}.register_startup') as mock_register,
             patch(f'{_MODULE}.remove_startup') as mock_remove,
+            patch(f'{_MODULE}.getattr', return_value=True),
         ):
             mock_resolve.return_value = MagicMock(auto_start=False)
             run_startup_preamble(r'C:\app\synodic.exe')
@@ -78,6 +81,7 @@ class TestRunStartupPreamble:
             patch(f'{_MODULE}.register_startup') as mock_register,
             patch(f'{_MODULE}.remove_startup'),
             patch(f'{_MODULE}.sys') as mock_sys,
+            patch(f'{_MODULE}.getattr', return_value=True),
         ):
             mock_sys.executable = r'C:\Python\python.exe'
             mock_resolve.return_value = MagicMock(auto_start=True)
@@ -86,6 +90,24 @@ class TestRunStartupPreamble:
         mock_proto.assert_called_once_with(r'C:\Python\python.exe')
         mock_register.assert_called_once_with(r'C:\Python\python.exe')
 
+    @staticmethod
+    def test_skips_registry_when_not_frozen() -> None:
+        """Protocol and startup registration are skipped in non-frozen builds."""
+        with (
+            patch(f'{_MODULE}.seed_user_config_from_build'),
+            patch(f'{_MODULE}.register_protocol') as mock_proto,
+            patch(f'{_MODULE}.resolve_config') as mock_resolve,
+            patch(f'{_MODULE}.register_startup') as mock_register,
+            patch(f'{_MODULE}.remove_startup') as mock_remove,
+            patch(f'{_MODULE}.getattr', return_value=False),
+        ):
+            mock_resolve.return_value = MagicMock(auto_start=True)
+            run_startup_preamble(r'C:\Python\python.exe')
+
+        mock_proto.assert_not_called()
+        mock_register.assert_not_called()
+        mock_remove.assert_not_called()
+
     @staticmethod
     def test_idempotent_on_second_call() -> None:
         """A second call is a no-op; the preamble runs only once."""