synapse-cli-agent 0.1.33__tar.gz → 0.1.34__tar.gz

{synapse_cli_agent-0.1.33 → synapse_cli_agent-0.1.34}/CHANGELOG.md

@@ -8,6 +8,20 @@ All entries are written in English.
 
 ---
 
+## v0.1.34
+
+### Bug Fixes
+
+- Fixed clipboard image paste on Linux/WSLg: WSLg syncs Windows screenshots as `image/bmp`, so the Linux reader now tries `image/png`, `image/bmp`, and `image/jpeg` and normalizes non-PNG data to PNG.
+- Fixed pasted image bytes being rendered as a text placeholder (`[BP... chars]`) instead of an image attachment by detecting mangled image signatures with binary noise and falling back to a clipboard image re-read.
+- Fixed multi-line and long Shift+Insert pastes being truncated to the first line; full content is preserved and expanded on submit.
+
+### Engineering
+
+- Added clipboard unit tests for BMP normalization, explicit text MIME requests, and mangled-prefix detection.
+
+---
+
 ## v0.1.33
 
 ### New Features

{synapse_cli_agent-0.1.33 → synapse_cli_agent-0.1.34}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: synapse-cli-agent
-Version: 0.1.33
+Version: 0.1.34
 Summary: Local coding agent built on LangChain Deep Agents (LocalShell, no sandbox)
 Project-URL: Homepage, https://github.com/alex8224/synapse-agent
 Project-URL: Repository, https://github.com/alex8224/synapse-agent

{synapse_cli_agent-0.1.33 → synapse_cli_agent-0.1.34}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "synapse-cli-agent"
-version = "0.1.33"
+version = "0.1.34"
 description = "Local coding agent built on LangChain Deep Agents (LocalShell, no sandbox)"
 readme = "README.md"
 license = { file = "LICENSE" }

synapse_cli_agent-0.1.34/release_body.md

@@ -0,0 +1,13 @@
+## v0.1.34
+
+### Bug Fixes
+
+- Fixed clipboard image paste on Linux/WSLg: WSLg syncs Windows screenshots as `image/bmp`, so the Linux reader now tries `image/png`, `image/bmp`, and `image/jpeg` and normalizes non-PNG data to PNG.
+- Fixed pasted image bytes being rendered as a text placeholder (`[BP... chars]`) instead of an image attachment by detecting mangled image signatures with binary noise and falling back to a clipboard image re-read.
+- Fixed multi-line and long Shift+Insert pastes being truncated to the first line; full content is preserved and expanded on submit.
+
+### Engineering
+
+- Added clipboard unit tests for BMP normalization, explicit text MIME requests, and mangled-prefix detection.
+
+---

{synapse_cli_agent-0.1.33 → synapse_cli_agent-0.1.34}/src/synapse/content/multimodal.py

@@ -433,6 +433,28 @@ class ClipboardResult:
     detail: str | None = None
 
 
+_IMAGE_MAGIC_PREFIXES = ("BM", "BP", "GIF8", "RIFF")
+
+
+def looks_like_image_data(text: str) -> bool:
+    """True when ``text`` looks like raw image bytes delivered as text.
+
+    Terminal-native paste of an image can deliver raw image bytes through the
+    text channel. Some terminal paths preserve BMP's ``BM`` signature while
+    others have been observed to expose it as ``BP``. Require substantial
+    binary noise as well as the signature to avoid treating ordinary text as
+    image data.
+    """
+    if not text:
+        return False
+    sample = text[:512]
+    head = sample[:8]
+    if not (head.startswith(_IMAGE_MAGIC_PREFIXES) or head.startswith("\ufffdPNG")):
+        return False
+    noisy = sum(1 for ch in sample if ch < " " or ch == "\ufffd")
+    return noisy >= max(8, len(sample) // 4)
+
+
 def read_clipboard() -> ClipboardResult:
     """Best-effort clipboard read: prefer image, else text.
 
@@ -485,7 +507,7 @@ def _read_clipboard_text() -> str | None:
             return out.decode("utf-8", errors="replace")
     # 3) Linux
     for cmd in (
-        ["wl-paste", "-n"],
+        ["wl-paste", "-n", "-t", "text/plain", "-t", "text/plain;charset=utf-8"],
         ["xclip", "-selection", "clipboard", "-o"],
         ["xsel", "--clipboard", "--output"],
     ):
@@ -669,16 +691,54 @@ def _mac_clipboard_image() -> tuple[bytes, str, str] | None:
 
 
 def _linux_clipboard_image() -> tuple[bytes, str, str] | None:
-    for cmd in (
-        ["wl-paste", "-t", "image/png"],
-        ["xclip", "-selection", "clipboard", "-t", "image/png", "-o"],
-    ):
-        out = _run_capture(cmd, timeout=5)
+    """Read a clipboard image on Linux/WSLg.
+
+    WSLg syncs Windows bitmap data as ``image/bmp`` (not ``image/png``), so
+    requesting only ``image/png`` misses screenshots pasted from Windows.
+    Common types are tried in order and normalized to PNG when Pillow is
+    available (otherwise the original bytes are kept under their real MIME).
+    """
+    for mime in ("image/png", "image/bmp", "image/jpeg"):
+        out = _run_capture(["wl-paste", "-t", mime], timeout=5)
         if out:
-            return out, "image/png", "clipboard.png"
+            data, mime_out = _normalize_image_bytes(out, mime)
+            return data, mime_out, "clipboard" + MIME_TO_EXT.get(mime_out, ".png")
+    for mime in ("image/png", "image/bmp"):
+        out = _run_capture(
+            ["xclip", "-selection", "clipboard", "-t", mime, "-o"], timeout=5
+        )
+        if out:
+            data, mime_out = _normalize_image_bytes(out, mime)
+            return data, mime_out, "clipboard" + MIME_TO_EXT.get(mime_out, ".png")
     return None
 
 
+def _normalize_image_bytes(data: bytes, mime: str) -> tuple[bytes, str]:
+    """Normalize clipboard image bytes, preferring PNG for model support.
+
+    PNG data with a valid signature is returned unchanged. Other formats
+    (BMP/JPEG, or mislabeled bytes) are re-encoded to PNG via Pillow when
+    available; without Pillow the original bytes and MIME are kept.
+    """
+    if mime == "image/png" and data[:8] == b"\x89PNG\r\n\x1a\n":
+        return data, mime
+    try:
+        from io import BytesIO
+
+        from PIL import Image  # type: ignore[import-not-found]
+    except Exception:  # noqa: BLE001
+        return data, mime
+    try:
+        im = Image.open(BytesIO(data))
+        if getattr(im, "mode", "") not in {"RGB", "RGBA"}:
+            im = im.convert("RGBA")
+        buf = BytesIO()
+        im.save(buf, format="PNG")
+        return buf.getvalue(), "image/png"
+    except Exception:  # noqa: BLE001
+        return data, mime
+
+
 def _run_capture(
     cmd: list[str],
     *,

{synapse_cli_agent-0.1.33 → synapse_cli_agent-0.1.34}/src/synapse/ui/prompt_controller.py

@@ -385,40 +385,76 @@ class PromptController:
             return
 
         if result.kind == "text":
-            text = result.text or ""
-            prompt = self._prompt_widget()
-            if len(text) > 200 or "\n" in text or "\r" in text:
-                prefix = text[:20].replace("\r", " ").replace("\n", " ").strip()
-                placeholder = f"[{prefix}... {len(text)} chars]"
-                self.state.paste_replacements[placeholder] = text
-                old = prompt.value or ""
-                prompt.value = old + placeholder
-                self._app.append_event(
-                    f"pasted text truncated: {len(text)} chars -> "
-                    "placeholder (content preserved)",
-                    "dim",
-                )
-            else:
-                old = prompt.value or ""
-                prompt.value = old + text
-            prompt.focus()
+            self.insert_pasted_text(result.text or "")
             return
 
         if result.kind == "image":
-            try:
-                att = self._image_bank.add_bytes(
-                    result.data, mime=result.mime, name=result.name
-                )
-            except Exception as exc:  # noqa: BLE001
-                self._app.append_event(f"image rejected: {exc}", "yellow")
-                return
+            self._attach_image(result)
+
+    def _attach_image(self, result: Any) -> None:
+        """Attach a clipboard image result to the prompt as ``[image#N]``."""
+        try:
+            att = self._image_bank.add_bytes(
+                result.data, mime=result.mime, name=result.name
+            )
+        except Exception as exc:  # noqa: BLE001
+            self._app.append_event(f"image rejected: {exc}", "yellow")
+            return
+        self._app.append_event(f"pasted {att.name} -> [image#{att.id}]", "dim")
+        prompt = self._prompt_widget()
+        old = prompt.value or ""
+        prompt.value = old + f" [image#{att.id}]"
+        prompt.focus()
+
+    def _paste_clipboard_image_only(self) -> None:
+        """Fallback for pasted image bytes: re-read the clipboard image.
+
+        Shift+Insert of an image may deliver raw image bytes as text; instead
+        of storing them as a text placeholder, re-read the clipboard and attach
+        the image when available.
+        """
+        from synapse.content.multimodal import read_clipboard
+
+        try:
+            result = read_clipboard()
+        except Exception:  # noqa: BLE001
+            self._app.append_event("clipboard read failed", "yellow")
+            return
+        if result.kind == "image":
+            self._attach_image(result)
+        else:
             self._app.append_event(
-                f"pasted {att.name} -> [image#{att.id}]", "dim"
+                "pasted content looks like image data but clipboard has no image",
+                "dim",
             )
-            prompt = self._prompt_widget()
+
+    def insert_pasted_text(self, text: str) -> None:
+        """Insert pasted text into the prompt.
+
+        Long or multi-line text is collapsed into a placeholder and stored in
+        ``state.paste_replacements``; the full content is expanded on submit.
+        """
+        from synapse.content.multimodal import looks_like_image_data
+
+        if looks_like_image_data(text):
+            self._paste_clipboard_image_only()
+            return
+        prompt = self._prompt_widget()
+        if len(text) > 200 or "\n" in text or "\r" in text:
+            prefix = text[:20].replace("\r", " ").replace("\n", " ").strip()
+            placeholder = f"[{prefix}... {len(text)} chars]"
+            self.state.paste_replacements[placeholder] = text
+            old = prompt.value or ""
+            prompt.value = old + placeholder
+            self._app.append_event(
+                f"pasted text truncated: {len(text)} chars -> "
+                "placeholder (content preserved)",
+                "dim",
+            )
+        else:
             old = prompt.value or ""
-            prompt.value = old + f" [image#{att.id}]"
-            prompt.focus()
+            prompt.value = old + text
+        prompt.focus()
 
     def expand_paste(self, text: str) -> tuple[str, str]:
         """Expand paste placeholders for submission.

{synapse_cli_agent-0.1.33 → synapse_cli_agent-0.1.34}/src/synapse/ui/tui.py

@@ -24,7 +24,7 @@ from textual import on, work
 from textual.app import App, ComposeResult
 from textual.binding import Binding
 from textual.containers import Vertical, VerticalScroll
-from textual.events import Click, Key, MouseMove, MouseUp
+from textual.events import Click, Key, MouseMove, MouseUp, Paste
 from textual.screen import ModalScreen
 from textual.widgets import Input, Static
 
@@ -178,6 +178,30 @@ def _git_branch(cwd: Path) -> str | None:
     """Backward-compatible branch name probe."""
     info = probe_git_branch_chrome(cwd)
     return info.name if info is not None else None
+class PromptInput(Input):
+    """Prompt input that routes terminal-native paste through the controller.
+
+    Shift+Insert / middle-click / right-click paste arrive as a bracketed-paste
+    ``Paste`` event. The stock ``Input`` keeps only the first line
+    (``event.text.splitlines()[0]``), which silently truncates multi-line
+    content; this subclass forwards the full text to the prompt controller so
+    long/multi-line pastes become ``[prefix... N chars]`` placeholders instead.
+    """
+
+    def __init__(self, on_paste_text: Any, **kwargs: Any) -> None:
+        super().__init__(**kwargs)
+        self._on_paste_text = on_paste_text
+
+    def _on_paste(self, event: Paste) -> None:
+        # prevent_default skips the parent Input._on_paste in the dispatch
+        # chain (named handlers are not deduplicated across the MRO), which
+        # would otherwise also insert the first line of the paste.
+        event.prevent_default()
+        event.stop()
+        if event.text:
+            self._on_paste_text(event.text)
+
+
 class CodingAgentApp(App[None]):
     """Cursor-like agent transcript."""
 
@@ -459,13 +483,14 @@ class CodingAgentApp(App[None]):
             yield Static("", id="status")
             yield Static("", id="complete-hint")
             yield ImagePreview(id="image-preview")
-            yield Input(
+            yield PromptInput(
                 placeholder=f"{_MARK_INPUT}  Build anything  (/ for commands, Tab complete)",
                 id="prompt",
                 suggester=make_textual_suggester(
                     self._prompt.complete_ctx,
                     workspace=self.project_root,
                 ),
+                on_paste_text=self._prompt.insert_pasted_text,
             )
             yield Static("", id="bottombar")
 

synapse_cli_agent-0.1.34/tests/test_clipboard.py

@@ -0,0 +1,94 @@
+"""Tests for clipboard reading helpers (multimodal).
+
+Focuses on Linux/WSLg clipboard image/text reads: WSLg syncs Windows bitmap
+data as ``image/bmp``, which the reader must accept and normalize to PNG.
+"""
+
+from __future__ import annotations
+
+from io import BytesIO
+
+from PIL import Image
+
+from synapse.content import multimodal
+
+
+def _make_bmp_bytes() -> bytes:
+    im = Image.new("RGB", (2, 2), (255, 0, 0))
+    buf = BytesIO()
+    im.save(buf, format="BMP")
+    return buf.getvalue()
+
+
+def test_normalize_image_bytes_png_passthrough() -> None:
+    png = b"\x89PNG\r\n\x1a\n" + b"\x00" * 32
+    data, mime = multimodal._normalize_image_bytes(png, "image/png")
+    assert data == png
+    assert mime == "image/png"
+
+
+def test_normalize_image_bytes_bmp_to_png() -> None:
+    bmp = _make_bmp_bytes()
+    data, mime = multimodal._normalize_image_bytes(bmp, "image/bmp")
+    assert mime == "image/png"
+    assert data[:8] == b"\x89PNG\r\n\x1a\n"
+
+
+def test_linux_clipboard_image_reads_bmp(monkeypatch) -> None:
+    bmp = _make_bmp_bytes()
+    seen: list[list[str]] = []
+
+    def fake_run(cmd, timeout=3.0):
+        seen.append(list(cmd))
+        if cmd[0] == "wl-paste" and cmd[2] == "image/bmp":
+            return bmp
+        return None
+
+    monkeypatch.setattr(multimodal, "_run_capture", fake_run)
+
+    result = multimodal._linux_clipboard_image()
+
+    assert result is not None
+    data, mime, name = result
+    assert mime == "image/png"
+    assert data[:8] == b"\x89PNG\r\n\x1a\n"
+    assert name == "clipboard.png"
+    assert any(c[2] == "image/bmp" for c in seen)
+
+
+def test_read_clipboard_text_linux_requests_explicit_text_type(monkeypatch) -> None:
+    seen: list[list[str]] = []
+
+    def fake_run(cmd, timeout=3.0):
+        seen.append(list(cmd))
+        if cmd[0] == "wl-paste":
+            return b"hello"
+        return None
+
+    monkeypatch.setattr(multimodal.os, "name", "posix")
+    monkeypatch.setattr(multimodal, "sys_platform", lambda: "linux")
+    monkeypatch.setattr(multimodal, "_run_capture", fake_run)
+
+    assert multimodal._read_clipboard_text() == "hello"
+    assert seen[0][0:3] == ["wl-paste", "-n", "-t"]
+    assert "text/plain" in seen[0]
+
+
+def test_looks_like_image_data_detects_bmp_bytes() -> None:
+    bmp = _make_bmp_bytes()
+    # Textual decodes terminal bytes lossily; non-ASCII bytes become U+FFFD.
+    text = bmp.decode("utf-8", errors="replace")
+    assert multimodal.looks_like_image_data(text) is True
+
+
+def test_looks_like_image_data_detects_terminal_mangled_bmp_prefix() -> None:
+    # Some terminal paste paths expose a BMP prefix as BP instead of BM.
+    text = "BP" + "\ufffd" * 250
+    assert multimodal.looks_like_image_data(text) is True
+
+
+def test_looks_like_image_data_rejects_normal_text() -> None:
+    assert multimodal.looks_like_image_data("BMW is a car brand") is False
+    assert multimodal.looks_like_image_data("BP is an energy company") is False
+    assert multimodal.looks_like_image_data("hello world") is False
+    assert multimodal.looks_like_image_data("") is False

{synapse_cli_agent-0.1.33 → synapse_cli_agent-0.1.34}/tests/test_prompt_controller.py

@@ -210,3 +210,54 @@ def test_paste_clipboard_stores_large_text_as_placeholder() -> None:
     assert "500 chars]" in app.prompt.value
     assert controller.state.paste_replacements[app.prompt.value.strip()] == big
     assert "pasted text truncated" in app.events[-1]
+
+
+def test_insert_pasted_text_multiline_becomes_placeholder() -> None:
+    controller, app = _make_controller()
+    body = "line one\nline two\nline three"
+
+    controller.insert_pasted_text(body)
+
+    assert app.prompt.value == "[line one line two li... 28 chars]"
+    assert controller.state.paste_replacements[app.prompt.value] == body
+    assert "pasted text truncated" in app.events[-1]
+
+
+def test_insert_pasted_text_short_appends_directly() -> None:
+    controller, app = _make_controller()
+    app.prompt.value = "prefix "
+
+    controller.insert_pasted_text("hello")
+
+    assert app.prompt.value == "prefix hello"
+    assert controller.state.paste_replacements == {}
+    assert app.prompt.focused is True
+
+
+def test_insert_pasted_text_image_bytes_falls_back_to_clipboard(monkeypatch) -> None:
+    controller, app = _make_controller()
+    called: list[bool] = []
+    monkeypatch.setattr(
+        controller, "_paste_clipboard_image_only", lambda: called.append(True)
+    )
+
+    # BMP magic prefix plus binary noise (as delivered by terminal paste).
+    controller.insert_pasted_text("BM" + "\ufffd" * 200)
+
+    assert called == [True]
+    assert app.prompt.value == ""
+    assert controller.state.paste_replacements == {}
+
+
+def test_insert_pasted_text_mangled_bmp_falls_back_to_clipboard(monkeypatch) -> None:
+    controller, app = _make_controller()
+    called: list[bool] = []
+    monkeypatch.setattr(
+        controller, "_paste_clipboard_image_only", lambda: called.append(True)
+    )
+
+    controller.insert_pasted_text("BP" + "\ufffd" * 250)
+
+    assert called == [True]
+    assert app.prompt.value == ""
+    assert controller.state.paste_replacements == {}

synapse_cli_agent-0.1.34/tests/test_tui_paste.py

@@ -0,0 +1,56 @@
+"""Tests for PromptInput terminal-native paste routing.
+
+Shift+Insert / middle-click paste arrives as a bracketed-paste ``Paste`` event.
+The stock ``Input`` keeps only the first line; ``PromptInput`` must forward the
+full text to the prompt controller, stop propagation, and prevent the parent
+``Input._on_paste`` from running (named handlers are not deduplicated across the
+MRO, so ``stop()`` alone is insufficient).
+"""
+
+from __future__ import annotations
+
+from textual.events import Paste
+
+from synapse.ui.tui import PromptInput
+
+
+def test_prompt_input_routes_full_multiline_paste() -> None:
+    received: list[str] = []
+    inp = PromptInput(on_paste_text=received.append)
+
+    event = Paste("alpha\nbeta\ngamma")
+    inp._on_paste(event)
+
+    assert event._stop_propagation is True
+    assert event._no_default_action is True
+    assert received == ["alpha\nbeta\ngamma"]
+
+
+def test_prompt_input_ignores_empty_paste() -> None:
+    received: list[str] = []
+    inp = PromptInput(on_paste_text=received.append)
+
+    event = Paste("")
+    inp._on_paste(event)
+
+    assert event._stop_propagation is True
+    assert event._no_default_action is True
+    assert received == []
+
+
+def test_prompt_input_prevents_parent_default_handler() -> None:
+    """The parent ``Input._on_paste`` must not run after our handler."""
+    received: list[str] = []
+    inp = PromptInput(on_paste_text=received.append)
+
+    event = Paste("line1\nline2")
+    methods = inp._get_dispatch_methods(Paste.handler_name, event)
+
+    first_cls, first_method = next(methods)
+    assert first_cls is PromptInput
+    first_method(event)
+
+    # prevent_default() inside our handler must stop the dispatch generator
+    # from yielding the inherited Input._on_paste.
+    assert list(methods) == []
+    assert received == ["line1\nline2"]

synapse_cli_agent-0.1.33/release_body.md

@@ -1,22 +0,0 @@
-## v0.1.33
-
-### New Features
-
-- Added per-subagent model and reasoning-effort configuration in the TUI, with layered configuration and display metadata for subagent tool calls.
-- Improved subagent activity rendering with live reasoning, tool-calling, and answering phases, including attribution for concurrent activity.
-
-### Bug Fixes
-
-- Fixed subagent tool-call inheritance and model selection behavior.
-- Enforced non-overridable file-tool path rules in subagent prompts.
-- Fixed TUI model and subagent picker keyboard interactions.
-- Fixed subagent sub-call display windows so recent calls remain visible as new calls arrive.
-- Fixed long-line Ruff violations in selectable-text and cancellation status rendering.
-
-### Engineering
-
-- Simplified subagent specifications and removed the obsolete DAG parallel-subagent runtime.
-- Improved TUI responsiveness by batching session replay and moving blocking work off the event loop.
-- Updated the bundled `synapse-core-tool` dependency metadata to v0.1.3.
-
----