squawk-cli 1.5.4__tar.gz → 1.5.5__tar.gz

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/Cargo.lock

@@ -1586,7 +1586,7 @@ checksum = "6e63cff320ae2c57904679ba7cb63280a3dc4613885beafb148ee7bf9aa9042d"
 
 [[package]]
 name = "squawk"
-version = "1.5.4"
+version = "1.5.5"
 dependencies = [
  "atty",
  "base64 0.12.3",

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: squawk-cli
-Version: 1.5.4
+Version: 1.5.5
 Classifier: License :: OSI Approved :: GNU General Public License v3 (GPLv3)
 Classifier: Operating System :: MacOS
 Classifier: Operating System :: Microsoft :: Windows

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/cli/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "squawk"
-version = "1.5.4"
+version = "1.5.5"
 authors = ["Steve Dignam <steve@dignam.xyz>"]
 edition = "2018"
 license = "GPL-3.0"

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/cli/src/config.rs

@@ -104,7 +104,7 @@ mod test_config {
     use super::*;
 
     #[test]
-    fn test_load_cfg_full() {
+    fn load_cfg_full() {
         let squawk_toml = NamedTempFile::new().expect("generate tempFile");
         let file = r#"
 pg_version = "19.1"
@@ -117,7 +117,7 @@ assume_in_transaction = true
         assert_debug_snapshot!(Config::parse(Some(squawk_toml.path().to_path_buf())));
     }
     #[test]
-    fn test_load_pg_version() {
+    fn load_pg_version() {
         let squawk_toml = NamedTempFile::new().expect("generate tempFile");
         let file = r#"
 pg_version = "19.1"
@@ -127,7 +127,7 @@ pg_version = "19.1"
         assert_debug_snapshot!(Config::parse(Some(squawk_toml.path().to_path_buf())));
     }
     #[test]
-    fn test_load_excluded_rules() {
+    fn load_excluded_rules() {
         let squawk_toml = NamedTempFile::new().expect("generate tempFile");
         let file = r#"
 excluded_rules = ["require-concurrent-index-creation"]
@@ -137,7 +137,7 @@ excluded_rules = ["require-concurrent-index-creation"]
         assert_debug_snapshot!(Config::parse(Some(squawk_toml.path().to_path_buf())));
     }
     #[test]
-    fn test_load_excluded_paths() {
+    fn load_excluded_paths() {
         let squawk_toml = NamedTempFile::new().expect("generate tempFile");
         let file = r#"
 excluded_paths = ["example.sql"]
@@ -147,7 +147,7 @@ excluded_paths = ["example.sql"]
         assert_debug_snapshot!(Config::parse(Some(squawk_toml.path().to_path_buf())));
     }
     #[test]
-    fn test_load_assume_in_transaction() {
+    fn load_assume_in_transaction() {
         let squawk_toml = NamedTempFile::new().expect("generate tempFile");
         let file = r"
 assume_in_transaction = false
@@ -157,7 +157,7 @@ assume_in_transaction = false
         assert_debug_snapshot!(Config::parse(Some(squawk_toml.path().to_path_buf())));
     }
     #[test]
-    fn test_load_fail_on_violations() {
+    fn load_fail_on_violations() {
         let squawk_toml = NamedTempFile::new().expect("generate tempFile");
         let file = r"
 [upload_to_github]

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/cli/src/reporter.rs

@@ -556,7 +556,7 @@ mod test_github_comment {
     /// Most cases, hopefully, will be a single migration for a given PR, but
     /// let's check the case of multiple migrations
     #[test]
-    fn test_generating_comment_multiple_files() {
+    fn generating_comment_multiple_files() {
         let violations = vec![ViolationContent {
             filename: "alpha.sql".into(),
             sql: r"
@@ -588,7 +588,7 @@ SELECT 1;
     /// Even when we don't have violations we still want to output the SQL for
     /// easy human reading.
     #[test]
-    fn test_generating_comment_no_violations() {
+    fn generating_comment_no_violations() {
         let violations = vec![
             ViolationContent {
                 filename: "alpha.sql".into(),
@@ -623,7 +623,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT 10;
     /// Ideally the logic won't leave a comment when there are no migrations but
     /// better safe than sorry
     #[test]
-    fn test_generating_no_violations_no_files() {
+    fn generating_no_violations_no_files() {
         let violations = vec![];
 
         let body = get_comment_body(&violations, "0.2.3");
@@ -642,7 +642,7 @@ mod test_check_files {
     use super::process_violations;
 
     #[test]
-    fn test_check_files_invalid_syntax() {
+    fn check_files_invalid_syntax() {
         let sql = r"
 select \;
         ";
@@ -672,7 +672,7 @@ mod test_reporter {
     }
 
     #[test]
-    fn test_display_violations_gcc() {
+    fn display_violations_gcc() {
         let sql = r#" 
    ALTER TABLE "core_recipe" ADD COLUMN "foo" integer NOT NULL;
 ALTER TABLE "core_foo" ADD COLUMN "bar" integer NOT NULL;
@@ -698,7 +698,7 @@ SELECT 1;
     }
 
     #[test]
-    fn test_display_violations_tty() {
+    fn display_violations_tty() {
         let sql = r#" 
    ALTER TABLE "core_recipe" ADD COLUMN "foo" integer NOT NULL;
 ALTER TABLE "core_foo" ADD COLUMN "bar" integer NOT NULL;
@@ -719,7 +719,7 @@ SELECT 1;
         assert_display_snapshot!(strip_ansi_codes(&String::from_utf8_lossy(&buff)));
     }
     #[test]
-    fn test_display_no_violations_tty() {
+    fn display_no_violations_tty() {
         let mut buff = Vec::new();
 
         let res = print_violations(
@@ -734,7 +734,7 @@ SELECT 1;
     }
 
     #[test]
-    fn test_display_violations_json() {
+    fn display_violations_json() {
         let sql = r#" 
    ALTER TABLE "core_recipe" ADD COLUMN "foo" integer NOT NULL;
 ALTER TABLE "core_foo" ADD COLUMN "bar" integer NOT NULL;
@@ -757,7 +757,7 @@ SELECT 1;
     }
 
     #[test]
-    fn test_span_offsets() {
+    fn span_offsets() {
         let sql = r#"
 
    ALTER TABLE "core_recipe" ADD COLUMN "foo" integer NOT NULL;
@@ -773,7 +773,7 @@ SELECT 1;
     /// `pretty_violations` was slicing the SQL improperly, trimming off the first
     /// letter.
     #[test]
-    fn test_trimming_sql_newlines() {
+    fn trimming_sql_newlines() {
         let sql = r#"ALTER TABLE "core_recipe" ADD COLUMN "foo" integer NOT NULL;"#;
         let violations = lint_sql(sql);
 

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/lib.rs

@@ -425,7 +425,7 @@ mod test_rules {
     }
     /// Ensure we handle both serializing and deserializing `RuleViolationKind`
     #[test]
-    fn test_parsing_rule_kind() {
+    fn parsing_rule_kind() {
         let rule_names = RULES.iter().map(|r| r.name.clone());
         for rule in rule_names {
             let rule_str = rule.to_string();
@@ -435,19 +435,19 @@ mod test_rules {
     }
     /// Ensure rule names don't change
     #[test]
-    fn test_rule_names_debug_snap() {
+    fn rule_names_debug_snap() {
         let rule_names: Vec<String> = RULES.iter().map(|r| r.name.to_string()).collect();
         assert_debug_snapshot!(rule_names);
     }
     #[test]
-    fn test_rule_names_display_snap() {
+    fn rule_names_display_snap() {
         let rule_names: Vec<String> = RULES.iter().map(|r| r.name.to_string()).collect();
         assert_display_snapshot!(rule_names.join("\n"));
     }
 
     /// Ensure we stort the resulting violations by where they occur in the file.
     #[test]
-    fn test_check_rules_orderin() {
+    fn check_rules_orderin() {
         let sql = r#"
   ALTER TABLE "table_name" RENAME COLUMN "column_name" TO "new_column_name";
   CREATE INDEX "field_name_idx" ON "table_name" ("field_name");

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/adding_field_with_default.rs

@@ -45,7 +45,6 @@ pub fn adding_field_with_default(
         .filter(|x| !x.is_empty())
         .collect();
 
-    // println!("{:#?}", non_volatile_funcs);
     for raw_stmt in tree {
         match &raw_stmt.stmt {
             Stmt::AlterTableStmt(stmt) => {
@@ -132,7 +131,7 @@ mod test_rules {
     /// -- remove nullability
     /// ```
     #[test]
-    fn test_docs_example_bad() {
+    fn docs_example_bad() {
         let bad_sql = r#"
 -- instead of
 ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT 10;
@@ -140,7 +139,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT 10;
         assert_debug_snapshot!(lint_sql(bad_sql, None));
     }
     #[test]
-    fn test_docs_example_ok() {
+    fn docs_example_ok() {
         let ok_sql = r#"
 -- use
 ALTER TABLE "core_recipe" ADD COLUMN "foo" integer;
@@ -152,7 +151,7 @@ ALTER TABLE "core_recipe" ALTER COLUMN "foo" SET DEFAULT 10;
     }
 
     #[test]
-    fn test_default_integer_ok() {
+    fn default_integer_ok() {
         let ok_sql = r#"
 -- NON-VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT 10;
@@ -163,7 +162,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT 10;
     }
 
     #[test]
-    fn test_default_uuid_err() {
+    fn default_uuid_err() {
         let bad_sql = r#"
 -- VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT uuid();
@@ -174,7 +173,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT uuid();
     }
 
     #[test]
-    fn test_default_volatile_func_err() {
+    fn default_volatile_func_err() {
         let bad_sql = r#"
 -- VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" boolean DEFAULT random();
@@ -183,7 +182,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" boolean DEFAULT random();
         assert_debug_snapshot!(lint_sql(bad_sql, pg_version_11));
     }
     #[test]
-    fn test_default_bool_ok() {
+    fn default_bool_ok() {
         let ok_sql = r#"
 -- NON-VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" boolean DEFAULT true;
@@ -192,7 +191,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" boolean DEFAULT true;
         assert_debug_snapshot!(lint_sql(ok_sql, pg_version_11));
     }
     #[test]
-    fn test_default_str_ok() {
+    fn default_str_ok() {
         let ok_sql = r#"
 -- NON-VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" text DEFAULT 'some-str';
@@ -201,7 +200,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" text DEFAULT 'some-str';
         assert_debug_snapshot!(lint_sql(ok_sql, pg_version_11));
     }
     #[test]
-    fn test_default_enum_ok() {
+    fn default_enum_ok() {
         let ok_sql = r#"
 -- NON-VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" some_enum_type DEFAULT 'my-enum-variant';
@@ -210,7 +209,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" some_enum_type DEFAULT 'my-enum-varia
         assert_debug_snapshot!(lint_sql(ok_sql, pg_version_11));
     }
     #[test]
-    fn test_default_jsonb_ok() {
+    fn default_jsonb_ok() {
         let ok_sql = r#"
 -- NON-VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" jsonb DEFAULT '{}'::jsonb;
@@ -219,7 +218,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" jsonb DEFAULT '{}'::jsonb;
         assert_debug_snapshot!(lint_sql(ok_sql, pg_version_11));
     }
     #[test]
-    fn test_default_arbitrary_func_err() {
+    fn default_arbitrary_func_err() {
         let ok_sql = r#"
 -- NON-VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" jsonb DEFAULT myjsonb();
@@ -228,7 +227,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" jsonb DEFAULT myjsonb();
         assert_debug_snapshot!(lint_sql(ok_sql, pg_version_11));
     }
     #[test]
-    fn test_default_random_with_args_err() {
+    fn default_random_with_args_err() {
         let ok_sql = r#"
 -- NON-VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" timestamptz DEFAULT now(123);
@@ -237,7 +236,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" timestamptz DEFAULT now(123);
         assert_debug_snapshot!(lint_sql(ok_sql, pg_version_11));
     }
     #[test]
-    fn test_default_now_func_ok() {
+    fn default_now_func_ok() {
         let ok_sql = r#"
 -- NON-VOLATILE
 ALTER TABLE "core_recipe" ADD COLUMN "foo" timestamptz DEFAULT now();
@@ -246,7 +245,7 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" timestamptz DEFAULT now();
         assert_debug_snapshot!(lint_sql(ok_sql, pg_version_11));
     }
     #[test]
-    fn test_add_numbers_ok() {
+    fn add_numbers_ok() {
         // This should be okay, but we don't handle expressions like this at the moment.
         let ok_sql = r"
 alter table account_metadata add column blah integer default 2 + 2;
@@ -256,7 +255,7 @@ alter table account_metadata add column blah integer default 2 + 2;
     }
 
     #[test]
-    fn test_generated_stored() {
+    fn generated_stored() {
         let bad_sql = r"
         ALTER TABLE foo
     ADD COLUMN bar numeric GENERATED ALWAYS AS (bar + baz) STORED;

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/adding_foreign_key_constraint.rs

@@ -85,7 +85,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_create_table_with_foreign_key_constraint() {
+    fn create_table_with_foreign_key_constraint() {
         let sql = r#"
 BEGIN;
 CREATE TABLE email (
@@ -104,7 +104,7 @@ COMMIT;
         assert_eq!(violations.len(), 0);
     }
     #[test]
-    fn test_add_foreign_key_constraint_not_valid_validate() {
+    fn add_foreign_key_constraint_not_valid_validate() {
         let sql = r#"
 BEGIN;
 ALTER TABLE "email" ADD COLUMN "user_id" INT;
@@ -117,7 +117,7 @@ COMMIT;
         assert_eq!(violations.len(), 0);
     }
     #[test]
-    fn test_add_foreign_key_constraint_lock() {
+    fn add_foreign_key_constraint_lock() {
         let sql = r#"
 BEGIN;
 ALTER TABLE "email" ADD COLUMN "user_id" INT;
@@ -133,7 +133,7 @@ COMMIT;
         );
     }
     #[test]
-    fn test_add_column_references_lock() {
+    fn add_column_references_lock() {
         let sql = r#"
 BEGIN;
 ALTER TABLE "emails" ADD COLUMN "user_id" INT REFERENCES "user" ("id");

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/adding_not_null_field.rs

@@ -7,16 +7,10 @@ use squawk_parser::ast::{AlterTableCmds, AlterTableType, RawStmt, Stmt};
 #[must_use]
 pub fn adding_not_nullable_field(
     tree: &[RawStmt],
-    pg_version: Option<Version>,
+    _pg_version: Option<Version>,
     _assume_in_transaction: bool,
 ) -> Vec<RuleViolation> {
     let mut errs = vec![];
-    if let Some(pg_version) = pg_version {
-        let pg_11 = Version::new(11, Some(0), Some(0));
-        if pg_version >= pg_11 {
-            return errs;
-        }
-    }
 
     for raw_stmt in tree {
         match &raw_stmt.stmt {
@@ -42,36 +36,27 @@ pub fn adding_not_nullable_field(
 
 #[cfg(test)]
 mod test_rules {
-    use std::str::FromStr;
-
     use crate::{
         check_sql_with_rule,
-        versions::Version,
         violations::{RuleViolation, RuleViolationKind},
     };
 
-    fn lint_sql(sql: &str, pg_version: Option<Version>) -> Vec<RuleViolation> {
-        check_sql_with_rule(
-            sql,
-            &RuleViolationKind::AddingNotNullableField,
-            pg_version,
-            false,
-        )
-        .unwrap()
+    fn lint_sql(sql: &str) -> Vec<RuleViolation> {
+        check_sql_with_rule(sql, &RuleViolationKind::AddingNotNullableField, None, false).unwrap()
     }
 
     use insta::assert_debug_snapshot;
 
     #[test]
-    fn test_set_not_null() {
-        let sql = r#"
+    fn set_not_null() {
+        let bad_sql = r#"
 ALTER TABLE "core_recipe" ALTER COLUMN "foo" SET NOT NULL;
         "#;
-        assert_debug_snapshot!(lint_sql(sql, None));
+        assert_debug_snapshot!(lint_sql(bad_sql));
     }
 
     #[test]
-    fn test_adding_field_that_is_not_nullable() {
+    fn adding_field_that_is_not_nullable() {
         let ok_sql = r#"
 BEGIN;
 -- This will cause a table rewrite for Postgres versions before 11, but that is handled by
@@ -80,28 +65,15 @@ ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT 10 NOT NULL;
 ALTER TABLE "core_recipe" ALTER COLUMN "foo" DROP DEFAULT;
 COMMIT;
         "#;
-        assert_debug_snapshot!(lint_sql(ok_sql, None));
+        assert_debug_snapshot!(lint_sql(ok_sql));
     }
 
     #[test]
-    fn test_adding_field_that_is_not_nullable_without_default() {
+    fn adding_field_that_is_not_nullable_without_default() {
         let ok_sql = r#"
 -- This won't work if the table is populated, but that error is caught by adding-required-field.
 ALTER TABLE "core_recipe" ADD COLUMN "foo" integer NOT NULL;
         "#;
-        assert_debug_snapshot!(lint_sql(ok_sql, None));
-    }
-
-    #[test]
-    fn test_adding_field_that_is_not_nullable_in_version_11() {
-        let ok_sql = r#"
-BEGIN;
---
--- Add field foo to recipe
---
-ALTER TABLE "core_recipe" ADD COLUMN "foo" integer NOT NULL DEFAULT 10;
-COMMIT;
-        "#;
-        assert_debug_snapshot!(lint_sql(ok_sql, Some(Version::from_str("11.0.0").unwrap()),));
+        assert_debug_snapshot!(lint_sql(ok_sql));
     }
 }

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/adding_primary_key_constraint.rs

@@ -75,7 +75,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_serial_primary_key() {
+    fn serial_primary_key() {
         let bad_sql = r"
 ALTER TABLE a ADD COLUMN b SERIAL PRIMARY KEY;
 ";
@@ -86,7 +86,7 @@ ALTER TABLE a ADD COLUMN b SERIAL PRIMARY KEY;
     }
 
     #[test]
-    fn test_plain_primary_key() {
+    fn plain_primary_key() {
         let bad_sql = r"
 ALTER TABLE items ADD PRIMARY KEY (id);
 ";

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/adding_required_field.rs

@@ -75,7 +75,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_nullable() {
+    fn nullable() {
         let ok_sql = r#"
 ALTER TABLE "recipe" ADD COLUMN "public" boolean;
   "#;
@@ -83,7 +83,7 @@ ALTER TABLE "recipe" ADD COLUMN "public" boolean;
     }
 
     #[test]
-    fn test_not_null_with_default() {
+    fn not_null_with_default() {
         let ok_sql = r#"
 ALTER TABLE "recipe" ADD COLUMN "public" boolean NOT NULL DEFAULT true;
   "#;
@@ -91,14 +91,14 @@ ALTER TABLE "recipe" ADD COLUMN "public" boolean NOT NULL DEFAULT true;
     }
 
     #[test]
-    fn test_not_null_without_default() {
+    fn not_null_without_default() {
         let bad_sql = r#"
 ALTER TABLE "recipe" ADD COLUMN "public" boolean NOT NULL;
   "#;
         assert_debug_snapshot!(lint_sql(bad_sql));
     }
     #[test]
-    fn test_generated_stored_not_null() {
+    fn generated_stored_not_null() {
         let ok_sql = r"
  ALTER TABLE foo
     ADD COLUMN bar numeric GENERATED ALWAYS AS (bar + baz) STORED NOT NULL;
@@ -106,7 +106,7 @@ ALTER TABLE "recipe" ADD COLUMN "public" boolean NOT NULL;
         assert_debug_snapshot!(lint_sql(ok_sql));
     }
     #[test]
-    fn test_generated_stored() {
+    fn generated_stored() {
         let ok_sql = r"
  ALTER TABLE foo
     ADD COLUMN bar numeric GENERATED ALWAYS AS (bar + baz) STORED ;

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/ban_char_field.rs

@@ -49,7 +49,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_creating_table_with_char_errors() {
+    fn creating_table_with_char_errors() {
         let sql = r#"
 BEGIN;
 CREATE TABLE "core_bar" (
@@ -65,7 +65,7 @@ COMMIT;
     }
 
     #[test]
-    fn test_creating_table_with_var_char_and_text_okay() {
+    fn creating_table_with_var_char_and_text_okay() {
         let sql = r#"
 BEGIN;
 CREATE TABLE "core_bar" (
@@ -77,17 +77,4 @@ COMMIT;
         "#;
         assert_debug_snapshot!(lint_sql(sql));
     }
-    #[test]
-    fn regression_with_indexing_2() {
-        let sql = r#"
-BEGIN;
-ALTER TABLE "core_recipe" ADD COLUMN "foo" integer DEFAULT 10;
-ALTER TABLE "core_recipe" ADD CONSTRAINT foo_not_null
-    CHECK ("foo" IS NOT NULL) NOT VALID;
-COMMIT;
-BEGIN;
-
-"#;
-        assert_debug_snapshot!(lint_sql(sql));
-    }
 }

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/ban_concurrent_index_creation_in_transaction.rs

@@ -73,7 +73,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_adding_index_concurrently_in_transaction() {
+    fn adding_index_concurrently_in_transaction() {
         let bad_sql = r#"
   -- instead of
   BEGIN;
@@ -91,7 +91,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_adding_index_concurrently_in_transaction_with_assume_in_transaction() {
+    fn adding_index_concurrently_in_transaction_with_assume_in_transaction() {
         let bad_sql = r#"
   -- instead of
   CREATE UNIQUE INDEX CONCURRENTLY "field_name_idx" ON "table_name" ("field_name");
@@ -108,7 +108,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_adding_index_concurrently_in_transaction_with_assume_in_transaction_but_outside() {
+    fn adding_index_concurrently_in_transaction_with_assume_in_transaction_but_outside() {
         let ok_sql = r#"
   -- the following will work too
   COMMIT;

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/ban_drop_column.rs

@@ -45,7 +45,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_drop_column() {
+    fn drop_column() {
         let sql = r#"
 ALTER TABLE "bar_tbl" DROP COLUMN "foo_col" CASCADE;
         "#;

squawk_cli-1.5.4/linter/src/rules/bad_drop_database.rs → squawk_cli-1.5.5/linter/src/rules/ban_drop_database.rs

@@ -41,7 +41,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_ban_drop_database() {
+    fn ban_drop_database() {
         let sql = r#"
 DROP DATABASE "table_name";
 DROP DATABASE IF EXISTS "table_name";

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/ban_drop_not_null.rs

@@ -42,7 +42,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_ban_drop_not_null() {
+    fn ban_drop_not_null() {
         let bad_sql = r#"
 ALTER TABLE "bar_tbl" ALTER COLUMN "foo_col" DROP NOT NULL;
   "#;

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/ban_drop_table.rs

@@ -40,7 +40,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_ban_drop_table() {
+    fn ban_drop_table() {
         let sql = r#"
 DROP TABLE "table_name";
 DROP TABLE IF EXISTS "table_name";

{squawk_cli-1.5.4 → squawk_cli-1.5.5}/linter/src/rules/changing_column_type.rs

@@ -44,7 +44,7 @@ mod test_rules {
     }
 
     #[test]
-    fn test_changing_field_type() {
+    fn changing_field_type() {
         let bad_sql = r#"
 BEGIN;
 --