squad 1.90__tar.gz → 1.92__tar.gz

{squad-1.90 → squad-1.92}/CHANGELOG.md

@@ -1,3 +1,47 @@
+# 1.92
+
+This 1.92 release avoids an extra retry when fetching errored builds/tests in Tuxsuite.
+
+# 1.91
+
+This 1.91 release brings a few changes worth pointing out separately:
+
+* Tuxsuite backend: add support for changing environment name if "test_name" is present. Artificial boot tests
+when jobs fail or get canceled. Also checks if the testjob's project contains a token allowing authenticated
+urls in Tuxsuite.
+
+* Log parser: Katie is putting a lot of work in improving linux-log-parser plugin. The idea is that it will
+become its own project in the future
+
+* Add support for performance tracking when supported (Sentry) 
+
+* Support for prometheus-like metrics output for supporting environments (AMQ)
+
+Full set of changes going in:
+
+* api/ci: check job id before accepting test job
+* api/prometheus.py: add initial prometheus metrics endpoint
+* ci/tuxsuite.py:
+  * add support for fetching authenticated tuxsuite urls
+  * change environment name if test_name is available
+  * create artificial boot test
+  * handle canceled tests
+* ci: lava: fix login test name
+* frontend/project.jinja2: add project description to project's home page
+* frontend: urls: point test to details page
+* plugins/linux_log_parser:
+  * Add a new multiline regex for KCSAN
+  * Add regex for capturing multiline kernel panic
+  * Ensure .* regex doesn't capture too much
+  * Extract reused regex components
+  * No longer create tests for passes
+  * Remove unhelpful information from test names
+  * Add support for PID after timestamp
+  * Add support for multiline oops message
+  * Improve log parser patterns
+* setup: change package to psycopg2-binary
+
+
 # 1.90
 
 This 1.90 release makes linux-log-parser more plugable, meaning that it could be

{squad-1.90/squad.egg-info → squad-1.92}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: squad
-Version: 1.90
+Version: 1.92
 Summary: Software Quality Dashboard
 Home-page: https://github.com/Linaro/squad
 Author: Antonio Terceiro

{squad-1.90 → squad-1.92}/doc/install.rst

@@ -214,6 +214,13 @@ __ https://docs.djangoproject.com/en/1.11/topics/email/
   it's recommended to disable sending admin notifications by setting
   ``SQUAD_SEND_ADMIN_ERROR_EMAIL = False``.
 
+* ``SENTRY_TRACES_SAMPLE_RATE``: Specifies the rate at which traces
+  (for performance monitoring) are sampled by Sentry. This value must be a
+  float between 0.0 and 1.0, where 1.0 represents 100% of traces being
+  captured. If not set, it defaults to 0. This option is used to configure
+  Sentry's performance monitoring, allowing you to control how much tracing
+  data is sent to Sentry. It works alongside the SENTRY_DSN setting.
+
 * ``SQUAD_STATIC_DIR``: Directory where SQUAD will find it's preprocessed
   static assets. This usually does not need to be set manually, and exists
   mostly for use in the Docker image.

{squad-1.90 → squad-1.92}/setup.py

@@ -18,7 +18,7 @@ if os.getenv('REQ_IGNORE_VERSIONS'):
     requirements = [req.split('>=')[0] for req in requirements]
 
 extras_require = {
-    'postgres': 'psycopg2',
+    'postgres': 'psycopg2-binary',
 }
 
 

{squad-1.90 → squad-1.92}/squad/api/ci.py

@@ -73,15 +73,26 @@ def submit_job(request, group_slug, project_slug, version, environment_slug):
 @csrf_exempt
 @auth_privileged
 def watch_job(request, group_slug, project_slug, version, environment_slug):
+
+    # testjob_id points to the backend's test job
+    testjob_id = request.POST.get('testjob_id', None)
+    if testjob_id is None:
+        return HttpResponseBadRequest("testjob_id is required")
+
     backend_name = request.POST.get('backend')
     if backend_name is None:
         return HttpResponseBadRequest("backend field is required")
+
     backend = None
     try:
         backend = Backend.objects.get(name=request.POST.get('backend'))
     except Backend.DoesNotExist:
         return HttpResponseBadRequest("requested backend does not exist")
 
+    check = backend.get_implementation().check_job_id(testjob_id)
+    if check is not True:
+        return HttpResponseBadRequest(check)
+
     # project has to exist or request will result with 400
     project = request.project
     if backend is None or project is None:
@@ -90,12 +101,6 @@ def watch_job(request, group_slug, project_slug, version, environment_slug):
     # create Build object
     build, _ = project.builds.get_or_create(version=version)
 
-    # testjob_id points to the backend's test job
-    testjob_id = request.POST.get('testjob_id', None)
-
-    if testjob_id is None:
-        return HttpResponseBadRequest("testjob_id is required")
-
     # create TestJob object
     test_job = TestJob(
         backend=backend,

squad-1.92/squad/api/prometheus.py

@@ -0,0 +1,52 @@
+import re
+import requests
+import celery
+
+from django.conf import settings
+from django.http import HttpResponse, HttpResponseForbidden
+from django.views.decorators.csrf import csrf_exempt
+from django.views.decorators.http import require_http_methods
+
+from squad.http import auth_user_from_request
+
+
+@csrf_exempt
+@require_http_methods(['GET'])
+def metrics(request):
+    user = auth_user_from_request(request, request.user)
+    if not user.is_authenticated:
+        return HttpResponseForbidden()
+
+    output = ''
+    available_queues = None
+
+    active_queues = celery.current_app.control.inspect().active_queues()
+    if active_queues is not None:
+        active_workers = set()
+        available_queues = set()
+        for worker_name, queues in active_queues.items():
+            active_workers.add(worker_name)
+            available_queues |= set([q['name'] for q in queues])
+
+        output += '# TYPE workers_count counter\n'
+        output += f'workers_count {len(active_workers)}\n'
+
+    # TODO: check how to get metrics for non-RabbitMQ brokers
+    if settings.CELERY_BROKER_URL:
+        rabbitmq_url = settings.CELERY_BROKER_URL.replace('amqps://', 'https://').replace('amqp://', 'http://')
+        rabbitmq_url = re.sub(r':\d+$', '', rabbitmq_url)
+        rabbitmq_url += '/api/queues'
+
+        response = requests.get(rabbitmq_url)
+        queues = response.json()
+        available_queues = {r["queue"] for r in settings.CELERY_TASK_ROUTES.values()}
+
+        for queue in queues:
+            if queue['name'] in available_queues:
+                metric_name = f'queue_{queue["name"]}_count'
+                length = queue['messages_ready']
+
+                output += f'\n# TYPE {metric_name} counter'
+                output += f'\n{metric_name} {length}'
+
+    return HttpResponse(output, status=200, content_type="text/plain;")

{squad-1.90 → squad-1.92}/squad/api/urls.py

@@ -5,6 +5,7 @@ from rest_framework.schemas import get_schema_view
 from . import views
 from . import data
 from . import ci
+from . import prometheus
 from . import rest
 
 
@@ -26,4 +27,5 @@ urlpatterns = [
     url(r'^resubmit/([0-9]+)', ci.resubmit_job),
     url(r'^forceresubmit/([0-9]+)', ci.force_resubmit_job),
     url(r'^version/', views.version),
+    url(r'^prometheus/', prometheus.metrics),
 ]

{squad-1.90 → squad-1.92}/squad/ci/backend/fake.py

@@ -72,6 +72,9 @@ class Backend(object):
     def check_job_definition(self, definition):
         return True
 
+    def check_job_id(self, job_id):
+        return True
+
     def get_job_definition(self, test_job):
         return "sample job definition"
 

{squad-1.90 → squad-1.92}/squad/ci/backend/lava.py

@@ -683,7 +683,7 @@ class Backend(BaseBackend):
                         if clone_measurements_to_tests:
                             res_value = result['result']
                             results.update({res_name: res_value})
-                elif result['name'] == 'auto-login-action' and handle_lava_boot:
+                elif 'login-action' in result['name'] and handle_lava_boot:
                     # add artificial 'boot' test result for each test job
                     # by default the boot test is named after the device_type
                     boot = "boot-%s" % test_job.name
@@ -785,6 +785,11 @@ class Backend(BaseBackend):
         except yaml.YAMLError as e:
             return str(e)
 
+    def check_job_id(self, job_id):
+        if re.match(r"^\d+$", str(job_id)) is not None:
+            return True
+        return "LAVA job id should be an integer"
+
     def get_job_definition(self, job_id):
         if self.use_xml_rpc:
             return self.proxy.scheduler.jobs.definition(job_id)

{squad-1.90 → squad-1.92}/squad/ci/backend/null.py

@@ -143,6 +143,12 @@ class Backend:
         """
         raise NotImplementedError
 
+    def check_job_id(self, job_id):
+        """
+        Returns True if job id matches what the backend expect, else returns the error message
+        """
+        raise NotImplementedError
+
     def format_message(self, msg):
         if self.data and hasattr(self.data, "name"):
             return self.data.name + ': ' + msg

{squad-1.90 → squad-1.92}/squad/ci/backend/tuxsuite.py

@@ -120,6 +120,13 @@ class Backend(BaseBackend):
         # The regex below is supposed to find only one match
         return matches[0]
 
+    def check_job_id(self, job_id):
+        try:
+            self.parse_job_id(job_id)
+            return True
+        except FetchIssue as e:
+            return str(e)
+
     def generate_job_id(self, result_type, result):
         """
             The job id for TuxSuite results is generated using 3 pieces of info:
@@ -144,7 +151,11 @@ class Backend(BaseBackend):
         url = reduce(urljoin, urlbits)
 
         try:
-            response = Backend.get_session().request("GET", url)
+            headers = {}
+            if hasattr(self, 'auth_token') and self.auth_token is not None:
+                headers = {'Authorization': self.auth_token}
+
+            response = Backend.get_session().request("GET", url, headers=headers)
         except Exception as e:
             raise TemporaryFetchIssue(f"Can't retrieve from {url}: {e}")
 
@@ -224,6 +235,11 @@ class Backend(BaseBackend):
         if 'toolchain' in build_metadata_keys and 'kconfig' in build_metadata_keys and metadata['build_name'] in [None, '']:
             metadata['build_name'] = self.generate_test_name(build_metadata)
 
+    def add_skip_boot_test(self, tests, metadata):
+        # Create an artificial boot test and mark it as skip
+        boot_test_name = 'boot/' + (metadata.get('build_name') or 'boot')
+        tests[boot_test_name] = None
+
     def parse_build_results(self, test_job, job_url, results, settings):
         required_keys = ['build_status', 'warnings_count', 'download_url', 'retry']
         self.__check_required_keys__(required_keys, results)
@@ -233,9 +249,6 @@ class Backend(BaseBackend):
         test_job.name = test_name
 
         build_status = results['build_status']
-        if build_status == 'error' and results['retry'] < 2:
-            # SQUAD should retry fetching the build until retry == 2
-            raise TemporaryFetchIssue(results.get('status_message', 'TuxSuite Error'))
 
         # Make metadata
         metadata_keys = settings.get('BUILD_METADATA_KEYS', [])
@@ -254,7 +267,7 @@ class Backend(BaseBackend):
         metrics = {}
 
         completed = True
-        if results['retry'] >= 2:
+        if build_status == 'error':
             # This indicates that TuxSuite gave up trying to work on this build
             status = 'Incomplete'
             tests[f'build/{test_name}'] = 'skip'
@@ -318,6 +331,11 @@ class Backend(BaseBackend):
         metadata_keys = settings.get('TEST_METADATA_KEYS', [])
         metadata = {k: results.get(k) for k in metadata_keys}
 
+        # Change environment name
+        if 'test_name' in results and results.get('test_name') is not None:
+            test_job.environment = results.get('test_name')
+            test_job.save()
+
         # Add extra metadata from metadata file if it exists
         self.update_metadata_from_file(results=results, metadata=metadata)
 
@@ -340,6 +358,8 @@ class Backend(BaseBackend):
             else:
                 test_job.failure = 'sanity test failed'
 
+            self.add_skip_boot_test(tests, metadata)
+
             return status, completed, metadata, tests, metrics, logs
 
         # Fetch results even if the job fails, but has results
@@ -348,8 +368,14 @@ class Backend(BaseBackend):
 
         elif results['result'] == 'error':
             test_job.failure = 'tuxsuite infrastructure error'
+            self.add_skip_boot_test(tests, metadata)
             return 'Incomplete', completed, metadata, tests, metrics, logs
 
+        elif results['result'] == 'canceled':
+            test_job.failure = 'tuxsuite job canceled'
+            self.add_skip_boot_test(tests, metadata)
+            return 'Canceled', completed, metadata, tests, metrics, logs
+
         # If boot result is unkown, a retry is needed, otherwise, it either passed or failed
         if 'unknown' == results['results']['boot']:
             return None
@@ -384,6 +410,10 @@ class Backend(BaseBackend):
 
     def fetch(self, test_job):
         url = self.job_url(test_job)
+
+        settings = self.__resolve_settings__(test_job)
+        self.auth_token = settings.get('TUXSUITE_TOKEN', None)
+
         if test_job.input:
             results = self.fetch_from_results_input(test_job)
             test_job.input = None
@@ -393,11 +423,12 @@ class Backend(BaseBackend):
         if results.get('state') != 'finished':
             return None
 
-        settings = self.__resolve_settings__(test_job)
-
         result_type = self.parse_job_id(test_job.job_id)[0]
         parse_results = getattr(self, f'parse_{result_type.lower()}_results')
-        return parse_results(test_job, url, results, settings)
+        parsed = parse_results(test_job, url, results, settings)
+
+        self.auth_token = None
+        return parsed
 
     def job_url(self, test_job):
         result_type, tux_project, tux_uid = self.parse_job_id(test_job.job_id)

{squad-1.90 → squad-1.92}/squad/frontend/templates/squad/project.jinja2

@@ -6,6 +6,14 @@
 
 {% include "squad/project-nav.jinja2" %}
 
+
+{% if project.description%}
+<h2>{{ _('Description') }}</h2>
+<div class='description-{{project.id}}'>
+    {{project.description}}
+</div>
+{% endif %}
+
 {% if last_build %}
 <div>
 <h2>

{squad-1.90 → squad-1.92}/squad/frontend/urls.py

@@ -52,6 +52,7 @@ urlpatterns = [
     url(r'^(%s)/(%s)/build/([^/]+)/attachments/testrun/([^/]+)/([^/]+)$' % group_and_project, views.build_attachment, name='build_attachments'),
     url(r'^(%s)/(%s)/build/([^/]+)/testrun/([^/]+)/suite/([^/]+)/tests/$' % group_and_project, views.test_run_suite_tests, name='testrun_suite_tests'),
     url(r'^(%s)/(%s)/build/([^/]+)/testrun/([^/]+)/suite/([^/]+)/test/([^/]+)/history/$' % group_and_project, tests.test_history, name='test_history'),
+    url(r'^(%s)/(%s)/build/([^/]+)/testrun/([^/]+)/suite/([^/]+)/test/([^/]+)/$' % group_and_project, views.test_run_suite_test_details, name='testrun_suite_test_details'),
     url(r'^(%s)/(%s)/build/([^/]+)/testrun/([^/]+)/suite/([^/]+)/test/([^/]+)/details/$' % group_and_project, views.test_run_suite_test_details, name='testrun_suite_test_details'),
     url(r'^(%s)/(%s)/build/([^/]+)/testrun/([^/]+)/suite/([^/]+)/metrics/$' % group_and_project, views.test_run_suite_metrics, name='testrun_suite_metrics'),
     url(r'^(%s)/(%s)/build/([^/]+)/testrun/([^/]+)/suite/([^/]+)/test/([^/]+)/log$' % group_and_project, views.test_details_log, name='test_details_log'),

{squad-1.90 → squad-1.92}/squad/plugins/lib/base_log_parser.py

@@ -8,6 +8,11 @@ REGEX_NAME = 0
 REGEX_BODY = 1
 REGEX_EXTRACT_NAME = 2
 
+tstamp = r"\[[ \d]+\.[ \d]+\]"
+pid = r"(?:\s*?\[\s*?[CT]\d+\s*?\])"
+not_newline_or_plus = r"[^\+\n]"
+square_brackets_and_contents = r"\[[^\]]+\]"
+
 
 class BaseLogParser:
     def compile_regexes(self, regexes):
@@ -15,8 +20,13 @@ class BaseLogParser:
         return re.compile(r"|".join(combined), re.S | re.M)
 
     def remove_numbers_and_time(self, snippet):
+        # [ 1067.461794][  T132] BUG: KCSAN: data-race in do_page_fault spectre_v4_enable_task_mitigation
+        # -> [ .][  T] BUG: KCSAN: data-race in do_page_fault spectre_v_enable_task_mitigation
         without_numbers = re.sub(r"(0x[a-f0-9]+|[<\[][0-9a-f]+?[>\]]|\d+)", "", snippet)
-        without_time = re.sub(r"^\[[^\]]+\]", "", without_numbers)
+
+        # [ .][  T] BUG: KCSAN: data-race in do_page_fault spectre_v_enable_task_mitigation
+        # ->  BUG: KCSAN: data-race in do_page_fault spectre_v_enable_task_mitigation
+        without_time = re.sub(f"^{square_brackets_and_contents}({square_brackets_and_contents})?", "", without_numbers) # noqa
 
         return without_time
 
@@ -56,11 +66,6 @@ class BaseLogParser:
         tests_without_shas_to_create = defaultdict(set)
         tests_with_shas_to_create = defaultdict(set)
 
-        # If there are no lines, use the default name and create a passing
-        # test. For example "check-kernel-oops"
-        if not lines:
-            tests_without_shas_to_create[test_name] = []
-
         # If there are lines, then create the tests for these.
         for line in lines:
             extracted_name = self.create_name(line, test_regex)

{squad-1.90 → squad-1.92}/squad/plugins/linux_log_parser.py

@@ -1,23 +1,26 @@
 import logging
 import re
 from squad.plugins import Plugin as BasePlugin
-from squad.plugins.lib.base_log_parser import BaseLogParser, REGEX_NAME, REGEX_EXTRACT_NAME
+from squad.plugins.lib.base_log_parser import BaseLogParser, REGEX_NAME, REGEX_EXTRACT_NAME, tstamp, pid, not_newline_or_plus
 
 logger = logging.getLogger()
 
 MULTILINERS = [
-    ('check-kernel-exception', r'-+\[? cut here \]?-+.*?-+\[? end trace \w* \]?-+', r"\d][^\+\n]*"),
-    ('check-kernel-kasan', r'=+\n\[[\s\.\d]+\]\s+BUG: KASAN:.*?=+', r"BUG: KASAN:[^\+\n]*"),
-    ('check-kernel-kfence', r'=+\n\[[\s\.\d]+\]\s+BUG: KFENCE:.*?=+', r"BUG: KFENCE:[^\+\n]*"),
+    ('exception', fr'-+\[? cut here \]?-+.*?{tstamp}{pid}?\s+-+\[? end trace \w* \]?-+', fr"\n{tstamp}{not_newline_or_plus}*"), # noqa
+    ('kasan', fr'{tstamp}{pid}?\s+=+\n{tstamp}{pid}?\s+BUG: KASAN:.*?\n*?{tstamp}{pid}?\s+=+', fr"BUG: KASAN:{not_newline_or_plus}*"), # noqa
+    ('kcsan', fr'{tstamp}{pid}?\s+=+\n{tstamp}{pid}?\s+BUG: KCSAN:.*?=+', fr"BUG: KCSAN:{not_newline_or_plus}*"), # noqa
+    ('kfence', fr'{tstamp}{pid}?\s+=+\n{tstamp}{pid}?\s+BUG: KFENCE:.*?{tstamp}{pid}?\s+=+', fr"BUG: KFENCE:{not_newline_or_plus}*"), # noqa
+    ('panic-multiline', fr'{tstamp}{pid}?\s+Kernel panic - [^\n]+\n.*?-+\[? end Kernel panic - [^\n]+ \]?-*', fr"Kernel {not_newline_or_plus}*"), # noqa
+    ('internal-error-oops', fr'{tstamp}{pid}?\s+Internal error: Oops.*?-+\[? end trace \w+ \]?-+', fr"Oops{not_newline_or_plus}*"), # noqa
 ]
 
 ONELINERS = [
-    ('check-kernel-oops', r'^[^\n]+Oops(?: -|:).*?$', r"Oops[^\+\n]*"),
-    ('check-kernel-fault', r'^[^\n]+Unhandled fault.*?$', r"Unhandled [^\+\n]*"),
-    ('check-kernel-warning', r'^[^\n]+WARNING:.*?$', r"WARNING: [^\+\n]*"),
-    ('check-kernel-bug', r'^[^\n]+(?: kernel BUG at|BUG:).*?$', r"BUG[^\+\n]*"),
-    ('check-kernel-invalid-opcode', r'^[^\n]+invalid opcode:.*?$', r"invalid opcode: [^\+\n]*"),
-    ('check-kernel-panic', r'Kernel panic - not syncing.*?$', r"Kernel [^\+\n]*"),
+    ('oops', r'^[^\n]+Oops(?: -|:).*?$', fr"Oops{not_newline_or_plus}*"), # noqa
+    ('fault', r'^[^\n]+Unhandled fault.*?$', fr"Unhandled {not_newline_or_plus}*"), # noqa
+    ('warning', r'^[^\n]+WARNING:.*?$', fr"WARNING:{not_newline_or_plus}*"), # noqa
+    ('bug', r'^[^\n]+(?: kernel BUG at|BUG:).*?$', fr"BUG{not_newline_or_plus}*"), # noqa
+    ('invalid-opcode', r'^[^\n]+invalid opcode:.*?$', fr"invalid opcode:{not_newline_or_plus}*"), # noqa
+    ('panic', r'Kernel panic - not syncing.*?$', fr"Kernel {not_newline_or_plus}*"), # noqa
 ]
 
 # Tip: broader regexes should come first
@@ -38,7 +41,7 @@ class Plugin(BasePlugin, BaseLogParser):
         return boot_log, test_log
 
     def __kernel_msgs_only(self, log):
-        kernel_msgs = re.findall(r'(\[[ \d]+\.[ \d]+\] .*?)$', log, re.S | re.M)
+        kernel_msgs = re.findall(f'({tstamp}{pid}? .*?)$', log, re.S | re.M) # noqa
         return '\n'.join(kernel_msgs)
 
     def postprocess_testrun(self, testrun):

{squad-1.90 → squad-1.92}/squad/settings.py

@@ -422,6 +422,7 @@ CRISPY_TEMPLATE_PACK = 'bootstrap3'
 
 # Sentry support
 SENTRY_DSN = os.getenv('SENTRY_DSN')
+SENTRY_TRACES_SAMPLE_RATE = os.getenv('SENTRY_TRACES_SAMPLE_RATE', '0')
 if SENTRY_DSN:
     try:
         import sentry_sdk
@@ -432,6 +433,7 @@ if SENTRY_DSN:
             dsn=SENTRY_DSN,
             integrations=[DjangoIntegration(), CeleryIntegration()],
             release='%s@%s' % (os.getenv('ENV', 'squad'), squad_version),
+            traces_sample_rate=float(SENTRY_TRACES_SAMPLE_RATE),
         )
     except ImportError:
         pass

squad-1.92/squad/version.py

@@ -0,0 +1 @@
+__version__ = '1.92'

{squad-1.90 → squad-1.92/squad.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: squad
-Version: 1.90
+Version: 1.92
 Summary: Software Quality Dashboard
 Home-page: https://github.com/Linaro/squad
 Author: Antonio Terceiro

{squad-1.90 → squad-1.92}/squad.egg-info/SOURCES.txt

@@ -100,6 +100,7 @@ squad/api/apps.py
 squad/api/ci.py
 squad/api/data.py
 squad/api/filters.py
+squad/api/prometheus.py
 squad/api/rest.py
 squad/api/urls.py
 squad/api/utils.py
@@ -617,11 +618,15 @@ test/plugins/test_github.py
 test/plugins/test_linux_log_parser.py
 test/plugins/test_log_parser_base.py
 test/plugins/test_plugin.py
+test/plugins/linux_log_parser/internal-error-oops.log
 test/plugins/linux_log_parser/kasan.log
+test/plugins/linux_log_parser/kcsan_full_log.log
+test/plugins/linux_log_parser/kcsan_simple.log
 test/plugins/linux_log_parser/kernel_bug_and_invalid_opcode.log
 test/plugins/linux_log_parser/kernelexceptiontrace.log
 test/plugins/linux_log_parser/kernelexceptiontrace_without_squarebraces.log
-test/plugins/linux_log_parser/kernelpanic.log
+test/plugins/linux_log_parser/kernelpanic-multiline.log
+test/plugins/linux_log_parser/kernelpanic-single-and-multiline.log
 test/plugins/linux_log_parser/kfence.log
 test/plugins/linux_log_parser/multiple_issues_dmesg.log
 test/plugins/linux_log_parser/oops.log

{squad-1.90 → squad-1.92}/squad.egg-info/requires.txt

@@ -31,4 +31,4 @@ svgwrite
 whitenoise
 
 [postgres]
-psycopg2
+psycopg2-binary

{squad-1.90 → squad-1.92}/test/api/test_ci.py

@@ -156,6 +156,15 @@ class CiApiTest(TestCase):
         r = self.client.post('/api/submitjob/mygroup/myproject/1/myenv', args)
         self.assertEqual(400, r.status_code)
 
+    @patch('squad.ci.backend.fake.Backend.check_job_id', return_value='bad definition')
+    def test_bad_job_id(self, check_job_id):
+        args = {
+            'backend': 'lava',
+            'testjob_id': 'invalid job id'
+        }
+        r = self.client.post('/api/submitjob/mygroup/myproject/1/myenv', args)
+        self.assertEqual(400, r.status_code)
+
     def test_disabled_environment(self):
         args = {
             'backend': 'lava',

{squad-1.90 → squad-1.92}/test/ci/backend/test_lava.py

@@ -448,6 +448,12 @@ class LavaTest(TestCase):
         check = lava.check_job_definition(definition)
         self.assertIn('found unexpected end of stream', check)
 
+    def test_check_job_id(self):
+        lava = LAVABackend(None)
+        self.assertTrue(lava.check_job_id(1))
+        self.assertTrue(lava.check_job_id('1'))
+        self.assertEqual("LAVA job id should be an integer", lava.check_job_id("abc"))
+
     def test_lava_job_name(self):
         lava = LAVABackend(None)
         self.assertIsNone(lava._Backend__lava_job_name('no name:'))