sqlite-export-for-ynab 2.8.0__tar.gz → 2.9.0__tar.gz

{sqlite_export_for_ynab-2.8.0/sqlite_export_for_ynab.egg-info → sqlite_export_for_ynab-2.9.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sqlite_export_for_ynab
-Version: 2.8.0
+Version: 2.9.0
 Summary: SQLite Export for YNAB - Export YNAB Data to SQLite
 Home-page: https://github.com/mxr/sqlite-export-for-ynab
 Author: Max R
@@ -272,7 +272,7 @@ WITH interest_by_account AS (
     SELECT
         plan_id
         , account_name
-        , SUM(-amount_currency) AS total
+        , SUM(amount_currency) AS total
     FROM flat_transactions
     WHERE
         TRUE

{sqlite_export_for_ynab-2.8.0 → sqlite_export_for_ynab-2.9.0}/README.md

@@ -242,7 +242,7 @@ WITH interest_by_account AS (
     SELECT
         plan_id
         , account_name
-        , SUM(-amount_currency) AS total
+        , SUM(amount_currency) AS total
     FROM flat_transactions
     WHERE
         TRUE

{sqlite_export_for_ynab-2.8.0 → sqlite_export_for_ynab-2.9.0}/setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = sqlite_export_for_ynab
-version = 2.8.0
+version = 2.9.0
 description = SQLite Export for YNAB - Export YNAB Data to SQLite
 long_description = file: README.md
 long_description_content_type = text/markdown

{sqlite_export_for_ynab-2.8.0 → sqlite_export_for_ynab-2.9.0}/sqlite_export_for_ynab/_main.py

@@ -46,6 +46,8 @@ from sqlite_export_for_ynab import ddl
 
 if TYPE_CHECKING:
     from collections.abc import AsyncIterator
+    from collections.abc import Awaitable
+    from collections.abc import Callable
     from collections.abc import Iterator
     from collections.abc import Sequence
 
@@ -603,7 +605,13 @@ async def insert_entries(
     if not entries:
         return
 
-    entry_keys = tuple(entries[0])
+    async with context.con.cursor() as cur:
+        await cur.execute(f"PRAGMA table_info({table})")
+        table_columns = {row["name"] async for row in cur}
+
+    # Ignore any keys the YNAB API returns that aren't columns in the DDL so
+    # newly-added API fields don't break the insert.
+    entry_keys = tuple(k for k in entries[0] if k in table_columns)
     sql = f"INSERT OR REPLACE INTO {table} ({', '.join(entry_keys + ('plan_id',))}) VALUES ({', '.join('?' * (len(entry_keys) + 1))})"
 
     async with context.con.cursor() as cur:
@@ -634,100 +642,45 @@ async def _get_all_ynab(
 async def _get_plan_data(
     context: _Context, plan_id: str, lkos: dict[str, int], task_id: TaskID
 ) -> tuple[str, _YnabPlanData]:
-    (
-        accounts,
-        categories,
-        payees,
-        transactions_serverknowledge,
-        scheduled_transactions,
-    ) = await asyncio.gather(
-        _get_accounts(context, plan_id, lkos, task_id),
-        _get_categories(context, plan_id, lkos, task_id),
-        _get_payees(context, plan_id, lkos, task_id),
-        _get_transactions(context, plan_id, lkos, task_id),
-        _get_scheduled_transactions(context, plan_id, lkos, task_id),
+    accounts, categories, payees, transactions, scheduled = await asyncio.gather(
+        *(
+            _get_ynab(context, endpoint, plan_id, lkos, task_id)
+            for endpoint in (
+                AccountsApi(context.api_client).get_accounts,
+                CategoriesApi(context.api_client).get_categories,
+                PayeesApi(context.api_client).get_payees,
+                TransactionsApi(context.api_client).get_transactions,
+                ScheduledTransactionsApi(context.api_client).get_scheduled_transactions,
+            )
+        )
     )
-    transactions, server_knowledge = transactions_serverknowledge
     return (
         plan_id,
         _YnabPlanData(
-            accounts=accounts,
-            category_groups=categories,
-            payees=payees,
-            transactions=transactions,
-            server_knowledge=server_knowledge,
-            scheduled_transactions=scheduled_transactions,
+            accounts=accounts.data.accounts,
+            category_groups=categories.data.category_groups,
+            payees=payees.data.payees,
+            transactions=transactions.data.transactions,
+            server_knowledge=transactions.data.server_knowledge,
+            scheduled_transactions=scheduled.data.scheduled_transactions,
         ),
     )
 
 
 @retry(stop=stop_after_attempt(3))
-async def _get_accounts(
-    context: _Context, plan_id: str, lkos: dict[str, int], task_id: TaskID
-) -> list[Account]:
-    resp = await AccountsApi(context.api_client).get_accounts(
-        plan_id=plan_id, last_knowledge_of_server=lkos.get(plan_id)
-    )
-    context.progress.update(task_id, advance=1)
-    return resp.data.accounts
-
-
-@retry(stop=stop_after_attempt(3))
-async def _get_categories(
-    context: _Context, plan_id: str, lkos: dict[str, int], task_id: TaskID
-) -> list[CategoryGroupWithCategories]:
-    resp = await CategoriesApi(context.api_client).get_categories(
-        plan_id=plan_id, last_knowledge_of_server=lkos.get(plan_id)
-    )
-    context.progress.update(task_id, advance=1)
-    return resp.data.category_groups
-
-
-@retry(stop=stop_after_attempt(3))
-async def _get_payees(
-    context: _Context, plan_id: str, lkos: dict[str, int], task_id: TaskID
-) -> list[Payee]:
-    resp = await PayeesApi(context.api_client).get_payees(
-        plan_id=plan_id, last_knowledge_of_server=lkos.get(plan_id)
-    )
-    context.progress.update(task_id, advance=1)
-    return resp.data.payees
-
-
-@retry(stop=stop_after_attempt(3))
-async def _get_transactions(
-    context: _Context, plan_id: str, lkos: dict[str, int], task_id: TaskID
-) -> tuple[list[TransactionDetail], int]:
-    resp = await TransactionsApi(context.api_client).get_transactions(
-        plan_id=plan_id, last_knowledge_of_server=lkos.get(plan_id)
-    )
-    context.progress.update(task_id, advance=1)
-    return resp.data.transactions, resp.data.server_knowledge
-
-
-@retry(stop=stop_after_attempt(3))
-async def _get_scheduled_transactions(
-    context: _Context, plan_id: str, lkos: dict[str, int], task_id: TaskID
-) -> list[ScheduledTransactionDetail]:
-    resp = await ScheduledTransactionsApi(
-        context.api_client
-    ).get_scheduled_transactions(
-        plan_id=plan_id, last_knowledge_of_server=lkos.get(plan_id)
-    )
-    context.progress.update(task_id, advance=1)
-    return resp.data.scheduled_transactions
-
-
-# @retry(stop=stop_after_attempt(3))
-# async def _get_ynab[T](
-#     context: _Context,
-#     getter: Callable[..., Awaitable[T]],
-#     task_id: TaskID,
-# ) -> T:
-#     try:
-#         return await getter()
-#     finally:
-#         context.progress.update(task_id, advance=1)
+async def _get_ynab[T](
+    context: _Context,
+    endpoint: Callable[..., Awaitable[T]],
+    plan_id: str,
+    lkos: dict[str, int],
+    task_id: TaskID,
+) -> T:
+    try:
+        return await endpoint(
+            plan_id=plan_id, last_knowledge_of_server=lkos.get(plan_id)
+        )
+    finally:
+        context.progress.update(task_id, advance=1)
 
 
 def main(

{sqlite_export_for_ynab-2.8.0 → sqlite_export_for_ynab-2.9.0/sqlite_export_for_ynab.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sqlite_export_for_ynab
-Version: 2.8.0
+Version: 2.9.0
 Summary: SQLite Export for YNAB - Export YNAB Data to SQLite
 Home-page: https://github.com/mxr/sqlite-export-for-ynab
 Author: Max R
@@ -272,7 +272,7 @@ WITH interest_by_account AS (
     SELECT
         plan_id
         , account_name
-        , SUM(-amount_currency) AS total
+        , SUM(amount_currency) AS total
     FROM flat_transactions
     WHERE
         TRUE

{sqlite_export_for_ynab-2.8.0 → sqlite_export_for_ynab-2.9.0}/tests/_main_test.py

@@ -29,6 +29,7 @@ from sqlite_export_for_ynab._main import get_last_knowledge_of_server
 from sqlite_export_for_ynab._main import get_relations
 from sqlite_export_for_ynab._main import insert_accounts
 from sqlite_export_for_ynab._main import insert_category_groups
+from sqlite_export_for_ynab._main import insert_entries
 from sqlite_export_for_ynab._main import insert_payees
 from sqlite_export_for_ynab._main import insert_plans
 from sqlite_export_for_ynab._main import insert_scheduled_transactions
@@ -499,6 +500,31 @@ async def test_insert_payees(context):
     )
 
 
+@pytest.mark.asyncio
+async def test_insert_entries_ignores_unknown_keys(context):
+    task_id = context.progress.add_task("Payees", total=1)
+    entry = {
+        "id": PAYEE_ID_1,
+        "name": "Payee",
+        "transfer_account_id": None,
+        "deleted": False,
+        "brand_new_api_field": "surprise",
+    }
+    await insert_entries(context, "payees", PLAN_ID_1, [entry], task_id)
+    assert_rows(
+        await fetchall(context.con, "SELECT * FROM payees"),
+        [
+            {
+                "id": PAYEE_ID_1,
+                "plan_id": PLAN_ID_1,
+                "name": "Payee",
+                "transfer_account_id": None,
+                "deleted": False,
+            }
+        ],
+    )
+
+
 @pytest.mark.asyncio
 async def test_insert_transactions(context):
     await insert_transactions(context, PLAN_ID_1, [])