sql-code-graph 1.33.0__tar.gz → 1.33.1__tar.gz

{sql_code_graph-1.33.0 → sql_code_graph-1.33.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sql-code-graph
-Version: 1.33.0
+Version: 1.33.1
 Summary: SQL code graph analyzer and lineage tracer
 Project-URL: Homepage, https://github.com/Warhorze/sql-code-graph
 Project-URL: Repository, https://github.com/Warhorze/sql-code-graph

{sql_code_graph-1.33.0 → sql_code_graph-1.33.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "sql-code-graph"
-version = "1.33.0"
+version = "1.33.1"
 description = "SQL code graph analyzer and lineage tracer"
 readme = "README.md"
 requires-python = ">=3.12"

{sql_code_graph-1.33.0 → sql_code_graph-1.33.1}/src/sqlcg/__init__.py

@@ -1,5 +1,5 @@
 """SQL Code Graph - SQL lineage and dependency analysis tool."""
 
-__version__ = "1.33.0"
+__version__ = "1.33.1"
 
 __all__ = ["__version__"]

{sql_code_graph-1.33.0 → sql_code_graph-1.33.1}/src/sqlcg/server/tools.py

@@ -2532,12 +2532,16 @@ def _diff_lost_producers(
     lost_raw = before - after
     new_raw = after - before
 
-    # Exclude synthetic from both sides.
-    if lost_raw:
-        lost_cleaned, _ = _exclude_synthetic_tables(db, sorted(lost_raw))
-        lost_set = set(lost_cleaned)
-    else:
-        lost_set = set()
+    # Lost-producer side: do NOT apply _exclude_synthetic_tables.
+    # The lost set comes exclusively from GET_PRODUCER_TABLES (SqlQuery.target_table),
+    # which is only ever a real top-level write target — a CTE/derived intermediate alias
+    # is never a SqlQuery.target_table.  An INSERT target with no surviving consumers
+    # keeps kind='derived' (the indexer only upgrades 'derived'→'table' when a SELECT
+    # reads the table elsewhere), so applying _exclude_synthetic_tables here would drop
+    # genuine write targets that happen to be unconsumed (bug #3 false-safety signal).
+    # The synthetic filter is still applied to the NEW-producer side below (for rename
+    # classification), where genuine intermediate nodes can appear via new CTEs/views.
+    lost_set = set(lost_raw)
 
     if new_raw:
         new_cleaned, _ = _exclude_synthetic_tables(db, sorted(new_raw))

{sql_code_graph-1.33.0 → sql_code_graph-1.33.1}/tests/integration/test_pr_impact_integration.py

@@ -134,6 +134,76 @@ def test_genuine_deletion_lost_producer_and_blast_radius(tmp_path):
     assert "da.child" in all_affected or blast.downstream_count >= 0  # lenient — may vary by schema
 
 
+def test_sole_producer_deleted_no_consumer_still_reported(tmp_path):
+    """Deleting the sole producer of a never-consumed table surfaces it as lost.
+
+    An INSERT-only target with NO consumers keeps kind='derived' in the graph
+    (the indexer only upgrades 'derived'→'table' when the table is read elsewhere).
+    Before this fix, _exclude_synthetic_tables on the lost-producer side dropped the
+    table because 'derived' ∈ _SYNTHETIC_TABLE_KINDS, producing a false "No producers
+    lost — no data-loss blast radius." safety signal.
+
+    This is the regression test for bug #3 from the impact-analysis bugfix sprint.
+    Guards plan/sprints/bugfix_impact_analysis_validation.md §PR-A.
+
+    Acceptance criteria A1, A2, A5 from the plan:
+    - A1: lost_producer_tables is non-empty; da.lonely is in it.
+    - A2: da.lonely is in result.attribution (deleted file attributed).
+    - A5: blast_radius may be empty (no consumers), but da.lonely is still listed.
+    The rendered hint must NOT contain "No producers lost".
+    """
+    _init_repo(tmp_path)
+
+    # --- Base state: two producer files, NO consumer for da.lonely ---
+    # da.lonely has NO downstream reader → kind stays 'derived' after resync.
+    # da.keeper has a consumer da.consumer (so it becomes kind='table').
+    (tmp_path / "prod.sql").write_text("INSERT INTO da.lonely SELECT id, amount FROM da.source_raw")
+    (tmp_path / "other.sql").write_text("INSERT INTO da.keeper SELECT x FROM da.up")
+    (tmp_path / "consumer.sql").write_text("INSERT INTO da.downstream SELECT k FROM da.keeper")
+    base_sha = _commit_all(tmp_path, "base")
+
+    backend = _make_backend()
+    _index(tmp_path, backend, base_sha)
+
+    # Verify both are producers at base.
+    producers_base = _capture_producer_set(backend)
+    assert "da.lonely" in producers_base, "da.lonely must be a producer at base"
+    assert "da.keeper" in producers_base, "da.keeper must be a producer at base"
+
+    # --- Head state: delete prod.sql (da.lonely loses its sole producer) ---
+    (tmp_path / "prod.sql").unlink()
+    _commit_all(tmp_path, "delete prod.sql — removes sole producer of da.lonely")
+
+    tools._backend = backend
+    tools._metrics = None
+
+    result = get_pr_impact(base_ref=base_sha)
+
+    # A1: da.lonely must appear in lost_producer_tables despite kind='derived'.
+    assert result.lost_producer_tables is not None
+    assert "da.lonely" in result.lost_producer_tables, (
+        f"da.lonely must be detected as a genuine lost producer; got {result.lost_producer_tables}"
+    )
+
+    # A3 / no over-report: da.keeper is still produced — must not appear.
+    assert "da.keeper" not in result.lost_producer_tables, (
+        "da.keeper is still produced — must NOT appear in lost producers"
+    )
+
+    # A2: Attribution must map da.lonely to the deleted file.
+    lonely_files = result.attribution.get("da.lonely", [])
+    assert any("prod.sql" in f for f in lonely_files), (
+        f"prod.sql must appear in attribution for da.lonely; got {lonely_files}"
+    )
+
+    # A5: blast_radius can be empty (no consumers), but the table is still listed.
+    # The hint must NOT carry the false-safety "No producers lost" text.
+    hint = result.hint or ""
+    assert "No producers lost" not in hint, (
+        f"hint must not claim no producers lost when da.lonely was genuinely removed; got: {hint!r}"
+    )
+
+
 def test_modified_still_producing_not_reported(tmp_path):
     """Modifying a file that still writes the same table does NOT report a lost producer.
 

{sql_code_graph-1.33.0 → sql_code_graph-1.33.1}/uv.lock

@@ -2844,7 +2844,7 @@ wheels = [
 
 [[package]]
 name = "sql-code-graph"
-version = "1.33.0"
+version = "1.33.1"
 source = { editable = "." }
 dependencies = [
     { name = "duckdb" },