spots-cli 0.2.0__tar.gz → 0.2.1__tar.gz

{spots_cli-0.2.0 → spots_cli-0.2.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: spots_cli
-Version: 0.2.0
+Version: 0.2.1
 Summary: Spots is a modular music coordination library that unifies multiple providers (e.g. Deezer, Spotify, YouTube) into a single, consistent interface.
 Project-URL: Homepage, https://github.com/mdesignscode/spots_flask
 Project-URL: Issues, https://github.com/mdesignscode/spots_flask

{spots_cli-0.2.0 → spots_cli-0.2.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "spots_cli"
-version = "0.2.0"
+version = "0.2.1"
 authors = [
   { name="Marlon Baatjes", email="marlonbaatjes62@gmail.com" }
 ]

{spots_cli-0.2.0 → spots_cli-0.2.1}/src/spots_cli/app/domain_resolver.py

@@ -27,7 +27,7 @@ class ResolvedDomainResult:
     youtube: YTVideoInfo
 
 
-def _fallback_metadata(video: YTVideoInfo) -> Metadata:
+def fallback_metadata(video: YTVideoInfo) -> Metadata:
     """Builds a bare-bones Metadata object straight from a YouTube result.
 
     Used when no provider (Spotify/Deezer) has metadata for a track, or the
@@ -41,6 +41,7 @@ def _fallback_metadata(video: YTVideoInfo) -> Metadata:
         artist=video.uploader,
         link=video.video_link,
         artist_id="",
+        is_fallback=True,
     )
 
 
@@ -96,7 +97,7 @@ class DomainResolver:
                         f"No provider metadata for '{video_title}', "
                         "falling back to YouTube-derived metadata"
                     )
-                    fallback = _fallback_metadata(video)
+                    fallback = fallback_metadata(video)
                     self.core.storage.new(
                         query=video_title, result=fallback, query_type="metadata"
                     )
@@ -117,7 +118,7 @@ class DomainResolver:
                         f"Provider metadata for '{video_title}' didn't match, "
                         "falling back to YouTube-derived metadata"
                     )
-                    fallback = _fallback_metadata(video)
+                    fallback = fallback_metadata(video)
                     self.core.storage.new(
                         query=video_title, result=fallback, query_type="metadata"
                     )

{spots_cli-0.2.0 → spots_cli-0.2.1}/src/spots_cli/app/media_resolver.py

@@ -4,10 +4,12 @@ from logging import getLogger
 from tenacity import stop_after_delay
 from typing import TYPE_CHECKING, Any, cast
 
+from spots_cli.app.domain_resolver import fallback_metadata
 from spots_cli.engine import retry
 from spots_cli.models import (
     InvalidURL,
     SongNotFound,
+    SpotifyUnavailableError,
     MediaResourceSingle,
     MediaResourcePlaylist,
     PlaylistInfo,
@@ -50,6 +52,13 @@ class MediaResolver:
         """
         # process spotify link
         if "spotify" in url:
+            # a Spotify id means nothing to the other providers
+            if not self.clients.spotify:
+                raise SpotifyUnavailableError(
+                    "Spotify links need Spotify turned on. Run `spots_cli setup` "
+                    "and enable Spotify, or paste the YouTube link instead."
+                )
+
             # single
             if "track" in url:
                 # retrieve Provider data
@@ -187,40 +196,33 @@ class MediaResolver:
                 yt_title = self.core.extractor.build_search_query(
                     video_info.result.uploader, video_info.result.title
                 )
+                # the user picked this video, so it is downloaded either way;
+                # the provider only adds tags (cover, album, lyrics)
                 try:
                     metadata = self.domain.provider_search.search_track(
                         yt_title)
                 except SongNotFound:
-                    self.core.storage.new(
-                        query=yt_title, result=Sentinel(), query_type="metadata"
-                    )
-                    self.core.storage.new(
-                        query=yt_title, result=Sentinel(), query_type="youtube"
-                    )
-                    raise
+                    metadata = None
 
-                tracks_match = self.core.matcher.match_tracks(
+                if metadata is None or not self.core.matcher.match_tracks(
                     metadata=metadata, video_info=video_info.result
-                )
-                if not tracks_match:
-                    self.core.storage.new(
-                        query=yt_title, result=Sentinel(), query_type="metadata"
-                    )
-                    self.core.storage.new(
-                        query=yt_title, result=Sentinel(), query_type="youtube"
-                    )
-                    raise SongNotFound(yt_title)
-                else:
-                    self.core.storage.new(
-                        query=yt_title, result=metadata, query_type="metadata"
-                    )
-                    self.core.storage.new(
-                        query=yt_title, result=video_info.result, query_type="youtube"
-                    )
-                    return MediaResourceSingle(
-                        resource_type="single",
-                        metadata=metadata,
-                        video_info=video_info.result,
+                ):
+                    logger.debug(
+                        f"No matching provider metadata for '{yt_title}', "
+                        "falling back to YouTube-derived metadata"
                     )
+                    metadata = fallback_metadata(video_info.result)
+
+                self.core.storage.new(
+                    query=yt_title, result=metadata, query_type="metadata"
+                )
+                self.core.storage.new(
+                    query=yt_title, result=video_info.result, query_type="youtube"
+                )
+                return MediaResourceSingle(
+                    resource_type="single",
+                    metadata=metadata,
+                    video_info=video_info.result,
+                )
         else:
             raise InvalidURL(url)

{spots_cli-0.2.0 → spots_cli-0.2.1}/src/spots_cli/core/pattern_matcher.py

@@ -141,8 +141,13 @@ class PatternMatcher:
         self.extractor = extractor
 
     def match_tracks(self, *, video_info: YTVideoInfo, metadata: Metadata) -> bool:
-        yt_artist = video_info.uploader or ""
-        yt_title = video_info.title or ""
+        # compare the song, not the raw upload: "Tyla - Water (Official
+        # Music Video)" by Tyla is the song "Water" by "Tyla"
+        cleaned = self.extractor.extract_artist_and_title(
+            video_info=video_info, metadata=metadata
+        )
+        yt_artist = cleaned.artist or video_info.uploader or ""
+        yt_title = cleaned.title or video_info.title or ""
 
         sp_artist = metadata.artist or ""
         sp_title = metadata.title or ""
@@ -164,7 +169,7 @@ class PatternMatcher:
         title_score = token_similarity(yt_title_tokens, sp_title_tokens)
         artist_score = token_similarity(yt_artist_tokens, sp_artist_tokens)
 
-        penalty = uploader_penalty(yt_artist)
+        penalty = uploader_penalty(video_info.uploader or "")
 
         final_score = 0.6 * title_score + 0.3 * artist_score - penalty
 

{spots_cli-0.2.0 → spots_cli-0.2.1}/src/spots_cli/engine/retry.py

@@ -1,18 +1,31 @@
 from tenacity import retry as _retry
 from tenacity import retry_if_exception
 
-from spots_cli.models import SongNotFound
+from spots_cli.models import (
+    InvalidURL,
+    SongNotFound,
+    SpotifyUnavailableError,
+    YouTubeUnavailableError,
+)
+
+# not transient: retrying can't change the answer
+PERMANENT_ERRORS = (
+    InvalidURL,
+    SongNotFound,
+    SpotifyUnavailableError,
+    YouTubeUnavailableError,
+)
 
 
 def is_retryable_exception(exc: BaseException) -> bool:
     # Only retry transient failures
-    return not isinstance(exc, SongNotFound)
+    return not isinstance(exc, PERMANENT_ERRORS)
 
 
 def retry(*args, **kwargs):
     """
     Project-wide retry decorator.
-    - Never retries SongNotFound
+    - Never retries PERMANENT_ERRORS
     - Always re-raises the final exception
     """
 

{spots_cli-0.2.0 → spots_cli-0.2.1}/src/spots_cli/models/metadata.py

@@ -17,6 +17,7 @@ class Metadata:
         preview_url (str | None, optional): A link to a 30 second preview (MP3 format) of the track. Defaults to None.
         artist_cover (str | None, optional): The artist's cover image. Defauls to None.
         artist_id (str): The artist's id.
+        is_fallback (bool): True when no provider had this song, so the tags come from the YouTube title. Defaults to False.
     """
 
     title: str
@@ -30,6 +31,7 @@ class Metadata:
     release_date: str | None = None
     preview_url: str | None = None
     artist_cover: str | None = None
+    is_fallback: bool = False
 
     @property
     def full_title(self):

spots_cli-0.2.1/tests/app/test_media_resolver.py

@@ -0,0 +1,80 @@
+from types import SimpleNamespace
+from unittest.mock import Mock
+
+import pytest
+
+from spots_cli.app.media_resolver import MediaResolver
+from spots_cli.core.pattern_matcher import PatternMatcher
+from spots_cli.core.youtube_extractor import YouTubeExtractor
+from spots_cli.models import Metadata, SongNotFound, SpotifyUnavailableError, YTVideoInfo
+
+LINK = "https://www.youtube.com/watch?v=XoiOOiuH8iI"
+
+
+@pytest.fixture
+def upload() -> YTVideoInfo:
+    return YTVideoInfo(
+        id="XoiOOiuH8iI",
+        title="Tyla - Water (Official Music Video)",
+        uploader="Tyla",
+        audio_ext="webm",
+        filesize=4,
+    )
+
+
+def build_resolver(upload, *, provider_result=None, provider_error=None, spotify=None):
+    extractor = YouTubeExtractor()
+    core = Mock(extractor=extractor, matcher=PatternMatcher(extractor=extractor))
+    domain = Mock()
+    domain.youtube_search.video_search.return_value = SimpleNamespace(
+        is_cached=False, result=upload
+    )
+    if provider_error:
+        domain.provider_search.search_track.side_effect = provider_error
+    else:
+        domain.provider_search.search_track.return_value = provider_result
+    clients = Mock(spotify=spotify)
+    return MediaResolver(core=core, domain=domain, clients=clients, domain_resolver=Mock())
+
+
+def song(title: str, artist: str) -> Metadata:
+    return Metadata(title=title, artist=artist, link="", artist_id="", album=title)
+
+
+def test_youtube_link_uses_matching_provider_metadata(upload):
+    resolver = build_resolver(upload, provider_result=song("Water", "Tyla"))
+
+    resource = resolver.resolve(url=LINK)
+
+    assert resource.metadata.album == "Water"
+    assert not resource.metadata.is_fallback
+    assert resource.video_info is upload
+
+
+def test_youtube_link_without_provider_metadata_still_resolves(upload):
+    resolver = build_resolver(upload, provider_error=SongNotFound("Tyla - Water"))
+
+    resource = resolver.resolve(url=LINK)
+
+    assert resource.metadata.is_fallback
+    assert resource.metadata.artist == "Tyla"
+    assert resource.video_info is upload
+
+
+def test_youtube_link_with_mismatched_provider_metadata_falls_back(upload):
+    resolver = build_resolver(upload, provider_result=song("Truth or Dare", "Tyla"))
+
+    resource = resolver.resolve(url=LINK)
+
+    assert resource.metadata.is_fallback
+    assert resource.metadata.title != "Truth or Dare"
+
+
+def test_spotify_link_needs_spotify_turned_on(upload):
+    resolver = build_resolver(upload)
+
+    with pytest.raises(SpotifyUnavailableError, match="spots_cli setup"):
+        resolver.resolve(url="https://open.spotify.com/track/5aIVCx5tnk0ntmdiinnYvw")
+
+    # not retried, and the Spotify id never reaches another provider
+    resolver.domain.provider_metadata.get.assert_not_called()

spots_cli-0.2.1/tests/core/test_pattern_matcher.py

@@ -0,0 +1,52 @@
+import pytest
+
+from spots_cli.core.pattern_matcher import PatternMatcher
+from spots_cli.core.youtube_extractor import YouTubeExtractor
+from spots_cli.models import Metadata, YTVideoInfo
+
+
+@pytest.fixture
+def matcher() -> PatternMatcher:
+    return PatternMatcher(extractor=YouTubeExtractor())
+
+
+def song(title: str, artist: str) -> Metadata:
+    return Metadata(title=title, artist=artist, link="", artist_id="")
+
+
+def video(title: str, uploader: str) -> YTVideoInfo:
+    return YTVideoInfo(id="x", title=title, uploader=uploader, audio_ext="webm", filesize=4)
+
+
+@pytest.mark.parametrize(
+    "title, uploader",
+    [
+        ("Tyla - Water (Official Music Video)", "Tyla"),
+        ("Tyla - Water (Official Audio)", "Tyla"),
+        ("Tyla - Water", "LatinHype"),
+        ("Water", "Tyla"),
+    ],
+)
+def test_matches_raw_youtube_titles(matcher, title, uploader):
+    assert matcher.match_tracks(video_info=video(title, uploader), metadata=song("Water", "Tyla"))
+
+
+def test_rejects_a_different_song_by_the_same_artist(matcher):
+    raw = video("Tyla - Truth or Dare (Official Video)", "Tyla")
+    assert not matcher.match_tracks(video_info=raw, metadata=song("Water", "Tyla"))
+
+
+def test_does_not_change_the_video(matcher):
+    raw = video("Tyla - Water (Official Music Video)", "Tyla")
+    matcher.match_tracks(video_info=raw, metadata=song("Water", "Tyla"))
+    assert (raw.title, raw.uploader) == ("Tyla - Water (Official Music Video)", "Tyla")
+
+
+def test_song_named_after_the_artist(matcher):
+    raw = video("Tyla - Tyla (Official Video)", "Tyla")
+    assert matcher.match_tracks(video_info=raw, metadata=song("Tyla", "Tyla"))
+
+
+def test_karaoke_channels_are_still_penalised(matcher):
+    raw = video("Tyla - Water (Karaoke Version)", "Sing King Karaoke")
+    assert not matcher.match_tracks(video_info=raw, metadata=song("Water", "Tyla"))