sportsball 0.4.4__tar.gz → 0.4.6__tar.gz

{sportsball-0.4.4/sportsball.egg-info → sportsball-0.4.6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.2
 Name: sportsball
-Version: 0.4.4
+Version: 0.4.6
 Summary: A library for pulling in and normalising sports stats.
 Home-page: https://github.com/8W9aG/sportsball
 Author: Will Sackfield

{sportsball-0.4.4 → sportsball-0.4.6}/setup.py

@@ -26,7 +26,7 @@ def install_requires() -> typing.List[str]:
 
 setup(
     name='sportsball',
-    version='0.4.4',
+    version='0.4.6',
     description='A library for pulling in and normalising sports stats.',
     long_description=long_description,
     long_description_content_type='text/markdown',

{sportsball-0.4.4 → sportsball-0.4.6}/sportsball/__init__.py

@@ -4,4 +4,4 @@
 import cchardet  # type: ignore
 import lxml  # noqa: ignore
 
-__VERSION__ = "0.4.4"
+__VERSION__ = "0.4.6"

{sportsball-0.4.4 → sportsball-0.4.6}/sportsball/data/afl/afltables/afl_afltables_coach_model.py

@@ -3,7 +3,6 @@
 # pylint: disable=too-many-locals
 import datetime
 import io
-import logging
 import os
 import urllib.parse
 from urllib.parse import urlparse
@@ -23,7 +22,7 @@ _COACH_URL_CACHE: dict[str, str] = {}
 
 def _create_afl_afltables_coach_model(
     url: str, session: requests_cache.CachedSession, year: int, dt: datetime.datetime
-) -> CoachModel:
+) -> CoachModel | None:
     html = _COACH_URL_CACHE.get(url)
     if html is None:
         with session.cache_disabled():
@@ -46,14 +45,15 @@ def _create_afl_afltables_coach_model(
         if "-" in year_range:
             start_year, end_year = [int(x) for x in year_range.split("-")]
         else:
-            start_year = end_year = int(year_range)
+            try:
+                start_year = end_year = int(year_range)
+            except ValueError:
+                continue
         if start_year <= year <= end_year:
             name = names[count].strip()
             break
     if name is None:
-        logging.error(html)
-        logging.error(url)
-        raise ValueError("name is null")
+        return None
 
     coach_url = None
     soup = BeautifulSoup(html, "lxml")
@@ -84,13 +84,13 @@ def _create_afl_afltables_coach_model(
 @MEMORY.cache(ignore=["session"])
 def _cached_create_afl_afltables_coach_model(
     url: str, session: requests_cache.CachedSession, year: int, dt: datetime.datetime
-) -> CoachModel:
+) -> CoachModel | None:
     return _create_afl_afltables_coach_model(url=url, session=session, year=year, dt=dt)
 
 
 def create_afl_afltables_coach_model(
     url: str, session: requests_cache.CachedSession, year: int, dt: datetime.datetime
-) -> CoachModel:
+) -> CoachModel | None:
     """Create a coach model from AFL tables."""
     if not pytest_is_running.is_running():
         return _cached_create_afl_afltables_coach_model(

{sportsball-0.4.4 → sportsball-0.4.6}/sportsball/data/afl/afltables/afl_afltables_team_model.py

@@ -106,6 +106,11 @@ def _create_afl_afltables_team_model(
             break
     if coaches_url is None:
         raise ValueError("coaches_url is null")
+
+    coach_model = create_afl_afltables_coach_model(
+        url=coaches_url, session=session, year=dt.year, dt=dt
+    )
+
     return TeamModel(
         identifier=identifier,
         name=name,
@@ -149,11 +154,7 @@ def _create_afl_afltables_team_model(
         news=create_google_news_models(name, session, dt, league),
         social=create_x_social_model(identifier, session, dt),
         field_goals=None,
-        coaches=[
-            create_afl_afltables_coach_model(
-                url=coaches_url, session=session, year=dt.year, dt=dt
-            )
-        ],
+        coaches=[coach_model] if coach_model is not None else [],
         lbw=None,
         end_dt=None,
     )

{sportsball-0.4.4 → sportsball-0.4.6/sportsball.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.2
 Name: sportsball
-Version: 0.4.4
+Version: 0.4.6
 Summary: A library for pulling in and normalising sports stats.
 Home-page: https://github.com/8W9aG/sportsball
 Author: Will Sackfield

{sportsball-0.4.4 → sportsball-0.4.6}/tests/data/afl/afltables/afl_afltables_coach_model_test.py

@@ -14,7 +14,7 @@ class TestAFLTablesCoachModel(unittest.TestCase):
         self._session = requests_cache.CachedSession(backend="memory")
         self.dir = os.path.dirname(__file__)
 
-    def test_dt(self):
+    def test_name(self):
         with requests_mock.Mocker() as m:
             url = "https://afltables.com/afl/stats/coaches/goldcoast.html"
             with open(os.path.join(self.dir, "coaches_goldcoast.html"), "rb") as f:
@@ -28,3 +28,29 @@ class TestAFLTablesCoachModel(unittest.TestCase):
                 dt=datetime.datetime(2012, 10, 10),
             )
             self.assertEqual(coach_model.name, "McKenna, Guy")
+
+    def test_null_coach(self):
+        with requests_mock.Mocker() as m:
+            url = "https://afltables.com/afl/stats/coaches/fitzroy.html"
+            with open(os.path.join(self.dir, "coaches_fitzroy.html"), "rb") as f:
+                m.get(url, content=f.read())
+            coach_model = create_afl_afltables_coach_model(
+                url=url,
+                session=self._session,
+                year=1897,
+                dt=datetime.datetime(2012, 10, 10),
+            )
+            self.assertIsNone(coach_model)
+
+    def test_bad_year_range(self):
+        with requests_mock.Mocker() as m:
+            url = "https://afltables.com/afl/stats/coaches/collingwood.html"
+            with open(os.path.join(self.dir, "coaches_collingwood.html"), "rb") as f:
+                m.get(url, content=f.read())
+            coach_model = create_afl_afltables_coach_model(
+                url=url,
+                session=self._session,
+                year=1897,
+                dt=datetime.datetime(2012, 10, 10),
+            )
+            self.assertIsNone(coach_model)