sportsball 0.4.12__tar.gz → 0.4.14__tar.gz

{sportsball-0.4.12/sportsball.egg-info → sportsball-0.4.14}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.2
 Name: sportsball
-Version: 0.4.12
+Version: 0.4.14
 Summary: A library for pulling in and normalising sports stats.
 Home-page: https://github.com/8W9aG/sportsball
 Author: Will Sackfield

{sportsball-0.4.12 → sportsball-0.4.14}/setup.py

@@ -26,7 +26,7 @@ def install_requires() -> typing.List[str]:
 
 setup(
     name='sportsball',
-    version='0.4.12',
+    version='0.4.14',
     description='A library for pulling in and normalising sports stats.',
     long_description=long_description,
     long_description_content_type='text/markdown',

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/__init__.py

@@ -4,4 +4,4 @@
 import cchardet  # type: ignore
 import lxml  # noqa: ignore
 
-__VERSION__ = "0.4.12"
+__VERSION__ = "0.4.14"

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/afl/afl/afl_afl_league_model.py

@@ -7,12 +7,12 @@ import re
 import urllib.parse
 from typing import Iterator
 
-import requests_cache
 from bs4 import BeautifulSoup, Tag
 from dateutil.parser import parse
 from playwright.sync_api import Playwright, sync_playwright
 
 from ....playwright import ensure_install
+from ....proxy_session import ProxySession
 from ...game_model import GameModel
 from ...league import League
 from ...league_model import LeagueModel
@@ -22,7 +22,7 @@ from .afl_afl_game_model import create_afl_afl_game_model, parse_players_v1
 
 def _parse_v1(
     soup: BeautifulSoup,
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     ladder: list[str],
     html_url: str,
     playwright: Playwright,
@@ -143,7 +143,7 @@ def _parse_v2_soup(
 
 def _parse_v2(
     soup: BeautifulSoup,
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     ladder: list[str],
     html_url: str,
     playwright: Playwright,
@@ -163,7 +163,7 @@ def _parse_v2(
 
 def _parse_game_info(
     html: str,
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     ladder: list[str],
     html_url: str,
     playwright: Playwright,
@@ -180,9 +180,7 @@ def _parse_game_info(
 class AFLAFLLeagueModel(LeagueModel):
     """AFL AFL implementation of the league model."""
 
-    def __init__(
-        self, session: requests_cache.CachedSession, position: int | None = None
-    ) -> None:
+    def __init__(self, session: ProxySession, position: int | None = None) -> None:
         super().__init__(League.AFL, session, position=position)
 
     @classmethod

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/afl/afltables/afl_afltables_league_model.py

@@ -8,11 +8,11 @@ import urllib.parse
 from typing import Iterator
 from urllib.parse import urlparse
 
-import requests_cache
 import tqdm
 from bs4 import BeautifulSoup
 from dateutil import parser
 
+from ....proxy_session import ProxySession
 from ...game_model import GameModel
 from ...league import League
 from ...league_model import LeagueModel
@@ -42,9 +42,7 @@ def _find_dt(td_text: str, season_url: str) -> datetime.datetime:
 class AFLAFLTablesLeagueModel(LeagueModel):
     """AFL AFLTables implementation of the league model."""
 
-    def __init__(
-        self, session: requests_cache.CachedSession, position: int | None = None
-    ) -> None:
+    def __init__(self, session: ProxySession, position: int | None = None) -> None:
         super().__init__(League.AFL, session)
 
     @classmethod

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/afl/aussportsbetting/afl_aussportsbetting_league_model.py

@@ -1,7 +1,6 @@
 """AFL aussportsbetting league model."""
 
-import requests_cache
-
+from ....proxy_session import ProxySession
 from ...aussportsbetting.aussportsbetting_league_model import \
     AusSportsBettingLeagueModel
 from ...league import League
@@ -10,9 +9,7 @@ from ...league import League
 class AFLAusSportsBettingLeagueModel(AusSportsBettingLeagueModel):
     """AFL AusSportsBetting implementation of the league model."""
 
-    def __init__(
-        self, session: requests_cache.CachedSession, position: int | None = None
-    ) -> None:
+    def __init__(self, session: ProxySession, position: int | None = None) -> None:
         super().__init__(League.AFL, session, position=position)
 
     @classmethod

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/afl/combined/afl_combined_league_model.py

@@ -1,7 +1,6 @@
 """AFL combined league model."""
 
-import requests_cache
-
+from ....proxy_session import ProxySession
 from ...combined.combined_league_model import CombinedLeagueModel
 from ...league import League
 from ..afl.afl_afl_league_model import AFLAFLLeagueModel
@@ -269,9 +268,7 @@ AFL_VENUE_IDENTITY_MAP = {
 class AFLCombinedLeagueModel(CombinedLeagueModel):
     """AFL combined implementation of the league model."""
 
-    def __init__(
-        self, session: requests_cache.CachedSession, league_filter: str | None
-    ) -> None:
+    def __init__(self, session: ProxySession, league_filter: str | None) -> None:
         super().__init__(
             session,
             League.AFL,

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/afl/espn/afl_espn_league_model.py

@@ -2,8 +2,7 @@
 
 # pylint: disable=line-too-long
 
-import requests_cache
-
+from ....proxy_session import ProxySession
 from ...espn.espn_league_model import ESPNLeagueModel
 from ...league import League
 
@@ -13,9 +12,7 @@ _SEASON_URL = "https://sports.core.api.espn.com/v2/sports/australian-football/le
 class AFLESPNLeagueModel(ESPNLeagueModel):
     """AFL ESPN implementation of the league model."""
 
-    def __init__(
-        self, session: requests_cache.CachedSession, position: int | None = None
-    ) -> None:
+    def __init__(self, session: ProxySession, position: int | None = None) -> None:
         super().__init__(_SEASON_URL, League.AFL, session, position=position)
 
     @classmethod

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/afl/oddsportal/afl_oddsportal_league_model.py

@@ -2,8 +2,7 @@
 
 # pylint: disable=line-too-long
 
-import requests_cache
-
+from ....proxy_session import ProxySession
 from ...league import League
 from ...oddsportal.oddsportal_league_model import OddsPortalLeagueModel
 
@@ -11,9 +10,7 @@ from ...oddsportal.oddsportal_league_model import OddsPortalLeagueModel
 class AFLOddsPortalLeagueModel(OddsPortalLeagueModel):
     """AFL OddsPortal implementation of the league model."""
 
-    def __init__(
-        self, session: requests_cache.CachedSession, position: int | None = None
-    ) -> None:
+    def __init__(self, session: ProxySession, position: int | None = None) -> None:
         super().__init__(League.AFL, session, position=position)
 
     @classmethod

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/aussportsbetting/aussportsbetting_league_model.py

@@ -4,11 +4,11 @@
 from io import BytesIO
 from typing import Any, Iterator
 
-import requests_cache
 import tqdm
 from dateutil.parser import parse
 from openpyxl import load_workbook
 
+from ...proxy_session import ProxySession
 from ..game_model import GameModel
 from ..league import League
 from ..league_model import LeagueModel
@@ -21,7 +21,7 @@ class AusSportsBettingLeagueModel(LeagueModel):
     def __init__(
         self,
         league: League,
-        session: requests_cache.CachedSession,
+        session: ProxySession,
         position: int | None = None,
     ) -> None:
         super().__init__(league, session, position=position)

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/combined/combined_league_model.py

@@ -6,8 +6,7 @@ import multiprocessing
 from concurrent.futures import ThreadPoolExecutor
 from typing import Any, Iterator
 
-import requests_cache
-
+from ...proxy_session import ProxySession
 from ..game_model import GameModel
 from ..league import League
 from ..league_model import LeagueModel
@@ -23,7 +22,7 @@ class CombinedLeagueModel(LeagueModel):
 
     def __init__(
         self,
-        session: requests_cache.CachedSession,
+        session: ProxySession,
         league: League,
         league_models: list[LeagueModel],
         league_filter: str | None,

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/espn/espn_league_model.py

@@ -3,9 +3,9 @@
 # pylint: disable=too-many-locals,too-many-arguments
 from typing import Any, Iterator
 
-import requests_cache
 import tqdm
 
+from ...proxy_session import ProxySession
 from ..game_model import GameModel
 from ..league import League
 from ..league_model import LeagueModel
@@ -32,7 +32,7 @@ class ESPNLeagueModel(LeagueModel):
         self,
         start_url: str,
         league: League,
-        session: requests_cache.CachedSession,
+        session: ProxySession,
         position: int | None = None,
     ) -> None:
         super().__init__(league, session, position=position)

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/espn/espn_player_model.py

@@ -50,8 +50,7 @@ def _create_espn_player_model(
     try:
         birth_date = parse(athlete_dict["dateOfBirth"]).date()
     except KeyError:
-        logging.error(athlete_response.url)
-        raise
+        logging.warning("Failed to get birth date for %s", athlete_response.url)
 
     birth_place = athlete_dict["birthPlace"]
     return PlayerModel(

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/google/google_address_model.py

@@ -15543,6 +15543,25 @@ _CACHED_GEOCODES: dict[str, Any] = {
         housenumber="",
         country="Spain",
     ),
+    "Corinthians Arena - Sao Paulo": SportsballGeocodeTuple(
+        city="Sao Paulo",
+        state="",
+        postal="",
+        lat=-23.54525,
+        lng=-46.474278,
+        housenumber="",
+        country="Brazil",
+    ),
+    "AT&T Stadium, Arlington, TX, USA": ATT_STADIUM,
+    "Brandon, MS, USA": SportsballGeocodeTuple(
+        city="Brandon",
+        state="MS",
+        postal="",
+        lat=32.280278,
+        lng=-89.998333,
+        housenumber="",
+        country="USA",
+    ),
 }
 
 

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/hkjc/hkjc/hkjc_hkjc_coach_model.py

@@ -4,19 +4,18 @@ import io
 
 import pandas as pd
 import pytest_is_running
-import requests_cache
 
 from ....cache import MEMORY
-from ....proxy_session import X_NO_WAYBACK
+from ....proxy_session import ProxySession
 from ...coach_model import CoachModel
 
 
 def _create_hkjc_hkjc_coach_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     url: str,
 ) -> CoachModel:
-    headers = {X_NO_WAYBACK: "1"}
-    response = session.get(url, headers=headers)
+    with session.wayback_disabled():
+        response = session.get(url)
     response.raise_for_status()
 
     handle = io.StringIO()
@@ -49,14 +48,14 @@ def _create_hkjc_hkjc_coach_model(
 
 @MEMORY.cache(ignore=["session"])
 def _cached_create_hkjc_hkjc_coach_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     url: str,
 ) -> CoachModel:
     return _create_hkjc_hkjc_coach_model(session=session, url=url)
 
 
 def create_hkjc_hkjc_coach_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     url: str,
 ) -> CoachModel:
     """Create a coach model based off HKJC."""

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/hkjc/hkjc/hkjc_hkjc_game_model.py

@@ -9,11 +9,11 @@ from urllib.parse import urlparse
 
 import pandas as pd
 import pytest_is_running
-import requests_cache
 from bs4 import BeautifulSoup
 from dateutil.parser import parse
 
 from ....cache import MEMORY
+from ....proxy_session import ProxySession
 from ...game_model import GameModel
 from ...league import League
 from ..position import position_from_str
@@ -28,7 +28,7 @@ RACE_COURSE_QUERY_KEY = "Racecourse"
 
 
 def _create_hkjc_hkjc_game_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     html: str,
     url: str,
 ) -> GameModel | None:
@@ -279,7 +279,7 @@ def _create_hkjc_hkjc_game_model(
 
 @MEMORY.cache(ignore=["session"])
 def _cached_create_hkjc_hkjc_game_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     html: str,
     url: str,
 ) -> GameModel | None:
@@ -288,7 +288,7 @@ def _cached_create_hkjc_hkjc_game_model(
 
 
 def create_hkjc_hkjc_game_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     html: str,
     url: str,
 ) -> GameModel | None:

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/hkjc/hkjc/hkjc_hkjc_league_model.py

@@ -6,11 +6,10 @@ import urllib.parse
 from typing import Iterator
 from urllib.parse import urlparse
 
-import requests_cache
 import tqdm
 from bs4 import BeautifulSoup
 
-from ....proxy_session import X_NO_WAYBACK
+from ....proxy_session import ProxySession
 from ...game_model import GameModel
 from ...league import League
 from ...league_model import LeagueModel
@@ -23,9 +22,7 @@ from .hkjc_hkjc_venue_model import HAPPY_VALLEY_VENUE_CODE, SHA_TIN_VENUE_CODE
 class HKJCHKJCLeagueModel(LeagueModel):
     """HKJC HKJC implementation of the league model."""
 
-    def __init__(
-        self, session: requests_cache.CachedSession, position: int | None = None
-    ) -> None:
+    def __init__(self, session: ProxySession, position: int | None = None) -> None:
         super().__init__(League.HKJC, session, position=position)
 
     @classmethod
@@ -37,10 +34,10 @@ class HKJCHKJCLeagueModel(LeagueModel):
         def games_for_date(dt: datetime.date) -> Iterator[GameModel]:
             dt_str = dt.strftime("%Y/%m/%d")
             for course in [SHA_TIN_VENUE_CODE, HAPPY_VALLEY_VENUE_CODE]:
-                response = self.session.get(
-                    f"https://racing.hkjc.com/racing/information/English/Racing/LocalResults.aspx?{RACE_DATE_QUERY_KEY}={dt_str}&{RACE_COURSE_QUERY_KEY}={course}&{RACE_NUMBER_QUERY_KEY}=1",
-                    headers={X_NO_WAYBACK: "1"},
-                )
+                with self.session.wayback_disabled():
+                    response = self.session.get(
+                        f"https://racing.hkjc.com/racing/information/English/Racing/LocalResults.aspx?{RACE_DATE_QUERY_KEY}={dt_str}&{RACE_COURSE_QUERY_KEY}={course}&{RACE_NUMBER_QUERY_KEY}=1",
+                    )
                 response.raise_for_status()
                 game_model = create_hkjc_hkjc_game_model(
                     self.session, response.text, response.url
@@ -61,7 +58,8 @@ class HKJCHKJCLeagueModel(LeagueModel):
                         continue
                     if query[RACE_COURSE_QUERY_KEY][0] != course:
                         continue
-                    response = self.session.get(url, headers={X_NO_WAYBACK: "1"})
+                    with self.session.wayback_disabled():
+                        response = self.session.get(url)
                     response.raise_for_status()
                     game_model = create_hkjc_hkjc_game_model(
                         self.session, response.text, response.url

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/hkjc/hkjc/hkjc_hkjc_player_model.py

@@ -8,11 +8,10 @@ from urllib.parse import urlparse
 
 import pandas as pd
 import pytest_is_running
-import requests_cache
 from bs4 import BeautifulSoup
 
 from ....cache import MEMORY
-from ....proxy_session import X_NO_WAYBACK
+from ....proxy_session import ProxySession
 from ...google.google_address_model import create_google_address_model
 from ...player_model import PlayerModel
 from ...sex import sex_from_str
@@ -22,15 +21,15 @@ from .hkjc_hkjc_owner_model import create_hkjc_hkjc_owner_model
 
 
 def _create_hkjc_hkjc_player_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     url: str,
     jersey: str | None,
     handicap_weight: float | None,
     starting_position: Position | None,
     weight: float | None,
 ) -> PlayerModel | None:
-    headers = {X_NO_WAYBACK: "1"}
-    response = session.get(url, headers=headers)
+    with session.wayback_disabled():
+        response = session.get(url)
     response.raise_for_status()
 
     o = urlparse(url)
@@ -42,13 +41,12 @@ def _create_hkjc_hkjc_player_model(
     dfs = []
     try:
         dfs = pd.read_html(handle)
-    except AttributeError as exc:
-        logging.warning(str(exc))
     except ValueError:
         if not is_sire:
             logging.error(response.text)
             logging.error(url)
-            raise
+            logging.error(response.url)
+            return None
 
     soup = BeautifulSoup(response.text, "lxml")
     for noscript in soup.find_all("noscript"):
@@ -65,7 +63,7 @@ def _create_hkjc_hkjc_player_model(
     age = None
     birth_address = None
     owner = None
-    if o.path.endswith("/Horse/Horse.aspx"):
+    if o.path.endswith("/Horse/Horse.aspx") or o.path.endswith("/Horse/OtherHorse.aspx"):
         species = Species.HORSE
         for count, df in enumerate(dfs):
             if count == 0:
@@ -124,6 +122,7 @@ def _create_hkjc_hkjc_player_model(
         logging.error(dfs)
         logging.error(o.path)
         logging.error(url)
+        logging.error(response.url)
         raise ValueError("name is null")
 
     return PlayerModel(
@@ -177,7 +176,7 @@ def _create_hkjc_hkjc_player_model(
 
 @MEMORY.cache(ignore=["session"])
 def _cached_create_hkjc_hkjc_player_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     url: str,
     jersey: str | None,
     handicap_weight: float | None,
@@ -195,7 +194,7 @@ def _cached_create_hkjc_hkjc_player_model(
 
 
 def create_hkjc_hkjc_player_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     url: str,
     jersey: str | None,
     handicap_weight: float | None,

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/hkjc/hkjc/hkjc_hkjc_team_model.py

@@ -4,9 +4,9 @@
 import datetime
 
 import pytest_is_running
-import requests_cache
 
 from ....cache import MEMORY
+from ....proxy_session import ProxySession
 from ...odds_model import OddsModel
 from ...team_model import TeamModel
 from ..position import Position
@@ -15,7 +15,7 @@ from .hkjc_hkjc_player_model import create_hkjc_hkjc_player_model
 
 
 def _create_hkjc_hkjc_team_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     horse_url: str,
     jockey_url: str | None,
     trainer_url: str | None,
@@ -75,7 +75,7 @@ def _create_hkjc_hkjc_team_model(
 
 @MEMORY.cache(ignore=["session"])
 def _cached_create_hkjc_hkjc_team_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     horse_url: str,
     jockey_url: str | None,
     trainer_url: str | None,
@@ -105,7 +105,7 @@ def _cached_create_hkjc_hkjc_team_model(
 
 
 def create_hkjc_hkjc_team_model(
-    session: requests_cache.CachedSession,
+    session: ProxySession,
     horse_url: str,
     jockey_url: str | None,
     trainer_url: str | None,

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/league_model.py

@@ -5,11 +5,11 @@ import datetime
 from typing import Iterator, get_args, get_origin
 
 import pandas as pd
-import requests_cache
 import tqdm
 from flatten_json import flatten  # type: ignore
 from pydantic import BaseModel
 
+from ..proxy_session import ProxySession
 from .address_model import ADDRESS_TIMEZONE_COLUMN
 from .field_type import FieldType
 from .game_model import GAME_DT_COLUMN, VENUE_COLUMN_PREFIX, GameModel
@@ -76,7 +76,7 @@ class LeagueModel(Model):
     def __init__(
         self,
         league: League,
-        session: requests_cache.CachedSession,
+        session: ProxySession,
         position: int | None = None,
     ) -> None:
         super().__init__(session)

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/model.py

@@ -2,21 +2,20 @@
 
 # pylint: disable=too-few-public-methods
 import pandas as pd
-import requests_cache
 
-from ..proxy_session import create_proxy_session
+from ..proxy_session import ProxySession, create_proxy_session
 
 
 class Model:
     """The base model class."""
 
-    _session: requests_cache.CachedSession | None
+    _session: ProxySession | None
 
-    def __init__(self, session: requests_cache.CachedSession) -> None:
+    def __init__(self, session: ProxySession) -> None:
         self._session = session
 
     @property
-    def session(self) -> requests_cache.CachedSession:
+    def session(self) -> ProxySession:
         """Fetch a session that can never be null."""
         session = self._session
         if session is None:

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/nba/combined/nba_combined_league_model.py

@@ -2,8 +2,7 @@
 
 # pylint: disable=line-too-long
 
-import requests_cache
-
+from ....proxy_session import ProxySession
 from ...combined.combined_league_model import CombinedLeagueModel
 from ...league import League
 from ..espn.nba_espn_league_model import NBAESPNLeagueModel
@@ -897,9 +896,7 @@ NBA_PLAYER_IDENTITY_MAP: dict[str, str] = {}
 class NBACombinedLeagueModel(CombinedLeagueModel):
     """NBA combined implementation of the league model."""
 
-    def __init__(
-        self, session: requests_cache.CachedSession, league_filter: str | None
-    ) -> None:
+    def __init__(self, session: ProxySession, league_filter: str | None) -> None:
         super().__init__(
             session,
             League.NBA,

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/nba/espn/nba_espn_league_model.py

@@ -1,7 +1,6 @@
 """NBA ESPN league model."""
 
-import requests_cache
-
+from ....proxy_session import ProxySession
 from ...espn.espn_league_model import ESPNLeagueModel
 from ...league import League
 from ..position import Position
@@ -14,9 +13,7 @@ _SEASON_URL = (
 class NBAESPNLeagueModel(ESPNLeagueModel):
     """NBA ESPN implementation of the league model."""
 
-    def __init__(
-        self, session: requests_cache.CachedSession, position: int | None = None
-    ) -> None:
+    def __init__(self, session: ProxySession, position: int | None = None) -> None:
         super().__init__(_SEASON_URL, League.NBA, session, position=position)
 
     @classmethod

{sportsball-0.4.12 → sportsball-0.4.14}/sportsball/data/nba/nba/nba_nba_league_model.py

@@ -4,13 +4,13 @@ import datetime
 from typing import Iterator, TypedDict
 
 import pandas as pd
-import requests_cache
 import tqdm
 from dateutil.parser import parse
 from dateutil.relativedelta import relativedelta
 from nba_api.library.http import NBAHTTP  # type: ignore
 from nba_api.stats.endpoints import leaguegamefinder  # type: ignore
 
+from ....proxy_session import ProxySession
 from ...game_model import GameModel
 from ...league import League
 from ...league_model import LeagueModel
@@ -67,9 +67,7 @@ class NBANBALeagueModel(LeagueModel):
         start: datetime.datetime
         games: int
 
-    def __init__(
-        self, session: requests_cache.CachedSession, position: int | None = None
-    ) -> None:
+    def __init__(self, session: ProxySession, position: int | None = None) -> None:
         super().__init__(League.NBA, session, position=position)
         self._league_id = "00"
         NBAHTTP.set_session(session)