splent-cli 1.48.2__tar.gz → 1.49.0__tar.gz

{splent_cli-1.48.2/src/splent_cli.egg-info → splent_cli-1.49.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: splent_cli
-Version: 1.48.2
+Version: 1.49.0
 Summary: SPLENT-CLI is a CLI to be able to work on your development more easily.
 Author-email: DiversoLab <diversolab@us.es>
 License-Expression: LGPL-3.0-or-later

{splent_cli-1.48.2 → splent_cli-1.49.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "splent_cli"
-version = "1.48.2"
+version = "1.49.0"
 description = "SPLENT-CLI is a CLI to be able to work on your development more easily."
 readme = "README.md"
 requires-python = ">=3.13"

{splent_cli-1.48.2 → splent_cli-1.49.0}/src/splent_cli/cli.py

@@ -45,6 +45,41 @@ def _quiet_unless(debug: bool):
         logging.disable(logging.NOTSET)
 
 
+@contextlib.contextmanager
+def _held_logs(debug: bool):
+    """Hold what is logged while the app is built here, for a command that
+    may run in the product's web container instead.
+
+    A build that fails on a package the CLI's image lacks hands the command
+    to the web container, which builds the app again and says there all
+    the build has to say. What the attempt here logged first (the features'
+    warnings, the traceback of the import that failed) came before it, as
+    if the command had failed. Yields the records held, which
+    :func:`_replay` hands to their loggers when the command does not move
+    after all. SPLENT_DEBUG shows them as they happen.
+    """
+    held: list[tuple[logging.Logger, logging.LogRecord]] = []
+    if debug:
+        yield held
+        return
+    handle = logging.Logger.handle
+
+    def hold(logger, record):
+        held.append((logger, record))
+
+    logging.Logger.handle = hold
+    try:
+        yield held
+    finally:
+        logging.Logger.handle = handle
+
+
+def _replay(held) -> None:
+    """Log what :func:`_held_logs` held, as it would have been logged."""
+    for logger, record in held:
+        logger.handle(record)
+
+
 class SPLENTCLI(click.Group):
     """
     Main SPLENT CLI class.
@@ -211,14 +246,18 @@ class SPLENTCLI(click.Group):
             if context.is_override():
                 self._delegate_to_the_product(ctx)
 
+            debug = bool(os.getenv("SPLENT_DEBUG"))
             try:
-                app = get_app()
+                with _held_logs(debug) as held:
+                    app = get_app()
             except Exception as exc:
                 missing = _missing_module(exc)
                 if missing is None:
+                    _replay(held)
                     raise
                 # Only then: where the app builds here, the command runs here
                 # with the tools the CLI image has (ruff formats migrations).
+                # The web container builds it again and logs what it logs.
                 self._delegate_to_the_product(ctx)
                 product = context.active_app() or "The product"
                 raise click.ClickException(
@@ -227,6 +266,7 @@ class SPLENTCLI(click.Group):
                     "  Start the product (splent product:up --dev) and run the "
                     "command again: it then runs in the product's web container."
                 ) from exc
+            _replay(held)
             if getattr(command, "requires_db", False):
                 if not check_db_connection(app):
                     raise SystemExit(1)

{splent_cli-1.48.2 → splent_cli-1.49.0}/src/splent_cli/commands/cache/cache_clear.py

@@ -39,8 +39,8 @@ def _validate_feature(ctx, param, value):
         or (at and not _plain(version, _VERSION_RE))
     ):
         raise click.BadParameter(
-            "must be a feature name such as splent_feature_auth, optionally"
-            " with a namespace and a version (splent-io/splent_feature_auth@v1.2.0)."
+            "must be a feature name such as splent_feature_notes, optionally"
+            " with a namespace and a version (splent-io/splent_feature_notes@v1.2.0)."
         )
     ns, name, version = parse_feature_entry(value)
     return {

{splent_cli-1.48.2 → splent_cli-1.49.0}/src/splent_cli/commands/clear/clear_uploads.py

@@ -289,8 +289,8 @@ def clear_uploads(env_dev, env_prod, yes):
 
     if not yes:
         click.confirm(
-            f"Delete every file in {uploads_dir}? The datasets and documents "
-            "the app serves from it cannot be recovered.",
+            f"Delete every file in {uploads_dir}? What the features stored "
+            "there, and the app serves from it, cannot be recovered.",
             abort=True,
         )
 

{splent_cli-1.48.2 → splent_cli-1.49.0}/src/splent_cli/commands/feature/feature_contract.py

@@ -21,10 +21,12 @@ from pathlib import Path
 
 from splent_cli.services import context
 from splent_cli.commands.feature.feature_release import (
+    REVISION_ID_MAX,
     _interactive,
     infer_contract,
     merge_preserved,
     requirement_problems,
+    revision_id_problems,
     write_contract,
 )
 from splent_cli.utils.feature_resolution import package_identifier, resolve_feature_ref
@@ -444,7 +446,25 @@ def feature_contract(feature_ref, write, inject_config):
         for problem in problems:
             click.secho(f"     {problem}", fg="red")
         click.echo(
-            '     Write a short name with an optional PEP 440 specifier, such as "auth>=1.20.0".'
+            '     Write a short name with an optional PEP 440 specifier, such as "notes>=1.20.0".'
+        )
+        raise SystemExit(1)
+
+    # A migration no database can record: refused here, in the dry run too,
+    # as feature:release refuses it, before anyone releases it.
+    long_ids = revision_id_problems(str(cache_path), name)
+    if long_ids:
+        click.secho(
+            f"  ❌ These revision ids are longer than the {REVISION_ID_MAX} "
+            "characters alembic_version.version_num holds:",
+            fg="red",
+        )
+        for problem in long_ids:
+            click.secho(f"     {problem}", fg="red")
+        click.echo(
+            "     The upgrade would run the migration and then fail to record "
+            "it.\n     Shorten the revision id, and every down_revision that "
+            "names it."
         )
         raise SystemExit(1)