specsmith 0.18.0.dev686__tar.gz → 0.18.0.dev691__tar.gz

{specsmith-0.18.0.dev686/src/specsmith.egg-info → specsmith-0.18.0.dev691}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: specsmith
-Version: 0.18.0.dev686
+Version: 0.18.0.dev691
 Summary: AEE governance toolkit for AI-assisted development — session preflight gates, multi-agent dispatch, requirements↔test traceability, ESDB persistence, MCP server, and skills for Warp, Cursor, Claude Code, Copilot, Windsurf, and Aider.
 Author: Layer1Labs Silicon, Inc.
 License-Expression: MIT

{specsmith-0.18.0.dev686 → specsmith-0.18.0.dev691}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "specsmith"
-version = "0.18.0.dev686"
+version = "0.18.0.dev691"
 description = "AEE governance toolkit for AI-assisted development — session preflight gates, multi-agent dispatch, requirements↔test traceability, ESDB persistence, MCP server, and skills for Warp, Cursor, Claude Code, Copilot, Windsurf, and Aider."
 readme = "README.md"
 license = "MIT"

{specsmith-0.18.0.dev686 → specsmith-0.18.0.dev691}/src/specsmith/esdb/__init__.py

@@ -136,7 +136,10 @@ def open_default_store(
 
     from pathlib import Path
 
-    root = Path(str(project_root)).resolve()
+    # CodeQL py/path-injection: use os.path.realpath (recognised normaliser);
+    # the filesystem-path containment checks live in SqliteStore.__init__ and
+    # _maybe_promote_sqlite_to_chrono where the actual sinks are.
+    root = Path(_os.path.realpath(str(project_root)))
 
     # Priority 1: explicit override
     if _os.environ.get("SPECSMITH_ESDB_BACKEND", "").strip().lower() == "sqlite":
@@ -172,7 +175,11 @@ def _maybe_promote_sqlite_to_chrono(root: "object", chrono: "object") -> None:
     from pathlib import Path as _Path
 
     try:
-        sqlite_path = _Path(str(root)) / ".specsmith" / "esdb.sqlite3"
+        _r = os.path.realpath(str(root))
+        _sp = os.path.realpath(os.path.join(_r, ".specsmith", "esdb.sqlite3"))
+        if _sp != _r and not _sp.startswith(_r + os.sep):
+            return
+        sqlite_path = _Path(_sp)
         if not sqlite_path.exists():
             return
 

{specsmith-0.18.0.dev686 → specsmith-0.18.0.dev691}/src/specsmith/esdb/sqlite_store.py

@@ -150,8 +150,15 @@ class SqliteStore:
     """
 
     def __init__(self, project_root: str | Path) -> None:
-        self.root = Path(project_root).resolve()
-        self._db_path = self.root / ".specsmith" / _DB_FILENAME
+        # CodeQL py/path-injection: normalize with os.path.realpath AND assert the
+        # DB path stays within the project root (containment), then store the
+        # sanitised values so the open() sinks (mkdir/connect) receive clean paths.
+        _root = os.path.realpath(str(project_root))
+        _db = os.path.realpath(os.path.join(_root, ".specsmith", _DB_FILENAME))
+        if _db != _root and not _db.startswith(_root + os.sep):
+            raise ValueError(f"Database path escapes project root: {_db!r}")
+        self.root = Path(_root)
+        self._db_path = Path(_db)
         self._conn: sqlite3.Connection | None = None
         self._open: bool = False
 
@@ -415,10 +422,15 @@ class SqliteStore:
         Returns a dict with counts: ``{"requirements": N, "testcases": M, "skipped": K}``.
         Already-present records (by ID) are updated in-place.
         """
-        state_dir = Path(specsmith_dir)
+        # CodeQL py/path-injection: normalize + containment-check each JSON path
+        # before the .exists()/.read_text() sinks below.
+        _state = os.path.realpath(str(specsmith_dir))
         counts: dict[str, int] = {"requirements": 0, "testcases": 0, "skipped": 0}
 
-        req_path = state_dir / "requirements.json"
+        _req = os.path.realpath(os.path.join(_state, "requirements.json"))
+        if _req != _state and not _req.startswith(_state + os.sep):
+            raise ValueError(f"Path escapes state directory: {_req!r}")
+        req_path = Path(_req)
         if req_path.exists():
             try:
                 reqs = json.loads(req_path.read_text(encoding="utf-8"))
@@ -439,7 +451,10 @@ class SqliteStore:
             except (OSError, ValueError):
                 counts["skipped"] += 1  # file unreadable or invalid JSON
 
-        test_path = state_dir / "testcases.json"
+        _test = os.path.realpath(os.path.join(_state, "testcases.json"))
+        if _test != _state and not _test.startswith(_state + os.sep):
+            raise ValueError(f"Path escapes state directory: {_test!r}")
+        test_path = Path(_test)
         if test_path.exists():
             try:
                 tests = json.loads(test_path.read_text(encoding="utf-8"))

{specsmith-0.18.0.dev686 → specsmith-0.18.0.dev691}/src/specsmith/governance_logic.py

@@ -98,10 +98,23 @@ def run_preflight(
     # traces the py/path-injection sanitiser inline; selecting between two
     # already-sanitised Paths does not re-taint.  infer_scope handles a
     # non-existent path gracefully (returns an empty scope).
-    _req_md_docs = Path(os.path.realpath(os.path.join(_safe_root, "docs", "REQUIREMENTS.md")))
-    _req_md_root = Path(os.path.realpath(os.path.join(_safe_root, "REQUIREMENTS.md")))
+    # CodeQL py/path-injection requires normalize (realpath) AND containment
+    # (startswith root), not normalization alone. Build each candidate as a
+    # realpath string, assert it stays within _safe_root, then wrap in Path so
+    # the sanitised value flows into infer_scope() and the .is_file() sinks.
+    _docs_str = os.path.realpath(os.path.join(_safe_root, "docs", "REQUIREMENTS.md"))
+    if _docs_str != _safe_root and not _docs_str.startswith(_safe_root + os.sep):
+        raise ValueError(f"Path escapes project root: {_docs_str!r}")
+    _root_md_str = os.path.realpath(os.path.join(_safe_root, "REQUIREMENTS.md"))
+    if _root_md_str != _safe_root and not _root_md_str.startswith(_safe_root + os.sep):
+        raise ValueError(f"Path escapes project root: {_root_md_str!r}")
+    _repo_idx_str = os.path.realpath(os.path.join(_safe_root, ".repo-index", "files.json"))
+    if _repo_idx_str != _safe_root and not _repo_idx_str.startswith(_safe_root + os.sep):
+        raise ValueError(f"Path escapes project root: {_repo_idx_str!r}")
+    _req_md_docs = Path(_docs_str)
+    _req_md_root = Path(_root_md_str)
     _req_md = _req_md_docs if _req_md_docs.is_file() else _req_md_root
-    _repo_idx = Path(os.path.realpath(os.path.join(_safe_root, ".repo-index", "files.json")))
+    _repo_idx = Path(_repo_idx_str)
     scope = infer_scope(
         utterance,
         _req_md,
@@ -122,7 +135,10 @@ def run_preflight(
     # Read requirements machine-state using os.path.join on the clean _root_str
     # so CodeQL traces the full sanitisation chain without re-tainting via Path.
     rq_records: list[Any] = []
-    rq_path = Path(os.path.realpath(os.path.join(_safe_root, ".specsmith", "requirements.json")))
+    rq_str = os.path.realpath(os.path.join(_safe_root, ".specsmith", "requirements.json"))
+    if rq_str != _safe_root and not rq_str.startswith(_safe_root + os.sep):
+        raise ValueError(f"Path escapes project root: {rq_str!r}")
+    rq_path = Path(rq_str)
     if rq_path.is_file():
         try:
             _rq = _json.loads(rq_path.read_text(encoding="utf-8"))
@@ -139,7 +155,10 @@ def run_preflight(
     # Read test-case machine-state (same rationale as above).
     test_case_ids: list[str] = []
     tc_records: list[Any] = []
-    tc_path = Path(os.path.realpath(os.path.join(_safe_root, ".specsmith", "testcases.json")))
+    tc_str = os.path.realpath(os.path.join(_safe_root, ".specsmith", "testcases.json"))
+    if tc_str != _safe_root and not tc_str.startswith(_safe_root + os.sep):
+        raise ValueError(f"Path escapes project root: {tc_str!r}")
+    tc_path = Path(tc_str)
     if tc_path.is_file():
         try:
             _tc = _json.loads(tc_path.read_text(encoding="utf-8"))

{specsmith-0.18.0.dev686 → specsmith-0.18.0.dev691/src/specsmith.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: specsmith
-Version: 0.18.0.dev686
+Version: 0.18.0.dev691
 Summary: AEE governance toolkit for AI-assisted development — session preflight gates, multi-agent dispatch, requirements↔test traceability, ESDB persistence, MCP server, and skills for Warp, Cursor, Claude Code, Copilot, Windsurf, and Aider.
 Author: Layer1Labs Silicon, Inc.
 License-Expression: MIT