specfuse-loop 0.23.2__tar.gz → 0.23.3__tar.gz

{specfuse_loop-0.23.2/specfuse_loop.egg-info → specfuse_loop-0.23.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: specfuse-loop
-Version: 0.23.2
+Version: 0.23.3
 Summary: Local-first executor for the Specfuse Plan + Work Unit gate-cycle methodology.
 Author: Specfuse contributors
 License: Apache-2.0

{specfuse_loop-0.23.2 → specfuse_loop-0.23.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "specfuse-loop"
-version = "0.23.2"
+version = "0.23.3"
 description = "Local-first executor for the Specfuse Plan + Work Unit gate-cycle methodology."
 readme = "README.md"
 requires-python = ">=3.10"

specfuse_loop-0.23.3/specfuse/loop/data/VERSION

@@ -0,0 +1 @@
+0.23.3

{specfuse_loop-0.23.2 → specfuse_loop-0.23.3}/specfuse/loop/loop.py

@@ -125,7 +125,7 @@ SPECFUSE_DIR = Path(".specfuse")
 REPO_ROOT = SPECFUSE_DIR.parent
 FEATURES_DIR = SPECFUSE_DIR / "features"
 VERIFICATION_PATH = SPECFUSE_DIR / "verification.yml"
-DRIVER_VERSION = "0.23.2"
+DRIVER_VERSION = "0.23.3"
 # Oldest scaffold layout this driver can drive. init.sh stamps the scaffold's own
 # version into `.specfuse/VERSION`; check_scaffold_version() fails loud at startup if
 # the consumer's scaffold is older than this, pointing at `specfuse upgrade`. Bump

{specfuse_loop-0.23.2 → specfuse_loop-0.23.3}/specfuse/loop/red_on_base.py

@@ -52,6 +52,12 @@ from pathlib import Path
 from typing import Any, Callable, Optional
 
 
+#: POSIX reserves these for the shell's own failure to run the command: 126 is
+#: "found but not executable", 127 is "not found". Neither says anything about
+#: the test, so neither may be read as a verdict on it (#3403).
+_COULD_NOT_EXECUTE = frozenset({126, 127})
+
+
 def select_test_files(changed_files: Any, test_paths: Any) -> list:
     """The changed files that live under a declared test root.
 
@@ -126,6 +132,19 @@ def test_was_red_on_base(
         code = getattr(result, "returncode", None)
         if not isinstance(code, int):
             return None
+        if code in _COULD_NOT_EXECUTE:
+            # The shell could not run the command at all. That is "the check
+            # never ran", not "the test failed" -- and the difference is the
+            # whole point of keeping those two declining reasons apart.
+            #
+            # Measured: an operator whose command is a committed script hits
+            # this on every PR whose merge base predates that script. The
+            # worktree is the BASE tree, so the script is simply absent there,
+            # `sh` exits 127, and reading that as red would let the merge
+            # through on the strength of a command that never ran. Fail-open,
+            # in the one guardrail whose entire job is to be harder to satisfy
+            # than the others.
+            return None
         # Non-zero at the base is the proof we want: the test the PR adds does
         # not hold on the tree the fix was written against.
         return code != 0

{specfuse_loop-0.23.2 → specfuse_loop-0.23.3/specfuse_loop.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: specfuse-loop
-Version: 0.23.2
+Version: 0.23.3
 Summary: Local-first executor for the Specfuse Plan + Work Unit gate-cycle methodology.
 Author: Specfuse contributors
 License: Apache-2.0

{specfuse_loop-0.23.2 → specfuse_loop-0.23.3}/tests/test_red_on_base_probe.py

@@ -248,5 +248,47 @@ class TheCommandGetsAShell(unittest.TestCase):
         self.assertIn("'tests/c;d.py'", seen["argv"][2])
 
 
+class ACommandThatCannotRunIsUnverified(unittest.TestCase):
+    """127 is the shell saying it could not run the command, not a verdict.
+
+    Reading it as "red on base" is fail-OPEN, in the one guardrail whose whole
+    job is to be harder to satisfy than the other six.
+
+    Measured on a real repository: the operator's command was a committed
+    script, the probe's worktree is the BASE tree, and on every PR whose merge
+    base predates that script the file is simply absent. `sh` exits 127 and the
+    merge proceeded on the strength of a command that never ran.
+    """
+
+    def _tmp(self) -> Path:
+        tmp = TemporaryDirectory()
+        self.addCleanup(tmp.cleanup)
+        return Path(tmp.name)
+
+    def _verdict_for(self, exit_code):
+        def runner(argv, **kw):
+            if argv[:2] == ["git", "worktree"]:
+                return SimpleNamespace(returncode=0, stdout="", stderr="")
+            return SimpleNamespace(returncode=exit_code, stdout="", stderr="")
+
+        return test_was_red_on_base(
+            runner, base_sha="abc123", test_files=["tests/test_a.py"],
+            command_template="./scripts/probe.sh {tests}",
+            worktree_root=self._tmp(),
+        )
+
+    def test_command_not_found_is_unverified(self):
+        self.assertIsNone(self._verdict_for(127))
+
+    def test_command_not_executable_is_unverified(self):
+        self.assertIsNone(self._verdict_for(126))
+
+    def test_an_ordinary_test_failure_is_still_red(self):
+        self.assertIs(True, self._verdict_for(1))
+
+    def test_a_pass_is_still_not_red(self):
+        self.assertIs(False, self._verdict_for(0))
+
+
 if __name__ == "__main__":  # pragma: no cover
     unittest.main()

specfuse_loop-0.23.2/specfuse/loop/data/VERSION

@@ -1 +0,0 @@
-0.23.2