specfact-cli 0.46.0__tar.gz → 0.46.2__tar.gz

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: specfact-cli
-Version: 0.46.0
+Version: 0.46.2
 Summary: The swiss knife CLI for agile DevOps teams. Keep backlog, specs, tests, and code in sync with validation and contract enforcement for new projects and long-lived codebases.
 Project-URL: Homepage, https://github.com/nold-ai/specfact-cli
 Project-URL: Repository, https://github.com/nold-ai/specfact-cli.git
@@ -308,7 +308,7 @@ uvx specfact-cli code review run --path . --scope full
 **Sample output:**
 
 ```text
-SpecFact CLI - v0.46.0
+SpecFact CLI - v0.46.1
 
 Running Ruff checks...
 Running Radon complexity checks...
@@ -361,16 +361,27 @@ It exists because delivery drifts in predictable ways:
 
 ## Add SpecFact to your workflow
 
-**Pre-commit hook**
+### Pre-commit hook
+
+This repository uses a **modular** local hook layout (parity with `specfact-cli-modules`: `fail_fast`,
+separate verify / format / YAML / Markdown / workflow / lint / Block 2 hooks). If you copy
+[`.pre-commit-config.yaml`](.pre-commit-config.yaml) into another repo, you must also vendor the
+referenced `scripts/*.sh` entrypoints (at minimum `scripts/pre-commit-quality-checks.sh`,
+`scripts/pre-commit-verify-modules.sh`, and `scripts/git-branch-module-signature-flag.sh`) so hook
+`entry:` paths resolve. Alternatively, skip vendoring the modular file and use the remote hook below.
+
+For a **single-hook** setup in downstream repos, keep using the stable id and script shim:
 
 ```yaml
 - repo: https://github.com/nold-ai/specfact-cli
-  rev: v0.46.0
+  rev: v0.46.1
   hooks:
     - id: specfact-smart-checks
 ```
 
-**GitHub Actions**
+The shim runs `scripts/pre-commit-quality-checks.sh all` (full pipeline including module verify).
+
+### GitHub Actions
 
 ```yaml
 - name: SpecFact Gate

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/README.md

@@ -27,7 +27,7 @@ uvx specfact-cli code review run --path . --scope full
 **Sample output:**
 
 ```text
-SpecFact CLI - v0.46.0
+SpecFact CLI - v0.46.1
 
 Running Ruff checks...
 Running Radon complexity checks...
@@ -80,16 +80,27 @@ It exists because delivery drifts in predictable ways:
 
 ## Add SpecFact to your workflow
 
-**Pre-commit hook**
+### Pre-commit hook
+
+This repository uses a **modular** local hook layout (parity with `specfact-cli-modules`: `fail_fast`,
+separate verify / format / YAML / Markdown / workflow / lint / Block 2 hooks). If you copy
+[`.pre-commit-config.yaml`](.pre-commit-config.yaml) into another repo, you must also vendor the
+referenced `scripts/*.sh` entrypoints (at minimum `scripts/pre-commit-quality-checks.sh`,
+`scripts/pre-commit-verify-modules.sh`, and `scripts/git-branch-module-signature-flag.sh`) so hook
+`entry:` paths resolve. Alternatively, skip vendoring the modular file and use the remote hook below.
+
+For a **single-hook** setup in downstream repos, keep using the stable id and script shim:
 
 ```yaml
 - repo: https://github.com/nold-ai/specfact-cli
-  rev: v0.46.0
+  rev: v0.46.1
   hooks:
     - id: specfact-smart-checks
 ```
 
-**GitHub Actions**
+The shim runs `scripts/pre-commit-quality-checks.sh all` (full pipeline including module verify).
+
+### GitHub Actions
 
 ```yaml
 - name: SpecFact Gate

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "specfact-cli"
-version = "0.46.0"
+version = "0.46.2"
 description = "The swiss knife CLI for agile DevOps teams. Keep backlog, specs, tests, and code in sync with validation and contract enforcement for new projects and long-lived codebases."
 readme = "README.md"
 requires-python = ">=3.11"
@@ -209,7 +209,8 @@ validate-prompts = "python tools/validate_prompts.py"
 test = "pytest {args}"
 test-cov = "pytest --cov=src --cov-report=term-missing {args}"
 type-check = "basedpyright --pythonpath $(python -c 'import sys; print(sys.executable)') {args}"
-lint = "ruff format . --check && basedpyright --pythonpath $(python -c 'import sys; print(sys.executable)') && ruff check . && pylint src tests tools && python scripts/verify_safe_project_writes.py"
+# basedpyright --level error: suppress warning noise in pre-commit (Block 1 runs `hatch run lint`).
+lint = "ruff format . --check && basedpyright --level error --pythonpath $(python -c 'import sys; print(sys.executable)') && ruff check . && pylint src tests tools && python scripts/verify_safe_project_writes.py"
 governance = "pylint src tests tools --reports=y --output-format=parseable"
 format = "ruff check . --fix && ruff format ."
 
@@ -236,7 +237,8 @@ check-cross-site-links = "python scripts/check-cross-site-links.py"
 doc-frontmatter-check = "python scripts/check_doc_frontmatter.py"
 validate-agent-rule-signals = "python scripts/validate_agent_rule_applies_when.py"
 check-version-sources = "python scripts/check_version_sources.py"
-release = "python scripts/check_version_sources.py"
+check-pypi-ahead = "python scripts/check_local_version_ahead_of_pypi.py"
+release = "python scripts/check_local_version_ahead_of_pypi.py && python scripts/check_version_sources.py"
 docs-validate = "python scripts/check-docs-commands.py && python scripts/check-cross-site-links.py --warn-only && python scripts/check_doc_frontmatter.py && python scripts/validate_agent_rule_applies_when.py"
 
 # Legacy entry (kept for compatibility); prefer `workflows-lint` above
@@ -286,7 +288,6 @@ contract-prune = "python tools/migrate_tests_to_contracts.py --prune --dry-run"
 # Pre-commit hooks
 pre-commit-install = "bash scripts/setup-git-hooks.sh"
 pre-commit-checks = "bash scripts/pre-commit-smart-checks.sh"
-pre-commit-test = "bash scripts/pre-commit-smart-test.sh"
 
 [tool.hatch.envs.py311]
 python = "3.11"

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/__init__.py

@@ -3,4 +3,4 @@ SpecFact CLI - Spec→Contract→Sentinel tool for contract-driven development.
 """
 
 # Package version: keep in sync with pyproject.toml, setup.py, src/specfact_cli/__init__.py
-__version__ = "0.46.0"
+__version__ = "0.46.2"

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/__init__.py

@@ -45,6 +45,6 @@ def _bootstrap_bundle_paths() -> None:
 
 _bootstrap_bundle_paths()
 
-__version__ = "0.46.0"
+__version__ = "0.46.2"
 
 __all__ = ["__version__"]

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/adapters/ado.py

@@ -54,7 +54,7 @@ console = Console()
 
 @dataclass(frozen=True, slots=True)
 class _AdoCreatedWorkItemRef:
-    work_item_id: Any
+    work_item_id: int | str
     work_item_url: str
     org: str
     project: str
@@ -744,7 +744,10 @@ class AdoAdapter(BridgeAdapter, BacklogAdapterMixin, BacklogAdapter):
             },
         }
         source_tracking = proposal_data.get("source_tracking")
-        if source_tracking is None:
+        if isinstance(source_tracking, list):
+            cast(list[dict[str, Any]], source_tracking).append(tracking_update)
+            return
+        if source_tracking is None or (isinstance(source_tracking, dict) and len(source_tracking) == 0):
             proposal_data["source_tracking"] = tracking_update
             return
         if isinstance(source_tracking, dict):
@@ -752,11 +755,6 @@ class AdoAdapter(BridgeAdapter, BacklogAdapterMixin, BacklogAdapter):
             st.update(tracking_update)
             proposal_data["source_tracking"] = st
             return
-        if isinstance(source_tracking, list):
-            if not source_tracking:
-                proposal_data["source_tracking"] = [tracking_update]
-                return
-            cast(list[dict[str, Any]], source_tracking).append(tracking_update)
 
     def _is_on_premise(self) -> bool:
         """
@@ -2270,8 +2268,10 @@ class AdoAdapter(BridgeAdapter, BacklogAdapterMixin, BacklogAdapter):
         Returns:
             Dict with updated work item data: {"work_item_id": int, "work_item_url": str, "state": str}
         """
-        target_repo = f"{org}/{project}"
-        work_item_id = self._get_source_tracking_work_item_id(proposal_data.get("source_tracking", {}), target_repo)
+        work_item_id = self._get_source_tracking_work_item_id(
+            proposal_data.get("source_tracking", {}),
+            f"{org}/{project}",
+        )
         ado_state = self._resolve_proposal_ado_state(proposal_data)
         work_item_data = self._patch_work_item(
             org,

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/adapters/github.py

@@ -159,7 +159,11 @@ def _get_github_token_from_gh_cli() -> str | None:
     return None
 
 
-_GITHUB_GIT_CONFIG_URL_RE = re.compile(r"(?im)^\s*url\s*=\s*(https?://\S+|ssh://\S+|git://\S+|git@[^:\s]+:\S+)\s*$")
+# Line-anchored so ``pushurl =`` / ``insteadOf`` lines do not match the ``url`` token inside another key.
+# Matches: https://, http://, ssh://, git://, and git@host:path remotes.
+_GITHUB_GIT_CONFIG_URL_RE = re.compile(
+    r"(?m)^\s*url\s*=\s*(https?://[^\s]+|ssh://[^\s]+|git://[^\s]+|git@[^:]+:[^\s]+)"
+)
 
 
 def _git_config_content_indicates_github(config_content: str) -> bool:
@@ -1471,7 +1475,14 @@ class GitHubAdapter(BridgeAdapter, BacklogAdapterMixin, BacklogAdapter):
             title = raw_title
 
         body = self._render_issue_body(
-            _IssueBodyRenderInput(title, description, rationale, impact, change_id, raw_body)
+            _IssueBodyRenderInput(
+                title=title,
+                description=description,
+                rationale=rationale,
+                impact=impact,
+                change_id=change_id,
+                raw_body=raw_body,
+            )
         )
 
         # Check for API token before making request
@@ -1735,7 +1746,15 @@ class GitHubAdapter(BridgeAdapter, BacklogAdapterMixin, BacklogAdapter):
         current_body, current_title, current_state = self._fetch_issue_snapshot(repo_owner, repo_name, issue_number)
         preserved_sections = self._preserved_issue_sections(current_body, change_id)
         body = self._render_issue_body(
-            _IssueBodyRenderInput(title, description, rationale, impact, change_id, raw_body, preserved_sections)
+            _IssueBodyRenderInput(
+                title=title,
+                description=description,
+                rationale=rationale,
+                impact=impact,
+                change_id=change_id,
+                raw_body=raw_body,
+                preserved_sections=preserved_sections,
+            )
         )
 
         # Update issue body via GitHub API PATCH

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/adapters/speckit.py

@@ -462,15 +462,19 @@ class SpecKitAdapter(BridgeAdapter):
             story_title = sd.get("title", "Unknown Story")
             priority = sd.get("priority", "P3")
             acceptance_raw = sd.get("acceptance", [])
-            default_acceptance = [f"{story_title} is implemented"]
             if isinstance(acceptance_raw, list) and acceptance_raw:
                 if all(isinstance(x, str) for x in acceptance_raw):
-                    acceptance = list(acceptance_raw) or default_acceptance
+                    acceptance = [s.strip() for s in acceptance_raw if isinstance(s, str) and s.strip()]
                 else:
-                    extracted = self._extract_text_list(cast(list[Any], acceptance_raw))
-                    acceptance = extracted or default_acceptance
+                    acceptance = [
+                        s.strip() for s in self._extract_text_list(cast(list[Any], acceptance_raw)) if s.strip()
+                    ]
+                    if not acceptance:
+                        acceptance = [f"{story_title} is implemented"]
+                if not acceptance:
+                    acceptance = [f"{story_title} is implemented"]
             else:
-                acceptance = default_acceptance
+                acceptance = [f"{story_title} is implemented"]
             story_points = priority_map.get(str(priority), 3)
             stories.append(
                 Story(
@@ -548,14 +552,13 @@ class SpecKitAdapter(BridgeAdapter):
 
         if existing_feature:
             existing_feature.title = payload.feature_title
-            existing_feature.outcomes = (
-                list(payload.outcomes) if payload.outcomes else list(existing_feature.outcomes or [])
-            )
-            existing_feature.acceptance = (
-                list(payload.acceptance) if payload.acceptance else list(existing_feature.acceptance or [])
-            )
+            existing_feature.outcomes = list(payload.outcomes)
+            existing_feature.acceptance = list(payload.acceptance)
             existing_feature.stories = [s.model_copy(deep=True) for s in payload.stories]
             existing_feature.constraints = list(constraints)
+            existing_feature.source_tracking = self._build_speckit_source_tracking(
+                payload.spec_path, payload.bridge_config
+            )
             return
 
         feature = Feature(

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/analyzers/code_analyzer.py

@@ -738,19 +738,8 @@ class CodeAnalyzer:
     @staticmethod
     def _themes_for_import_module(module_name: str, theme_keywords: dict[str, str]) -> set[str]:
         lowered = module_name.lower()
-        tokens = [t for t in re.split(r"[._-]", lowered) if t]
-        top_level = lowered.split(".", 1)[0]
-        found: set[str] = set()
-        for keyword, theme in theme_keywords.items():
-            if keyword == lowered or lowered.startswith(f"{keyword}."):
-                found.add(theme)
-                continue
-            if keyword == top_level or top_level.startswith(f"{keyword}."):
-                found.add(theme)
-                continue
-            if keyword in tokens:
-                found.add(theme)
-        return found
+        segments = {p for p in lowered.replace("-", ".").split(".") if p}
+        return {theme for keyword, theme in theme_keywords.items() if keyword in segments}
 
     def _themes_for_import_node(self, node: ast.Import | ast.ImportFrom, theme_keywords: dict[str, str]) -> set[str]:
         if isinstance(node, ast.Import):
@@ -1745,14 +1734,50 @@ class CodeAnalyzer:
         self.async_patterns[module_name].extend(async_methods)
         return async_methods
 
-    def _detect_async_patterns_parallel(self, tree: ast.AST, file_path: Path) -> list[str]:
+    @staticmethod
+    def _build_ast_parent_map(tree: ast.AST) -> dict[ast.AST, ast.AST | None]:
+        parents: dict[ast.AST, ast.AST | None] = {}
+
+        def visit(node: ast.AST, parent: ast.AST | None) -> None:
+            parents[node] = parent
+            for child in ast.iter_child_nodes(node):
+                visit(child, node)
+
+        visit(tree, None)
+        return parents
+
+    @staticmethod
+    def _function_name_holding_await(parents: dict[ast.AST, ast.AST | None], await_node: ast.Await) -> str | None:
+        current: ast.AST | None = await_node
+        while current is not None:
+            par = parents.get(current)
+            if par is None:
+                return None
+            if isinstance(par, (ast.FunctionDef, ast.AsyncFunctionDef)):
+                return par.name
+            current = par
+        return None
+
+    def _detect_async_patterns_parallel(self, tree: ast.AST, _file_path: Path) -> list[str]:
         """
         Detect async/await patterns in code (thread-safe version).
 
         Returns:
             List of async method/function names
         """
-        return [node.name for node in ast.walk(tree) if isinstance(node, ast.AsyncFunctionDef)]
+        async_methods: list[str] = []
+        parents = self._build_ast_parent_map(tree)
+
+        for node in ast.walk(tree):
+            if isinstance(node, ast.AsyncFunctionDef):
+                async_methods.append(node.name)
+            if not isinstance(node, ast.Await):
+                continue
+            host = self._function_name_holding_await(parents, node)
+            if host and host not in async_methods:
+                async_methods.append(host)
+
+        return async_methods
 
     def _apply_commit_hash_to_matching_features(self, feature_num: str, commit_hash: str) -> None:
         for feature in self.features:

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/analyzers/graph_analyzer.py

@@ -191,22 +191,12 @@ class GraphAnalyzer:
         graph: StrDiGraph,
         module_name: str,
         call_graph: dict[str, list[str]],
-        python_files: list[Path],
+        loaded_contents: list[tuple[str, str]],
     ) -> None:
-        """Add call-graph-derived dependency edges for one module.
-
-        Args:
-            graph: Dependency graph being populated.
-            module_name: Source module name for emitted edges.
-            call_graph: Mapping of caller symbols to callee symbol lists.
-            python_files: Repository Python files used for callee module resolution.
-
-        Returns:
-            None.
-        """
+        """Add directed edges from ``module_name`` to callees that resolve to known graph nodes."""
         for _caller, callees in call_graph.items():
             for callee in callees:
-                callee_module = self._resolve_module_from_function(callee, python_files)
+                callee_module = self._resolve_module_from_function_preloaded(callee, loaded_contents)
                 if callee_module is None or callee_module not in graph:
                     continue
                 graph.add_edge(module_name, callee_module)
@@ -222,6 +212,7 @@ class GraphAnalyzer:
         """Populate graph with edges derived from pyan call graphs (parallel phase 2)."""
         from concurrent.futures import ThreadPoolExecutor, as_completed
 
+        loaded_contents = self._load_python_file_contents_index(python_files)
         executor = ThreadPoolExecutor(max_workers=max_workers)
         completed = 0
         try:
@@ -231,7 +222,7 @@ class GraphAnalyzer:
                 try:
                     call_graph = future.result()
                     module_name = self._path_to_module_name(file_path)
-                    self._add_call_graph_edges_for_module(graph, module_name, call_graph, python_files)
+                    self._add_call_graph_edges_for_module(graph, module_name, call_graph, loaded_contents)
                 except (OSError, RuntimeError):
                     pass
                 completed += 1
@@ -443,24 +434,30 @@ class GraphAnalyzer:
         return self._find_matching_module_suffix_overlap(imported, known_modules)
 
     @beartype
-    @require(lambda function_name: isinstance(function_name, str), "Function name must be str")
     @require(lambda python_files: isinstance(python_files, list), "Python files must be list")
-    @ensure(lambda result: result is None or isinstance(result, str), "Must return None or str")
-    def _resolve_module_from_function(self, function_name: str, python_files: list[Path]) -> str | None:
-        """
-        Resolve module name from function name.
-
-        This is a heuristic - tries to find the module containing the function.
-        """
-        # Simple heuristic: search for function name in files
+    @ensure(lambda result: isinstance(result, list), "Must return list")
+    def _load_python_file_contents_index(self, python_files: list[Path]) -> list[tuple[str, str]]:
+        """Preload (module_name, source_text) pairs once per graph build for callee resolution."""
+        loaded: list[tuple[str, str]] = []
         for file_path in python_files:
             try:
                 content = file_path.read_text(encoding="utf-8")
-                if f"def {function_name}" in content or f"class {function_name}" in content:
-                    return self._path_to_module_name(file_path)
-            except (UnicodeDecodeError, Exception):
+            except (OSError, UnicodeDecodeError):
                 continue
+            loaded.append((self._path_to_module_name(file_path), content))
+        return loaded
 
+    @beartype
+    @require(lambda function_name: isinstance(function_name, str), "Function name must be str")
+    @require(lambda loaded_contents: isinstance(loaded_contents, list), "Loaded contents must be list")
+    @ensure(lambda result: result is None or isinstance(result, str), "Must return None or str")
+    def _resolve_module_from_function_preloaded(
+        self, function_name: str, loaded_contents: list[tuple[str, str]]
+    ) -> str | None:
+        """Resolve module for ``function_name`` using preloaded sources (same heuristic as one-file scan)."""
+        for module_name, content in loaded_contents:
+            if f"def {function_name}" in content or f"class {function_name}" in content:
+                return module_name
         return None
 
     @beartype

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/common/logger_setup.py

@@ -283,7 +283,7 @@ class MessageFlowFormatter(logging.Formatter):
         return formatted_message
 
 
-@dataclass
+@dataclass(slots=True)
 class _FileOutputPipelineConfig:
     logger_name: str
     logger: logging.Logger
@@ -294,6 +294,7 @@ class _FileOutputPipelineConfig:
     append_mode: bool
 
 
+@beartype
 @dataclass
 class LoggerCreateOptions:
     """Options for :meth:`LoggerSetup.create_logger`."""

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/generators/persona_exporter.py

@@ -203,10 +203,10 @@ class PersonaExporter:
             return
         if spec.use_getattr:
             val = getattr(feature, spec.field_name, None)
-            if val:
+            if val is not None:
                 feature_dict[spec.field_name] = val
             return
-        if spec.value:
+        if spec.value is not None:
             feature_dict[spec.field_name] = spec.value
 
     def _merge_feature_optional_sections(

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/generators/test_to_openapi.py

@@ -359,13 +359,7 @@ class OpenAPITestConverter:
         if isinstance(node, ast.Constant):
             return node.value
         if isinstance(node, ast.Dict):
-            result: dict[str, Any] = {}
-            for k, v in zip(node.keys, node.values, strict=True):
-                key = self._extract_ast_value(k) if k else None
-                val = self._extract_ast_value(v)
-                if key is not None:
-                    result[str(key)] = val
-            return result
+            return self._coerce_ast_dict_to_plain(node)
         if isinstance(node, ast.List):
             return [self._extract_ast_value(item) for item in node.elts]
         if isinstance(node, ast.Name):
@@ -380,6 +374,18 @@ class OpenAPITestConverter:
         return None
 
     def _examples_from_parsed_test_file(self, tree: ast.AST, func_name: str | None) -> dict[str, dict[str, Any]]:
+        """Collect OpenAPI-style examples from test functions in a parsed module.
+
+        Args:
+            tree: Parsed AST for a test module.
+            func_name: When set, only this ``test_*`` function is scanned; otherwise every
+                ``test_*`` definition is considered.
+
+        Returns:
+            ``operation_id`` → merged example payload. Keys default to ``\"unknown\"`` when
+            ``operation_id`` is missing. Later ``test_*`` blocks win on duplicate keys inside
+            the merged dict for the same operation.
+        """
         by_operation: dict[str, dict[str, Any]] = {}
         for node in ast.walk(tree):
             if not isinstance(node, ast.FunctionDef):

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/modules/init/module-package.yaml

@@ -1,5 +1,5 @@
 name: init
-version: 0.1.25
+version: 0.1.30
 commands:
   - init
 category: core
@@ -17,5 +17,5 @@ publisher:
 description: Initialize SpecFact workspace and bootstrap local configuration.
 license: Apache-2.0
 integrity:
-  checksum: sha256:4b1d6a9399a5417a213f91a9bf0272986ed52ac8cca53f96b9e1899e028f90b4
-  signature: CfTDUOZ7PrhgJ1+mFg228b+Pvn6crWYaF3hD+jQznXjbn304ONS1g1CePU4JrjBQmeE1RKdoldeAMTHqJ56JCQ==
+  checksum: sha256:9e03421972d3254082307834b474e7673957de8c11ffacc563f2da3f35e7cf05
+  signature: ikUYhUJ8AFU9RkB+ZBnp0lKrDLT7ZIqkauRYUMRY/swrIjRCTRzHIpNcvCmujK6h1w6EtT/+wGG1v5bZtZB8CQ==

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/modules/init/src/first_run_selection.py

@@ -184,7 +184,7 @@ def _install_marketplace_for_bundle(bid: str, marketplace_id: str, deps: _InitBu
     try:
         deps.install_module(
             marketplace_id,
-            InstallModuleOptions(
+            options=InstallModuleOptions(
                 install_root=deps.root,
                 non_interactive=deps.non_interactive,
                 trust_non_official=deps.trust_non_official,

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/registry/module_installer.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import hashlib
+import logging
 import os
 import re
 import shutil
@@ -40,6 +41,7 @@ from specfact_cli.runtime import is_debug_mode
 USER_MODULES_ROOT = Path.home() / ".specfact" / "modules"
 
 
+@beartype
 @dataclass(slots=True)
 class InstallModuleOptions:
     """Options for :func:`install_module`."""
@@ -61,7 +63,7 @@ class _BundleDepsInstallContext:
     trust_non_official: bool
     non_interactive: bool
     force: bool
-    logger: Any
+    logger: logging.Logger
 
 
 MARKETPLACE_MODULES_ROOT = Path.home() / ".specfact" / "marketplace-modules"

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/sync/bridge_watch.py

@@ -32,10 +32,14 @@ def _match_feature_id_from_pattern_parts(pattern_parts: list[str], file_parts: l
         feature_id_index = pattern_parts.index("{feature_id}")
     except ValueError:
         return None
+    if len(file_parts) != len(pattern_parts):
+        return None
     if feature_id_index >= len(file_parts):
         return None
-    for i in range(feature_id_index):
-        if i >= len(file_parts) or pattern_parts[i] != file_parts[i]:
+    for i, part in enumerate(pattern_parts):
+        if part == "{feature_id}":
+            continue
+        if i >= len(file_parts) or file_parts[i] != part:
             return None
     return file_parts[feature_id_index]
 

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/utils/source_scanner.py

@@ -117,8 +117,6 @@ class SourceArtifactMap:
 @dataclass(slots=True)
 class _FeatureLinkingContext:
     repo_path: Path
-    impl_files: list[Path]
-    test_files: list[Path]
     file_functions_cache: dict[str, list[str]]
     file_test_functions_cache: dict[str, list[str]]
     file_hashes_cache: dict[str, str]
@@ -436,8 +434,6 @@ class SourceArtifactScanner:
 
         linking_ctx = _FeatureLinkingContext(
             repo_path=repo_path,
-            impl_files=impl_files,
-            test_files=test_files,
             file_functions_cache=file_functions_cache,
             file_test_functions_cache=file_test_functions_cache,
             file_hashes_cache=file_hashes_cache,

{specfact_cli-0.46.0 → specfact_cli-0.46.2}/src/specfact_cli/validators/cli_first_validator.py

@@ -188,21 +188,29 @@ def detect_direct_manipulation(specfact_dir: Path) -> list[Path]:
 
     # Check project bundles
     projects_dir = specfact_dir / "projects"
-    if not projects_dir.exists():
+    if not projects_dir.is_dir():
         return suspicious_files
 
-    for bundle_dir in projects_dir.iterdir():
-        if not bundle_dir.is_dir():
-            continue
-        manifest_file = bundle_dir / "bundle.manifest.yaml"
-        if manifest_file.exists() and not is_cli_generated(manifest_file):
-            suspicious_files.append(manifest_file)
+    try:
+        bundle_iter = list(projects_dir.iterdir())
+    except OSError:
+        return suspicious_files
 
-        features_dir = bundle_dir / "features"
-        if not features_dir.exists():
+    for bundle_dir in bundle_iter:
+        try:
+            if not bundle_dir.is_dir():
+                continue
+            manifest_file = bundle_dir / "bundle.manifest.yaml"
+            if manifest_file.exists() and not is_cli_generated(manifest_file):
+                suspicious_files.append(manifest_file)
+
+            features_dir = bundle_dir / "features"
+            if not features_dir.is_dir():
+                continue
+            for feature_file in features_dir.glob("*.yaml"):
+                if not is_cli_generated(feature_file):
+                    suspicious_files.append(feature_file)
+        except OSError:
             continue
-        for feature_file in features_dir.glob("*.yaml"):
-            if not is_cli_generated(feature_file):
-                suspicious_files.append(feature_file)
 
     return suspicious_files