spatialdds 0.5.0__tar.gz → 0.5.2__tar.gz

{spatialdds-0.5.0 → spatialdds-0.5.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: spatialdds
-Version: 0.5.0
+Version: 0.5.2
 Summary: SpatialDDS over plain HTTPS and a WebSocket: a client for the web binding (Appendix N), and the reference registry behind one command.
 Author: Open AR Cloud
 License: Apache-2.0
@@ -409,7 +409,26 @@ already worked changed. An embedder with its own source passes
 no write surface at all — which was unreachable before, when keeping
 subscribers connected meant exposing writes.
 
-## Not in 0.5.0
+0.5.1 fixes a defect in 0.4.0's seam that only its first real consumer could
+find: `make_app(command_registry=...)` silently replaced a registry that was
+empty at the time, because `Registry` was falsy when empty and the assignment
+used `or`. Since an embedder must have the app before it can build the backend
+that supplies the handlers, passing an empty registry and filling it a few
+lines later is the normal shape — and every one of those registrations went to
+an object the app had already discarded. If you called `register()` before
+`make_app()`, 0.4.0 and 0.5.0 worked; if you called it after, the command lane
+advertised nothing and refused every POST.
+
+0.5.2 makes `notify` safe from the thread its own docstring invited. It put
+onto the subscriber queue directly, and `asyncio.Queue.put_nowait` from a
+foreign thread enqueues without waking the loop — so a backend reading a bus
+in a thread fed a parked subscriber nothing until the loop woke for some other
+reason. Busy endpoint, invisible; idle endpoint, silent. Measured: a bridge
+pumping 202 samples into two registered subscriber queues delivered 0 live
+events. If you call `notify` only from the serving loop, 0.5.0 and 0.5.1 were
+correct for you.
+
+## Not in 0.5.2
 
 Stated so nobody waits for them: no async API, no caching beyond ETag
 revalidation, no retry policy, no MCAP tooling beyond the journal the server

{spatialdds-0.5.0 → spatialdds-0.5.2}/README.md

@@ -385,7 +385,26 @@ already worked changed. An embedder with its own source passes
 no write surface at all — which was unreachable before, when keeping
 subscribers connected meant exposing writes.
 
-## Not in 0.5.0
+0.5.1 fixes a defect in 0.4.0's seam that only its first real consumer could
+find: `make_app(command_registry=...)` silently replaced a registry that was
+empty at the time, because `Registry` was falsy when empty and the assignment
+used `or`. Since an embedder must have the app before it can build the backend
+that supplies the handlers, passing an empty registry and filling it a few
+lines later is the normal shape — and every one of those registrations went to
+an object the app had already discarded. If you called `register()` before
+`make_app()`, 0.4.0 and 0.5.0 worked; if you called it after, the command lane
+advertised nothing and refused every POST.
+
+0.5.2 makes `notify` safe from the thread its own docstring invited. It put
+onto the subscriber queue directly, and `asyncio.Queue.put_nowait` from a
+foreign thread enqueues without waking the loop — so a backend reading a bus
+in a thread fed a parked subscriber nothing until the loop woke for some other
+reason. Busy endpoint, invisible; idle endpoint, silent. Measured: a bridge
+pumping 202 samples into two registered subscriber queues delivered 0 live
+events. If you call `notify` only from the serving loop, 0.5.0 and 0.5.1 were
+correct for you.
+
+## Not in 0.5.2
 
 Stated so nobody waits for them: no async API, no caching beyond ETag
 revalidation, no retry policy, no MCAP tooling beyond the journal the server

{spatialdds-0.5.0 → spatialdds-0.5.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "spatialdds"
-version = "0.5.0"
+version = "0.5.2"
 description = "SpatialDDS over plain HTTPS and a WebSocket: a client for the web binding (Appendix N), and the reference registry behind one command."
 readme = "README.md"
 requires-python = ">=3.9"

{spatialdds-0.5.0 → spatialdds-0.5.2}/spatialdds/__init__.py

@@ -37,7 +37,7 @@ __all__ = [
     "content_manifest", "geo_anchor", "service_uri", "content_uri",
 ]
 
-__version__ = "0.5.0"
+__version__ = "0.5.2"
 #: The SpatialDDS-spec commit whose Appendix N and generated artifacts this
 #: package implements. Package versions and specification versions move
 #: independently; this is the one that says what the wire looks like.

{spatialdds-0.5.0 → spatialdds-0.5.2}/spatialdds/server/commands.py

@@ -127,5 +127,11 @@ class Registry:
     def types(self) -> list[str]:
         return sorted(self._handlers)
 
-    def __bool__(self) -> bool:
-        return bool(self._handlers)
+    # No `__bool__`. It returned `bool(self._handlers)`, which reads as a
+    # convenience and was a trap: `make_app` had `command_registry or
+    # Registry()`, so an empty registry -- the normal thing to pass, since an
+    # embedder needs the app before it can build the handlers -- was silently
+    # replaced by a fresh one, and every later `register()` was lost. Nothing
+    # else ever used the truthiness. A class whose emptiness is a legitimate
+    # state should not make `or` mean something surprising, so the method is
+    # gone rather than documented around.

{spatialdds-0.5.0 → spatialdds-0.5.2}/spatialdds/server/gw_http.py

@@ -476,6 +476,24 @@ def _written(request: web.Request, doc: Any, created: bool,
                      **_cache_headers(gateway.OPERATOR), **extra})
 
 
+def _running_loop():
+    """The loop running in *this* thread, or None. Never raises."""
+    try:
+        return asyncio.get_running_loop()
+    except RuntimeError:
+        return None
+
+
+async def _remember_loop(app: web.Application) -> None:
+    """Record the serving loop, so `notify` can reach it from a thread.
+
+    An `on_startup` signal rather than `make_app`, because `make_app` is
+    ordinarily called before there is a loop to record -- an embedder builds
+    the app, then hands it to `run_app`.
+    """
+    app["loop"] = asyncio.get_running_loop()
+
+
 def notify(app: web.Application, topic: str, event: dict) -> None:
     """Hand an event to every subscriber currently on that topic.
 
@@ -500,16 +518,38 @@ def notify(app: web.Application, topic: str, event: dict) -> None:
                                     "topic": topic,
                                     "key": key, "data": data})
 
-    Synchronous on purpose: it only puts onto unbounded queues, so there is
-    nothing to await, and a backend reading a DDS bus from a thread can call
-    it without arranging a loop.
+    Synchronous on purpose: there is nothing to await, so a backend reading a
+    DDS bus from a thread can call it without arranging a loop. **That use is
+    now actually safe**, which it was not in 0.5.0 and 0.5.1: this put onto
+    the queue directly, and `asyncio.Queue.put_nowait` from a foreign thread
+    enqueues without waking the selector, so a parked subscriber resumed only
+    when the loop happened to wake for some other reason. On a busy endpoint
+    that is immediate and the bug invisible; on an idle one the events sat
+    unseen. The docstring promised the thread case before the code delivered
+    it, which is the worse half of the defect.
 
     Subscriptions only stay open to be woken when `live_subscriptions` is on
     --- see `make_app`. Calling this against an endpoint serving a finished
     recording is harmless and reaches nobody.
     """
+    loop = app.get("loop")
     for q in list(app["subs"].get(topic, ())):
-        q.put_nowait(event)
+        if loop is None or loop is _running_loop():
+            q.put_nowait(event)
+        else:
+            # `asyncio.Queue.put_nowait` is not thread-safe, and the part
+            # that bites is not the enqueue -- it is the wakeup. It resolves
+            # the parked getter's future directly, and resolving a future
+            # from a foreign thread schedules the callback without waking
+            # the selector, so the subscriber's `await q.get()` resumes only
+            # when the loop next happens to wake for some other reason. On a
+            # busy endpoint that is immediate and the bug is invisible; on an
+            # idle one the events sit in the queue.
+            #
+            # Measured on 2026-10-17: a bridge pumping 202 samples into two
+            # registered subscriber queues delivered 0 live events, while the
+            # same call from the loop thread delivered every one.
+            loop.call_soon_threadsafe(q.put_nowait, event)
 
 
 async def _broadcast(request: web.Request, topic: str, event: dict) -> None:
@@ -876,9 +916,23 @@ def make_app(state: gateway.State, base: str, token: str | None,
     # The N.6 seam. Empty is the normal state: a gateway serving a recording
     # has no verbs, and N.6 says a suite MUST NOT require a command surface
     # to exist. An embedder registers handlers on this.
-    app["commands"] = command_registry or commands.Registry()
+    # `is not None`, not `or`. An empty registry is the normal thing to pass:
+    # an embedder needs the app before it can build the backend that supplies
+    # the handlers, so it passes a registry and populates it a few lines
+    # later. With `or` that registry was silently replaced -- `Registry` used
+    # to be falsy when empty -- and every later `register()` went to an object
+    # the app had already thrown away. Found by the web bridge, whose command
+    # lane advertised nothing and refused every POST while its own registry
+    # held the handler.
+    app["commands"] = (command_registry if command_registry is not None
+                       else commands.Registry())
     app["journal"] = journal
     app["subs"] = {}
+    #: The serving loop, filled in at startup. `notify` needs it to hand an
+    #: event across a thread boundary safely; None until then, which is
+    #: correct -- nothing can be subscribed before the app is running.
+    app["loop"] = None
+    app.on_startup.append(_remember_loop)
     app["assets"] = assets
     app.add_routes([
         web.get("/", root),

{spatialdds-0.5.0 → spatialdds-0.5.2}/spatialdds.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: spatialdds
-Version: 0.5.0
+Version: 0.5.2
 Summary: SpatialDDS over plain HTTPS and a WebSocket: a client for the web binding (Appendix N), and the reference registry behind one command.
 Author: Open AR Cloud
 License: Apache-2.0
@@ -409,7 +409,26 @@ already worked changed. An embedder with its own source passes
 no write surface at all — which was unreachable before, when keeping
 subscribers connected meant exposing writes.
 
-## Not in 0.5.0
+0.5.1 fixes a defect in 0.4.0's seam that only its first real consumer could
+find: `make_app(command_registry=...)` silently replaced a registry that was
+empty at the time, because `Registry` was falsy when empty and the assignment
+used `or`. Since an embedder must have the app before it can build the backend
+that supplies the handlers, passing an empty registry and filling it a few
+lines later is the normal shape — and every one of those registrations went to
+an object the app had already discarded. If you called `register()` before
+`make_app()`, 0.4.0 and 0.5.0 worked; if you called it after, the command lane
+advertised nothing and refused every POST.
+
+0.5.2 makes `notify` safe from the thread its own docstring invited. It put
+onto the subscriber queue directly, and `asyncio.Queue.put_nowait` from a
+foreign thread enqueues without waking the loop — so a backend reading a bus
+in a thread fed a parked subscriber nothing until the loop woke for some other
+reason. Busy endpoint, invisible; idle endpoint, silent. Measured: a bridge
+pumping 202 samples into two registered subscriber queues delivered 0 live
+events. If you call `notify` only from the serving loop, 0.5.0 and 0.5.1 were
+correct for you.
+
+## Not in 0.5.2
 
 Stated so nobody waits for them: no async API, no caching beyond ETag
 revalidation, no retry policy, no MCAP tooling beyond the journal the server