sourcecode 2.5.18__tar.gz → 2.5.19__tar.gz

{sourcecode-2.5.18 → sourcecode-2.5.19}/CHANGELOG.md

@@ -1,5 +1,49 @@
 # Changelog
 
+## [2.5.19] — 2026-07-20
+
+**Engineering Decision Support — Part A, F2: manual validation (guard clauses) is
+now a recognised validation source.** A repo that validates request bodies with
+hand-written null/empty guards instead of Bean Validation was reported as having no
+validation — a confirmed false negative. F2 reuses the β `GuardClause` atom already
+in the Semantic IR rather than adding a parallel extractor. Full suite (3542 passed,
+5 skipped) confirms confinement.
+
+### Fixed
+
+- **F2 — β guard-clause extraction now covers endpoint-kind handler bodies.**
+  `_extract_guard_facts` scanned only `symbol_kind in {method, constructor}`; an
+  annotation-classified handler (`@PostMapping …`) surfaces as `symbol_kind="endpoint"`,
+  so **every guard living in a handler body was silently dropped** — the β atom
+  existed, its coverage did not. The scan now includes endpoint-kind symbols (the same
+  `_scan_guard_clauses`, widened to a kind it skipped). This also lets the impact
+  engine see handler-entry guards it was previously blind to (measured: additive
+  behavioural notes only, each backed by a real atom — e.g. keycloak 34 handler types
+  gain a "null/empty guard" note; petclinic unchanged).
+
+### Added
+
+- **F2 — `manual_validation` request-body pattern in `validation_inference`.** When no
+  Bean Validation is present but body handlers guard their input with null/empty β
+  guard clauses that early-exit, the `validation` command now classifies
+  `manual_validation` (Likely) with a per-endpoint `manual_guard` finding, instead of
+  the old `no_validation_detected`. Scoped to `null_check`/`empty_check`: β's `other`
+  test kind lumps range checks with non-validation guards (availability, memoization,
+  preconditions), so counting it would inflate false positives — range validation is an
+  honest, documented under-report. Bean validation still takes repo-level precedence; a
+  handler that both `@Valid`-s and hand-guards is bean-validated, not manual.
+
+### Validation (real-repo field check)
+
+- **True positive** — eureka `ApplicationResource#addInstance` (POST) validates its
+  request body with an `isBlank(...)` / `== null` guard cascade; previously reported as
+  unvalidated, now `manual_validation`.
+- **True negative preserved** — neo4j stays `no_validation_detected`: its handler guards
+  are database-availability checks (`if (isDatabaseNotAvailable(db)) return`, β
+  `other`), which the `other`-exclusion correctly refuses to call input validation.
+- **No drift** — petclinic stays `bean_validation_active`, jobrunr stays
+  `no_validation_detected`.
+
 ## [2.5.18] — 2026-07-20
 
 **Engineering Decision Support — Part A, F1: standalone OpenAPI specs now reach the

{sourcecode-2.5.18 → sourcecode-2.5.19}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sourcecode
-Version: 2.5.18
+Version: 2.5.19
 Summary: Persistent structural context and ultra-fast repeated analysis for AI coding agents
 License-File: LICENSE
 Keywords: agents,ai,codebase,context,developer-tools,llm

{sourcecode-2.5.18 → sourcecode-2.5.19}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "sourcecode"
-version = "2.5.18"
+version = "2.5.19"
 description = "Persistent structural context and ultra-fast repeated analysis for AI coding agents"
 readme = "README.md"
 requires-python = ">=3.9"

{sourcecode-2.5.18 → sourcecode-2.5.19}/src/sourcecode/__init__.py

@@ -4,4 +4,4 @@ ASK Engine is the product. ``ask`` is the canonical CLI command; ``sourcecode``
 the legacy compatibility alias and the Python/PyPI package name. See
 docs/PRODUCT_IDENTITY.md (normative)."""
 
-__version__ = "2.5.18"
+__version__ = "2.5.19"

{sourcecode-2.5.18 → sourcecode-2.5.19}/src/sourcecode/repository_ir.py

@@ -2475,10 +2475,20 @@ def _scan_guard_clauses(body: str) -> list[dict]:
 
 
 def _extract_guard_facts(symbols: list[SymbolRecord], source: str) -> dict[str, list[dict]]:
-    """Ordered `guard_clause` atoms per method/constructor FQN. Reuses the SAME
-    `_method_body` extraction as the other body facts; the scanner keeps only the
-    structural guard shape (β), on its own occurrence axis."""
-    callers = [s for s in symbols if s.symbol_kind in ("method", "constructor") and s.line]
+    """Ordered `guard_clause` atoms per method/constructor/endpoint FQN. Reuses the
+    SAME `_method_body` extraction as the other body facts; the scanner keeps only
+    the structural guard shape (β), on its own occurrence axis.
+
+    Endpoint-kind bodies are included (F2): an annotation-classified handler
+    (`@PostMapping …`, symbol_kind="endpoint") is still a method body, and a guard
+    that throws on a bad request parameter (`if (x == null || x.isBlank()) throw`)
+    is exactly the manual-validation shape the validation surface must see. The
+    scope was previously method/constructor only, which silently dropped every
+    guard living in a handler body — the atom exists, the coverage did not."""
+    callers = [
+        s for s in symbols
+        if s.symbol_kind in ("method", "constructor", "endpoint") and s.line
+    ]
     if not callers:
         return {}
     raw_lines = source.splitlines()

{sourcecode-2.5.18 → sourcecode-2.5.19}/src/sourcecode/validation_inference.py

@@ -15,20 +15,23 @@ VAI note (§0.5): the only names this module keys on are **published open
 standards** (`jakarta.validation`, `javax.validation`, the bean-validation
 annotation vocabulary). No client / convention name enters a predicate.
 
-ARCHITECTURAL DIVERGENCE — manual_validation (design §2, deferred)
------------------------------------------------------------------
-Design §2 also asks for a `manual_validation` class detected by the **β
-GuardClause** shape on handler bodies (a guard that throws on a bad parameter).
-That path assumes guard atoms cover handlers. They do NOT: `_extract_guard_facts`
-(repository_ir.py) scans only `symbol_kind in {"method", "constructor"}`, and a
-mapped handler surfaces as kind `"endpoint"` — so `guard_facts` is empty for
-every handler body. Design §8 classifies §2 as *Incremental / no new primitive*;
-against the current architecture that is false. Rather than smuggle in an IR
-change under an "Incremental" increment, `manual_validation` is deferred and the
-conflict is documented in the design doc (EPV / INV-2: build the endpoint-scoped
-guard capability only when this consumer is ratified). The three classes that ARE
-reuse-only (active / available-unused / none) ship here and already resolve the
-field defect.
+manual_validation (design §2) — RESOLVED (F2, roadmap Engineering Decision Support)
+-----------------------------------------------------------------------------------
+Design §2 asks for a `manual_validation` class detected by the **β GuardClause**
+shape on handler bodies (a guard that throws/returns on a bad parameter). This was
+previously deferred because `_extract_guard_facts` scanned only
+`symbol_kind in {"method","constructor"}` and a mapped handler surfaces as kind
+`"endpoint"`, so `guard_facts` was empty for every handler body (EPV/INV-2: build
+the endpoint-scoped guard capability only when this consumer is ratified).
+
+Roadmap F2 ratifies the consumer. `_extract_guard_facts` now includes endpoint-kind
+bodies (repository_ir.py) — the SAME β scan widened to a symbol_kind it silently
+skipped, no new atom type — so a handler's entry guards are visible here. This
+module now classifies `manual_validation` from those atoms, scoped to
+null/empty-check guards (β's `other` test_kind lumps range checks with
+non-validation guards like memoization/preconditions, so counting it would inflate
+false positives; range validation is therefore not separately claimed — an honest
+under-report, labelled Likely never Verified).
 """
 from __future__ import annotations
 
@@ -64,6 +67,30 @@ _VALIDATE_MARKERS: frozenset[str] = frozenset({"Valid", "Validated"})
 # Body-carrying HTTP verbs — the surface where request-body validation applies.
 _BODY_VERBS: frozenset[str] = frozenset({"POST", "PUT", "PATCH"})
 
+# β GuardClause test kinds that read as manual input validation (F2). `other`
+# is excluded on purpose: at β it lumps range checks with non-validation guards
+# (memoization, preconditions), so it cannot be claimed as validation.
+_MANUAL_GUARD_TESTS: frozenset[str] = frozenset({"null_check", "empty_check"})
+
+
+def _manual_guarded_handlers(
+    cir: "CanonicalRepositoryIR", handler_symbols: "set[str]"
+) -> set[str]:
+    """Handler symbols carrying ≥1 null/empty β GuardClause that early-exits.
+
+    Every β atom already early-exits (return/throw — `_scan_guard_clauses` records
+    no other shape), so presence of a null/empty atom on a handler body IS the
+    manual-validation signal. Scoped to the handlers actually on the body surface
+    so a guard in an unrelated method never counts."""
+    gf = cir.guard_facts
+    out: set[str] = set()
+    for h in handler_symbols:
+        for atom in gf.get(h, ()) or ():
+            if atom.get("test_kind") in _MANUAL_GUARD_TESTS:
+                out.add(h)
+                break
+    return out
+
 
 def _validation_available(cir: "CanonicalRepositoryIR") -> tuple[bool, list[str]]:
     """True when a published bean-validation framework is on the classpath,
@@ -133,10 +160,11 @@ def infer_validation_pattern(cir: "CanonicalRepositoryIR") -> ValidationInferenc
 
     Repo-level class (DESIGN §2):
       - ``bean_validation_active``            — @Valid present on body handlers.
+      - ``manual_validation``                 — no @Valid, but body handlers guard
+        their input with null/empty β guard clauses that early-exit (Likely).
       - ``bean_validation_available_unused``  — validation on the classpath and
         body endpoints exist, but no handler validates → risk (Likely).
       - ``no_validation_detected``            — none of the above (Unknown).
-        (``manual_validation`` deferred — see module docstring.)
 
     Never raises.
     """
@@ -145,15 +173,30 @@ def infer_validation_pattern(cir: "CanonicalRepositoryIR") -> ValidationInferenc
 
     body_eps = [ep for ep in cir.endpoints if str(ep.method).upper() in _BODY_VERBS]
     body_total = len(body_eps)
+    body_handlers = {ep.handler_symbol for ep in body_eps}
+    manual_handlers = _manual_guarded_handlers(cir, body_handlers)
     validated_body = sum(1 for ep in body_eps if ep.handler_symbol in validated_handlers)
+    # manual guards only "count" where bean validation is absent — a handler that
+    # both @Valid-s and hand-guards is bean-validated, not manual.
+    manual_body = sum(
+        1 for ep in body_eps
+        if ep.handler_symbol in manual_handlers
+        and ep.handler_symbol not in validated_handlers
+    )
     unvalidated_body = body_total - validated_body
 
     # per-endpoint findings (only the body surface — where a request body applies)
     endpoint_findings: list[dict] = []
-    rollup = {"validated": 0, "available_unused": 0, "unvalidated_unknown": 0}
+    rollup = {
+        "validated": 0, "manual_guard": 0,
+        "available_unused": 0, "unvalidated_unknown": 0,
+    }
     for ep in body_eps:
         if ep.handler_symbol in validated_handlers:
             klass, conf = "validated", Confidence.VERIFIED
+        elif ep.handler_symbol in manual_handlers:
+            # hand-written null/empty guard on the handler body → manual validation
+            klass, conf = "manual_guard", Confidence.LIKELY
         elif available:
             # @RequestBody-shaped verb, framework available, no @Valid → gap
             klass, conf = "available_unused", Confidence.LIKELY
@@ -175,11 +218,11 @@ def infer_validation_pattern(cir: "CanonicalRepositoryIR") -> ValidationInferenc
         "the exact @RequestBody parameter count is not captured (no IR atom "
         "exposes it), so 'available_unused' may include body-less handlers."
     )
-    manual_fn = (
-        "manual_validation (a handler that throws on a bad parameter) is not "
-        "detected — guard-clause atoms do not cover endpoint-kind handlers "
-        "(architectural defer, see module docstring); such a repo classifies "
-        "no_validation_detected here."
+    manual_range_fn = (
+        "manual_validation is detected from null/empty β guard clauses only; "
+        "range/other-shaped guards (e.g. `if (n < 0) throw`) are indistinguishable "
+        "at β from non-validation guards and are not counted, so a purely "
+        "range-guarded handler can under-report."
     )
 
     if validated_body > 0:
@@ -193,11 +236,38 @@ def infer_validation_pattern(cir: "CanonicalRepositoryIR") -> ValidationInferenc
                     "validated_body_endpoints": validated_body,
                     "body_endpoints": body_total,
                     "unvalidated_body_endpoints": unvalidated_body,
+                    "manual_guarded_body_endpoints": manual_body,
                     "validation_available": available,
                 },
             ),
             limitations=[common_limitation],
-            fn_causes=[manual_fn],
+            fn_causes=[manual_range_fn],
+        )
+    elif manual_body > 0:
+        pattern = "manual_validation"
+        verdict = Verdict(
+            claim="Request bodies validated by hand-written guard clauses (no bean validation)",
+            confidence=Confidence.LIKELY,
+            evidence=Evidence(
+                atoms_used=[f"null/empty guard: {h}" for h in sorted(manual_handlers)][:50],
+                details={
+                    "body_endpoints": body_total,
+                    "manual_guarded_body_endpoints": manual_body,
+                    "validated_body_endpoints": 0,
+                    "validation_available": available,
+                },
+            ),
+            limitations=[
+                common_limitation,
+                "A null/empty guard is a likely input-validation signal, not a "
+                "proof — it could defend an internal invariant unrelated to the "
+                "request contract.",
+            ],
+            fp_causes=[
+                "A null/empty guard may protect against an internal null rather "
+                "than validate the request body.",
+            ],
+            fn_causes=[manual_range_fn],
         )
     elif available and body_total > 0:
         pattern = "bean_validation_available_unused"
@@ -222,7 +292,7 @@ def infer_validation_pattern(cir: "CanonicalRepositoryIR") -> ValidationInferenc
                 "A body endpoint may be intentionally unvalidated (idempotent "
                 "echo, internal-only), or validated manually.",
             ],
-            fn_causes=[manual_fn],
+            fn_causes=[manual_range_fn],
         )
     else:
         pattern = "no_validation_detected"
@@ -238,7 +308,7 @@ def infer_validation_pattern(cir: "CanonicalRepositoryIR") -> ValidationInferenc
                 "validation import, and no body endpoints, or validation is done "
                 "by a mechanism this projection does not model.",
             ],
-            fn_causes=[manual_fn],
+            fn_causes=[manual_range_fn],
         )
 
     return ValidationInferenceResult(