sourcecode 1.70.0__tar.gz → 1.71.0__tar.gz

{sourcecode-1.70.0 → sourcecode-1.71.0}/CHANGELOG.md

@@ -1,5 +1,68 @@
 # Changelog
 
+## [1.71.0] — 2026-07-01
+
+### Fixed — framework-framing & migration reliability on a large non-Boot Spring repo (Jenkins core field test)
+
+A migration/architecture audit of **jenkins-ci/jenkins** (`e7eef8d2cf`, branch
+`master`; ~1,900 production Java classes, Maven multi-module, uses
+`spring-security-web` but **no Spring MVC, no Spring Boot, no DI container** —
+Jenkins runs on its own Stapler web framework and ACL/SecurityRealm security SPI)
+surfaced five reproducible defects. In every case the engine already computed the
+*correct* internal signal (downgraded confidence, `spring_present`, `not_detected`,
+a prose `coverage_note`) but that signal did not propagate to the high-level field
+an automated consumer reads first. Each fix targets the root cause and adds
+regression coverage. All findings were verified against direct `grep` over the same
+repo.
+
+- **Framework detection — phantom "Spring MVC / Spring AOP" from pom exclusion blocks (BUG #1).**
+  `_frameworks_from_pom` serialized the *entire* pom to text and substring-matched
+  framework tokens, so `<exclude>org.springframework:spring-web</exclude>` and
+  `<exclude>…:spring-aop</exclude>` inside an enforcer bytecode rule in
+  `war/pom.xml` (artifact **exclusions**, not dependencies) read as "uses Spring
+  MVC / Spring AOP". Detection is now restricted to real dependency / plugin /
+  parent **coordinates** (`<exclusion>`/`<exclude>` and comments carry none) — the
+  same discipline the Gradle path already applied (JobRunr fix). The Spring Security
+  token was also broadened to the true-positive `spring-security-web` /
+  `-config` coordinates (Jenkins' real dep), so the honest label survives while the
+  phantoms disappear.
+- **`architecture_summary` — categorical "MVC pattern with … view layers" on a repo with zero controllers (BUG #1).**
+  The `mvc` pattern is a directory-name heuristic. On a Java/Kotlin repo it is now
+  cross-checked against the canonical endpoint extractor in the same run; with no
+  HTTP controllers detected it degrades to a directory-derived "Layered code
+  organization (… — no HTTP controllers detected)" note, dropping the unverified
+  "view" claim rather than asserting MVC.
+- **`migrate-check` — `boot3` dimension applicable without any Spring Boot (BUG #2).**
+  The Boot 2→3 axis was gated on `spring_present` (any `org.springframework.*`
+  coordinate), so a repo carrying only `spring-security-web` received a
+  contaminated `readiness_score` from a migration that does not exist. Applicability
+  now requires **positive evidence**: a `spring-boot*` coordinate / Gradle plugin
+  (`@SpringBootApplication` always ships one), **or** a concrete `spring_boot_3` /
+  `spring_security_6` finding in main code. jakarta findings alone no longer enable
+  boot3. A new `spring_boot_present` flag is surfaced; when N/A the dimension is
+  excluded from the aggregate with a clear reason.
+- **`migrate-check` — `MIG-002` (javax.servlet) counted `@Deprecated` frozen-legacy shims as high blockers (BUG #3).**
+  A namespace-migration finding on a **class-level `@Deprecated`** type (kept for
+  binary compat, with a live replacement — Jenkins `ChainedServletFilter` →
+  `ChainedServletFilter2`) is now classified `code_context="deprecated_shim"` and
+  excluded from `blocking_count`, readiness, and effort, alongside the existing
+  test/generated buckets. A `@Deprecated` **method** on a live class stays blocking.
+  On Jenkins this dropped `blocking_count` from 6 to 2.
+- **`repo-ir` — `security_model` was a bare `"unknown"` string with no reason (BUG #4).**
+  A structured `security_model_detail` companion now mirrors the `not_detected`
+  pattern used elsewhere: `status`, `spring_security_filter_chain_detected`,
+  `annotation_policies_detected`, `custom_spi_detected`, and a `reason` that
+  explicitly notes absence of a *recognized* pattern is not evidence the repo is
+  unsecured (Jenkins uses a custom ACL/SecurityRealm SPI).
+- **`export --integrations` — low count carried no structured coverage flag (BUG #5).**
+  The honest coverage caveat lived only in the prose `coverage_note`. A structured
+  `coverage_confidence` (`low` / `partial` / `high`) plus `coverage_confidence_reason`
+  is now emitted: a large repo (≥300 source files) with <10 recognized constructs is
+  flagged `low` so a consumer cannot read a low count as low external coupling
+  (Jenkins' custom remoting/SCM/Update-Center SPIs are invisible to static matching).
+
+New regression coverage across five suites; full suite green (2,900+ tests).
+
 ## [1.70.0] — 2026-07-01
 
 ### Fixed — reliability & internal-consistency on a large Spring 5 / Hibernate 5 repo (openmrs-core field test)

{sourcecode-1.70.0 → sourcecode-1.71.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sourcecode
-Version: 1.70.0
+Version: 1.71.0
 Summary: Persistent structural context and ultra-fast repeated analysis for AI coding agents
 License-File: LICENSE
 Keywords: agents,ai,codebase,context,developer-tools,llm
@@ -411,7 +411,7 @@ Emits **structured, tool-agnostic** codebase views as plain JSON/YAML — the ki
 |------|--------|
 | `--by-directory` | One group per source directory, each symbol with a `source_file:line` reference. |
 | `--module-graph` | `{nodes, edges, summary}` — directories as modules, inter-module dependencies rolled up from class-level relation edges with hit counts + edge types. |
-| `--integrations` | Outbound integrations across Spring **and** plain-Java/Jakarta stacks: HTTP (`RestTemplate`, `WebClient`, `@FeignClient`, JDK `HttpClient`, Apache, OkHttp), LDAP (`LdapTemplate`, JNDI `InitialDirContext`/`LdapContext`), SMTP (`JavaMailSender`, JavaMail `Transport`/`MimeMessage`), and JMS — with `file:line` evidence and a literal `target` when present. Emits an explicit `confidence` (`observed` / `not_analyzed`) + `coverage_note`: a count of `0` means "no client construct found", **not** "no integrations" (runtime/DI-wired clients are not statically visible). |
+| `--integrations` | Outbound integrations across Spring **and** plain-Java/Jakarta stacks: HTTP (`RestTemplate`, `WebClient`, `@FeignClient`, JDK `HttpClient`, Apache, OkHttp), LDAP (`LdapTemplate`, JNDI `InitialDirContext`/`LdapContext`), SMTP (`JavaMailSender`, JavaMail `Transport`/`MimeMessage`), and JMS — with `file:line` evidence and a literal `target` when present. Emits an explicit `confidence` (`observed` / `not_analyzed`), a structured `coverage_confidence` (`low` / `partial` / `high`) with `coverage_confidence_reason`, and a prose `coverage_note`: a count of `0` — or a low count on a large repo (≥300 files, <10 constructs) — is flagged `low`, so a low count is never read as low external coupling (custom protocol/SPI clients are not statically visible). |
 | `--c4` | Unified document: `c4.{context, containers, components, code}` + `api_surface` + a `manifest` with per-directory content hashes for **incremental** consumers (skip directories whose hash is unchanged). `components.module_roots` rolls leaf source dirs up to architectural module roots and classifies each `layered` (DDD: ≥2 of `domain`/`application`/`infrastructure`) vs `flat` (legacy/flat package), with a verifiable `module_count` — so a consumer enumerates real modules instead of inferring boundaries from leaf directories. |
 
 The section flags compose (pass several for one multi-section document); `--c4` assembles the full export on its own. URLs assembled at runtime yield `target: null` (honest absence, never a guess); containers are derived from build files (Maven/Gradle) and reported as a limitation when none are found.
@@ -734,9 +734,20 @@ evidence. `migrate-check` enforces:
   `hibernate_rewrite` headline. An **unresolved** version degrades to a
   low-confidence hypothesis with no headline blocker. See
   `hibernate.effective_version` / `version_major` / `version_confidence`.
-- **Boot3 auto-disables without Spring.** `boot3.applicable` tracks real Spring
-  usage; Quarkus / Micronaut / Helidon / Jakarta-pure repos report `boot3` as N/A
-  (`spring_present: false`), not a contradictory `applicable: true`.
+- **Boot3 needs Spring _Boot_, not just Spring.** `boot3.applicable` requires
+  positive Spring Boot evidence — a `spring-boot*` coordinate / Gradle plugin (or
+  `@SpringBootApplication`), **or** a concrete `spring_boot_3` / `spring_security_6`
+  finding. A repo that merely carries a Spring library (e.g. `spring-security-web`
+  with no Boot — Jenkins core) reports `boot3` as N/A with a reason and is excluded
+  from the aggregate; `spring_present: true` but `spring_boot_present: false`. Quarkus
+  / Micronaut / Helidon / Jakarta-pure repos likewise report `boot3` N/A. jakarta
+  findings alone never enable boot3.
+- **Frozen-legacy `@Deprecated` shims aren't blockers.** A `javax→jakarta` finding
+  on a **class-level `@Deprecated`** type (kept for binary compat, replaced
+  elsewhere) is classified `code_context: "deprecated_shim"` and excluded from
+  `blocking_count` / readiness / effort — surfaced under `non_blocking` with a
+  "verify before removing" note. A `@Deprecated` **method** on a live class still
+  blocks.
 - **Permanent `javax.*` are never jakarta debt.** JDK/JSR namespaces
   (`javax.cache`, `javax.sql`, `javax.xml` JAXP, `javax.crypto`, `javax.naming`,
   `javax.management`, `javax.security.auth`, `javax.annotation.processing`, …) are

{sourcecode-1.70.0 → sourcecode-1.71.0}/README.md

@@ -373,7 +373,7 @@ Emits **structured, tool-agnostic** codebase views as plain JSON/YAML — the ki
 |------|--------|
 | `--by-directory` | One group per source directory, each symbol with a `source_file:line` reference. |
 | `--module-graph` | `{nodes, edges, summary}` — directories as modules, inter-module dependencies rolled up from class-level relation edges with hit counts + edge types. |
-| `--integrations` | Outbound integrations across Spring **and** plain-Java/Jakarta stacks: HTTP (`RestTemplate`, `WebClient`, `@FeignClient`, JDK `HttpClient`, Apache, OkHttp), LDAP (`LdapTemplate`, JNDI `InitialDirContext`/`LdapContext`), SMTP (`JavaMailSender`, JavaMail `Transport`/`MimeMessage`), and JMS — with `file:line` evidence and a literal `target` when present. Emits an explicit `confidence` (`observed` / `not_analyzed`) + `coverage_note`: a count of `0` means "no client construct found", **not** "no integrations" (runtime/DI-wired clients are not statically visible). |
+| `--integrations` | Outbound integrations across Spring **and** plain-Java/Jakarta stacks: HTTP (`RestTemplate`, `WebClient`, `@FeignClient`, JDK `HttpClient`, Apache, OkHttp), LDAP (`LdapTemplate`, JNDI `InitialDirContext`/`LdapContext`), SMTP (`JavaMailSender`, JavaMail `Transport`/`MimeMessage`), and JMS — with `file:line` evidence and a literal `target` when present. Emits an explicit `confidence` (`observed` / `not_analyzed`), a structured `coverage_confidence` (`low` / `partial` / `high`) with `coverage_confidence_reason`, and a prose `coverage_note`: a count of `0` — or a low count on a large repo (≥300 files, <10 constructs) — is flagged `low`, so a low count is never read as low external coupling (custom protocol/SPI clients are not statically visible). |
 | `--c4` | Unified document: `c4.{context, containers, components, code}` + `api_surface` + a `manifest` with per-directory content hashes for **incremental** consumers (skip directories whose hash is unchanged). `components.module_roots` rolls leaf source dirs up to architectural module roots and classifies each `layered` (DDD: ≥2 of `domain`/`application`/`infrastructure`) vs `flat` (legacy/flat package), with a verifiable `module_count` — so a consumer enumerates real modules instead of inferring boundaries from leaf directories. |
 
 The section flags compose (pass several for one multi-section document); `--c4` assembles the full export on its own. URLs assembled at runtime yield `target: null` (honest absence, never a guess); containers are derived from build files (Maven/Gradle) and reported as a limitation when none are found.
@@ -696,9 +696,20 @@ evidence. `migrate-check` enforces:
   `hibernate_rewrite` headline. An **unresolved** version degrades to a
   low-confidence hypothesis with no headline blocker. See
   `hibernate.effective_version` / `version_major` / `version_confidence`.
-- **Boot3 auto-disables without Spring.** `boot3.applicable` tracks real Spring
-  usage; Quarkus / Micronaut / Helidon / Jakarta-pure repos report `boot3` as N/A
-  (`spring_present: false`), not a contradictory `applicable: true`.
+- **Boot3 needs Spring _Boot_, not just Spring.** `boot3.applicable` requires
+  positive Spring Boot evidence — a `spring-boot*` coordinate / Gradle plugin (or
+  `@SpringBootApplication`), **or** a concrete `spring_boot_3` / `spring_security_6`
+  finding. A repo that merely carries a Spring library (e.g. `spring-security-web`
+  with no Boot — Jenkins core) reports `boot3` as N/A with a reason and is excluded
+  from the aggregate; `spring_present: true` but `spring_boot_present: false`. Quarkus
+  / Micronaut / Helidon / Jakarta-pure repos likewise report `boot3` N/A. jakarta
+  findings alone never enable boot3.
+- **Frozen-legacy `@Deprecated` shims aren't blockers.** A `javax→jakarta` finding
+  on a **class-level `@Deprecated`** type (kept for binary compat, replaced
+  elsewhere) is classified `code_context: "deprecated_shim"` and excluded from
+  `blocking_count` / readiness / effort — surfaced under `non_blocking` with a
+  "verify before removing" note. A `@Deprecated` **method** on a live class still
+  blocks.
 - **Permanent `javax.*` are never jakarta debt.** JDK/JSR namespaces
   (`javax.cache`, `javax.sql`, `javax.xml` JAXP, `javax.crypto`, `javax.naming`,
   `javax.management`, `javax.security.auth`, `javax.annotation.processing`, …) are

{sourcecode-1.70.0 → sourcecode-1.71.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "sourcecode"
-version = "1.70.0"
+version = "1.71.0"
 description = "Persistent structural context and ultra-fast repeated analysis for AI coding agents"
 readme = "README.md"
 requires-python = ">=3.9"

{sourcecode-1.70.0 → sourcecode-1.71.0}/src/sourcecode/__init__.py

@@ -1,3 +1,3 @@
 """sourcecode — Deterministic codebase context maps for AI coding agents."""
 
-__version__ = "1.70.0"
+__version__ = "1.71.0"

{sourcecode-1.70.0 → sourcecode-1.71.0}/src/sourcecode/architecture_summary.py

@@ -142,6 +142,7 @@ class ArchitectureSummarizer:
         # Line 2: architecture pattern + layers
         if arch and arch.pattern not in (None, "unknown", "flat"):
             arch_line = self._describe_arch_pattern(arch)
+            arch_line = self._qualify_web_pattern(arch, arch_line, sm)
             if arch_line:
                 lines.append(arch_line)
 
@@ -227,6 +228,32 @@ class ArchitectureSummarizer:
         self._endpoint_support_cache = (total, high)
         return self._endpoint_support_cache
 
+    def _qualify_web_pattern(self, arch: Any, arch_line: str, sm: SourceMap) -> str:
+        """BUG #1 (Jenkins field test): the "mvc" pattern is a directory-name
+        heuristic (dirs matching controller/model/view keywords). On a Java/Kotlin
+        repo, do not assert "MVC pattern with ... view layers" in prose when the
+        canonical endpoint extractor finds no HTTP controllers in the same run —
+        Jenkins (Stapler web framework) matches model/view-ish dirs but declares
+        zero Spring MVC controllers. Cross-check against `endpoints` and degrade to
+        a consistent, non-committal phrasing instead of a categorical MVC claim."""
+        if not arch_line or arch.pattern not in ("mvc", "spring_mvc_layered"):
+            return arch_line
+        primary = next((s for s in sm.stacks if s.primary), sm.stacks[0] if sm.stacks else None)
+        if primary is None or primary.stack not in {"java", "kotlin"}:
+            return arch_line
+        _total, high = self._endpoint_support()
+        if high >= _MIN_REST_ENDPOINTS_FOR_LABEL:
+            return arch_line
+        # No controller backing → the MVC/view claim is unverified. Report the
+        # directory-derived layers without the framework label or the "view" claim.
+        layer_names = [l.name for l in arch.layers[:4] if l.name != "view"] if arch.layers else []
+        if layer_names:
+            return (
+                f"Layered code organization ({', '.join(layer_names)}; "
+                f"directory-based — no HTTP controllers detected)."
+            )
+        return ""
+
     def _describe_arch_pattern(self, arch: Any) -> str:
         pattern_labels = {
             "clean": "Clean Architecture",

{sourcecode-1.70.0 → sourcecode-1.71.0}/src/sourcecode/detectors/java.py

@@ -284,10 +284,43 @@ class JavaDetector(AbstractDetector):
             if parent_artifact == "spring-boot-starter-parent":
                 sb_version = (parent_elem.findtext(f"{ns}version") or "").strip() or None
 
-        text = ElementTree.tostring(root_elem, encoding="unicode").lower()
+        # BUG #1 (Jenkins field test): framework tokens must be matched only inside
+        # genuine dependency / plugin / parent coordinates, never anywhere in the
+        # serialized pom. Jenkins' war/pom.xml lists `<exclude>...:spring-web</exclude>`
+        # and `<exclude>...:spring-aop</exclude>` in an enforcer-plugin bytecode rule
+        # — those are exclusions of transitive artifacts, not declared dependencies.
+        # Serializing the whole tree let them read as "uses Spring MVC / Spring AOP".
+        # Restrict the scan to real dependency/plugin/parent artifact coordinates;
+        # `<exclusion>` and `<exclude>` elements carry neither.
+        text = self._pom_coordinate_text(root_elem, ns)
         frameworks = self._detect_jvm_frameworks(text, "pom.xml", sb_version=sb_version)
         return frameworks
 
+    def _pom_coordinate_text(self, root_elem: ElementTree.Element, ns: str) -> str:
+        """Collect groupId:artifactId coordinates from real dependency, plugin, and
+        parent declarations only. Skips `<exclusion>`/`<exclude>` (transitive-artifact
+        removals) and comments, which must never be read as usage signal."""
+        coords: list[str] = []
+
+        def _coord(elem: ElementTree.Element) -> None:
+            gid = (elem.findtext(f"{ns}groupId") or "").strip()
+            aid = (elem.findtext(f"{ns}artifactId") or "").strip()
+            if aid:
+                coords.append(f"{gid}:{aid}" if gid else aid)
+
+        # <dependency> nodes anywhere (dependencies, dependencyManagement, profiles).
+        # ElementTree never yields <dependency> under <exclusions> (those are
+        # <exclusion>), so exclusion coordinates are structurally excluded.
+        for dep in root_elem.iter(f"{ns}dependency"):
+            _coord(dep)
+        for plugin in root_elem.iter(f"{ns}plugin"):
+            _coord(plugin)
+        parent_elem = root_elem.find(f"{ns}parent")
+        if parent_elem is not None:
+            _coord(parent_elem)
+
+        return "\n".join(coords).lower()
+
     def _frameworks_from_gradle(self, path: Path) -> list[FrameworkDetection]:
         original = "\n".join(read_text_lines(path))
         content = original.lower()
@@ -361,7 +394,12 @@ class JavaDetector(AbstractDetector):
             frameworks.append(FrameworkDetection(name="Thymeleaf", source=source))
         if "freemarker" in text:
             frameworks.append(FrameworkDetection(name="FreeMarker", source=source))
-        if "spring-boot-starter-security" in text or "spring-security-core" in text:
+        if (
+            "spring-boot-starter-security" in text
+            or "spring-security-core" in text
+            or "spring-security-web" in text
+            or "spring-security-config" in text
+        ):
             frameworks.append(FrameworkDetection(name="Spring Security", source=source))
         if "spring-boot-starter-data-jpa" in text or "spring-data-jpa" in text:
             frameworks.append(FrameworkDetection(name="Spring Data JPA", source=source))

{sourcecode-1.70.0 → sourcecode-1.71.0}/src/sourcecode/integration_detector.py

@@ -58,6 +58,13 @@ _ATTR_URL_RE = re.compile(r'url\s*=\s*"([^"]*)"')
 _ATTR_NAME_RE = re.compile(r'(?:name|value)\s*=\s*"([^"]*)"')
 _FIRST_LITERAL_RE = re.compile(r'^\s*"([^"]*)"')
 
+# BUG #5 (Jenkins field test): thresholds for the structured coverage_confidence
+# signal. A repo at/above _LARGE_REPO_FILE_THRESHOLD source files with fewer than
+# _LOW_COVERAGE_COUNT recognized integration constructs is flagged "low" coverage —
+# the count almost certainly under-represents custom-protocol/SPI integrations.
+_LARGE_REPO_FILE_THRESHOLD: int = 300
+_LOW_COVERAGE_COUNT: int = 10
+
 # token -> (kind, client). Matched as whole-word usage outside imports/comments.
 # Covers Spring AND plain-Java/Jakarta stacks (Quarkus, Micronaut, Keycloak SPI):
 # the detector must not be Spring-centric, or a non-Spring repo with real LDAP /
@@ -316,11 +323,50 @@ def detect_integrations(file_paths: "list[str]", root: Path) -> dict:
     # clients (DI, config-driven endpoints, JCA connectors) are invisible to static
     # text matching. Report that explicitly instead of an authoritative "0".
     confidence = "observed" if records else "not_analyzed"
+
+    # BUG #5 (Jenkins field test): the coverage caveat lived only inside the prose
+    # `coverage_note`. Propagate it as a STRUCTURED signal so an automated consumer
+    # does not read a low `count` as "low external coupling". A large repo with few
+    # recognized constructs (Jenkins: custom remoting/SCM/Update-Center SPIs, not
+    # RestTemplate/WebClient) is under-counted, not loosely coupled.
+    _repo_size = len(file_paths)
+    _large_repo = _repo_size >= _LARGE_REPO_FILE_THRESHOLD
+    if not records:
+        coverage_confidence = "low"
+        _cov_reason = (
+            "no recognized client-library construct found; custom protocol/SPI-based "
+            "or DI-wired integrations are not statically detectable by this analyzer. "
+            "A count of 0 does not imply the system has no outbound integrations."
+        )
+    elif _large_repo and len(records) < _LOW_COVERAGE_COUNT:
+        coverage_confidence = "low"
+        _cov_reason = (
+            f"only {len(records)} recognized construct(s) across {_repo_size} source "
+            "files; count reflects only recognized client-library patterns "
+            "(RestTemplate/WebClient/JDK/Apache/OkHttp/LDAP/JMS/…). Custom protocol/"
+            "SPI-based integrations are likely under-counted — do not read a low count "
+            "as low external coupling."
+        )
+    elif len(records) < _LOW_COVERAGE_COUNT:
+        coverage_confidence = "partial"
+        _cov_reason = (
+            "recognized client-library constructs detected; custom protocol/SPI-based "
+            "or DI-wired integrations, if any, are not statically visible."
+        )
+    else:
+        coverage_confidence = "high"
+        _cov_reason = (
+            "recognized client-library constructs cover the observable integration "
+            "surface; runtime/DI-wired clients remain out of static scope."
+        )
+
     return {
         "integrations": records,
         "by_kind": {k: by_kind[k] for k in sorted(by_kind)},
         "count": len(records),
         "confidence": confidence,
+        "coverage_confidence": coverage_confidence,
+        "coverage_confidence_reason": _cov_reason,
         "coverage_note": (
             "Detects HTTP (RestTemplate/WebClient/JDK/Apache/OkHttp), LDAP (Spring "
             "+ JNDI), DNS (JNDI DirContext w/ DnsContextFactory), SMTP (JavaMail, "

{sourcecode-1.70.0 → sourcecode-1.71.0}/src/sourcecode/migrate_check.py

@@ -652,6 +652,13 @@ def _classify_code_context(finding: "MigrationFinding") -> str:
         imp.rsplit(".", 1)[-1] == "Generated" for imp in finding.imports_found
     ):
         return "generated"
+    # BUG #3 (Jenkins field test): a namespace-migration finding (javax→jakarta,
+    # e.g. javax.servlet) on a class-level @Deprecated type is a frozen-legacy
+    # compatibility shim — kept for binary compat, with a live replacement elsewhere
+    # (Jenkins ChainedServletFilter → ChainedServletFilter2). Not an active blocker:
+    # segregate it out of blocking_count like test/generated, with its own label.
+    if finding.enclosing_deprecated and finding.migration_target in _JAKARTA_TARGETS:
+        return "deprecated_shim"
     return "main"
 
 
@@ -1181,6 +1188,11 @@ class MigrationFinding:
     # harness), or "generated" (autogenerated source). Only "main" counts toward
     # blocking_count / readiness; test+generated are reported in a separate bucket.
     code_context: str = "main"
+    # BUG #3 (Jenkins field test): the enclosing top-level TYPE carries a class-level
+    # @Deprecated annotation. A namespace-migration finding on such a class is a
+    # frozen-legacy compatibility shim (kept for binary compat, replaced elsewhere),
+    # not an active migration blocker — reclassified out of blocking_count.
+    enclosing_deprecated: bool = False
 
     @staticmethod
     def make_id(rule_id: str, source_file: str) -> str:
@@ -1294,6 +1306,12 @@ class MigrationReport:
     spring_boot_version_detected: Optional[str] = None
     # BUG #2: whether Spring is used AT RUNTIME. The Boot3 dimension is N/A without it.
     spring_present: bool = True
+    # BUG #2 (Jenkins field test): whether the repo is a Spring BOOT application
+    # (spring-boot* coordinate / @SpringBootApplication), as opposed to merely having
+    # a Spring library (e.g. spring-security-web) on the classpath. The boot3 (Boot
+    # 2→3) migration dimension is applicable ONLY to Boot repos — a non-Boot Spring
+    # repo has no Boot upgrade axis and must not receive a contaminated readiness.
+    spring_boot_present: bool = False
     # BUG #1/#2: Spring appears ONLY as a test dependency (e.g. spring-test). Reported
     # so a consumer can see WHY boot3 is N/A despite an org.springframework coordinate.
     spring_test_only: bool = False
@@ -1366,7 +1384,19 @@ class MigrationReport:
         self.jakarta_readiness = _dimension_score(main_findings, _JAKARTA_TARGETS)
         self.boot3_readiness = _dimension_score(main_findings, _BOOT3_MIGRATION_TARGETS)
         self.jdk_modernization = _dimension_score(main_findings, None)
-        if not self.spring_present:
+        # BUG #2 (Jenkins field test): the boot3 axis applies only with POSITIVE
+        # evidence — a Spring BOOT repo (spring-boot* coordinate / @SpringBootApplication),
+        # OR a concrete Boot-3 / Security-6 migration finding in main code. A repo that
+        # merely carries a Spring library (spring-security-web) with no Boot and no
+        # Boot/Security migration findings (Jenkins) has no boot3 axis — jakarta-shaped
+        # findings must not masquerade as a boot3 readiness deficit. Note: jakarta
+        # findings do NOT make boot3 applicable; only genuine boot3/security-6 targets do.
+        _boot3_migration_findings = any(
+            f.migration_target in (_BOOT3_MIGRATION_TARGETS - _JAKARTA_TARGETS)
+            for f in main_findings
+        )
+        _boot3_applies = self.spring_boot_present or _boot3_migration_findings
+        if not _boot3_applies:
             self.boot3_readiness = 100
 
         # BUG #3/#4: the jakarta dimension is applicable ONLY with POSITIVE evidence the
@@ -1442,14 +1472,23 @@ class MigrationReport:
                            else "N/A — no migratable javax.* imports detected"),
             },
             "boot3": {
-                "applicable": self.spring_present,
-                "score": self.boot3_readiness if self.spring_present else None,
-                "reason": ("Spring Boot 2→3 / Security 6 migration"
-                           if self.spring_present
-                           else ("N/A — Spring present only as a TEST dependency "
-                                 "(spring-test); no runtime Spring"
-                                 if self.spring_test_only
-                                 else "N/A — no Spring usage detected (non-Spring stack)")),
+                "applicable": _boot3_applies,
+                "score": self.boot3_readiness if _boot3_applies else None,
+                "reason": (
+                    "Spring Boot 2→3 / Security 6 migration"
+                    if self.spring_boot_present
+                    else "Spring Security 6 migration (spring_security_6 / spring_boot_3 "
+                         "findings present) — no Spring Boot detected"
+                    if _boot3_applies
+                    else "N/A — Spring present only as a TEST dependency (spring-test); "
+                         "no runtime Spring, no Spring Boot"
+                    if self.spring_test_only
+                    else "N/A — Spring library on the classpath but no spring-boot "
+                         "dependency / @SpringBootApplication and no Boot/Security-6 "
+                         "migration finding — not a Spring Boot application"
+                    if self.spring_present
+                    else "N/A — no Spring usage detected (non-Spring stack)"
+                ),
             },
             "jdk_modernization": {"applicable": True, "score": self.jdk_modernization,
                                   "reason": "orthogonal JDK modernization debt (excluded from "
@@ -1542,8 +1581,11 @@ class MigrationReport:
             "count": sum(_nb_by_ctx.values()),
             "by_context": _nb_by_ctx,
             "by_rule": _nb_by_rule,
-            "note": ("Findings in test/fixture harnesses or autogenerated sources. "
-                     "Excluded from blocking_count, readiness, and effort."),
+            "note": ("Findings in test/fixture harnesses, autogenerated sources, or "
+                     "class-level @Deprecated frozen-legacy shims (code_context="
+                     "\"deprecated_shim\" — kept for binary compat with a live "
+                     "replacement; verify before removing). Excluded from "
+                     "blocking_count, readiness, and effort."),
         }
 
         self.summary = {
@@ -1585,6 +1627,7 @@ class MigrationReport:
             "hygiene_findings": self.hygiene_findings,
             "non_blocking": self.non_blocking,
             "spring_present": self.spring_present,
+            "spring_boot_present": self.spring_boot_present,
             "spring_test_only": self.spring_test_only,
             "spring_boot_2_detected": self.spring_boot_2_detected,
             "spring_boot_version_detected": self.spring_boot_version_detected,
@@ -1746,12 +1789,35 @@ def _neutralize_non_spring_explanation(text: str) -> str:
     return text
 
 
+# BUG #3 (Jenkins field test): the primary top-level type declaration in a .java
+# file. Used to test whether a class-level @Deprecated annotation precedes it.
+_PRIMARY_TYPE_DECL_RE: re.Pattern = re.compile(
+    r"(?m)^[ \t]*(?:public\s+|final\s+|abstract\s+|sealed\s+|non-sealed\s+|strictfp\s+)*"
+    r"(?:class|interface|enum|record)\s+\w"
+)
+
+
+def _primary_type_is_deprecated(source: str) -> bool:
+    """True iff the file's primary top-level type carries a class-level @Deprecated
+    annotation. Scoped to the region between the last import and the type keyword so
+    a @Deprecated on a METHOD (below the class declaration) never counts — that is a
+    live class with a deprecated member, not a frozen-legacy shim."""
+    m = _PRIMARY_TYPE_DECL_RE.search(source)
+    if not m:
+        return False
+    head = source[: m.start()]
+    last_import = head.rfind("\nimport ")
+    window = head[last_import:] if last_import != -1 else head
+    return "@Deprecated" in window
+
+
 def _scan_file(
     source: str,
     rel_path: str,
     rules: list[_Rule],
 ) -> list[MigrationFinding]:
     findings: list[MigrationFinding] = []
+    type_deprecated = _primary_type_is_deprecated(source)
 
     for rule in rules:
         matched_imports: list[str] = []
@@ -1820,6 +1886,7 @@ def _scan_file(
                 fix_hint=rule.fix_hint,
                 migration_target=rule.migration_target,
                 openrewrite_recipe=rule.openrewrite_recipe,
+                enclosing_deprecated=type_deprecated,
             )
         )
 
@@ -1941,6 +2008,7 @@ def run_migrate_check(
     spring_present, spring_test_only = _detect_spring_usage(
         root, spring_runtime_import_seen, spring_test_import_seen
     )
+    spring_boot_present = _detect_spring_boot_present(root)
 
     # BUG #8: classify each finding's code context (main / test / generated) so the
     # report can keep test fixtures and autogenerated sources out of blocking_count.
@@ -1965,6 +2033,7 @@ def run_migrate_check(
         spring_boot_2_detected=spring_boot_2,
         spring_boot_version_detected=spring_boot_version,
         spring_present=spring_present,
+        spring_boot_present=spring_boot_present,
         spring_test_only=spring_test_only,
         jakarta_namespace_adopted=jakarta_import_count > 0,
         findings=all_findings,
@@ -2065,6 +2134,46 @@ def _extract_boot_versions(text: str) -> tuple[set[int], Optional[str]]:
     return majors, full
 
 
+# BUG #2 (Jenkins field test): strip XML comments and exclusion/exclude blocks
+# before scanning for a spring-boot coordinate, so a `<exclude>...:spring-boot</…>`
+# or a comment never reads as "this repo uses Spring Boot" — the same exclusion
+# poison that produced phantom Spring MVC/AOP in framework detection.
+_XML_COMMENT_RE: re.Pattern = re.compile(r"<!--.*?-->", re.DOTALL)
+_XML_EXCLUSION_EL_RE: re.Pattern = re.compile(r"<exclusion\b.*?</exclusion\s*>", re.DOTALL | re.IGNORECASE)
+_XML_EXCLUDE_EL_RE: re.Pattern = re.compile(r"<exclude\b.*?</exclude\s*>", re.DOTALL | re.IGNORECASE)
+# A spring-boot* Maven/Gradle artifact coordinate (starter, BOM, dependency, plugin).
+_SPRING_BOOT_ARTIFACT_RE: re.Pattern = re.compile(r"\bspring-boot(?:-[a-z0-9.\-]+)?\b", re.IGNORECASE)
+
+
+def _strip_xml_exclusions(text: str) -> str:
+    """Remove XML comments and exclusion/exclude elements so their coordinates are
+    not mistaken for declared dependencies."""
+    text = _XML_COMMENT_RE.sub(" ", text)
+    text = _XML_EXCLUSION_EL_RE.sub(" ", text)
+    text = _XML_EXCLUDE_EL_RE.sub(" ", text)
+    return text
+
+
+def _detect_spring_boot_present(root: Path) -> bool:
+    """True iff there is POSITIVE Spring Boot evidence — a spring-boot* build
+    coordinate (parent / BOM / dependency / plugin) or the Spring Boot Gradle
+    plugin. Distinguishes a Spring Boot application from a repo that merely has a
+    Spring library on the classpath (e.g. Jenkins' spring-security-web). Gates the
+    boot3 (Boot 2→3) migration dimension. @SpringBootApplication is not scanned
+    separately: its annotation class ships in spring-boot-autoconfigure, so a Boot
+    app always carries a spring-boot* coordinate."""
+    for abs_path, _rel in _find_build_files(root):
+        try:
+            text = abs_path.read_text(encoding="utf-8", errors="replace")
+        except OSError:
+            continue
+        if _SPRING_BOOT_PLUGIN_RE.search(text):
+            return True
+        if _SPRING_BOOT_ARTIFACT_RE.search(_strip_xml_exclusions(text)):
+            return True
+    return False
+
+
 def _detect_spring_boot(root: Path, jakarta_import_count: int) -> tuple[Optional[bool], Optional[str]]:
     """Tri-state Spring Boot 2 detection. Returns (spring_boot_2_detected, version).
 

{sourcecode-1.70.0 → sourcecode-1.71.0}/src/sourcecode/repository_ir.py

@@ -2872,12 +2872,35 @@ def _assemble(
     else:
         _security_model_asm = "unknown"
 
+    # BUG #4 (Jenkins field test): the bare "unknown" string carried no reason or
+    # sub-structure — inconsistent with the not_detected+reason pattern used
+    # elsewhere (migrate-check hibernate). Emit a structured companion so a consumer
+    # sees WHY, and never reads "unknown" as "unsecured". A repo with a custom
+    # security SPI (Jenkins ACL/SecurityRealm) simply matched no RECOGNIZED pattern.
+    _security_model_detail_asm = {
+        "model": _security_model_asm,
+        "status": "detected" if _security_model_asm != "unknown" else "not_detected",
+        "spring_security_filter_chain_detected": _filter_based_asm,
+        "annotation_policies_detected": _has_ann_sec_asm,
+        "custom_spi_detected": [],
+        "reason": (
+            "recognized security model: " + _security_model_asm
+            if _security_model_asm != "unknown"
+            else "N/A — no Spring Security filter chain, no annotation-based policy, "
+                 "and no recognized custom security SPI matched. Absence of a "
+                 "recognized pattern is not evidence the repo is unsecured — it may "
+                 "use a framework-specific or custom access-control model this "
+                 "analyzer does not model."
+        ),
+    }
+
     return {
         **_base,
         "route_surface": _route_surface,
         "spring_events": _spring_events,
         "analysis_gaps": _analysis_gaps,
         "security_model": _security_model_asm,
+        "security_model_detail": _security_model_detail_asm,
         "audit": {
             "dropped_fields": dropped_fields,
         },
@@ -3510,6 +3533,15 @@ def build_repo_ir(
             ir["security_model"] = "xml_or_filter_chain"
         elif _sec_model in ("annotation_based", "mixed"):
             ir["security_model"] = "mixed"
+        # BUG #4: keep the structured detail consistent with the rewritten string.
+        _detail = ir.get("security_model_detail")
+        if isinstance(_detail, dict):
+            _detail["model"] = ir["security_model"]
+            _detail["status"] = "detected"
+            _detail["spring_security_filter_chain_detected"] = True
+            _detail["reason"] = ("XML/filter-chain security configuration detected "
+                                 "(declarative filter mapping in web.xml or Spring "
+                                 "security XML)")
         # Retag route_surface entries that have no security (would become none_detected in CIR)
         for _r in ir.get("route_surface") or []:
             _r_sec = _r.get("security_annotations")