sourcecode 1.68.0__tar.gz → 1.69.0__tar.gz

{sourcecode-1.68.0 → sourcecode-1.69.0}/CHANGELOG.md

@@ -1,5 +1,65 @@
 # Changelog
 
+## [1.69.0] — 2026-06-30
+
+### Fixed — framing & symbol-graph fidelity on a non-framework Java library (JobRunr field test)
+
+A full architectural audit of **JobRunr** (Gradle multi-module, 707 classes, a
+background-job-processing **library** that is framework-agnostic at its core and
+integrates with Quarkus/Micronaut/Spring only through small optional adapter
+modules) surfaced four reproducible defects. Each fix targets the **root cause** so
+it generalizes to any equivalent repo, with new regression coverage across five
+suites.
+
+- **`migrate-check` MIG-011 — false positive on JDK-exported packages (BUG #1).**
+  The rule flagged *any* `sun.*` / `com.sun.*` import as a strongly-encapsulated
+  JDK internal on a pure prefix heuristic. On JobRunr this turned 14 benign
+  `com.sun.net.httpserver.*` imports into 14 `high`/`manual_migration` findings —
+  **100% of an inflated `blocking_count: 14`** on a healthy repo (the GO/NO-GO
+  metric). `com.sun.net.httpserver` is exported **unconditionally** by the
+  `jdk.httpserver` module (public since Java 6, basis of JEP 408) and needs no
+  `--add-exports`/`--add-opens`. MIG-011 now consults an allowlist of
+  unconditionally-exported JDK packages **generated from the running JDK** by
+  `scripts/generate_jdk_exports.py` (`src/sourcecode/jdk_exports.py`), never
+  hand-maintained. Genuinely-internal packages (`sun.misc.Unsafe`,
+  `com.sun.tools.*`, `com.sun.jdi.*`, `com.sun.source.*`) stay `high`.
+  `blocking_count` and `estimated_effort_days` recompute accordingly. JobRunr
+  `blocking_count` 14 → 0.
+- **Phantom symbols extracted from prose (BUG #2).** `modernize`'s
+  `statically_unreferenced` / `framework_dispatched` lists (and the shared symbol
+  graph behind `repo-ir` / `impact` / `export --c4`) contained FQNs that match no
+  real type — e.g. `org.jobrunr.configuration.provides` (from the Javadoc "This
+  class **provides** the entry point") and `…details.instead` (from an exception
+  string "…**instead** of an actual implementation"). The non-annotated fast-path
+  symbol scan ran `(?:class|interface|enum)\s+(\w+)` over **raw source**, tokenizing
+  words inside comments and string literals. It now strips comments + string
+  literals first and requires a capitalized type name, matching the precision of the
+  annotated-file extractor. Fixing the shared parser fixes every downstream command.
+- **`endpoints` — total false negative on imperative router DSLs (BUG #3).** JobRunr
+  exposes 12 live dashboard REST routes via `get("/jobs", handler)` /
+  `post(...)` / `delete(...)` calls; the annotation-only extractor returned **0
+  endpoints** (silently disabling `validation` downstream). A shape-based detector
+  now recognizes router-DSL registrations — an HTTP-verb method whose first argument
+  is a path literal **and** that has a second argument (the trailing comma
+  distinguishes a route from a 1-arg `Map.get`). Reported at `confidence: medium`
+  with `source: router_dsl`. Handles bare (Spark/static-import) and `app.get(...)`
+  (Javalin) forms. JobRunr `endpoints` 0 → 12.
+- **Stack/architecture classification biased to the most-recognizable framework (BUG #4).**
+  JobRunr (19 modules, framework only in 3 small adapters, `core` ≈ 85% of code) was
+  reported as `project_type: "api"` / `frameworks: ["Quarkus"]`. Two root causes:
+  (a) the Gradle detector substring-matched `"quarkus"` inside an **exclusion filter**
+  (`configure(subprojects.findAll { !it.name.contains('quarkus') })`) — framework
+  tokens are now matched only inside genuine dependency/plugin lines; and (b)
+  presence-based typing — a framework confined to a minority adapter module (its
+  dominant source module uses no framework) no longer drives the project type, and a
+  multi-module JVM repo with no defining web/API framework classifies as `library`,
+  never `unknown`. A monolithic framework app is unaffected. `explain` no longer
+  emits the misleading "No stereotype detected — may be a plain class or utility" for
+  a structurally central non-annotated class: it infers a low-confidence stereotype
+  from in-degree, lifecycle methods, and naming (e.g. `BackgroundJobServer` →
+  "Likely server/orchestrator … lifecycle methods detected (start/stop)"). JobRunr
+  `project_type` "api" → "library", `frameworks` `["Quarkus"]` → `[]`.
+
 ## [1.68.0] — 2026-06-30
 
 ### Fixed — narrative/structured-data parity on non-Spring DI repos (Netflix Eureka field test)

{sourcecode-1.68.0 → sourcecode-1.69.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sourcecode
-Version: 1.68.0
+Version: 1.69.0
 Summary: Persistent structural context and ultra-fast repeated analysis for AI coding agents
 License-File: LICENSE
 Keywords: agents,ai,codebase,context,developer-tools,llm

{sourcecode-1.68.0 → sourcecode-1.69.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "sourcecode"
-version = "1.68.0"
+version = "1.69.0"
 description = "Persistent structural context and ultra-fast repeated analysis for AI coding agents"
 readme = "README.md"
 requires-python = ">=3.9"

sourcecode-1.69.0/scripts/generate_jdk_exports.py

@@ -0,0 +1,132 @@
+#!/usr/bin/env python3
+"""Generate the JDK unconditional-export allowlist used by migrate-check MIG-011.
+
+MIG-011 flags `sun.*` / `com.sun.*` imports as strongly-encapsulated JDK-internal
+APIs. That heuristic is *prefix-based* and produces false positives on packages
+that merely share the prefix but are in fact exported **unconditionally** by a
+JDK module (no `to` clause) and therefore require NO `--add-exports` /
+`--add-opens` on any classpath or module-path scenario. The canonical example is
+`com.sun.net.httpserver.*` (module `jdk.httpserver`) — public and documented
+since Java 6, the basis of JEP 408.
+
+This script derives the allowlist directly from the running JDK by parsing
+`java --describe-module` for every module, so the data tracks the real platform
+instead of a hand-maintained list that silently rots across releases.
+
+Two filters are applied:
+
+  1. Only `exports <pkg>` lines WITHOUT a `to <module>` qualifier are kept
+     (qualified exports still need `--add-exports` for arbitrary code).
+
+  2. Modules whose whole purpose is internal / tooling / deprecated access are
+     DENYLISTED — their `sun.*` / `com.sun.*` exports are genuine migration
+     concerns and must keep MIG-011's `high` severity:
+        - jdk.unsupported  → sun.misc.Unsafe, sun.reflect (deprecated for removal)
+        - jdk.compiler     → com.sun.source.*, com.sun.tools.javac (compiler internals)
+        - jdk.attach       → com.sun.tools.attach.* (tooling)
+        - jdk.jdi          → com.sun.jdi.* (debugger internals)
+        - jdk.jconsole / jdk.jdeps / jdk.javadoc / jdk.jshell → com.sun.tools.*
+
+Run with the OLDEST supported target JDK to stay conservative (a package
+exported in JDK 21 but not JDK 17 must not be allowlisted for a JDK 17 target).
+Re-run after a JDK bump and commit the regenerated module.
+
+Usage:
+    python scripts/generate_jdk_exports.py > src/sourcecode/jdk_exports.py
+"""
+from __future__ import annotations
+
+import re
+import subprocess
+import sys
+
+# Modules whose sun.*/com.sun.* exports are genuinely internal/tooling/deprecated.
+# Their packages must NOT be allowlisted — MIG-011 keeps firing `high` for them.
+_DENYLIST_MODULES: frozenset[str] = frozenset(
+    {
+        "jdk.unsupported",
+        "jdk.compiler",
+        "jdk.attach",
+        "jdk.jdi",
+        "jdk.jconsole",
+        "jdk.jdeps",
+        "jdk.javadoc",
+        "jdk.jshell",
+        "jdk.internal.ed",
+        "jdk.internal.le",
+        "jdk.internal.opt",
+        "jdk.internal.vm.ci",
+        "jdk.internal.vm.compiler",
+    }
+)
+
+_EXPORT_RE = re.compile(r"^exports\s+(\S+?)(?:\s+to\s+.*)?$")
+
+
+def _list_modules() -> list[str]:
+    out = subprocess.run(
+        ["java", "--list-modules"], capture_output=True, text=True, check=True
+    ).stdout
+    return [line.split("@", 1)[0].strip() for line in out.splitlines() if line.strip()]
+
+
+def _module_exports(module: str) -> list[tuple[str, bool]]:
+    """Return (package, is_unconditional) for each `exports` line of a module."""
+    out = subprocess.run(
+        ["java", "--describe-module", module],
+        capture_output=True,
+        text=True,
+    ).stdout
+    results: list[tuple[str, bool]] = []
+    for line in out.splitlines():
+        line = line.strip()
+        m = _EXPORT_RE.match(line)
+        if not m:
+            continue
+        pkg = m.group(1)
+        unconditional = " to " not in line
+        results.append((pkg, unconditional))
+    return results
+
+
+def main() -> int:
+    java_version = subprocess.run(
+        ["java", "-version"], capture_output=True, text=True
+    ).stderr.splitlines()[0]
+
+    allowlist: set[str] = set()
+    for module in _list_modules():
+        if module in _DENYLIST_MODULES:
+            continue
+        for pkg, unconditional in _module_exports(module):
+            if not unconditional:
+                continue
+            if pkg.startswith("sun.") or pkg.startswith("com.sun."):
+                allowlist.add(pkg)
+
+    packages = sorted(allowlist)
+
+    print('"""GENERATED FILE — do not edit by hand.')
+    print()
+    print("Allowlist of sun.* / com.sun.* packages exported UNCONDITIONALLY by the")
+    print("JDK (no `--add-exports` / `--add-opens` required on classpath or module")
+    print("path). Consumed by migrate-check MIG-011 to suppress false positives.")
+    print()
+    print(f"Regenerate with:  python scripts/generate_jdk_exports.py > "
+          "src/sourcecode/jdk_exports.py")
+    print(f"Generated from:   {java_version}")
+    print('"""')
+    print("from __future__ import annotations")
+    print()
+    print()
+    print("JDK_UNCONDITIONAL_EXPORTS: frozenset[str] = frozenset(")
+    print("    {")
+    for pkg in packages:
+        print(f'        "{pkg}",')
+    print("    }")
+    print(")")
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main())

{sourcecode-1.68.0 → sourcecode-1.69.0}/src/sourcecode/__init__.py

@@ -1,3 +1,3 @@
 """sourcecode — Deterministic codebase context maps for AI coding agents."""
 
-__version__ = "1.68.0"
+__version__ = "1.69.0"

{sourcecode-1.68.0 → sourcecode-1.69.0}/src/sourcecode/classifier.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import re
 from collections.abc import Iterable, Sequence
 from dataclasses import replace
 from typing import Any, Literal
@@ -104,6 +105,21 @@ class TypeClassifier:
         stack_names = {stack.stack for stack in stacks}
         framework_names = {framework.name for stack in stacks for framework in stack.frameworks}
 
+        # BUG #4 (JobRunr field test): a framework present only in a small optional
+        # integration/adapter submodule must NOT label the whole repo as that
+        # framework's app type. JobRunr is a framework-agnostic background-job
+        # LIBRARY whose `core` module holds ~85% of the code; Quarkus/Micronaut/Spring
+        # appear only in tiny per-framework adapter modules — yet presence-based
+        # classification returned project_type="api"+Quarkus. We weight by code
+        # locality: if the DOMINANT source module (the one with the most source files)
+        # contains no evidence of the app-defining framework, the framework is an
+        # optional adapter and the repo is a library. A monolithic Spring app is
+        # unaffected — its dominant module *does* use the framework. Drop such
+        # localized frameworks from the set that drives the app-type decision below.
+        _app_frameworks = framework_names & (_WEB_FRAMEWORKS | _API_FRAMEWORKS)
+        _localized = self._localized_adapter_frameworks(file_tree, stacks, _app_frameworks)
+        framework_names = framework_names - _localized
+
         if len(stack_names) >= 2 and self._is_fullstack(stacks):
             return "fullstack"
 
@@ -129,9 +145,16 @@ class TypeClassifier:
         if framework_names & _API_FRAMEWORKS:
             return "api"
 
+        # All app-defining frameworks were localized to optional adapter submodules
+        # (multi-module library with per-framework integrations) — report library,
+        # never "unknown", when there is clearly source code present.
+        if _localized and not (framework_names & (_WEB_FRAMEWORKS | _API_FRAMEWORKS)):
+            return "library"
+
+        # Strong CLI signals: a CLI framework or an explicit cli entry point.
         if framework_names & _CLI_FRAMEWORKS or any(
             entry.kind == "cli" for entry in entry_points
-        ) or any(path.startswith("bin/") for path in flat_paths):
+        ):
             return "cli"
 
         if stack_names:
@@ -141,8 +164,105 @@ class TypeClassifier:
             if single in {"cpp", "dotnet"} and any(entry.kind == "cli" for entry in entry_points):
                 return "cli"
 
+        # BUG #4 (JobRunr field test): a multi-module JVM repo with no app-defining
+        # web/API framework is a library/toolkit, not an "unknown" — never let the
+        # first command of an audit emit a vacuous classification for a clearly
+        # structured codebase (e.g. JobRunr: core + per-framework adapter modules).
+        # This is checked BEFORE the weak `bin/`-directory CLI heuristic so a build
+        # output / wrapper `bin/` dir does not mislabel a library as a CLI.
+        if stack_names & {"java", "kotlin", "scala"} and self._is_multi_module(file_tree):
+            return "library"
+
+        # Weak CLI heuristic: a top-level bin/ directory (only when nothing stronger).
+        if any(path.startswith("bin/") for path in flat_paths):
+            return "cli"
+
         return "unknown" if stacks else None
 
+    def _is_multi_module(self, file_tree: dict[str, Any]) -> bool:
+        """True when the repo has >1 source module (distinct `*/src/...` roots)."""
+        _CODE_EXTS = (".java", ".kt", ".kts", ".scala", ".groovy")
+        modules = {
+            self._module_of(p)
+            for p in flatten_file_tree(file_tree)
+            if p.endswith(_CODE_EXTS)
+        }
+        modules.discard("")
+        return len(modules) >= 2
+
+    @staticmethod
+    def _module_of(path: str) -> str:
+        """Group a source path into its module root.
+
+        For Maven/Gradle layouts the module is everything before `/src/`
+        (e.g. `framework-support/jobrunr-quarkus/src/main/java/...` →
+        `framework-support/jobrunr-quarkus`). Otherwise the top-level directory.
+        """
+        norm = path.replace("\\", "/")
+        idx = norm.find("/src/")
+        if idx > 0:
+            return norm[:idx]
+        head, _, tail = norm.partition("/")
+        return head if tail else ""
+
+    _EVIDENCE_PATH_RE = re.compile(r"\(([^()]+)\)\s*$")
+
+    def _localized_adapter_frameworks(
+        self,
+        file_tree: dict[str, Any],
+        stacks: Sequence[StackDetection],
+        candidate_frameworks: set[str],
+    ) -> set[str]:
+        """Frameworks confined to a minority module while a framework-agnostic
+        module dominates the codebase (library + per-framework adapters).
+
+        Returns the subset of ``candidate_frameworks`` that should NOT drive the
+        project-type decision. A framework qualifies only when (a) the repo is
+        multi-module, (b) the framework's evidence files are all outside the
+        dominant source module, and (c) the framework has located evidence files
+        (a manifest-only/root detection applies repo-wide and never localizes).
+        """
+        if not candidate_frameworks:
+            return set()
+
+        _CODE_EXTS = (".java", ".kt", ".kts", ".scala", ".groovy")
+        module_file_counts: dict[str, int] = {}
+        for p in flatten_file_tree(file_tree):
+            if not p.endswith(_CODE_EXTS):
+                continue
+            mod = self._module_of(p)
+            module_file_counts[mod] = module_file_counts.get(mod, 0) + 1
+
+        # Need a genuine multi-module repo to reason about locality.
+        if len(module_file_counts) < 2:
+            return set()
+        dominant_module = max(module_file_counts, key=lambda m: module_file_counts[m])
+
+        # Collect evidence file paths per framework from detected_via.
+        evidence: dict[str, set[str]] = {}
+        for stack in stacks:
+            for fw in stack.frameworks:
+                if fw.name not in candidate_frameworks:
+                    continue
+                paths = evidence.setdefault(fw.name, set())
+                for ev in fw.detected_via:
+                    if ev.startswith("manifest:"):
+                        continue
+                    m = self._EVIDENCE_PATH_RE.search(ev)
+                    if m:
+                        paths.add(m.group(1).strip())
+
+        localized: set[str] = set()
+        for fw_name in candidate_frameworks:
+            files = evidence.get(fw_name) or set()
+            if not files:
+                # No locatable evidence (manifest-only) → applies repo-wide.
+                continue
+            modules = {self._module_of(f) for f in files}
+            if dominant_module not in modules:
+                localized.add(fw_name)
+        return localized
+
     def _is_fullstack(self, stacks: Sequence[StackDetection]) -> bool:
         has_web = False
         has_api = False

{sourcecode-1.68.0 → sourcecode-1.69.0}/src/sourcecode/detectors/java.py

@@ -90,6 +90,19 @@ _GRADLE_JAVA_VERSION_RE = re.compile(
 _GRADLE_JAVA_ENUM_RE = re.compile(
     r"""(?:sourceCompatibility|targetCompatibility)\s*=\s*JavaVersion\.VERSION_(\d+)"""
 )
+# BUG #4: a gradle line that genuinely declares a dependency or plugin. Matches a
+# quoted Maven coordinate (group:artifact, requires the colon), a plugins-block
+# `id '...'`, an `apply plugin:`, or a `classpath`/`platform(`/`enforcedPlatform(`
+# declaration. Deliberately does NOT match `it.name.contains('quarkus')`-style
+# subproject filters (a bare quoted name with no colon and no plugin/dep keyword).
+_GRADLE_DEP_LINE_RE = re.compile(
+    r"""['"][\w.\-]+:[\w.\-]+"""          # maven coordinate "group:artifact..."
+    r"""|\bclasspath\b"""
+    r"""|\b(?:enforced)?platform\s*\("""
+    r"""|\bapply\s+plugin\s*:"""
+    r"""|\bid\s*[('"]""",
+    re.IGNORECASE,
+)
 
 
 class JavaDetector(AbstractDetector):
@@ -279,7 +292,29 @@ class JavaDetector(AbstractDetector):
         original = "\n".join(read_text_lines(path))
         content = original.lower()
         sb_version = self._extract_gradle_sb_version(original)
-        return self._detect_jvm_frameworks(content, "build.gradle", sb_version=sb_version)
+        # BUG #4 (JobRunr field test): framework tokens must be matched only inside
+        # genuine dependency / plugin declarations, never anywhere in the file. A
+        # multi-module root build.gradle that EXCLUDES a subproject by name —
+        # `configure(subprojects.findAll { !it.name.contains('quarkus') })` — must
+        # not be read as "this project uses Quarkus". Restrict the scan to lines
+        # carrying a Maven coordinate / plugin id; the exclusion filter has neither.
+        dep_text = self._gradle_dependency_text(content)
+        return self._detect_jvm_frameworks(dep_text, "build.gradle", sb_version=sb_version)
+
+    @staticmethod
+    def _gradle_dependency_text(content: str) -> str:
+        """Keep only gradle lines that declare a dependency or plugin.
+
+        A real dependency carries a Maven coordinate (`group:artifact`...) and a
+        plugin carries an `id`/`plugin`/`classpath` token. Subproject-name filters
+        and arbitrary prose are dropped, so a framework substring there cannot
+        manufacture a phantom framework detection.
+        """
+        kept: list[str] = []
+        for line in content.splitlines():
+            if _GRADLE_DEP_LINE_RE.search(line):
+                kept.append(line)
+        return "\n".join(kept)
 
     def _extract_gradle_sb_version(self, content: str) -> str | None:
         m = _GRADLE_SB_PLUGIN_RE.search(content)

{sourcecode-1.68.0 → sourcecode-1.69.0}/src/sourcecode/explain.py

@@ -223,7 +223,89 @@ def _build_purpose(
         if role_anns:
             desc = f"{role_anns[0]} bean"
 
-    return desc or "No stereotype detected — may be a plain class or utility."
+    if desc:
+        return desc
+
+    # BUG #4 (JobRunr field test): with no recognized framework annotation, the old
+    # fallback returned "No stereotype detected — may be a plain class or utility",
+    # which is actively misleading for a central domain class. Libraries and clean/
+    # hexagonal architectures model rich roles WITHOUT DI annotations. Infer a
+    # low-confidence structural role from signals the tool already computes:
+    # in-degree (coupling), lifecycle methods, and naming convention.
+    structural = _structural_purpose(class_fqn, raw_nodes, cir)
+    if structural:
+        return structural
+    return "No stereotype detected — may be a plain class or utility."
+
+
+# Lifecycle method names that signal an orchestrator/component managing state.
+_LIFECYCLE_METHODS = frozenset({
+    "start", "stop", "init", "initialize", "shutdown", "close",
+    "pause", "resume", "run", "destroy", "open", "restart",
+})
+
+# Class-name suffix → inferred role (no annotation required).
+_NAME_ROLE_SUFFIXES: tuple[tuple[str, str], ...] = (
+    ("Server", "server/orchestrator"),
+    ("Manager", "manager/coordinator"),
+    ("Controller", "controller"),
+    ("Service", "service"),
+    ("Repository", "repository/data access"),
+    ("Factory", "factory"),
+    ("Builder", "builder"),
+    ("Handler", "handler"),
+    ("Listener", "listener"),
+    ("Provider", "provider"),
+    ("Registry", "registry"),
+    ("Scheduler", "scheduler"),
+    ("Dispatcher", "dispatcher"),
+    ("Processor", "processor"),
+    ("Filter", "filter"),
+    ("Interceptor", "interceptor"),
+)
+
+
+def _structural_purpose(
+    class_fqn: str,
+    raw_nodes: list[dict],
+    cir: "CanonicalRepositoryIR",
+) -> str:
+    """Infer a low-confidence stereotype from structural signals (no annotations)."""
+    try:
+        in_degree = len(_build_callers(class_fqn, cir))
+    except Exception:
+        in_degree = 0
+
+    try:
+        method_names = {m.split("(")[0].lower() for m in _build_public_methods(class_fqn, raw_nodes)}
+    except Exception:
+        method_names = set()
+    lifecycle = sorted(method_names & _LIFECYCLE_METHODS)
+
+    simple = _simple(class_fqn)
+    role = ""
+    for suffix, label in _NAME_ROLE_SUFFIXES:
+        if simple.endswith(suffix):
+            role = label
+            break
+    if not role and lifecycle:
+        role = "orchestrator/lifecycle component"
+
+    # Require at least one real signal — otherwise stay honestly silent.
+    if not role and in_degree < 3:
+        return ""
+
+    head = f"Likely {role} (no DI annotations found)" if role else \
+        "Likely a structurally significant class (no DI annotations found)"
+    signals: list[str] = []
+    if in_degree >= 3:
+        signals.append(f"high in-degree ({in_degree})")
+    elif in_degree:
+        signals.append(f"in-degree {in_degree}")
+    if lifecycle:
+        signals.append(f"lifecycle methods detected ({'/'.join(lifecycle)})")
+    suffix = f" — {', '.join(signals)}" if signals else ""
+    return f"{head}{suffix} — inferred from structure, not annotations (low confidence)."
 
 
 def _build_public_methods(class_fqn: str, raw_nodes: list[dict]) -> list[str]:

sourcecode-1.69.0/src/sourcecode/jdk_exports.py

@@ -0,0 +1,26 @@
+"""GENERATED FILE — do not edit by hand.
+
+Allowlist of sun.* / com.sun.* packages exported UNCONDITIONALLY by the
+JDK (no `--add-exports` / `--add-opens` required on classpath or module
+path). Consumed by migrate-check MIG-011 to suppress false positives.
+
+Regenerate with:  python scripts/generate_jdk_exports.py > src/sourcecode/jdk_exports.py
+Generated from:   java version "21.0.10" 2026-01-20 LTS
+"""
+from __future__ import annotations
+
+
+JDK_UNCONDITIONAL_EXPORTS: frozenset[str] = frozenset(
+    {
+        "com.sun.java.accessibility.util",
+        "com.sun.management",
+        "com.sun.net.httpserver",
+        "com.sun.net.httpserver.spi",
+        "com.sun.nio.sctp",
+        "com.sun.security.auth",
+        "com.sun.security.auth.callback",
+        "com.sun.security.auth.login",
+        "com.sun.security.auth.module",
+        "com.sun.security.jgss",
+    }
+)

{sourcecode-1.68.0 → sourcecode-1.69.0}/src/sourcecode/migrate_check.py

@@ -23,6 +23,7 @@ from pathlib import Path
 from typing import Optional, TYPE_CHECKING
 
 from sourcecode.path_filters import is_test_or_fixture_path
+from sourcecode.jdk_exports import JDK_UNCONDITIONAL_EXPORTS
 
 if TYPE_CHECKING:
     from sourcecode.hibernate_strat import HibernateStratification
@@ -381,15 +382,22 @@ _JAVA_9_RULES: list[_Rule] = [
         severity="high",
         title="JDK internal API imports (sun.* / com.sun.net.*) — strong encapsulation since Java 9",
         explanation=(
-            "Imports from sun.* and com.sun.net.* reference JDK-internal APIs that are "
-            "not part of the public specification. Since Java 9 (JPMS), these packages are "
-            "strongly encapsulated and require --add-exports / --add-opens JVM flags, "
-            "which are cumbersome and may be removed in future Java releases."
+            "Imports from sun.* and com.sun.* (tools/jdi/source internals) reference "
+            "JDK-internal APIs that are not part of the public specification. Since Java 9 "
+            "(JPMS), these packages are strongly encapsulated and require --add-exports / "
+            "--add-opens JVM flags, which are cumbersome and may be removed in future Java "
+            "releases. Packages the JDK exports UNCONDITIONALLY (e.g. com.sun.net.httpserver "
+            "in jdk.httpserver, com.sun.management in jdk.management) are NOT flagged: they "
+            "need no JVM flags on any classpath or module path."
         ),
         fix_hint=(
             "Replace internal API usage with public equivalents. "
-            "For com.sun.net.httpserver, migrate to java.net.http.HttpServer or a framework. "
-            "Add '--add-exports java.base/sun.misc=ALL-UNNAMED' only as a last resort."
+            "For sun.misc.Unsafe migrate to java.lang.invoke.VarHandle; for com.sun.tools.* "
+            "use the public javax.tools / java.compiler API. "
+            "Add '--add-exports java.base/sun.misc=ALL-UNNAMED' only as a last resort. "
+            "Note: unconditionally-exported packages (com.sun.net.httpserver, "
+            "com.sun.management, com.sun.security.auth, ...) are auto-excluded — they are "
+            "public, stable, and require no migration."
         ),
         migration_target="java_9_plus",
         openrewrite_recipe=None,
@@ -585,6 +593,45 @@ def _is_no_migrate_javax(fqn: str) -> bool:
     return any(fqn.startswith(p) for p in _JAKARTA_NO_MIGRATE_PREFIXES)
 
 
+# BUG #1 (JobRunr field test): MIG-011 flags `sun.*` / `com.sun.*` imports as
+# strongly-encapsulated JDK internals on a pure PREFIX heuristic. That is wrong
+# for packages the JDK exports UNCONDITIONALLY (no `to` clause) — e.g.
+# `com.sun.net.httpserver` (module jdk.httpserver, public since Java 6, the basis
+# of JEP 408) or `com.sun.management` (jdk.management, JMX/diagnostics). These
+# need NO `--add-exports` / `--add-opens` on any classpath or module path, so they
+# must not be flagged `high` / `manual_migration`. The allowlist is generated from
+# the running JDK by scripts/generate_jdk_exports.py (see sourcecode/jdk_exports.py),
+# never hand-maintained. Genuinely-internal packages (sun.misc.Unsafe, com.sun.tools.*,
+# com.sun.jdi.*, com.sun.source.*) are NOT in the allowlist and keep `high` severity.
+
+
+def _import_package(fqn: str) -> str:
+    """Extract the Java package of an import FQN.
+
+    Packages are lowercase by convention and types are Capitalized, so the
+    package is the maximal prefix of non-type segments. Handles wildcard
+    (`a.b.*`) and `static` imports. Conservative: an unrecognized shape yields
+    the leading lowercase run, never a broader prefix — so a sub-package like
+    `com.sun.management.internal` is never confused with `com.sun.management`.
+    """
+    fqn = fqn.strip().rstrip(";").strip()
+    if fqn.startswith("static "):
+        fqn = fqn[len("static "):].strip()
+    if fqn.endswith(".*"):
+        return fqn[:-2]
+    pkg_parts: list[str] = []
+    for seg in fqn.split("."):
+        if seg[:1].isupper():  # first type segment — package ends here
+            break
+        pkg_parts.append(seg)
+    return ".".join(pkg_parts)
+
+
+def _is_jdk_unconditional_export(fqn: str) -> bool:
+    """True if an import targets a package the JDK exports unconditionally."""
+    return _import_package(fqn) in JDK_UNCONDITIONAL_EXPORTS
+
+
 # BUG #8: autogenerated source markers — path fragments and the JSR-250 marker.
 _GENERATED_PATH_FRAGMENTS: tuple[str, ...] = (
     "/generated-sources/", "/generated/", "/target/generated",
@@ -1698,6 +1745,16 @@ def _scan_file(
             # javax.annotation.processing.*, ...). These do NOT migrate to jakarta.
             if matches and rule.migration_target == "jakarta":
                 matches = [m for m in matches if not _is_no_migrate_javax(m.group(1).strip())]
+            # BUG #1: MIG-011 prefix heuristic must not flag sun.*/com.sun.* packages
+            # the JDK exports unconditionally (no --add-exports/--add-opens needed).
+            # Drop those imports; if none remain, the file produces no MIG-011 finding
+            # (so it never inflates blocking_count / effort). Genuinely-internal
+            # packages are absent from the allowlist and survive as `high`.
+            if matches and rule.id == "MIG-011":
+                matches = [
+                    m for m in matches
+                    if not _is_jdk_unconditional_export(m.group(1).strip())
+                ]
             if matches:
                 import_first_line = source[: matches[0].start()].count("\n") + 1
                 matched_imports = [m.group(1) for m in matches]

{sourcecode-1.68.0 → sourcecode-1.69.0}/src/sourcecode/repository_ir.py

@@ -3366,9 +3366,20 @@ def build_repo_ir(
                 and not _INHERIT_PRESCAN_RE.search(source):
             pkg_m = _PKG_RE.search(source)
             _pkg = pkg_m.group(1) if pkg_m else ""
-            # Minimal class-name symbols for same-package map (no methods/fields)
+            # Minimal class-name symbols for same-package map (no methods/fields).
+            # BUG #2 (JobRunr field test): this fast-path regex previously ran over RAW
+            # source, so prose inside Javadoc/comments and string literals (e.g.
+            # "This class provides the entry point", "...the interface is Serializable
+            # ...instead.") was tokenized into phantom type symbols like
+            # `org.jobrunr.configuration.provides`. Those leaked into the symbol graph
+            # and every consumer of it (modernize statically_unreferenced /
+            # framework_dispatched, impact, export --c4). Strip comments AND string
+            # literals before scanning so only real declarations are captured. The name
+            # must also start uppercase ([A-Z]) — Java type convention, matching the
+            # precision of the full _CLASS_DECL_RE used on annotated files.
+            _decl_source = _STRING_LITERAL_RE.sub('', _strip_java_comments(source))
             _min_syms: list[SymbolRecord] = []
-            for _cm in re.finditer(r'(?:class|interface|enum)\s+(\w+)', source):
+            for _cm in re.finditer(r'\b(?:class|interface|enum)\s+([A-Z]\w*)', _decl_source):
                 _cls_name = _cm.group(1)
                 _fqn = f"{_pkg}.{_cls_name}" if _pkg else _cls_name
                 _min_syms.append(SymbolRecord(
@@ -4023,6 +4034,27 @@ def extract_java_endpoints(root: Path) -> "dict[str, Any]":
     _SERVLET_RE = _re.compile(r"\bextends\s+\w*HttpServlet\b")
     _nonspring: dict[str, int] = {"webscripts": 0, "jax_rs": 0, "servlets": 0}
 
+    # BUG #3 (JobRunr field test): imperative router-DSL routes. Lightweight HTTP
+    # frameworks that deliberately avoid Spring/JAX-RS (JobRunr's own dashboard
+    # handler, Javalin, Spark Java, hand-rolled routers) register routes as method
+    # calls `get("/path", handler)` / `post(...)` instead of annotations, so the
+    # annotation surface above never sees them and `endpoints` returns 0 — a silent
+    # total false negative that also disables the `validation` command downstream.
+    # Detection is by SYNTACTIC SHAPE (no framework knowledge): an HTTP-verb method
+    # name, a first argument that is a string literal looking like a path (starts
+    # with "/", may contain :param / {param}), AND a second argument (the trailing
+    # comma) — the comma is what distinguishes a route registration from a 1-arg
+    # getter such as Map.get("/k"). Matches both bare `get(...)` (static-import /
+    # Spark style) and `app.get(...)` (Javalin style); the lookbehind only rejects
+    # an identifier char so `forget(` is not mistaken for `get(`. Reported at
+    # confidence "medium" — an occasional flagged false positive beats a total
+    # silent false negative.
+    _DSL_ROUTE_RE = _re.compile(
+        r'(?<![A-Za-z0-9_])(get|post|put|delete|patch|head|options)\s*\(\s*'
+        r'"(/[^"\s]*)"\s*,'
+    )
+    _dsl_routes: list[dict] = []
+
     for jf in java_files:
         try:
             source = jf.read_text(encoding="utf-8", errors="replace")
@@ -4051,6 +4083,27 @@ def extract_java_endpoints(root: Path) -> "dict[str, Any]":
                 if m:
                     extends_map[sym.symbol] = m.group(1)
 
+        # BUG #3: scan for imperative router-DSL route registrations. Strip comments
+        # first so commented-out / example routes don't leak in. The enclosing class
+        # is the first class/interface symbol in the file (route DSLs live in one
+        # handler class); fall back to the file stem when none was extracted.
+        _dsl_src = _strip_java_comments(source)
+        _dsl_matches = list(_DSL_ROUTE_RE.finditer(_dsl_src))
+        if _dsl_matches:
+            _cls_fqn = next(
+                (s.symbol for s in symbols if s.type in ("class", "interface")), None
+            )
+            _cls_simple = (
+                _cls_fqn.split(".")[-1] if _cls_fqn else Path(rel).stem
+            )
+            for _m in _dsl_matches:
+                _dsl_routes.append({
+                    "method": _m.group(1).upper(),
+                    "path": _m.group(2),
+                    "controller": _cls_simple,
+                    "effective_class": _cls_fqn or _cls_simple,
+                })
+
     routes = _build_route_surface(
         all_symbols, route_diffs=None, extends_map=extends_map,
         custom_security=_custom_sec_tuple,
@@ -4226,6 +4279,32 @@ def extract_java_endpoints(root: Path) -> "dict[str, Any]":
             if e.get("security", {}).get("policy") == "none_detected"
         )
 
+    # BUG #3: merge imperative router-DSL endpoints. Dedup against the annotation
+    # surface (method+path) in case a handler is both annotated and DSL-registered.
+    # These carry confidence "medium" (no unambiguous annotation) and explicit
+    # provenance so a consumer can tell shape-detected routes from annotated ones.
+    if _dsl_routes:
+        _seen_mp = {(e.get("method"), e.get("path")) for e in endpoints}
+        for _r in _dsl_routes:
+            _key = (_r["method"], _r["path"])
+            if _key in _seen_mp:
+                continue
+            _seen_mp.add(_key)
+            endpoints.append({
+                "method": _r["method"],
+                "path": _r["path"],
+                "controller": _r["controller"],
+                "handler": _r["controller"],
+                "return_type": "unknown",
+                "security": {"policy": "none_detected"},
+                "confidence": "medium",
+                "source": "router_dsl",
+            })
+        no_security_signal = sum(
+            1 for e in endpoints
+            if e.get("security", {}).get("policy") == "none_detected"
+        )
+
     # Append spec-recovered endpoints AFTER the security-model heuristics (which
     # are about annotation/filter/XML coverage of scanned source) so spec-sourced
     # entries don't skew those signals. They carry their own source provenance.