sourcecode 1.31.8__tar.gz → 1.31.9__tar.gz

sourcecode-1.31.9/.continue-here.md

@@ -0,0 +1,180 @@
+# Continue Here — atlas-cli sesión 17
+
+**Paused:** 2026-05-21
+**Repo:** `/Users/user/Downloads/atlas-cli`
+**Branch:** master
+**Working tree:** 6 archivos modificados, SIN commitear (user lo hará manualmente)
+
+---
+
+## Trabajo de esta sesión — Truth-Model Unification (IC-001..IC-006)
+
+Benchmark completo de sourcecode contra BroadleafCommerce reveló 6 inconsistencias donde herramientas contradicen misma verdad del repo. Todos los fixes aplicados a `src/sourcecode/`.
+
+### Causa raíz crítica descubierta
+
+`find_java_files(max_files=500)` truncaba repos grandes. BroadleafCommerce tiene 2762 Java files; `AdminBasicEntityController` estaba en posición 632 → excluido del IR → todo el análisis de herencia fallaba.
+
+### Fixes aplicados
+
+| IC | Descripción | Archivo | Resultado |
+|---|---|---|---|
+| IC-001 | `max_files` 500→3000 | `repository_ir.py:1929` | AdminBasicEntityController incluido |
+| IC-001 | `_build_route_surface` con Phase 1/2/3 inheritance projection | `repository_ir.py:1610` | route_surface 23→118 en Broadleaf |
+| IC-002 | `extends_map` pasado desde `_assemble` a `_build_route_surface` | `repository_ir.py:1573` | declaring_class/effective_class/inheritance_depth |
+| IC-003 | `graph_modules=True` en agent mode | `cli.py:839` | architecture.method: filesystem_inference→graph+structure |
+| IC-003 | Mensaje "run with --graph-modules" eliminado | `architecture_analyzer.py:333` | No más phantom flag guidance |
+| IC-004 | `_compute_maven_fan_in()` nuevo método | `runtime_classifier.py` | pom.xml cross-module deps como fan_in |
+| IC-004 | `_classify_maven_module()` nuevo método | `runtime_classifier.py` | Java modules sin package.json clasificados |
+| IC-004 | `_criticality()`: infrastructure_layer+fan_in≥3→high | `runtime_classifier.py` | common: unknown/low→infrastructure_layer/high |
+| IC-005 | `spring_events` block en `_assemble` output | `repository_ir.py:1540` | repo-ir expone event flows |
+| IC-005 | `_spring_event_signal()` + wire en `agent_view` | `serializer.py:382,2005` | agent signals.event_flows presente |
+| IC-006 | `suspected_areas` recomputado post-ranking | `prepare_context.py:1215` | Usa RelevantFile.path/.reason, no dict |
+
+### Verificación contra BroadleafCommerce
+
+```
+route_surface:         23 → 118  ✓
+AdminCategoryController: 0 → 17 routes  ✓
+inherited routes:      0 → 51 (depth>0)  ✓
+event_flows:           absent → flow_count=12  ✓
+architecture.method:   filesystem_inference → graph+structure  ✓
+common criticality:    low → high  ✓
+suspected_areas:       2 files → 7 ranked results  ✓
+```
+
+### Pendiente conocido (no bloqueante)
+
+**Gap route_surface vs endpoints (118 vs 130 — 12 routes):**
+Bug pre-existente en `_extract_symbols`: anotaciones multi-línea tipo:
+```java
+@RequestMapping(value = "deletePhone", method = {
+    RequestMethod.GET, RequestMethod.POST
+})
+```
+El fallback en `repository_ir.py:611` (`pending_anns = []`) limpia la anotación antes
+de llegar al método. Afecta `CustomerPhoneController` (4 ep) y 2 métodos de
+`AdminBasicEntityController`. Fix: rastrear apertura/cierre de `()` además de `{}`.
+
+**Architecture confidence sigue "low":**
+`ArchitectureAnalyzer` requiere ≥3 strong_domains para confidence "medium".
+BroadleafCommerce solo tiene 1 ("admin"). Domain clusterer no reconoce módulos Maven
+como bounded contexts. Fix separado en architecture_analyzer.py domain detection.
+
+---
+
+## Estado de archivos modificados (sin commitear)
+
+```bash
+git diff --stat
+# src/sourcecode/architecture_analyzer.py |   2 +-
+# src/sourcecode/cli.py                   |   1 +
+# src/sourcecode/prepare_context.py       |  35 ++
+# src/sourcecode/repository_ir.py         | 137 +++++++++++++++++---
+# src/sourcecode/runtime_classifier.py    |  80 +++++++++++++++++-
+# src/sourcecode/serializer.py            |  58 +++++++++++++
+# 6 files changed, 295 insertions(+), 18 deletions(-)
+```
+
+Mensaje de commit listo:
+```
+fix(java): unify truth model across endpoint, IR, agent, and classifier pipelines
+
+Fixes 6 consistency bugs where sourcecode produced contradictory outputs for the same repo state:
+
+IC-001: find_java_files cap 500→3000 — AdminBasicEntityController was at position 632,
+silently excluded from IR on BroadleafCommerce-scale repos.
+
+IC-001/IC-002: _build_route_surface gains 3-phase inheritance projection. Subclasses
+with class-level @RequestMapping but zero own methods now inherit parent endpoints.
+Adds declaring_class, effective_class, inheritance_depth to route surface entries.
+Result: 23→118 routes on BroadleafCommerce, AdminCategoryController 0→17 routes.
+
+IC-003: agent mode forces graph_modules=True so ArchitectureAnalyzer receives import
+graph instead of falling back to filesystem_inference. Removes phantom --graph-modules
+guidance from limitation messages.
+
+IC-004: RuntimeClassifier gains Maven pom.xml fallback (_compute_maven_fan_in,
+_classify_maven_module). Java modules with no package.json no longer classified as
+unknown/low. common module: unknown/low→infrastructure_layer/high when fan_in≥3.
+_criticality: infrastructure_layer with fan_in≥3 now returns high.
+
+IC-005: spring_events block added to repo-ir _assemble output. _spring_event_signal
+helper added to serializer, wired into agent_view signals. @EventListener and
+publishEvent flows now visible in both repo-ir and --agent outputs.
+
+IC-006: fix-bug suspected_areas recomputed after relevant_files ranking completes.
+Uses RelevantFile.path/.reason (dataclass), not dict. RankingEngine output is primary
+signal; BUG/FIXME comment counts demoted to secondary.
+
+Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
+```
+
+---
+
+## Heredados de sesión 16 (siguen vigentes)
+
+1. **CHANGELOG.md untracked** — quedó fuera del commit de sesión 16:
+   ```bash
+   git add CHANGELOG.md
+   git commit -m "docs: add CHANGELOG.md with BUG-1..5 and IMP-1 entries"
+   ```
+   Pero puede ir en el mismo commit que el de sesión 17.
+
+2. **Spring bean wiring graph** — `_build_relations` emite `injects` edges. Falta: trazar `@Configuration → @Bean → @Autowired` completo.
+
+3. **Transaction boundary edges** — `@Transactional` detectado en IR. Falta: emitir `transactional_boundary` edges entre service y DAO.
+
+4. **`_diff_routes` para class-level `@RequestMapping`** — class-level mapping change debería propagarse a todos los endpoints del controller.
+
+5. **Tests para symptom fix (sesión 15)** — `tests/test_prepare_context_symptom.py`.
+
+6. **Multi-línea annotation parser fix** — `_extract_symbols` pierde `@RequestMapping(method={...})` en líneas separadas.
+
+---
+
+## Estado de tests
+
+Tests de sesión 17: no corridos formalmente (cambios son fixes de output, no de lógica de test coverage existente). Suite anterior: 1010 passed.
+
+Pre-existing failures (no tocar):
+- `tests/test_block2_coverage.py::TestDocAnalyzerLanguageCoverage::test_java_marked_unsupported`
+- `tests/test_dependency_analyzer_node_python.py::test_python_requirements_without_lockfile_keeps_declared_versions`
+- `tests/test_scoring_calibration.py` — varios
+
+---
+
+## Primera acción al retomar
+
+```bash
+cd /Users/user/Downloads/atlas-cli
+
+# 1. Revisar diff antes de commitear
+git diff --stat
+
+# 2. Correr tests rápidos para verificar no hay regresiones
+python3 -m pytest tests/ \
+  --ignore=tests/test_block2_coverage.py \
+  --ignore=tests/test_scoring_calibration.py \
+  --deselect=tests/test_dependency_analyzer_node_python.py::test_python_requirements_without_lockfile_keeps_declared_versions \
+  -q -x
+
+# 3. Si pasan, commitear sesión 17 + CHANGELOG.md pendiente
+git add src/sourcecode/architecture_analyzer.py \
+        src/sourcecode/cli.py \
+        src/sourcecode/prepare_context.py \
+        src/sourcecode/repository_ir.py \
+        src/sourcecode/runtime_classifier.py \
+        src/sourcecode/serializer.py \
+        CHANGELOG.md
+git commit -m "fix(java): unify truth model across endpoint, IR, agent, and classifier pipelines
+..."
+
+# 4. Siguiente: fix multi-línea annotation parser en _extract_symbols
+#    Archivo: src/sourcecode/repository_ir.py ~línea 407-614
+#    Bug: pending_anns limpiado por líneas intermedias de args multi-línea
+```
+
+---
+
+*Pausado 2026-05-21 — gsd:pause-work (sesión 17)*