sourcecode 1.29.0__tar.gz → 1.30.0__tar.gz

sourcecode-1.30.0/.continue-here.md

@@ -0,0 +1,118 @@
+# Continue Here — atlas-cli session 5
+
+**Paused:** 2026-05-16 (sesión 5)
+**Repo:** `/Users/user/Downloads/atlas-cli`
+**Branch:** master
+**Commits esta sesión:** `e5a1a05` + `5c06ef3` (ambos committed, working tree limpio)
+
+---
+
+## Lo que se hizo esta sesión
+
+### Fix 1 — Windows encoding crash en `--since` (`e5a1a05`)
+
+**Root cause:** `_get_available_refs()` en `prepare_context.py` llamaba `subprocess.run(text=True)` sin `encoding=` — usaba cp1252 en Windows. Byte 0x8d → `UnicodeDecodeError` no capturado. Además `r.stdout.splitlines()` sin guard → `AttributeError` si stdout fuera None.
+
+**Fix:** dos líneas en `prepare_context.py:2309-2315`:
+```python
+encoding="utf-8", errors="replace",   # añadido
+(r.stdout or "").splitlines()          # guard añadido
+```
+
+**Tests añadidos:** `tests/test_encoding_regression.py` — clase `TestGetAvailableRefsWindowsEncoding` (4 casos: stdout=None, bytes inválidos, ref inexistente, returncode!=0).
+
+---
+
+### Fix 2 — `review-pr` reescrito como pipeline delta-first (`5c06ef3`)
+
+**Problema:** `review-pr` devolvía output genérico de repo completo sin diff real. Inútil para CI/PR review.
+
+**Cambios:**
+
+| Archivo | Qué cambió |
+|---------|-----------|
+| `prepare_context.py` | Gate 5d: 3 errores tempranos (no_git_repo, no_diff, git_ref_not_found). Reutiliza `_build_delta_impact`. Deriva security_impact/transactional_impact/test_coverage_risk del análisis delta. 7 nuevos campos en TaskOutput. |
+| `cli.py` | Content map review-pr. Bloque output PR-específico. Error JSON + exit(1). Help text. |
+| `test_v1_10_regressions.py` | 3 tests viejos (comportamiento genérico) reemplazados por 4 nuevos (gate git + mocks). |
+
+**Nuevos campos en output:**
+```json
+{
+  "review_type": "pull_request",
+  "ci_decision": "analysis_success",
+  "base_ref": "origin/main",
+  "changed_files": [...],
+  "affected_modules": [...],
+  "security_impact": {"affected_resources": [...], "risk_level": "high"},
+  "transactional_impact": {"affected_transactions": [...], "risk": "..."},
+  "test_coverage_risk": {"changed_files_without_tests": [...], "risk_level": "medium"},
+  "review_hotspots": [...],
+  "suggested_review_order": [...]
+}
+```
+
+**GitHub Actions ready:**
+```yaml
+- run: sourcecode prepare-context review-pr . --since origin/main --output review.json
+# exit 1 si no hay diff o ref no existe
+```
+
+---
+
+## Estado de tests al pausar
+
+```
+770 passed, 3 skipped
+```
+
+Fallos pre-existentes (no relacionados, ya presentes antes de esta sesión):
+- `test_block2_coverage.py::test_java_marked_unsupported` — `DocRecord.__init__` bug en `doc_analyzer.py`
+- `test_dependency_analyzer_node_python.py::test_python_requirements_without_lockfile` — typer version mismatch
+
+---
+
+## Pendiente / próximos pasos opcionales
+
+1. **Smoke test review-pr en saint-server real con diff:**
+   ```bash
+   cd saint-server
+   git checkout -b test-review-pr
+   # modificar un controller
+   sourcecode prepare-context review-pr . --since main --output /tmp/review.json
+   cat /tmp/review.json | python3 -c "import json,sys; d=json.load(sys.stdin); print('sections:', list(d.keys()))"
+   ```
+
+2. **Verificar `security_impact` detecta correctamente:** cambiar un `SecurityConfig.java` y comprobar que aparece en `security_impact.affected_resources`.
+
+3. **`suggested_review_order` calidad:** verificar que el orden security→controller→service es correcto en PR reales con múltiples tipos de archivos.
+
+4. **`test_coverage_risk` stem matching sin normalización:** el gap entre `generate-tests` (normaliza `TestFoo→Foo`) y `review-pr` (stem directo). Si da falsos "untested", añadir normalización.
+
+5. **Agent token reduction** (trabajo sesiones anteriores): smoke test pendiente en saint-server — ver handoff sesión 4 para comandos.
+
+---
+
+## Para retomar
+
+```bash
+cd /Users/user/Downloads/atlas-cli
+git log --oneline -3
+# debe mostrar:
+# 5c06ef3 (feature) implementando mejoras significativas en prepare-context review-pr...
+# e5a1a05 corrigiendo bug en delta --since en windows
+# f1cb001 corrigiendo bug --agent que duplicaba tokens sin justificación
+
+python3 -m pytest tests/ \
+  --ignore=tests/test_block2_coverage.py \
+  --deselect=tests/test_dependency_analyzer_node_python.py::test_python_requirements_without_lockfile_keeps_declared_versions \
+  -q
+# Expected: 770 passed, 3 skipped
+
+# Smoke test review-pr
+sourcecode prepare-context review-pr . --since HEAD~1 --output /tmp/review.json
+python3 -c "import json; d=json.load(open('/tmp/review.json')); print(list(d.keys()))"
+```
+
+---
+
+*Pausado 2026-05-16 sesión 5 — gsd:pause-work*

{sourcecode-1.29.0 → sourcecode-1.30.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sourcecode
-Version: 1.29.0
+Version: 1.30.0
 Summary: Deterministic codebase context for AI coding agents
 License:                                  Apache License
                                    Version 2.0, January 2004
@@ -221,7 +221,7 @@ Description-Content-Type: text/markdown
 
 **Compressed AI-ready context for Java/Spring enterprise codebases.**
 
-![Version](https://img.shields.io/badge/version-1.29.0-blue)
+![Version](https://img.shields.io/badge/version-1.30.0-blue)
 ![Python](https://img.shields.io/badge/python-3.10%2B-green)
 
 ---
@@ -255,7 +255,7 @@ pipx install sourcecode
 
 ```bash
 sourcecode version
-# sourcecode 1.29.0
+# sourcecode 1.30.0
 ```
 
 ---

{sourcecode-1.29.0 → sourcecode-1.30.0}/README.md

@@ -2,7 +2,7 @@
 
 **Compressed AI-ready context for Java/Spring enterprise codebases.**
 
-![Version](https://img.shields.io/badge/version-1.29.0-blue)
+![Version](https://img.shields.io/badge/version-1.30.0-blue)
 ![Python](https://img.shields.io/badge/python-3.10%2B-green)
 
 ---
@@ -36,7 +36,7 @@ pipx install sourcecode
 
 ```bash
 sourcecode version
-# sourcecode 1.29.0
+# sourcecode 1.30.0
 ```
 
 ---

{sourcecode-1.29.0 → sourcecode-1.30.0}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "sourcecode"
-version = "1.29.0"
+version = "1.30.0"
 description = "Deterministic codebase context for AI coding agents"
 readme = "README.md"
 requires-python = ">=3.9"

{sourcecode-1.29.0 → sourcecode-1.30.0}/src/sourcecode/__init__.py

@@ -1,3 +1,3 @@
 """sourcecode — Deterministic codebase context maps for AI coding agents."""
 
-__version__ = "1.29.0"
+__version__ = "1.30.0"

{sourcecode-1.29.0 → sourcecode-1.30.0}/src/sourcecode/prepare_context.py

@@ -681,7 +681,13 @@ class TaskContextBuilder:
                     error_message="review-pr requires a git repository.",
                     ci_decision="no_git_repo",
                 )
-            _pr_raw = self._get_git_changed_files(since=since)
+            if since is None:
+                # review-pr with no --since: check only uncommitted changes.
+                # _get_git_changed_files(since=None) defaults to HEAD~1 which
+                # returns the last *committed* diff — a false positive here.
+                _pr_raw: Optional[list[str]] = self._get_uncommitted_changed_files()
+            else:
+                _pr_raw = self._get_git_changed_files(since=since)
             if _pr_raw is None:
                 _avail_pr, _sug_pr = self._get_available_refs(since or "")
                 _pr_hints: list[str] = []
@@ -2410,6 +2416,25 @@ class TaskContextBuilder:
                 "error": True,
             }
 
+    def _get_uncommitted_changed_files(self) -> list[str]:
+        """Return files with uncommitted working-tree changes (unstaged only).
+
+        Used by review-pr when no --since ref is given, so we don't confuse
+        the last *committed* diff (HEAD~1 vs HEAD) with an actual PR diff.
+        """
+        import subprocess
+        try:
+            result = subprocess.run(
+                ["git", "diff", "--name-only", "--relative"],
+                cwd=str(self.root), capture_output=True, text=True,
+                encoding="utf-8", errors="replace", timeout=10,
+            )
+            if result.returncode == 0:
+                return [l.strip() for l in (result.stdout or "").splitlines() if l.strip()]
+        except (subprocess.TimeoutExpired, FileNotFoundError):
+            pass
+        return []
+
     def _get_git_changed_files(self, since: Optional[str] = None) -> Optional[list[str]]:
         """Get files changed since a git ref (default: HEAD~1) relative to self.root.
 

{sourcecode-1.29.0 → sourcecode-1.30.0}/tests/test_v1_10_regressions.py

@@ -552,10 +552,10 @@ class TestReviewPrSuspectedAreas:
         assert "ci_decision" in data
 
     def test_review_pr_no_diff_error_when_git_but_no_changes(self, monkeypatch):
-        # Simulate: is_git_repo=True but no changed files
+        # Simulate: is_git_repo=True but no uncommitted changes
         from sourcecode import prepare_context as _pc
         monkeypatch.setattr(_pc.TaskContextBuilder, "_is_git_repo", lambda self: True)
-        monkeypatch.setattr(_pc.TaskContextBuilder, "_get_git_changed_files", lambda self, since=None: [])
+        monkeypatch.setattr(_pc.TaskContextBuilder, "_get_uncommitted_changed_files", lambda self: [])
         result = _invoke("prepare-context", "review-pr", str(FIXTURE))
         assert result.exit_code == 1
         data = _json(result)
@@ -563,12 +563,12 @@ class TestReviewPrSuspectedAreas:
         assert data.get("ci_decision") == "no_changes"
 
     def test_review_pr_with_mocked_diff_returns_pr_fields(self, monkeypatch):
-        # Simulate: valid git repo with one changed controller file
+        # Simulate: valid git repo with one changed controller file (no --since → uncommitted path)
         from sourcecode import prepare_context as _pc
         monkeypatch.setattr(_pc.TaskContextBuilder, "_is_git_repo", lambda self: True)
         monkeypatch.setattr(
-            _pc.TaskContextBuilder, "_get_git_changed_files",
-            lambda self, since=None: ["src/main/java/com/example/UserController.java"],
+            _pc.TaskContextBuilder, "_get_uncommitted_changed_files",
+            lambda self: ["src/main/java/com/example/UserController.java"],
         )
         result = _invoke("prepare-context", "review-pr", str(FIXTURE))
         assert result.exit_code == 0, result.output

sourcecode-1.29.0/.continue-here.md

@@ -1,108 +0,0 @@
-# Continue Here — atlas-cli --agent token reduction
-
-**Paused:** 2026-05-16 (sesión 4)
-**Repo:** `/Users/user/Downloads/atlas-cli`
-**Branch:** master
-**Commit:** `f1cb001 corrigiendo bug --agent que duplicaba tokens sin justificación` (committed)
-
----
-
-## Estado actual
-
-Sesión 4: refactorización de `agent_view()` en `serializer.py` completada. **Todo committed.** Working tree limpio.
-
----
-
-## Qué se hizo esta sesión
-
-### Problema resuelto
-
-`--agent` producía ~11.337 tokens en SAS vs ~5.885 de `--compact`, con contenido casi idéntico. Objetivo: reducir tokens significativamente manteniendo solo lo que diferencia `--agent`.
-
-### Cambios en `agent_view()` (`src/sourcecode/serializer.py`)
-
-| Cambio | Impacto |
-|--------|---------|
-| Elimina `production_dependencies` / `dev_tools` / `test_utilities` / `build_tooling` (dep_groups asdict completo) | Mayor fuente de bloat: -3.000-5.000 tokens en repos grandes |
-| `key_dependencies`: de asdict+50 items → `name+version+role+risk_flags` solo, cap 20 | -500-1.500 tokens |
-| Elimina `confidence_summary.hard_signals` / `soft_signals` / `ignored_signals` | -500-1.000 tokens |
-| Elimina bloque `agent_mode` (contenido estático sin señal) | -80 tokens siempre |
-| Elimina `signals.env_vars.keys[]` (duplica compact `env_map`) | -300-500 tokens |
-| `signals.code_notes.top` cap 10→5, strip a `kind+path+line+text` | -200 tokens |
-| Entry points (no-bootstrap): strip a `path+kind+confidence` (como compact) | reducción moderada |
-| Elimina `development_entry_points` (noise para agentes de producción) | pequeña |
-| `architecture.layers` capado a 5 | pequeña |
-
-**Reducción estimada para SAS:** −40–60% tokens vs `--agent` anterior.
-
-### Campos que permanecen únicos de `--agent`
-
-| Campo | Por qué justifica tokens extra vs `--compact` |
-|-------|----------------------------------------------|
-| `file_relevance` (top-20 scored) | Compact no tiene equivalente. Agente sabe qué leer sin explorar. |
-| `architecture.layers` | Compact solo tiene `architecture_summary` string. |
-| `suspicious_dependencies` | Deps declarados sin import observado. Compact no lo tiene. |
-| `confidence_reasons` | Explicación accionable de secciones low-confidence. Compact no lo tiene. |
-
-### Tests actualizados
-
-- `tests/test_block5_quality.py` — 5 tests de `agent_mode` reemplazados por tests de las nuevas garantías (no `agent_mode`, no `hard_signals`, no `env_vars.keys`, no dep_groups)
-- `tests/test_pipeline_integrity.py` — `test_agent_splits_development_and_auxiliary_eps` → verifica que dev/aux EPs NO aparecen
-
----
-
-## Tests al pausar
-
-Suite completa (sin fallos pre-existentes): **todo verde**
-
-Fallos pre-existentes (no relacionados, ya presentes antes):
-- `test_block2_coverage.py::test_java_marked_unsupported` — DocRecord bug en doc_analyzer.py
-- `test_dependency_analyzer_node_python.py::test_python_requirements_without_lockfile` — versión typer mismatch
-
----
-
-## Pendiente / próximos pasos opcionales
-
-1. **Smoke test en saint-server** para medir tokens reales antes/después:
-   ```bash
-   sourcecode saint-server --agent --output /tmp/agent_new.json
-   python3 -c "import json,sys; d=json.load(open('/tmp/agent_new.json')); print('agent tokens (est):', len(json.dumps(d))//4)"
-   ```
-
-2. **Verificar que `suspicious_dependencies` es útil en repos reales** — en repos Python/JS (no JVM, donde el index de imports no funciona). En JVM siempre vacío por diseño.
-
-3. **Ajustar caps según medición real**: si `file_relevance` (20 files) sigue siendo el mayor contribuyente de tokens, considerar reducir a 15. Medir con `--full` vs default.
-
-4. **Smoke tests delta pendientes** de sesión anterior — ver sección "Smoke tests sesión 3" en historial de commits.
-
----
-
-## Para retomar
-
-```bash
-cd /Users/user/Downloads/atlas-cli
-git log --oneline -3
-# debe mostrar: f1cb001 corrigiendo bug --agent que duplicaba tokens sin justificación
-
-python3 -m pytest tests/ \
-  --ignore=tests/test_block2_coverage.py \
-  --deselect=tests/test_dependency_analyzer_node_python.py::test_python_requirements_without_lockfile_keeps_declared_versions \
-  -q
-# Expected: todo verde
-
-# Verificación rápida agent_view
-python3 -c "
-from sourcecode.serializer import agent_view
-from sourcecode.schema import SourceMap, StackInfo, SourceMapMetadata
-sm = SourceMap(stacks=[StackInfo(stack='python', primary=True)], project_type='python', project_summary='test')
-r = agent_view(sm)
-assert 'agent_mode' not in r
-assert 'production_dependencies' not in r
-assert 'hard_signals' not in r.get('confidence_summary', {})
-print('OK — agent_mode/dep_groups/hard_signals all absent')
-"
-```
-
----
-
-*Pausado 2026-05-16 sesión 4 — gsd:pause-work*