solari-browser 0.2.2__tar.gz → 0.2.3__tar.gz

{solari_browser-0.2.2 → solari_browser-0.2.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: solari-browser
-Version: 0.2.2
+Version: 0.2.3
 Summary: Python SDK for Solari Browser — managed, stealthy remote Chromium over the Playwright wire protocol / raw CDP.
 Project-URL: Homepage, https://getsolari.com
 Author: Solari

{solari_browser-0.2.2 → solari_browser-0.2.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "solari-browser"
-version = "0.2.2"
+version = "0.2.3"
 description = "Python SDK for Solari Browser — managed, stealthy remote Chromium over the Playwright wire protocol / raw CDP."
 readme = "README.md"
 requires-python = ">=3.9"

{solari_browser-0.2.2 → solari_browser-0.2.3}/solari_browser/__init__.py

@@ -37,7 +37,7 @@ from .types import (
     Session,
 )
 
-__version__ = "0.2.2"
+__version__ = "0.2.3"
 
 __all__ = [
     "Solari",

{solari_browser-0.2.2 → solari_browser-0.2.3}/solari_browser/client.py

@@ -81,19 +81,23 @@ def _says_retryable(res: httpx.Response) -> bool:
         return False
     return isinstance(body, dict) and body.get("retryable") is True
 
-# A few 503s are answers, not outages: retrying cannot change them, and swallowing the body would hide the
-# code from the caller. `ProxyTierUnavailable` (explicitly requested proxy tier not servable) is one.
+# Some 5xx are answers, not outages: retrying cannot change them, and swallowing the body would hide the
+# code from the caller. The gateway says so itself with `retryable: false` (502 `PoolResponseUnparseable`:
+# the session may already exist, so a retry creates a second one; 503 `EgressBlockPeekUnsupportedOnFlavor`).
+# `ProxyTierUnavailable` (explicitly requested proxy tier not servable) is also terminal, whatever its flag.
 _TERMINAL_503_CODES = frozenset({"ProxyTierUnavailable"})
 
 
-def _is_terminal_503(res: httpx.Response) -> bool:
-    if res.status_code != 503:
-        return False
+def _is_terminal(res: httpx.Response) -> bool:
     try:
         body = res.json()
     except Exception:  # noqa: BLE001 - non-JSON body is an ordinary outage
         return False
-    return isinstance(body, dict) and body.get("code") in _TERMINAL_503_CODES
+    if not isinstance(body, dict):
+        return False
+    if body.get("retryable") is False:
+        return True
+    return res.status_code == 503 and body.get("code") in _TERMINAL_503_CODES
 
 
 # Mirrors `isLikelyTransientConnect`: which connect failures are worth relaunching.
@@ -486,11 +490,13 @@ class Solari:
                 res = await self._http.request(
                     method, url, headers=headers, content=payload
                 )
-                retry_this = (res.status_code in _RETRYABLE_STATUS and not _is_terminal_503(res)) or (
+                retry_this = (res.status_code in _RETRYABLE_STATUS and not _is_terminal(res)) or (
                     _is_safe_to_replay(method, idempotency_key)
                     and _says_retryable(res)
                 )
-                if res.status_code < 400 or not retry_this:
+                # Out of attempts: hand the last response back so the caller maps its
+                # status and `code` like any other error, not a status-less "exhausted".
+                if res.status_code < 400 or not retry_this or attempt == self._max_attempts:
                     return res
                 last_err = SolariError(f"Solari {method} {path}: {res.status_code}", res.status_code)
             except Exception as err:  # noqa: BLE001 - all transport errors are retryable

{solari_browser-0.2.2 → solari_browser-0.2.3}/tests/test_client.py

@@ -286,16 +286,26 @@ async def test_does_not_retry_400(gw):
 
 
 @sync
-async def test_exhausting_attempts_raises(gw):
+async def test_exhausting_attempts_on_5xx_keeps_the_status(gw):
     gw.route("POST", "/sessions", 503, {"error": "no capacity"})
     c = client(gw, backoff_ms=1, max_attempts=2)
     with pytest.raises(SolariError) as ei:
         await c.sessions.create()
     await c.close()
-    assert "exhausted 2 attempts" in str(ei.value)
+    assert ei.value.status == 503
     assert len(gw.seen) == 2
 
 
+@sync
+async def test_exhausting_attempts_on_transport_error_raises_exhausted():
+    c = Solari(api_key="slr_live_test", base_url="http://127.0.0.1:1", backoff_ms=1, max_attempts=2)
+    with pytest.raises(SolariError) as ei:
+        await c.sessions.create()
+    await c.close()
+    assert "exhausted 2 attempts" in str(ei.value)
+    assert ei.value.status is None
+
+
 # ---- release / replay ---------------------------------------------------------
 
 

{solari_browser-0.2.2 → solari_browser-0.2.3}/tests/test_retry_hint.py

@@ -115,3 +115,52 @@ def test_ordinary_503_is_still_retried(gw):  # noqa: F811
 
     create()
     assert len(gw.seen) == 2
+
+
+def test_pool_response_unparseable_502_is_not_retried_and_keeps_its_code(gw):  # noqa: F811
+    # The pool may already have created the session, so a retry would leave a second one behind.
+    gw.route("POST", "/sessions", 502,
+             {"error": "Pool returned an invalid response", "code": "PoolResponseUnparseable", "retryable": False})
+    gw.route("POST", "/sessions", 201, {"sessionId": "s-1", "wsEndpoint": "ws://127.0.0.1:1/ws"})
+
+    c = client(gw, backoff_ms=1)
+
+    @sync
+    async def create():
+        return await c.sessions.create()
+
+    with pytest.raises(SolariError) as info:
+        create()
+    assert info.value.code == "PoolResponseUnparseable"
+    assert info.value.status == 502
+    assert len(gw.seen) == 1, "retryable:false must not be retried"
+
+
+def test_bare_502_is_still_retried(gw):  # noqa: F811
+    gw.route("POST", "/sessions", 502, {"error": "bad gateway"})
+    gw.route("POST", "/sessions", 201, {"sessionId": "s-1", "wsEndpoint": "ws://127.0.0.1:1/ws"})
+
+    c = client(gw, backoff_ms=1)
+
+    @sync
+    async def create():
+        return await c.sessions.create()
+
+    create()
+    assert len(gw.seen) == 2
+
+
+def test_final_5xx_keeps_its_status_and_code(gw):  # noqa: F811
+    gw.route("POST", "/sessions", 503, {"error": "browser unhealthy", "code": "BrowserUnhealthy"})
+
+    c = client(gw, backoff_ms=1)
+
+    @sync
+    async def create():
+        return await c.sessions.create()
+
+    with pytest.raises(SolariError) as info:
+        create()
+    assert info.value.status == 503
+    assert info.value.code == "BrowserUnhealthy"
+    assert len(gw.seen) == 2, "both attempts are still made"