smooth-py 0.4.4.dev20260324__tar.gz → 0.4.4.dev20260423__tar.gz

{smooth_py-0.4.4.dev20260324 → smooth_py-0.4.4.dev20260423}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: smooth-py
-Version: 0.4.4.dev20260324
+Version: 0.4.4.dev20260423
 Summary: 
 Author: Luca Pinchetti
 Author-email: luca@circlemind.co

{smooth_py-0.4.4.dev20260324 → smooth_py-0.4.4.dev20260423}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "smooth-py"
-version = "0.4.4.dev20260324"
+version = "0.4.4.dev20260423"
 description = ""
 authors = [
     {name = "Luca Pinchetti",email = "luca@circlemind.co"}

{smooth_py-0.4.4.dev20260324 → smooth_py-0.4.4.dev20260423}/src/smooth/__init__.py

@@ -14,6 +14,7 @@ from ._tools import (
   AsyncSmoothTool,
   SmoothTool,
 )
+from .models import Secret
 
 # Export public API
 __all__ = [
@@ -28,6 +29,7 @@ __all__ = [
   "BadRequestError",
   "TimeoutError",
   "ToolCallError",
+  "Secret",
   # Deprecated
   "TaskHandle",
   "AsyncTaskHandle",

{smooth_py-0.4.4.dev20260324 → smooth_py-0.4.4.dev20260423}/src/smooth/_client.py

@@ -5,6 +5,7 @@ import io
 import os
 import secrets
 import threading
+import warnings
 from pathlib import Path
 from types import TracebackType
 from typing import Any, Callable, Coroutine, Generator, Sequence, Type, TypedDict, TypeVar, cast
@@ -177,6 +178,7 @@ class SmoothClient(BaseClient):
     profile_id: str | None = None,
     profile_read_only: bool = False,
     stealth_mode: bool = False,
+    use_stealth: bool = True,
     proxy_server: str | None = None,
     proxy_username: str | None = None,
     proxy_password: str | None = None,
@@ -190,6 +192,12 @@ class SmoothClient(BaseClient):
     show_cursor: bool = False,
   ) -> SessionHandle:
     """Opens a browser session."""
+    if stealth_mode:
+      warnings.warn(
+        "'stealth_mode' is deprecated and ignored, use 'use_stealth' instead (defaults to True)",
+        DeprecationWarning,
+        stacklevel=2,
+      )
     # Handle proxy_server="self" - auto-start local proxy tunnel
     self_proxy = proxy_server == "self"
     if self_proxy and not proxy_password:
@@ -206,6 +214,7 @@ class SmoothClient(BaseClient):
       profile_id=profile_id,
       profile_read_only=profile_read_only,
       stealth_mode=stealth_mode,
+      use_stealth=use_stealth,
       proxy_server=proxy_server,
       proxy_username=proxy_username,
       proxy_password=proxy_password,
@@ -252,6 +261,7 @@ class SmoothClient(BaseClient):
     profile_id: str | None = None,
     profile_read_only: bool = False,
     stealth_mode: bool = False,
+    use_stealth: bool = True,
     proxy_server: str | None = None,
     proxy_username: str | None = None,
     proxy_password: str | None = None,
@@ -285,7 +295,8 @@ class SmoothClient(BaseClient):
         session_id: (Deprecated, now `profile_id`) Browser session ID to use.
         profile_id: Browser profile ID to use. Each profile maintains its own state, such as cookies and login credentials.
         profile_read_only: If true, the profile specified by `profile_id` will be loaded in read-only mode.
-        stealth_mode: Run the browser in stealth mode.
+        stealth_mode: (Deprecated, ignored) Use `use_stealth` instead.
+        use_stealth: Run the browser in stealth mode. Default is True.
         proxy_server: Proxy server address to route browser traffic through.
         proxy_username: Proxy server username.
         proxy_password: Proxy server password.
@@ -307,6 +318,12 @@ class SmoothClient(BaseClient):
     Raises:
         ApiException: If the API request fails.
     """
+    if stealth_mode:
+      warnings.warn(
+        "'stealth_mode' is deprecated and ignored, use 'use_stealth' instead (defaults to True)",
+        DeprecationWarning,
+        stacklevel=2,
+      )
     custom_tools_ = (
       [tool if isinstance(tool, SmoothTool) else SmoothTool(**tool) for tool in custom_tools] if custom_tools else None
     )
@@ -332,6 +349,7 @@ class SmoothClient(BaseClient):
         profile_id=profile_id or session_id,
         profile_read_only=profile_read_only,
         stealth_mode=stealth_mode,
+        use_stealth=use_stealth,
         proxy_server=proxy_server,
         proxy_username=proxy_username,
         proxy_password=proxy_password,
@@ -628,6 +646,7 @@ class SmoothAsyncClient(BaseClient):
     profile_id: str | None = None,
     profile_read_only: bool = False,
     stealth_mode: bool = False,
+    use_stealth: bool = True,
     proxy_server: str | None = None,
     proxy_username: str | None = None,
     proxy_password: str | None = None,
@@ -651,6 +670,12 @@ class SmoothAsyncClient(BaseClient):
         async with client.session(...) as session:
             ...
     """
+    if stealth_mode:
+      warnings.warn(
+        "'stealth_mode' is deprecated and ignored, use 'use_stealth' instead (defaults to True)",
+        DeprecationWarning,
+        stacklevel=2,
+      )
     return _AsyncSessionContextManager(self._session_coro(
       url=None,
       files=files,
@@ -661,6 +686,7 @@ class SmoothAsyncClient(BaseClient):
       profile_id=profile_id,
       profile_read_only=profile_read_only,
       stealth_mode=stealth_mode,
+      use_stealth=use_stealth,
       proxy_server=proxy_server,
       proxy_username=proxy_username,
       proxy_password=proxy_password,
@@ -695,6 +721,7 @@ class SmoothAsyncClient(BaseClient):
     profile_id: str | None = None,
     profile_read_only: bool = False,
     stealth_mode: bool = False,
+    use_stealth: bool = True,
     proxy_server: str | None = None,
     proxy_username: str | None = None,
     proxy_password: str | None = None,
@@ -724,6 +751,7 @@ class SmoothAsyncClient(BaseClient):
       profile_id=profile_id,
       profile_read_only=profile_read_only,
       stealth_mode=stealth_mode,
+      use_stealth=use_stealth,
       proxy_server=proxy_server,
       proxy_username=proxy_username,
       proxy_password=proxy_password,
@@ -783,6 +811,7 @@ class SmoothAsyncClient(BaseClient):
     profile_id: str | None = None,
     profile_read_only: bool = False,
     stealth_mode: bool = False,
+    use_stealth: bool = True,
     proxy_server: str | None = None,
     proxy_username: str | None = None,
     proxy_password: str | None = None,
@@ -815,7 +844,8 @@ class SmoothAsyncClient(BaseClient):
         session_id: (Deprecated, now `profile_id`) Browser session ID to use.
         profile_id: Browser profile ID to use. Each profile maintains its own state, such as cookies and login credentials.
         profile_read_only: If true, the profile specified by `profile_id` will be loaded in read-only mode.
-        stealth_mode: Run the browser in stealth mode.
+        stealth_mode: (Deprecated, ignored) Use `use_stealth` instead.
+        use_stealth: Run the browser in stealth mode. Default is True.
         proxy_server: Proxy server address to route browser traffic through.
         proxy_username: Proxy server username.
         proxy_password: Proxy server password.
@@ -837,6 +867,12 @@ class SmoothAsyncClient(BaseClient):
     Raises:
         ApiException: If the API request fails.
     """
+    if stealth_mode:
+      warnings.warn(
+        "'stealth_mode' is deprecated and ignored, use 'use_stealth' instead (defaults to True)",
+        DeprecationWarning,
+        stacklevel=2,
+      )
     if proxy_server == "self" and task is not None:
       raise BadRequestError(
         'proxy_server="self" is not supported in run(). '
@@ -864,6 +900,7 @@ class SmoothAsyncClient(BaseClient):
       profile_id=profile_id or session_id,
       profile_read_only=profile_read_only,
       stealth_mode=stealth_mode,
+      use_stealth=use_stealth,
       proxy_server=proxy_server,
       proxy_username=proxy_username,
       proxy_password=proxy_password,  # pyright: ignore[reportArgumentType]

{smooth_py-0.4.4.dev20260324 → smooth_py-0.4.4.dev20260423}/src/smooth/_interface.py

@@ -19,6 +19,7 @@ from .models import (
   ActionGotoResponse,
   ActionRunTaskResponse,
   BrowserSessionResponse,
+  Secret,
   TaskEvent,
   TaskResponse,
   TaskUpdateRequest,
@@ -566,6 +567,7 @@ class AsyncSessionHandle(AsyncTaskHandleEx):
     response_model: dict[str, Any] | Type[BaseModel] | None = None,
     url: str | None = None,
     metadata: dict[str, Any] | None = None,
+    secrets: dict[str, Secret] | None = None,
   ):
     """Extracts from the given URL."""
     if response_model is not None and not isinstance(response_model, dict):
@@ -580,6 +582,7 @@ class AsyncSessionHandle(AsyncTaskHandleEx):
           "response_model": response_model,
           "url": url,
           "metadata": metadata,
+          "secrets": {k: v.model_dump(context={"reveal_secrets": True}) for k, v in secrets.items()} if secrets else None,
         },
       },
     )
@@ -721,9 +724,10 @@ class SessionHandle(TaskHandleEx):
     response_model: dict[str, Any] | Type[BaseModel] | None = None,
     url: str | None = None,
     metadata: dict[str, Any] | None = None,
+    secrets: dict[str, Secret] | None = None,
   ):
     """Extracts from the given URL."""
-    return self._run_async(self._async_handle.run_task(task, max_steps, response_model, url, metadata))
+    return self._run_async(self._async_handle.run_task(task, max_steps, response_model, url, metadata, secrets))
 
   def result(self, timeout: int | None = None, poll_interval: float | None = None) -> "TaskResponse":
     """Waits for the session to close and returns the result."""

{smooth_py-0.4.4.dev20260324 → smooth_py-0.4.4.dev20260423}/src/smooth/_proxy.py

@@ -9,7 +9,11 @@ The proxy connects to a remote FRP server and exposes a local SOCKS5 proxy
 that can be used by the browser session.
 """
 
+import collections
+import contextlib
+import fcntl
 import logging
+import os
 import platform
 import shutil
 import subprocess
@@ -24,14 +28,28 @@ from dataclasses import dataclass, field
 from pathlib import Path
 from typing import Any
 
+_frpc_logger = logging.getLogger("smooth.frpc")
+
 # FRP version to use
 FRP_VERSION = "0.66.0"
 
 # Directory to store FRP binaries and configs
 FRP_DIR = Path.home() / ".smooth" / "frp"
 
-# Lock to prevent concurrent FRP installations from racing
-_install_lock = threading.Lock()
+@contextlib.contextmanager
+def _file_lock(lock_path: Path):
+    """Cross-process file lock using fcntl (Unix) or msvcrt (Windows)."""
+    lock_path.parent.mkdir(parents=True, exist_ok=True)
+    fd = open(lock_path, "w")
+    try:
+        if platform.system().lower() == "windows":
+            import msvcrt
+            msvcrt.locking(fd.fileno(), msvcrt.LK_LOCK, 1)
+        else:
+            fcntl.flock(fd, fcntl.LOCK_EX)
+        yield
+    finally:
+        fd.close()
 
 
 @dataclass
@@ -48,9 +66,11 @@ class ProxyConfig:
 class _ProxyState:
   """Internal state for a proxy instance."""
 
-  process: subprocess.Popen[bytes] | None = None
+  process: subprocess.Popen[str] | None = None
   config_file: Path | None = None
   lock: threading.Lock = field(default_factory=threading.Lock)
+  log_tail: collections.deque[str] = field(default_factory=lambda: collections.deque(maxlen=200))
+  drain_thread: threading.Thread | None = None
 
 
 class FRPProxy:
@@ -114,16 +134,16 @@ class FRPProxy:
     bin_name = "frpc.exe" if os_name == "windows" else "frpc"
     bin_path = FRP_DIR / bin_name
 
-    # Check if binary already exists
+    # Fast path: binary already installed
     if bin_path.exists():
       return bin_path
 
-    with _install_lock:
-      # Re-check after acquiring lock (another thread may have installed it)
+    # Cross-process lock: only one process downloads at a time
+    with _file_lock(FRP_DIR / ".install.lock"):
+      # Re-check after acquiring lock (another process may have installed it)
       if bin_path.exists():
         return bin_path
 
-      # Construct download URL
       folder_name = f"frp_{FRP_VERSION}_{os_name}_{arch}"
       filename = f"{folder_name}.{ext}"
       url = f"https://github.com/fatedier/frp/releases/download/v{FRP_VERSION}/{filename}"
@@ -149,11 +169,14 @@ class FRPProxy:
             if attempt == max_retries - 1:
               raise
             backoff = 2 ** attempt
-            logging.getLogger("smooth").warning("FRP download failed (attempt %d/%d), retrying in %ds: %s", attempt + 1, max_retries, backoff, e)
+            logging.getLogger("smooth").warning(
+              "FRP download failed (attempt %d/%d), retrying in %ds: %s",
+              attempt + 1, max_retries, backoff, e,
+            )
             time.sleep(backoff)
 
-        # Extract to a unique temp dir to avoid races
-        extract_dir = FRP_DIR / f"extract_tmp_{threading.get_ident()}"
+        # Extract to a unique temp dir (PID-based to avoid cross-process collisions)
+        extract_dir = FRP_DIR / f"extract_tmp_{os.getpid()}"
         extract_dir.mkdir(exist_ok=True)
 
         if ext == "zip":
@@ -163,23 +186,26 @@ class FRPProxy:
           with tarfile.open(tmp_path, "r:gz") as t:
             t.extractall(extract_dir)
 
-        # Move binary
+        # Move binary: write to temp name, chmod, then atomic rename
         src = extract_dir / folder_name / bin_name
-        if bin_path.exists():
-          bin_path.unlink()
-        shutil.move(str(src), str(bin_path))
+        tmp_bin = FRP_DIR / f".{bin_name}.tmp.{os.getpid()}"
+        shutil.move(str(src), str(tmp_bin))
+
+        if os_name != "windows":
+          tmp_bin.chmod(0o755)
+
+        os.rename(str(tmp_bin), str(bin_path))
 
         # Cleanup
-        tmp_path.unlink()
+        tmp_path.unlink(missing_ok=True)
         shutil.rmtree(extract_dir, ignore_errors=True)
 
-        # Make executable on Unix
-        if os_name != "windows":
-          bin_path.chmod(0o755)
-
         return bin_path
 
       except Exception as e:
+        # Clean up partial artifacts on failure
+        tmp_bin = FRP_DIR / f".{bin_name}.tmp.{os.getpid()}"
+        tmp_bin.unlink(missing_ok=True)
         raise RuntimeError(f"Failed to install FRP: {e}") from e
 
   def _create_config(self) -> Path:
@@ -201,7 +227,8 @@ auth:
   token: "{self.config.token}"
 
 log:
-  level: "error"
+  to: "console"
+  level: "info"
 
 transport:
   protocol: "wss"
@@ -236,27 +263,52 @@ proxies:
         # Build command
         cmd = [str(self._bin_path), "-c", str(self._state.config_file)]
 
-        # Start process with suppressed output
+        # Pipe stdout/stderr so we can forward frpc's own logs through Python's
+        # logging system (captured by pytest/log handlers) and keep a bounded
+        # tail for error reporting.
         self._state.process = subprocess.Popen(
           cmd,
-          stdout=subprocess.DEVNULL,
-          stderr=subprocess.DEVNULL,
+          stdout=subprocess.PIPE,
+          stderr=subprocess.STDOUT,
+          bufsize=1,
+          text=True,
         )
 
-        # Give it a moment to start and check if it failed immediately
-        try:
-            # Wait for the process to exit or timeout
-            stdout_data, stderr_data = self._state.process.communicate(timeout=1.0)
+        session_id = self.config.session_id
+        proc = self._state.process
+        tail = self._state.log_tail
+
+        def _drain() -> None:
+          assert proc.stdout is not None
+          try:
+            for line in proc.stdout:
+              line = line.rstrip()
+              if not line:
+                continue
+              tail.append(line)
+              _frpc_logger.info("[%s] %s", session_id, line)
+          except Exception:
+            pass
 
-            # If we get here, the process exited within 1 second
-            stderr = stderr_data.decode() if stderr_data else ""
-            stdout = stdout_data.decode() if stdout_data else ""
-            self._cleanup()
-            raise RuntimeError(f"FRP process exited immediately: {stderr}. Output: {stdout}")
+        self._state.drain_thread = threading.Thread(
+          target=_drain, name=f"frpc-drain-{session_id}", daemon=True,
+        )
+        self._state.drain_thread.start()
 
+        # Give it a moment to start and check if it failed immediately.
+        try:
+          self._state.process.wait(timeout=1.0)
+          rc = self._state.process.returncode
+          # Let the drain thread flush what it has.
+          self._state.drain_thread.join(timeout=0.5)
+          tail_str = "\n".join(tail)
+          self._cleanup()
+          raise RuntimeError(
+            f"FRP process exited immediately (rc={rc}). frpc output:\n{tail_str}"
+          )
         except subprocess.TimeoutExpired:
-            # Process is still running after 1 second
-            pass
+          # Process is still running after 1 second — expected happy path.
+          pass
 
       except Exception as e:
         self._cleanup()
@@ -283,6 +335,13 @@ proxies:
         pass
       self._state.process = None
 
+    if self._state.drain_thread is not None:
+      try:
+        self._state.drain_thread.join(timeout=1.0)
+      except Exception:
+        pass
+      self._state.drain_thread = None
+
     if self._state.config_file is not None:
       try:
         if self._state.config_file.exists():

{smooth_py-0.4.4.dev20260324 → smooth_py-0.4.4.dev20260423}/src/smooth/cli.py

@@ -288,7 +288,7 @@ async def start_session(args: argparse.Namespace):
       device=args.device,
       allowed_urls=allowed_urls,
       enable_recording=True,  # Enabled by default
-      stealth_mode=True,  # Enabled by default
+      use_stealth=True,  # Enabled by default
       use_adblock=True,  # Enabled by default
       proxy_server=proxy_server,
       proxy_username=proxy_username,

{smooth_py-0.4.4.dev20260324 → smooth_py-0.4.4.dev20260423}/src/smooth/models/__init__.py

@@ -21,6 +21,12 @@ SensitiveStr = Annotated[SecretStr, PlainSerializer(_serialize_secret, when_used
 
 DeviceType = Literal["desktop", "mobile", "desktop-lg"]
 
+class Secret(BaseModel):
+  """A secret value with URL-based access control."""
+
+  value: SensitiveStr = Field(description="The secret value.")
+  allowed_urls: list[str] = Field(description="URL patterns where this secret can be used (e.g. 'https://github.com/*').")
+
 
 class Certificate(BaseModel):
   """Client certificate for accessing secure websites.
@@ -112,7 +118,12 @@ class TaskRequest(BaseModel):
       "Changes made during the task will not be saved back to the profile."
     ),
   )
-  stealth_mode: bool = Field(default=False, description="Run the browser in stealth mode.")
+  stealth_mode: bool = Field(
+    default=False,
+    description="(Deprecated, ignored) Use `use_stealth` instead. Stealth is on by default.",
+    deprecated=True,
+  )
+  use_stealth: bool = Field(default=True, description="Run the browser in stealth mode. Default is True.")
   proxy_server: str | None = Field(
     default=None,
     description=("Proxy server url to route browser traffic through."),
@@ -361,6 +372,7 @@ class BrowserSessionRequest(BaseModel):
   proxy_username: str | None = Field(default=None, description="Proxy server username.")
   proxy_password: SensitiveStr | None = Field(default=None, description="Proxy server password.")
   extensions: list[str] | None = Field(default=None, description="List of extensions to install for the task.")
+  use_stealth: bool = Field(default=True, description="Run the browser in stealth mode. Default is True.")
 
   @model_validator(mode="before")
   @classmethod
@@ -374,6 +386,17 @@ class BrowserSessionRequest(BaseModel):
       data["profile_id"] = data.pop("session_id")  # pyright: ignore[reportUnknownMemberType]
     return data  # pyright: ignore[reportUnknownVariableType]
 
+  @model_validator(mode="before")
+  @classmethod
+  def _handle_deprecated_stealth_mode(cls, data: Any) -> Any:
+    if isinstance(data, dict) and "stealth_mode" in data:
+      warnings.warn(
+        "'stealth_mode' is deprecated and ignored, use 'use_stealth' instead (defaults to True)",
+        DeprecationWarning,
+        stacklevel=2,
+      )
+    return data  # pyright: ignore[reportUnknownVariableType]
+
   @computed_field(return_type=str | None)
   @property
   def session_id(self):