smart-spatial-system 0.2.2__tar.gz → 0.2.3__tar.gz

{smart_spatial_system-0.2.2/smart_spatial_system.egg-info → smart_spatial_system-0.2.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: smart_spatial_system
-Version: 0.2.2
+Version: 0.2.3
 Summary: Plugin-based GeoAI backend: natural-language questions become QuerySpecs, DAG plans, and map/table/report outputs.
 Author: Araz Shah
 License-Expression: MIT

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/config/plugins/distance_calculator.example.yaml

@@ -14,6 +14,7 @@ drop_failed: false
 
 # Optional CRS hint. Does not transform data.
 source_crs: null
+target_crs: null
 warn_if_geographic_crs: true
 
 fields:

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/config/plugins/distance_calculator.yaml

@@ -5,6 +5,7 @@ preserve_properties: true
 drop_failed: false
 
 source_crs: null
+target_crs: null
 warn_if_geographic_crs: true
 
 fields:

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/config/plugins/nearest_neighbor.example.yaml

@@ -15,6 +15,7 @@ drop_unmatched: false
 include_target_geometry: false
 
 source_crs: null
+target_crs: null
 warn_if_geographic_crs: true
 
 fields:

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/config/plugins/nearest_neighbor.yaml

@@ -7,6 +7,7 @@ drop_unmatched: false
 include_target_geometry: false
 
 source_crs: null
+target_crs: null
 warn_if_geographic_crs: true
 
 fields:

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/orchestrator/planning/llm_spec_generator.py

@@ -1023,6 +1023,25 @@ Pending operations, not executable yet:
 {pending}
 
 Important mappings:
+- CRITICAL - any distance/nearest-neighbor operation (filter_by_distance,
+  spatial_nearest, nearest_neighbor, distance_to) needs BOTH of its vector
+  inputs reprojected with crs_transform first, not just the source/site
+  layer. Distance is computed from raw geometry coordinates with zero CRS
+  awareness - if one layer is reprojected to a metric CRS and the other is
+  left in whatever CRS it was uploaded in (commonly EPSG:4326), the
+  "distance" returned is a number between two points in DIFFERENT CRSs,
+  meaningless but not an error by itself. Reproject EVERY layer that feeds
+  a distance operation to the SAME target CRS, and pass that CRS as both
+  source_crs and target_crs on the distance operation itself - this lets
+  the operation catch a mismatch and raise instead of returning a bogus
+  value:
+    crs_transform(sites) -> sites_metric                 (target_crs="EPSG:31256")
+    crs_transform(metro) -> metro_metric                 (target_crs="EPSG:31256")
+    spatial_nearest(source=sites_metric, target=metro_metric,
+      params={{"source_crs": "EPSG:31256", "target_crs": "EPSG:31256"}})
+  WRONG: spatial_nearest(source=sites_metric, target=metro) - "metro" was
+  never reprojected, so its coordinates are still in the original CRS.
+
 - "nearer than X meters to POI":
   op="filter_by_distance"
   inputs={{"vector": "<source>", "reference": "<poi>"}}
@@ -1820,6 +1839,101 @@ def _validate_score_features_field_chaining(spec: QuerySpec) -> None:
                 )
 
 
+# The two vector-bearing input roles for each distance/nearest-neighbor
+# operation, in (this-layer, other-layer) order - used to check that both
+# were reprojected to the same CRS, not just one of them.
+_DISTANCE_OPS_VECTOR_ROLES = {
+    "spatial_nearest": ("source", "target"),
+    "nearest_neighbor": ("source", "target"),
+    "filter_by_distance": ("vector", "reference"),
+    "distance_to": ("vector", "target"),
+}
+
+
+def _crs_transform_target_crs(
+    ref: str, ops_by_output: dict[str, OperationSpec]
+) -> str | None:
+    """
+    The target_crs a ref was reprojected to, if ref is literally the
+    output of a crs_transform operation - None otherwise (ref is a raw
+    entity, or the output of some other operation).
+
+    Deliberately not a full ancestor walk (contrast _ancestor_refs): this
+    only recognizes reprojection immediately before the distance op, which
+    is exactly the shape both the correct pattern
+    (accessibility_query_spec.py) and the observed bug produce - crs_transform
+    feeding straight into the distance operation. Walking further back
+    would let this claim to know a ref's CRS through operations that don't
+    preserve one (a join, a filter combining two layers), which is a
+    guess this module has no basis for making.
+    """
+    op = ops_by_output.get(ref)
+    if op is None or op.op != "crs_transform":
+        return None
+
+    target_crs = op.params.get("target_crs")
+    return str(target_crs) if target_crs else None
+
+
+def _validate_distance_op_crs_symmetry(spec: QuerySpec) -> None:
+    """
+    Catch a distance/nearest-neighbor operation whose two vector inputs
+    were reprojected asymmetrically - one just-reprojected via
+    crs_transform, the other not (or reprojected to a different CRS).
+
+    Distance here is computed from raw geometry coordinates with zero CRS
+    awareness (see calculate_distances/find_nearest_neighbors). Reprojecting
+    only the source/site layer and leaving the target/amenity layer in its
+    original CRS - typically EPSG:4326 from the source upload - produces a
+    "distance" between two points in different CRSs: a large, consistent,
+    completely bogus number, not an error, because nothing before this
+    check ever compared the two layers' actual CRSs.
+
+    Deliberately conservative, same posture as
+    _validate_score_features_field_chaining: only fires when this module
+    can see BOTH refs' immediate CRS provenance disagree (see
+    _crs_transform_target_crs's docstring for exactly what "immediate"
+    means here). A ref this module can't trace to a crs_transform output
+    at all - already in a metric CRS from its source, for instance - is
+    left unvalidated rather than guessed at.
+    """
+    ops_by_output: dict[str, OperationSpec] = {
+        op.output: op for op in spec.operations if op.output
+    }
+
+    for op in spec.operations:
+        roles = _DISTANCE_OPS_VECTOR_ROLES.get(op.op)
+        if roles is None:
+            continue
+
+        this_role, other_role = roles
+        this_ref = op.inputs.get(this_role)
+        other_ref = op.inputs.get(other_role)
+        if not this_ref or not other_ref:
+            continue
+
+        this_crs = _crs_transform_target_crs(str(this_ref), ops_by_output)
+        other_crs = _crs_transform_target_crs(str(other_ref), ops_by_output)
+
+        if this_crs is None and other_crs is None:
+            continue
+
+        if this_crs == other_crs:
+            continue
+
+        raise LLMSpecGenerationError(
+            f"{op.op!r} (output={op.output!r}) reads {this_role}={this_ref!r} "
+            f"(reprojected to {this_crs!r}) and {other_role}={other_ref!r} "
+            f"(reprojected to {other_crs!r}) - these do not match. Every "
+            "layer feeding a distance/nearest-neighbor operation must be "
+            "reprojected with crs_transform to the SAME target CRS before "
+            "the operation runs, or the resulting distance is computed "
+            "between points in two different CRSs and is meaningless. See "
+            "the 'any distance/nearest-neighbor operation needs BOTH of "
+            "its vector inputs reprojected' guidance."
+        )
+
+
 class LLMQuerySpecGenerator:
     def __init__(
         self,
@@ -1869,6 +1983,7 @@ class LLMQuerySpecGenerator:
         spec = normalize_llm_query_spec_for_planning(spec)
         _validate_operation_input_roles(spec)
         _validate_score_features_field_chaining(spec)
+        _validate_distance_op_crs_symmetry(spec)
         return spec
 
 

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/orchestrator/planning/op_catalog.py

@@ -85,6 +85,10 @@ _NEAREST_PARAM_MAP = {
     "precision": "precision",
     "include_target_geometry": "include_target_geometry",
     "source_crs": "source_crs",
+    # Passing both source_crs and target_crs lets find_nearest_neighbors
+    # catch a source/target CRS mismatch and raise instead of silently
+    # computing a meaningless planar distance - see its docstring.
+    "target_crs": "target_crs",
     # Lets a plan chain several nearest-neighbour steps over the same
     # features, each writing its own distance field - see the capability's
     # docstring.
@@ -342,6 +346,10 @@ OP_CATALOG: dict[str, OpDescriptor] = {
             "precision": "precision",
             "drop_failed": "drop_failed",
             "source_crs": "source_crs",
+            # Passing both source_crs and target_crs lets calculate_distances
+            # catch a source/target CRS mismatch and raise instead of
+            # silently computing a meaningless planar distance.
+            "target_crs": "target_crs",
             "metadata": "metadata",
         },
         output_type="vector",

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/plugins/distance_calculator.py

@@ -713,6 +713,51 @@ def _is_geographic_crs(value: Any) -> bool:
     }
 
 
+def _raise_if_crs_mismatch(
+    *,
+    source_crs: str | None,
+    target_crs: str | None,
+    capability_name: str,
+) -> None:
+    """
+    Raise if source_crs and target_crs are both supplied and don't match.
+
+    Distance/nearest-neighbor calculation here works on raw geometry
+    coordinates with zero CRS awareness - it has no way to notice on its
+    own that source_features and target_features are in different CRSs
+    (e.g. only the source layer was reprojected with crs_transform before
+    this call, or the two calls in a plan used different target CRSs).
+    Left unchecked, that produces a number - not an error - that is
+    physically meaningless: a planar distance between a point in metres
+    and a point in degrees, indistinguishable from a real distance
+    without inspecting the value by hand. This is opt-in (only checked
+    when the caller supplies BOTH hints) rather than required, so callers
+    that don't pass CRS hints at all keep today's behaviour unchanged.
+
+    Comparison is a normalized (stripped, uppercased) string match, not
+    true CRS equivalence - "EPSG:4326" and "CRS:84" describe the same CRS
+    but won't match each other here. That is a deliberately conservative
+    trade-off: false negatives (a real mismatch expressed as equivalent-
+    but-differently-spelled CRSs, missed) are possible, but false
+    positives (correctly matching CRSs rejected) are not, since this
+    module has no CRS-equivalence table to consult.
+    """
+    if not source_crs or not target_crs:
+        return
+
+    if str(source_crs).strip().upper() == str(target_crs).strip().upper():
+        return
+
+    raise ValueError(
+        f"{capability_name}: source_crs={source_crs!r} and "
+        f"target_crs={target_crs!r} do not match. Computing distance "
+        "between features in two different CRSs produces a meaningless "
+        "number, not an error - reproject both source_features and "
+        "target_features to the same CRS with crs_transform first, then "
+        "pass matching source_crs/target_crs here."
+    )
+
+
 def _make_distance_feature(
     *,
     source_feature: dict[str, Any],
@@ -846,6 +891,7 @@ def _build_vector_metadata(features: list[dict[str, Any]]) -> dict[str, Any]:
         "precision",
         "drop_failed",
         "source_crs",
+        "target_crs",
         "metadata",
     ],
     output_kind="vector",
@@ -871,6 +917,7 @@ def calculate_distances(
     precision: int | None = None,
     drop_failed: bool | None = None,
     source_crs: str | None = None,
+    target_crs: str | None = None,
     metadata: dict[str, Any] | None = None,
 ) -> VectorOut:
     """
@@ -890,7 +937,19 @@ def calculate_distances(
         drop_failed:
             If True, failed source/pair results are removed.
         source_crs:
-            CRS hint. Used only for warning metadata.
+            CRS hint for source_features.
+        target_crs:
+            CRS hint for target_features.
+
+            Distance here is computed from raw geometry coordinates with
+            no CRS awareness at all - if source_features and
+            target_features are actually in different CRSs, the result is
+            a number, not an error: meaningless, but indistinguishable
+            from a real distance without inspecting it by hand. Supplying
+            both source_crs and target_crs lets this function catch that
+            case and raise instead of returning it. Neither hint changes
+            how distance is computed; only crs_transform actually
+            reprojects data.
         metadata:
             Optional metadata to merge.
 
@@ -920,8 +979,15 @@ def calculate_distances(
     )
 
     final_source_crs = pick_first(source_crs, config.get("source_crs"), default=None)
+    final_target_crs = pick_first(target_crs, config.get("target_crs"), default=None)
     warn_if_geographic_crs = bool(config.get("warn_if_geographic_crs", True))
 
+    _raise_if_crs_mismatch(
+        source_crs=final_source_crs,
+        target_crs=final_target_crs,
+        capability_name="calculate_distances",
+    )
+
     preserve_properties = bool(config.get("preserve_properties", True))
     fields = _configured_fields(config)
 
@@ -1102,6 +1168,7 @@ def calculate_distances(
         "coordinate_precision": final_precision,
         "drop_failed": final_drop_failed,
         "source_crs": final_source_crs,
+        "target_crs": final_target_crs,
         "planar_only": True,
         "warning": geographic_warning,
         "source_feature_count": len(source_items),

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/plugins/nearest_neighbor.py

@@ -45,6 +45,7 @@ from plugins.distance_calculator import (
     _calculate_distance,
     _geometry_bbox,
     _is_geographic_crs,
+    _raise_if_crs_mismatch,
     _validate_engine,
 )
 
@@ -356,6 +357,7 @@ def _build_vector_metadata(features: list[dict[str, Any]]) -> dict[str, Any]:
         "drop_unmatched",
         "include_target_geometry",
         "source_crs",
+        "target_crs",
         "metadata",
     ],
     output_kind="vector",
@@ -383,6 +385,7 @@ def find_nearest_neighbors(
     drop_unmatched: bool | None = None,
     include_target_geometry: bool | None = None,
     source_crs: str | None = None,
+    target_crs: str | None = None,
     distance_field: str | None = None,
     metadata: dict[str, Any] | None = None,
 ) -> VectorOut:
@@ -407,7 +410,20 @@ def find_nearest_neighbors(
         include_target_geometry:
             If True, target geometry is copied into output properties.
         source_crs:
-            CRS hint. Used only for warning metadata.
+            CRS hint for source_features.
+        target_crs:
+            CRS hint for target_features.
+
+            Distance here is computed from raw geometry coordinates with no
+            CRS awareness at all - if source_features and target_features
+            are actually in different CRSs (e.g. only one of them was
+            reprojected with crs_transform before this call), the result
+            is a number, not an error: meaningless, but indistinguishable
+            from a real distance without inspecting it by hand. Supplying
+            both source_crs and target_crs lets this function catch that
+            case and raise instead of returning it - see the raise below.
+            Neither hint changes how distance is computed; only
+            crs_transform actually reprojects data.
         distance_field:
             Optional output field name for the computed distance,
             overriding the configured default (config/plugins/
@@ -460,8 +476,15 @@ def find_nearest_neighbors(
     )
 
     final_source_crs = pick_first(source_crs, config.get("source_crs"), default=None)
+    final_target_crs = pick_first(target_crs, config.get("target_crs"), default=None)
     warn_if_geographic_crs = bool(config.get("warn_if_geographic_crs", True))
 
+    _raise_if_crs_mismatch(
+        source_crs=final_source_crs,
+        target_crs=final_target_crs,
+        capability_name="find_nearest_neighbors",
+    )
+
     preserve_properties = bool(config.get("preserve_properties", True))
     fields = _configured_fields(config)
 
@@ -594,6 +617,7 @@ def find_nearest_neighbors(
         "drop_unmatched": final_drop_unmatched,
         "include_target_geometry": final_include_target_geometry,
         "source_crs": final_source_crs,
+        "target_crs": final_target_crs,
         "planar_only": True,
         "warning": geographic_warning,
         "source_feature_count": len(source_items),

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/pyproject.toml

@@ -12,7 +12,7 @@ build-backend = "setuptools.build_meta"
 # "Open design questions" for why a namespace migration was deliberately
 # not done here.
 name = "smart_spatial_system"
-version = "0.2.2"
+version = "0.2.3"
 description = "Plugin-based GeoAI backend: natural-language questions become QuerySpecs, DAG plans, and map/table/report outputs."
 readme = "README.md"
 requires-python = ">=3.11"

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/smart_spatial_system/application/services/query_execution/accessibility_query_spec.py

@@ -191,7 +191,17 @@ def build_accessibility_query_spec(
             OperationSpec(
                 op="nearest_neighbor",
                 inputs={"source": current_sites_ref, "target": amenity_metric_ref},
-                params={"k": 1, "distance_field": amenity.distance_field},
+                # Both sides were just reprojected to target_crs above, so
+                # these are always equal here - passed anyway so
+                # find_nearest_neighbors' own source/target CRS mismatch
+                # check (plugins/distance_calculator.py) protects this
+                # call too, not only hand-written or LLM-generated plans.
+                params={
+                    "k": 1,
+                    "distance_field": amenity.distance_field,
+                    "source_crs": target_crs,
+                    "target_crs": target_crs,
+                },
                 output=enriched_ref,
             )
         )

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3/smart_spatial_system.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: smart_spatial_system
-Version: 0.2.2
+Version: 0.2.3
 Summary: Plugin-based GeoAI backend: natural-language questions become QuerySpecs, DAG plans, and map/table/report outputs.
 Author: Araz Shah
 License-Expression: MIT

{smart_spatial_system-0.2.2 → smart_spatial_system-0.2.3}/tests/test_distance_calculator.py

@@ -31,6 +31,7 @@ from plugins.distance_calculator import (  # noqa: E402
     _point_in_ring,
     _point_segment_distance,
     _python_distance_geometry,
+    _raise_if_crs_mismatch,
     _segment_segment_distance,
     _segments_intersect,
     _validate_engine,
@@ -545,3 +546,62 @@ def test_shapely_engine_if_installed() -> None:
 
     assert result.metadata["engines_used"] == ["shapely"]
     assert props["_distance"] == 5.0
+
+
+# ------------------------------------------------------------------ #
+# source_crs / target_crs mismatch guard
+# ------------------------------------------------------------------ #
+
+def test_calculate_distances_raises_on_crs_mismatch() -> None:
+    """
+    Regression test: with no CRS awareness at all in the actual distance
+    math, feeding source/target features in two different CRSs used to
+    return a large, silently-bogus number instead of an error. Supplying
+    both source_crs and target_crs must now catch a mismatch.
+    """
+    with pytest.raises(ValueError, match="do not match"):
+        calculate_distances(
+            source_features=[SOURCE_POINT],
+            target_features=[TARGET_POINT_A],
+            source_crs="EPSG:31256",
+            target_crs="EPSG:4326",
+        )
+
+
+def test_calculate_distances_accepts_matching_crs() -> None:
+    result = calculate_distances(
+        source_features=[SOURCE_POINT],
+        target_features=[TARGET_POINT_A],
+        source_crs="EPSG:31256",
+        target_crs="EPSG:31256",
+    )
+    assert result.metadata["source_crs"] == "EPSG:31256"
+    assert result.metadata["target_crs"] == "EPSG:31256"
+
+
+def test_calculate_distances_skips_check_when_no_crs_hints_given() -> None:
+    """
+    Opt-in by design: a caller that passes neither hint keeps today's
+    behaviour unchanged rather than being forced to supply CRS metadata
+    it may not have.
+    """
+    result = calculate_distances(source_features=[SOURCE_POINT], target_features=[TARGET_POINT_A])
+    assert result.metadata["source_crs"] is None
+    assert result.metadata["target_crs"] is None
+
+
+@pytest.mark.parametrize(
+    "source_crs,target_crs",
+    [(None, None), ("EPSG:4326", None), (None, "EPSG:4326"), ("epsg:4326", "EPSG:4326")],
+)
+def test_raise_if_crs_mismatch_does_not_raise(source_crs, target_crs) -> None:
+    _raise_if_crs_mismatch(
+        source_crs=source_crs, target_crs=target_crs, capability_name="x"
+    )
+
+
+def test_raise_if_crs_mismatch_raises_on_real_mismatch() -> None:
+    with pytest.raises(ValueError, match="EPSG:31256.*EPSG:4326"):
+        _raise_if_crs_mismatch(
+            source_crs="EPSG:31256", target_crs="EPSG:4326", capability_name="x"
+        )