simple-module-feature-flags 0.0.31__tar.gz → 0.0.32__tar.gz

{simple_module_feature_flags-0.0.31 → simple_module_feature_flags-0.0.32}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: simple_module_feature_flags
-Version: 0.0.31
+Version: 0.0.32
 Summary: Simple feature-flag module with per-tenant overrides and a consumer API for simple_module
 Project-URL: Homepage, https://github.com/antosubash/simple_module_python
 Project-URL: Repository, https://github.com/antosubash/simple_module_python
@@ -21,9 +21,9 @@ Classifier: Topic :: Internet :: WWW/HTTP
 Classifier: Topic :: Software Development :: Libraries :: Application Frameworks
 Classifier: Typing :: Typed
 Requires-Python: >=3.12
-Requires-Dist: simple-module-core==0.0.31
-Requires-Dist: simple-module-db==0.0.31
-Requires-Dist: simple-module-hosting==0.0.31
+Requires-Dist: simple-module-core==0.0.32
+Requires-Dist: simple-module-db==0.0.32
+Requires-Dist: simple-module-hosting==0.0.32
 Description-Content-Type: text/markdown
 
 # simple_module_feature_flags

{simple_module_feature_flags-0.0.31 → simple_module_feature_flags-0.0.32}/feature_flags/locales/en.json

@@ -30,6 +30,15 @@
     "system_value": "System: {value}",
     "clear_override": "Clear override"
   },
+  "confirm": {
+    "enable_title": "Enable \"{name}\"?",
+    "disable_title": "Disable \"{name}\"?",
+    "scope_system": "This changes the value for every tenant, immediately.",
+    "scope_tenant": "This sets an override for tenant \"{tenant_id}\" only. Other tenants keep following the system value.",
+    "enable_action": "Enable",
+    "disable_action": "Disable",
+    "cancel": "Cancel"
+  },
   "toasts": {
     "enabled": "\"{name}\" enabled",
     "disabled": "\"{name}\" disabled",

{simple_module_feature_flags-0.0.31 → simple_module_feature_flags-0.0.32}/feature_flags/pages/Browse.tsx

@@ -22,8 +22,10 @@ import {
 import { usePermissions } from '@simple-module-py/ui/hooks/use-permissions';
 import { AuthenticatedLayout } from '@simple-module-py/ui/layouts/AuthenticatedLayout';
 import { Flag, RotateCcw } from 'lucide-react';
+import { useState } from 'react';
 import { toast } from 'sonner';
 import { TenantPicker } from './components/TenantPicker';
+import { type PendingToggle, ToggleConfirmDialog } from './components/ToggleConfirmDialog';
 
 interface FeatureFlag {
   name: string;
@@ -55,17 +57,23 @@ function Browse() {
   const { can } = usePermissions();
   const canManage = can('feature_flags.manage');
 
-  function handleToggle(flag: FeatureFlag, next: boolean) {
+  // The switch stages the change; the confirm is what writes it. The Switch
+  // stays bound to the server value, so cancelling leaves it where it was
+  // without needing to undo anything.
+  const [pending, setPending] = useState<PendingToggle | null>(null);
+
+  function handleToggle({ name, next }: PendingToggle) {
+    setPending(null);
     router.post(
-      actionUrl(flag.name, 'toggle', tenant_id),
+      actionUrl(name, 'toggle', tenant_id),
       { enabled: next },
       {
         preserveScroll: true,
         onSuccess: () =>
           toast.success(
             next
-              ? t(keys.feature_flags.toasts.enabled, { name: flag.name })
-              : t(keys.feature_flags.toasts.disabled, { name: flag.name }),
+              ? t(keys.feature_flags.toasts.enabled, { name })
+              : t(keys.feature_flags.toasts.disabled, { name }),
           ),
         onError: () => toast.error(t(keys.feature_flags.toasts.toggle_failed)),
       },
@@ -166,7 +174,9 @@ function Browse() {
                     <div className="flex items-center gap-3">
                       <Switch
                         checked={flag.enabled}
-                        onCheckedChange={(checked) => handleToggle(flag, checked === true)}
+                        onCheckedChange={(checked) =>
+                          setPending({ name: flag.name, next: checked === true })
+                        }
                         disabled={!canManage}
                         aria-label={flag.name}
                       />
@@ -231,6 +241,13 @@ function Browse() {
             </TableBody>
           </Table>
         </Card>
+
+        <ToggleConfirmDialog
+          pending={pending}
+          tenantId={tenant_id}
+          onConfirm={handleToggle}
+          onCancel={() => setPending(null)}
+        />
       </PageShell>
     </>
   );

simple_module_feature_flags-0.0.32/feature_flags/pages/components/ToggleConfirmDialog.tsx

@@ -0,0 +1,69 @@
+import { keys, useT } from '@simple-module-py/i18n';
+import {
+  AlertDialog,
+  AlertDialogAction,
+  AlertDialogCancel,
+  AlertDialogContent,
+  AlertDialogDescription,
+  AlertDialogFooter,
+  AlertDialogHeader,
+  AlertDialogTitle,
+} from '@simple-module-py/ui/components/ui/alert-dialog';
+
+export interface PendingToggle {
+  name: string;
+  next: boolean;
+}
+
+interface Props {
+  pending: PendingToggle | null;
+  tenantId: string | null;
+  onConfirm: (pending: PendingToggle) => void;
+  onCancel: () => void;
+}
+
+/**
+ * Confirms a flag flip before it is written.
+ *
+ * A flag toggle takes effect the instant the switch moves, with no undo and no
+ * local record of who moved it — and the same switch means "for this tenant" or
+ * "for everyone" depending on a scope selector further up the page. That scope
+ * is the part worth restating: it is the difference between an experiment and
+ * an outage, and it is the piece you cannot see from the switch itself.
+ */
+export function ToggleConfirmDialog({ pending, tenantId, onConfirm, onCancel }: Props) {
+  const { t } = useT();
+  if (!pending) return null;
+
+  // Spelled out per branch — `t` needs a literal key, not one built at runtime.
+  const title = pending.next
+    ? t(keys.feature_flags.confirm.enable_title, { name: pending.name })
+    : t(keys.feature_flags.confirm.disable_title, { name: pending.name });
+  const scope = tenantId
+    ? t(keys.feature_flags.confirm.scope_tenant, { tenant_id: tenantId })
+    : t(keys.feature_flags.confirm.scope_system);
+
+  return (
+    <AlertDialog open onOpenChange={(open) => !open && onCancel()}>
+      <AlertDialogContent>
+        <AlertDialogHeader>
+          <AlertDialogTitle>{title}</AlertDialogTitle>
+          <AlertDialogDescription>{scope}</AlertDialogDescription>
+        </AlertDialogHeader>
+        <AlertDialogFooter>
+          <AlertDialogCancel onClick={onCancel}>
+            {t(keys.feature_flags.confirm.cancel)}
+          </AlertDialogCancel>
+          <AlertDialogAction
+            variant={pending.next ? 'default' : 'destructive'}
+            onClick={() => onConfirm(pending)}
+          >
+            {pending.next
+              ? t(keys.feature_flags.confirm.enable_action)
+              : t(keys.feature_flags.confirm.disable_action)}
+          </AlertDialogAction>
+        </AlertDialogFooter>
+      </AlertDialogContent>
+    </AlertDialog>
+  );
+}

{simple_module_feature_flags-0.0.31 → simple_module_feature_flags-0.0.32}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "simple_module_feature_flags"
-version = "0.0.31"
+version = "0.0.32"
 description = "Simple feature-flag module with per-tenant overrides and a consumer API for simple_module"
 readme = "README.md"
 license = "MIT"
@@ -21,9 +21,9 @@ classifiers = [
     "Typing :: Typed",
 ]
 dependencies = [
-    "simple_module_core==0.0.31",
-    "simple_module_db==0.0.31",
-    "simple_module_hosting==0.0.31",
+    "simple_module_core==0.0.32",
+    "simple_module_db==0.0.32",
+    "simple_module_hosting==0.0.32",
 ]
 
 [project.entry-points.simple_module]