simple-module-cli 0.0.38__tar.gz → 0.0.39__tar.gz

{simple_module_cli-0.0.38 → simple_module_cli-0.0.39}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: simple_module_cli
-Version: 0.0.38
+Version: 0.0.39
 Summary: Standalone scaffolder for the SimpleModule framework — `smpy new`, `smpy create-module`, plugin host.
 Project-URL: Homepage, https://github.com/antosubash/simple_module_python
 Project-URL: Repository, https://github.com/antosubash/simple_module_python
@@ -19,8 +19,8 @@ Classifier: Topic :: Software Development :: Code Generators
 Classifier: Topic :: Software Development :: Libraries :: Application Frameworks
 Classifier: Typing :: Typed
 Requires-Python: >=3.12
-Requires-Dist: tomlkit>=0.13
-Requires-Dist: typer>=0.12
+Requires-Dist: tomlkit<0.16,>=0.13
+Requires-Dist: typer<0.28,>=0.12
 Description-Content-Type: text/markdown
 
 # simple_module_cli

{simple_module_cli-0.0.38 → simple_module_cli-0.0.39}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "simple_module_cli"
-version = "0.0.38"
+version = "0.0.39"
 description = "Standalone scaffolder for the SimpleModule framework — `smpy new`, `smpy create-module`, plugin host."
 readme = "README.md"
 license = "MIT"
@@ -20,8 +20,8 @@ classifiers = [
     "Typing :: Typed",
 ]
 dependencies = [
-    "typer>=0.12",
-    "tomlkit>=0.13",
+    "typer>=0.12,<0.28",
+    "tomlkit>=0.13,<0.16",
 ]
 
 [project.scripts]

{simple_module_cli-0.0.38 → simple_module_cli-0.0.39}/simple_module_cli/skills/simple-module-conventions/SKILL.md

@@ -121,6 +121,17 @@ Build a `MailMessage(to, subject, text)` and send it with `current_mail_sender()
 
 Which module holds the accounts depends on the auth provider (`users` or `keycloak`). To name, look up, search or count users, use `get_user_directory(app)` from `simple_module_core.user_directory`: `get_many(db, ids, with_roles=...)`, `search(db, term, limit=...)`, `match_ids(term)` (a subquery) and `stats(db, active_window=...)`. Name a user with `DirectoryUser.label`. `roles is None` means the provider does not know them (Keycloak) — refuse anything that needs roles rather than treating the user as role-less. Importing `users.models` from another module silently queries an empty table under Keycloak.
 
+### 13. Raise domain exceptions from services
+
+Define a per-module base error in `<module>/exceptions.py` or `errors.py` and
+subclass it for business failures. Services must not raise `HTTPException`:
+CLI commands, tasks and durable handlers need transport-independent failures.
+Follow `file_storage`: map errors in endpoints or install HTTP handlers through
+`register_exception_handlers(app)`. Preserve status codes, exact JSON bodies,
+headers and translation keys when migrating; translate at the request boundary.
+Endpoint-level `HTTPException` for pure request validation is fine. Inertia
+forms may catch domain errors to report field errors or redirect.
+
 ## Related skills
 
 - **simple-module-database** — per-module Base, mixins, session lifecycle

{simple_module_cli-0.0.38 → simple_module_cli-0.0.39}/simple_module_cli/skills/simple-module-creating/SKILL.md

@@ -129,4 +129,10 @@ The new module should appear in the registered-modules log line. If it has a vie
 - **`name=` collides.** Two modules with the same `ModuleMeta.name` raise `SM008` at dev boot / `make doctor` (their lowercased names would also collide as table prefixes in the shared schema).
 - **Registered the module by hand in host code.** Don't — discovery is entry-point-only; host code never imports module code.
 
+Services raise domain exceptions derived from a per-module base in
+`exceptions.py` or `errors.py`, never `HTTPException`. Map them in endpoints or
+`register_exception_handlers(app)` (as in `file_storage`); translate at the
+request boundary. Preserve existing status codes, JSON bodies and headers.
+Endpoint-level `HTTPException` for pure request validation remains fine.
+
 For framework-wide rules that apply once the module exists (SQLModel-everywhere, file-size cap, settings layout, no `session.commit()` in services), see the **simple-module-conventions** skill. For migration mechanics see **simple-module-migrations**.

{simple_module_cli-0.0.38 → simple_module_cli-0.0.39}/simple_module_cli/templates/module/__PACKAGE__/service.py.tpl

@@ -1,4 +1,10 @@
-"""{{SINGULAR_CLASS}} service implementation."""
+"""{{SINGULAR_CLASS}} service implementation.
+
+Business failures raise domain exceptions derived from a per-module base in
+exceptions.py or errors.py, never HTTPException. Map them in endpoints or via
+ModuleBase.register_exception_handlers; keep HTTP status, payload, headers and
+translation at that boundary so this service also works in CLI/tasks.
+"""
 
 from __future__ import annotations
 

{simple_module_cli-0.0.38 → simple_module_cli-0.0.39}/tests/conftest.py

@@ -7,6 +7,7 @@ how the factory below gets shared.
 
 from __future__ import annotations
 
+import os
 import subprocess
 import sys
 from pathlib import Path
@@ -154,3 +155,17 @@ def make_git_module_repo(tmp_path: Path):
         return repo
 
     return factory
+
+
+@pytest.fixture
+def require_cli_asset():
+    """Keep optional local tooling from silently reducing CI coverage."""
+
+    def require(available: bool, message: str) -> None:
+        if available:
+            return
+        if os.environ.get("CI"):
+            pytest.fail(f"{message}. On CI this must fail rather than skip.")
+        pytest.skip(message)
+
+    return require

simple_module_cli-0.0.39/tests/test_cli_asset_prerequisites.py

@@ -0,0 +1,19 @@
+"""Missing frontend prerequisites may skip locally but must fail on CI."""
+
+import pytest
+
+
+@pytest.mark.parametrize("ci", [None, "true"])
+def test_cli_missing_asset_prerequisite_fails_on_ci(monkeypatch, require_cli_asset, ci):
+    if ci:
+        monkeypatch.setenv("CI", ci)
+    else:
+        monkeypatch.delenv("CI", raising=False)
+    outcome = pytest.fail.Exception if ci else pytest.skip.Exception
+    with pytest.raises(outcome, match="missing tool"):
+        require_cli_asset(False, "missing tool")
+
+
+def test_cli_available_asset_prerequisite_runs_on_ci(monkeypatch, require_cli_asset):
+    monkeypatch.setenv("CI", "true")
+    require_cli_asset(True, "missing tool")

{simple_module_cli-0.0.38 → simple_module_cli-0.0.39}/tests/test_cli_openapi_gen_types.py

@@ -185,8 +185,8 @@ def test_pinned_version_matches_the_ui_dev_dependency() -> None:
     assert ui["devDependencies"]["openapi-typescript"] == ot.OPENAPI_TYPESCRIPT_VERSION
 
 
-@pytest.mark.skipif(not LOCAL_TOOL.is_file(), reason="needs `npm install` (openapi-typescript)")
-def test_real_tool_emits_paths(importable: Path) -> None:
+def test_real_tool_emits_paths(importable: Path, require_cli_asset) -> None:
+    require_cli_asset(LOCAL_TOOL.is_file(), "needs `npm ci` (openapi-typescript)")
     targets = ot.module_targets(
         [_fake_module(importable, "gt_real", "Widgets", opted_in=True)], importable, []
     )

{simple_module_cli-0.0.38 → simple_module_cli-0.0.39}/tests/test_module_css_build.py

@@ -6,9 +6,8 @@ resolves the path and keeps the rule. This is the one assertion that exercises
 that whole chain, so it drives a genuine build rather than inspecting the
 generated text.
 
-Skipped where a build is impossible: CI's `python-tests` job installs Python
-deps only (`make install-py`), so `node_modules` is absent there. The JS jobs
-and local runs do have it.
+Missing build prerequisites skip locally and fail on CI, where the Python
+and JS build jobs install the required Node dependencies.
 """
 
 from __future__ import annotations
@@ -22,17 +21,21 @@ import pytest
 REPO_ROOT = Path(__file__).resolve().parents[3]
 
 pytestmark = [
-    pytest.mark.skipif(
-        not (REPO_ROOT / "node_modules").is_dir(),
-        reason="node_modules absent — run `npm install` to exercise the real build",
-    ),
-    pytest.mark.skipif(shutil.which("npm") is None, reason="npm not on PATH"),
     # Both tests rewrite the shared tree (generated manifests, host/static/dist, a
     # probe page under audit_log), so under xdist they must share one worker.
     pytest.mark.xdist_group("repo-build"),
 ]
 
 
+@pytest.fixture(autouse=True)
+def require_build_tools(require_cli_asset):
+    require_cli_asset(shutil.which("npm") is not None, "npm not on PATH")
+    require_cli_asset(
+        (REPO_ROOT / "node_modules").is_dir(),
+        "node_modules absent — run `npm ci` to exercise the real build",
+    )
+
+
 class TestModuleCssReachesBundle:
     def test_module_class_is_emitted_by_vite_build(self):
         """A class defined only in a module's styles.css appears in the built CSS.