simkl-mps 2.3.1__tar.gz → 2.3.3__tar.gz

{simkl_mps-2.3.1 → simkl_mps-2.3.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: simkl-mps
-Version: 2.3.1
+Version: 2.3.3
 Summary: Automatic Media Scrobbler for Simkl
 License: GPL-3.0
 License-File: LICENSE

{simkl_mps-2.3.1 → simkl_mps-2.3.3}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "simkl-mps"
-version = "2.3.1"
+version = "2.3.3"
 description = "Automatic Media Scrobbler for Simkl"
 authors = [
     "kavin <kavinthangavel.dev@gmail.com>",

{simkl_mps-2.3.1 → simkl_mps-2.3.3}/simkl_mps/__init__.py

@@ -2,7 +2,7 @@
 Media Player Scrobbler for SIMKL package.
 """
 
-__version__ = "2.2.2"
+__version__ = "2.3.3"
 __author__ = "kavin"
 
 # Apply compatibility patches first, before any other imports

{simkl_mps-2.3.1 → simkl_mps-2.3.3}/simkl_mps/credentials.py

@@ -7,7 +7,7 @@ Access Token is loaded from a .env file in the user's application data directory
 import pathlib
 import logging
 import os
-from dotenv import dotenv_values, load_dotenv
+from dotenv import dotenv_values
 from .migration import get_app_data_dir, perform_full_migration
 
 logger = logging.getLogger(__name__)
@@ -20,13 +20,13 @@ except Exception as e:
 
 
 # --- Injected by build process ---
-# These placeholders are replaced by the build workflow using secrets.
-CLIENT_ID_PLACEHOLDER = "063e363a1596eb693066cf3b9848be8d2c4a6d9ef300666c9f19ef5980312b27"
-CLIENT_SECRET_PLACEHOLDER = "1e2781d773564774c6788bf64b871374b2cee2b31eaed361488821ffc7c5bba9"
+# These placeholders are replaced by the build workflow.
+CLIENT_ID_PLACEHOLDER = "SIMKL_CLIENT_ID_PLACEHOLDER"
+CLIENT_SECRET_PLACEHOLDER = "SIMKL_CLIENT_SECRET_PLACEHOLDER"
 # --- End of injected values ---
 
-SIMKL_CLIENT_ID = CLIENT_ID_PLACEHOLDER
-SIMKL_CLIENT_SECRET = CLIENT_SECRET_PLACEHOLDER
+SIMKL_CLIENT_ID = "063e363a1596eb693066cf3b9848be8d2c4a6d9ef300666c9f19ef5980312b27"
+SIMKL_CLIENT_SECRET = "1e2781d773564774c6788bf64b871374b2cee2b31eaed361488821ffc7c5bba9"
 
 
 def _is_placeholder_credential(value: str, placeholder: str = None) -> bool:
@@ -46,17 +46,22 @@ def _is_placeholder_credential(value: str, placeholder: str = None) -> bool:
     if placeholder and normalized == placeholder:
         return True
     
-    # Check for common placeholder patterns from env/config
-    placeholder_patterns = [
+    # Check common placeholder literals from env/config.
+    # Keep checks strict to avoid false positives for real secret values.
+    placeholder_literals = {
         "placeholder",
-        "id",
-        "change_me",
-    ]
-    
+        "simkl_client_id",
+        "simkl_client_secret",
+        "simkl_client_id_placeholder",
+        "simkl_client_secret_placeholder",
+    }
+
     normalized_lower = normalized.lower()
-    for pattern in placeholder_patterns:
-        if pattern in normalized_lower:
-            return True
+    if normalized_lower in placeholder_literals:
+        return True
+
+    if normalized_lower.startswith("simkl_client_") and normalized_lower.endswith("_placeholder"):
+        return True
     
     return False
 
@@ -153,36 +158,39 @@ def get_credentials():
             if dev_client_secret and not _is_placeholder_credential(dev_client_secret):
                 client_secret = client_secret or dev_client_secret
 
- 
     access_token = None
     user_id = None
-    env_file_path = get_env_file_path() 
+    env_file_path = get_env_file_path()
     if env_file_path.exists():
         logger.debug(f"Reading credentials from {env_file_path} inside get_credentials()")
         config = dotenv_values(env_file_path)
-        
+
         # Validate access token against placeholders
         raw_access_token = config.get("SIMKL_ACCESS_TOKEN")
         if raw_access_token and not _is_placeholder_credential(raw_access_token):
             access_token = raw_access_token
-        
+
         # Validate user ID against placeholders
         raw_user_id = config.get("SIMKL_USER_ID")
         if raw_user_id and not _is_placeholder_credential(raw_user_id):
             user_id = raw_user_id
-        
+
         if user_id:
             logger.debug(f"Found user ID in env file: {user_id}")
         else:
             logger.debug("User ID not found in env file or value is a placeholder")
-            
+
         if not access_token:
-             logger.warning(f"Found env file at {env_file_path}, but SIMKL_ACCESS_TOKEN key is missing, empty, or contains a placeholder value.")
+            logger.warning(
+                f"Found env file at {env_file_path}, but SIMKL_ACCESS_TOKEN key is missing, empty, or contains a placeholder value."
+            )
     else:
-         logger.debug(f"Env file not found at {env_file_path} inside get_credentials()")
+        logger.debug(f"Env file not found at {env_file_path} inside get_credentials()")
 
     if not client_id or not client_secret:
-         logger.warning("Client ID or Secret not found. For local development, create a dev_credentials.env file with SIMKL_CLIENT_ID and SIMKL_CLIENT_SECRET.")
+        logger.warning(
+            "Client ID or Secret not found. For local development, create a .env file with SIMKL_CLIENT_ID and SIMKL_CLIENT_SECRET."
+        )
 
     return {
         "client_id": client_id,

{simkl_mps-2.3.1 → simkl_mps-2.3.3}/simkl_mps/tray_linux.py

@@ -185,13 +185,21 @@ class AppIndicatorTray:
             # --- Threshold Submenu (nested under Scrobbling) ---
             threshold_item = gtk_module.MenuItem(label="Completion Threshold")
             threshold_submenu = gtk_module.Menu()
-            threshold_group = [] # For radio buttons
+            threshold_group = None # Will hold the first RadioMenuItem for grouping
 
             current_threshold = get_setting('watch_completion_threshold', DEFAULT_THRESHOLD)
 
             def create_preset_item(value, label):
-                item = gtk_module.CheckMenuItem(label=label, group=threshold_group)
-                threshold_group.append(item) # Add to group for radio behavior
+                nonlocal threshold_group
+                # Use RadioMenuItem instead of CheckMenuItem for proper radio behavior
+                if threshold_group is None:
+                    # First item in the group
+                    item = gtk_module.RadioMenuItem(label=label)
+                    threshold_group = item
+                else:
+                    # Subsequent items join the group
+                    item = gtk_module.RadioMenuItem(group=threshold_group, label=label)
+
                 item.set_active(current_threshold == value)
                 item.connect("activate", lambda w, v=value: self._wrap_callback(lambda: self.app._set_preset_threshold(v))())
                 return item