service-capacity-modeling 0.3.45__tar.gz → 0.3.47__tar.gz

{service_capacity_modeling-0.3.45 → service_capacity_modeling-0.3.47}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: service-capacity-modeling
-Version: 0.3.45
+Version: 0.3.47
 Summary: Contains utilities for modeling capacity for pluggable workloads
 Author: Joseph Lynch
 Author-email: josephl@netflix.com

{service_capacity_modeling-0.3.45 → service_capacity_modeling-0.3.47}/service_capacity_modeling/models/org/netflix/kafka.py

@@ -159,7 +159,7 @@ def _estimate_kafka_requirement(  # pylint: disable=too-many-positional-argument
     needed_network_mbps = max(bw_in, bw_out) * 1.40
 
     needed_disk = math.ceil(
-        desires.data_shape.estimated_state_size_gib.mid * copies_per_region,
+        desires.data_shape.estimated_state_size_gib.mid,
     )
 
     # Keep the last N seconds hot in cache
@@ -416,6 +416,10 @@ class NflxKafkaArguments(BaseModel):
 
 
 class NflxKafkaCapacityModel(CapacityModel):
+
+    HA_DEFAULT_REPLICATION_FACTOR = 2
+    SC_DEFAULT_REPLICATION_FACTOR = 3
+
     @staticmethod
     def capacity_plan(
         instance: Instance,
@@ -427,11 +431,11 @@ class NflxKafkaCapacityModel(CapacityModel):
         cluster_type: ClusterType = ClusterType(
             extra_model_arguments.get("cluster_type", "high-availability")
         )
-        default_replication = 2
+        replication_factor = NflxKafkaCapacityModel.HA_DEFAULT_REPLICATION_FACTOR
         if cluster_type == ClusterType.strong:
-            default_replication = 3
+            replication_factor = NflxKafkaCapacityModel.SC_DEFAULT_REPLICATION_FACTOR
         copies_per_region: int = extra_model_arguments.get(
-            "copies_per_region", default_replication
+            "copies_per_region", replication_factor
         )
         if cluster_type == ClusterType.strong and copies_per_region < 3:
             raise ValueError("Strong consistency and RF<3 doesn't work")
@@ -503,8 +507,13 @@ class NflxKafkaCapacityModel(CapacityModel):
         retention = extra_model_arguments.get("retention", "PT8H")
         retention_secs = iso_to_seconds(retention)
 
-        # write throughput * retention = usage
-        state_gib = (write_bytes.mid * retention_secs) / GIB_IN_BYTES
+        # write throughput * retention * replication factor = usage
+        replication_factor = NflxKafkaCapacityModel.HA_DEFAULT_REPLICATION_FACTOR
+        if extra_model_arguments.get("cluster_type", None) == ClusterType.strong:
+            replication_factor = NflxKafkaCapacityModel.SC_DEFAULT_REPLICATION_FACTOR
+        state_gib = (
+            write_bytes.mid * retention_secs * replication_factor
+        ) / GIB_IN_BYTES
 
         return CapacityDesires(
             query_pattern=QueryPattern(

{service_capacity_modeling-0.3.45 → service_capacity_modeling-0.3.47}/service_capacity_modeling.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: service-capacity-modeling
-Version: 0.3.45
+Version: 0.3.47
 Summary: Contains utilities for modeling capacity for pluggable workloads
 Author: Joseph Lynch
 Author-email: josephl@netflix.com