sddflow 2.7.53__tar.gz → 2.7.55__tar.gz

{sddflow-2.7.53 → sddflow-2.7.55}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sddflow
-Version: 2.7.53
+Version: 2.7.55
 Summary: SDD Framework CLI — initialize and upgrade Spec-Driven Development packs
 Project-URL: Homepage, https://github.com/sunil1983us/universalguide
 Project-URL: Repository, https://github.com/sunil1983us/universalguide

{sddflow-2.7.53 → sddflow-2.7.55}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "sddflow"
-version = "2.7.53"
+version = "2.7.55"
 description = "SDD Framework CLI — initialize and upgrade Spec-Driven Development packs"
 readme = "README.md"
 requires-python = ">=3.9"

sddflow-2.7.55/sdd/__init__.py

@@ -0,0 +1 @@
+__version__ = "2.7.55"

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/commands/review.py

@@ -161,21 +161,43 @@ def _push_doc_page(doc: str, md_path: Path, feature_name: str) -> str | None:
 
 # ── Text extraction ────────────────────────────────────────────────────────────
 
+_ADF_BLOCK_TYPES = {"paragraph", "heading", "codeBlock", "blockquote", "listItem"}
+
+
 def _extract_text(body) -> str:
-    """Extract plain text from Jira ADF (Cloud) or string (Server/DC) comment body."""
+    """Extract plain text from Jira ADF (Cloud) or string (Server/DC) comment
+    body, preserving line boundaries between block-level nodes as newlines.
+
+    Jira's rich-text comment editor stores each line a user types as a
+    SEPARATE paragraph node in the ADF tree, not one paragraph with embedded
+    newlines -- joining every text run in the whole document with a single
+    space (the previous behavior) collapsed a multi-line reply like
+    pull-answers' "{doc}:NC-{NNN}: {answer}" format (one item per line) into
+    one run-on line, breaking _ANSWER_LINE_RE's per-line matching entirely."""
     if isinstance(body, str):
         return body
     if isinstance(body, dict):
-        texts: list[str] = []
+        lines: list[str] = []
 
-        def walk(node: dict) -> None:
+        def walk_inline(node: dict, buf: list[str]) -> None:
             if node.get("type") == "text":
-                texts.append(node.get("text", ""))
+                buf.append(node.get("text", ""))
+            elif node.get("type") == "hardBreak":
+                buf.append("\n")
             for child in node.get("content", []):
-                walk(child)
+                walk_inline(child, buf)
 
-        walk(body)
-        return " ".join(texts)
+        def walk_block(node: dict) -> None:
+            if node.get("type") in _ADF_BLOCK_TYPES:
+                buf: list[str] = []
+                walk_inline(node, buf)
+                lines.append("".join(buf))
+            else:
+                for child in node.get("content", []):
+                    walk_block(child)
+
+        walk_block(body)
+        return "\n".join(lines)
     return ""
 
 
@@ -314,6 +336,18 @@ _ANSWER_LINE_RE = re.compile(
     re.MULTILINE | re.IGNORECASE,
 )
 
+# validate.prompt.md tells the AI to cite each marker's doc as "{doc}:NC-{NNN}"
+# but doesn't mandate an exact spelling -- a model writing the Locations
+# column for use-cases.md has, in practice, abbreviated it "uc" (a reasonable
+# guess, but resolve_doc_path's actual doc key is "use-cases", matching the
+# filename). Normalize known abbreviations before ever calling
+# resolve_doc_path with a doc-key parsed out of a location ID.
+_DOC_KEY_ALIASES = {"uc": "use-cases", "usecases": "use-cases"}
+
+
+def _normalize_doc_key(doc_key: str) -> str:
+    return _DOC_KEY_ALIASES.get(doc_key.lower(), doc_key.lower())
+
 
 def _parse_open_questions(doc_text: str) -> list[dict]:
     """Parse a blocked document's `| ID | Locations | Question |` table
@@ -392,6 +426,52 @@ def _patch_marker(md_path: Path, nnn: str, answer: str) -> bool:
     return True
 
 
+_LEGACY_MARKER_RE = re.compile(r'\[NEEDS CLARIFICATION:\s*')
+
+
+def _number_legacy_markers(md_path: Path) -> int:
+    """Retroactively number any un-numbered `[NEEDS CLARIFICATION: ...]`
+    markers in md_path as `[NEEDS CLARIFICATION-NNN: ...]`, in order of
+    appearance, 1-indexed and zero-padded to 3 digits -- the exact
+    convention specify-brd/uc/srd/doc.prompt.md now write for documents
+    generated after this feature shipped.
+
+    Projects whose brd.md/use-cases.md/srd.md predate that convention
+    still have the old unnumbered form. validate.prompt.md's own
+    §3a-BLOCKING table numbers them the same way (order of appearance)
+    purely for DISPLAY -- it never patches the source file, since
+    scanning isn't editing. Without this retrofit, that displayed
+    numbering (what a reviewer's Jira/Confluence answer cites) never
+    lines up with any real text in the source file, so
+    push-questions/pull-answers's exact-ID matching can never find a
+    marker to patch.
+
+    The literal regex `\\[NEEDS CLARIFICATION:` (colon immediately
+    after "CLARIFICATION", no dash) only matches the legacy unnumbered
+    form -- an already-numbered `[NEEDS CLARIFICATION-NNN:` has a "-NNN"
+    in between and is left untouched. Numbering continues after the
+    highest existing NNN, so a doc with a mix of both forms doesn't
+    collide. Returns the count of markers renumbered (0 if none found,
+    including when the file doesn't exist)."""
+    if not md_path.exists():
+        return 0
+    text = md_path.read_text()
+
+    existing_nums = [int(n) for n in re.findall(r'\[NEEDS CLARIFICATION-(\d+):', text)]
+    state = {"next_num": max(existing_nums, default=0) + 1, "count": 0}
+
+    def renumber(_m: re.Match) -> str:
+        replacement = f"[NEEDS CLARIFICATION-{state['next_num']:03d}: "
+        state["next_num"] += 1
+        state["count"] += 1
+        return replacement
+
+    new_text = _LEGACY_MARKER_RE.sub(renumber, text)
+    if state["count"]:
+        md_path.write_text(new_text)
+    return state["count"]
+
+
 def _ensure_epic(jira_client: JiraClient, jira_cfg, feature_name: str) -> str | None:
     """Create the Feature/Epic container if it doesn't already exist yet,
     using the same content and idempotency label `sdd jira push` uses — so a
@@ -803,6 +883,28 @@ def review_pull_answers(doc, profile, feature):
     if not items:
         raise SystemExit(0)
 
+    # Retrofit: a doc that predates NEEDS CLARIFICATION-NNN numbering
+    # still has the old unnumbered [NEEDS CLARIFICATION: ...] form, even
+    # though validate.md's table above already displays synthesized
+    # brd:NC-001-style IDs for it (order-of-appearance, same rule) --
+    # number the source file's markers to match before attempting any
+    # patch, or the exact-ID search below would never find them.
+    referenced_docs = {
+        _normalize_doc_key(loc_id.split(":NC-")[0])
+        for item in items for loc_id in item["locations"]
+    }
+    for doc_key in referenced_docs:
+        try:
+            loc_path = resolve_doc_path(doc_key, feature_name)
+        except ValueError:
+            continue
+        renumbered = _number_legacy_markers(loc_path)
+        if renumbered:
+            console.print(
+                f"  [dim]·  Numbered {renumbered} legacy marker(s) in "
+                f"{loc_path.name} to match validate.md's IDs[/dim]"
+            )
+
     links     = _load_review_links()
     issue_key = (links.get(doc) or {}).get("key")
     if not issue_key:
@@ -841,6 +943,7 @@ def review_pull_answers(doc, profile, feature):
         answer_text = answers[item["id"]]
         for loc_id in item["locations"]:
             doc_key, nnn = loc_id.split(":NC-")
+            doc_key = _normalize_doc_key(doc_key)
             try:
                 loc_path = resolve_doc_path(doc_key, feature_name)
             except ValueError:

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/commands/upgrade.py

@@ -2117,6 +2117,93 @@ MIGRATIONS = [
         ],
         "migrate": lambda m: {**m, "sdd_version": "2.7.53"},
     },
+    {
+        "from":        "2.7.53",
+        "to":          "2.7.54",
+        "description": "Fix: multi-line sdd review pull-answers replies (one 'brd:NC-NNN: answer' per line, e.g. a real 7-item Jira comment) were silently collapsed into a single garbled line, so only the first item ever got parsed -- no manifest schema changes",
+        "notes": [
+            "User-reported: a reviewer answered all 7 open questions on a "
+            "push-questions ticket, one per line as instructed, but "
+            "pull-answers reported 'no new replies' every time",
+            "Root cause: _extract_text() joined every text run in the "
+            "whole ADF comment body with a single space, with no regard "
+            "for paragraph boundaries. Jira's rich-text comment editor "
+            "stores each line a user types as a SEPARATE paragraph node "
+            "in the ADF tree, not one paragraph with embedded newlines -- "
+            "so a real multi-line reply collapsed into one run-on line, "
+            "and _ANSWER_LINE_RE's per-line ^...$ matching (anchored on "
+            "actual \\n characters) then only ever found the first item, "
+            "with the rest of the comment swallowed into its answer",
+            "_extract_text() rewritten to walk ADF block-level nodes "
+            "(paragraph, heading, codeBlock, blockquote, listItem) and "
+            "join THOSE with newlines, while text runs within a single "
+            "block are concatenated directly (also fixes a smaller "
+            "pre-existing issue: formatting-split text runs within one "
+            "sentence previously got a spurious extra space inserted "
+            "between them). hardBreak nodes (shift+enter within one "
+            "paragraph) also now produce a newline",
+            "Also used by review_check's printed reviewer-comment display "
+            "and the dashboard's Jira-comment surfacing -- both benefit "
+            "from the same fix, previously showing run-on multi-line "
+            "Jira comments as one wrapped line",
+            "5 new tests: separate-paragraphs-become-separate-lines, "
+            "plain-string-body unchanged, hardBreak handling, and an "
+            "end-to-end reproduction of the exact reported bug (7 "
+            "distinct paragraph answers, all 7 must parse)",
+            "This migration only bumps sdd_version -- no manifest.yml "
+            "field changes for any pack",
+        ],
+        "migrate": lambda m: {**m, "sdd_version": "2.7.54"},
+    },
+    {
+        "from":        "2.7.54",
+        "to":          "2.7.55",
+        "description": "Fix: sdd review pull-answers never patched a marker in any project whose brd.md/use-cases.md/srd.md predate the NEEDS CLARIFICATION-NNN numbering feature -- no manifest schema changes",
+        "notes": [
+            "User-reported: pull-answers reported 0 items patched every "
+            "time despite valid, correctly-formatted answers on the "
+            "Jira ticket, confirmed via live diagnostics against the "
+            "user's real project -- extract_text (fixed in 2.7.54), "
+            "cwd, and comment parsing were each individually confirmed "
+            "correct in isolation, narrowing the failure to "
+            "_patch_marker itself",
+            "Root cause: validate.md's own §3a-BLOCKING scan only "
+            "DISPLAYS synthesized {doc}:NC-{NNN} IDs for legacy "
+            "unnumbered [NEEDS CLARIFICATION: ...] markers (order of "
+            "appearance) -- it never writes those numbers back into the "
+            "source document, since scanning isn't editing. Confirmed "
+            "via a live grep -o \"NEEDS CLARIFICATION-[0-9]*\" against "
+            "the user's brd.md returning zero matches despite the "
+            "displayed table citing brd:NC-001 etc. _patch_marker's "
+            "exact-string search for the numbered form therefore never "
+            "found anything to replace, in any project generated before "
+            "this feature shipped",
+            "New _number_legacy_markers(): retroactively numbers any "
+            "unnumbered [NEEDS CLARIFICATION: ...] marker in a source "
+            "doc as [NEEDS CLARIFICATION-NNN: ...], in order of "
+            "appearance, continuing after the highest existing number so "
+            "a doc with a mix of both forms doesn't collide -- wired "
+            "into review_pull_answers to run once per referenced doc "
+            "before any patch is attempted",
+            "Secondary fix: the AI generating validate.md's Locations "
+            "column has, in practice, abbreviated use-cases.md as 'uc' "
+            "(resolve_doc_path's real key is 'use-cases', matching the "
+            "filename stem) -- new _normalize_doc_key() maps known "
+            "abbreviations before every resolve_doc_path call sourced "
+            "from a parsed location ID. validate.prompt.md (all 5 packs) "
+            "tightened to require an exact filename stem going forward",
+            "11 new tests: legacy-marker numbering (order, zero-padding, "
+            "mixed-state continuation, already-numbered untouched, "
+            "missing file), doc-key alias normalization, and an "
+            "end-to-end reproduction of the exact reported bug (a "
+            "validate.md table citing brd:NC-001/uc:NC-001 against docs "
+            "still in the old unnumbered form, confirming pull-answers "
+            "now retrofits and patches both)",
+            "This migration only bumps sdd_version -- no manifest.yml "
+            "field changes for any pack",
+        ],
+        "migrate": lambda m: {**m, "sdd_version": "2.7.55"},
+    },
 ]
 
 

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-backend-service/.github/prompts/validate.prompt.md

@@ -71,7 +71,9 @@ For each `[ASSUMPTION-NNN]` the owner marks as incorrect:
    Scan brd.md, use-cases.md, and srd.md for any `[NEEDS CLARIFICATION-NNN: ...]`
    markers. If any found: list each as one row in a `| ID | Locations | Question |`
    table. **ID** = this marker's doc-qualified ID, `{doc}:NC-{NNN}` (e.g.
-   `brd:NC-002` for marker 002 in brd.md). **Locations** = comma-separated
+   `brd:NC-002` for marker 002 in brd.md — `{doc}` must exactly match the
+   file's stem: `brd`, `use-cases`, or `srd`, never an abbreviation like
+   `uc`). **Locations** = comma-separated
    doc-qualified IDs for every place this SAME question's answer applies —
    almost always just the ID itself again (e.g. `brd:NC-002`), but when one
    question was asked in more than one document (a duplicate — same

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-backend-service/.specify/manifest.yml

@@ -43,5 +43,5 @@ testing_style: "paired"
 # If using sdd-universal instead, set project_type: "backend-service" in its manifest.yml
 # project_type: "backend-service"
 
-sdd_version: "2.7.53"   # set by sdd init; used by sdd upgrade
+sdd_version: "2.7.55"   # set by sdd init; used by sdd upgrade
 ai_tool: ""             # set by sdd init: claude-code | copilot | cursor | windsurf | other

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-frontend-spa/.github/prompts/validate.prompt.md

@@ -71,7 +71,9 @@ For each `[ASSUMPTION-NNN]` the owner marks as incorrect:
    Scan brd.md, use-cases.md, and srd.md for any `[NEEDS CLARIFICATION-NNN: ...]`
    markers. If any found: list each as one row in a `| ID | Locations | Question |`
    table. **ID** = this marker's doc-qualified ID, `{doc}:NC-{NNN}` (e.g.
-   `brd:NC-002` for marker 002 in brd.md). **Locations** = comma-separated
+   `brd:NC-002` for marker 002 in brd.md — `{doc}` must exactly match the
+   file's stem: `brd`, `use-cases`, or `srd`, never an abbreviation like
+   `uc`). **Locations** = comma-separated
    doc-qualified IDs for every place this SAME question's answer applies —
    almost always just the ID itself again (e.g. `brd:NC-002`), but when one
    question was asked in more than one document (a duplicate — same

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-frontend-spa/.specify/manifest.yml

@@ -32,5 +32,5 @@ testing_style: "paired"
 # If using sdd-universal instead, set project_type: "frontend-spa" in its manifest.yml
 # project_type: "frontend-spa"
 
-sdd_version: "2.7.53"   # set by sdd init; used by sdd upgrade
+sdd_version: "2.7.55"   # set by sdd init; used by sdd upgrade
 ai_tool: ""             # set by sdd init: claude-code | copilot | cursor | windsurf | other

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-fullstack/.github/prompts/validate.prompt.md

@@ -72,7 +72,9 @@ For each `[ASSUMPTION-NNN]` the owner marks as incorrect:
    Scan brd.md, use-cases.md, and srd.md for any `[NEEDS CLARIFICATION-NNN: ...]`
    markers. If any found: list each as one row in a `| ID | Locations | Question |`
    table. **ID** = this marker's doc-qualified ID, `{doc}:NC-{NNN}` (e.g.
-   `brd:NC-002` for marker 002 in brd.md). **Locations** = comma-separated
+   `brd:NC-002` for marker 002 in brd.md — `{doc}` must exactly match the
+   file's stem: `brd`, `use-cases`, or `srd`, never an abbreviation like
+   `uc`). **Locations** = comma-separated
    doc-qualified IDs for every place this SAME question's answer applies —
    almost always just the ID itself again (e.g. `brd:NC-002`), but when one
    question was asked in more than one document (a duplicate — same

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-fullstack/.specify/manifest.yml

@@ -32,5 +32,5 @@ testing_style: "paired"
 # If using sdd-universal instead, set project_type: "fullstack" in its manifest.yml
 # project_type: "fullstack"
 
-sdd_version: "2.7.53"   # set by sdd init; used by sdd upgrade
+sdd_version: "2.7.55"   # set by sdd init; used by sdd upgrade
 ai_tool: ""             # set by sdd init: claude-code | copilot | cursor | windsurf | other

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-mobile/.github/prompts/validate.prompt.md

@@ -71,7 +71,9 @@ For each `[ASSUMPTION-NNN]` the owner marks as incorrect:
    Scan brd.md, use-cases.md, and srd.md for any `[NEEDS CLARIFICATION-NNN: ...]`
    markers. If any found: list each as one row in a `| ID | Locations | Question |`
    table. **ID** = this marker's doc-qualified ID, `{doc}:NC-{NNN}` (e.g.
-   `brd:NC-002` for marker 002 in brd.md). **Locations** = comma-separated
+   `brd:NC-002` for marker 002 in brd.md — `{doc}` must exactly match the
+   file's stem: `brd`, `use-cases`, or `srd`, never an abbreviation like
+   `uc`). **Locations** = comma-separated
    doc-qualified IDs for every place this SAME question's answer applies —
    almost always just the ID itself again (e.g. `brd:NC-002`), but when one
    question was asked in more than one document (a duplicate — same

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-mobile/.specify/manifest.yml

@@ -32,5 +32,5 @@ testing_style: "paired"
 # If using sdd-universal instead, set project_type: "mobile" in its manifest.yml
 # project_type: "mobile"
 
-sdd_version: "2.7.53"   # set by sdd init; used by sdd upgrade
+sdd_version: "2.7.55"   # set by sdd init; used by sdd upgrade
 ai_tool: ""             # set by sdd init: claude-code | copilot | cursor | windsurf | other

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-universal/.github/prompts/validate.prompt.md

@@ -71,7 +71,9 @@ For each `[ASSUMPTION-NNN]` the owner marks as incorrect:
    Scan brd.md, use-cases.md, and srd.md for any `[NEEDS CLARIFICATION-NNN: ...]`
    markers. If any found: list each as one row in a `| ID | Locations | Question |`
    table. **ID** = this marker's doc-qualified ID, `{doc}:NC-{NNN}` (e.g.
-   `brd:NC-002` for marker 002 in brd.md). **Locations** = comma-separated
+   `brd:NC-002` for marker 002 in brd.md — `{doc}` must exactly match the
+   file's stem: `brd`, `use-cases`, or `srd`, never an abbreviation like
+   `uc`). **Locations** = comma-separated
    doc-qualified IDs for every place this SAME question's answer applies —
    almost always just the ID itself again (e.g. `brd:NC-002`), but when one
    question was asked in more than one document (a duplicate — same

{sddflow-2.7.53 → sddflow-2.7.55}/sdd/packs/sdd-universal/.specify/manifest.yml

@@ -38,5 +38,5 @@ plan_mode: "unified"
 #   bdd:    Given/When/Then specs drive tests, written before implementation
 testing_style: "paired"
 
-sdd_version: "2.7.53"   # set by sdd init; used by sdd upgrade
+sdd_version: "2.7.55"   # set by sdd init; used by sdd upgrade
 ai_tool: ""             # set by sdd init: claude-code | copilot | cursor | windsurf | other

sddflow-2.7.53/sdd/__init__.py

@@ -1 +0,0 @@
-__version__ = "2.7.53"