scout-browser 4.82.1__tar.gz → 4.83__tar.gz

{scout-browser-4.82.1 → scout-browser-4.83}/CHANGELOG.md

@@ -4,7 +4,41 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 About changelog [here](https://keepachangelog.com/en/1.0.0/)
 
-# [4.82.1]
+## [4.83]
+### Added
+- Edit ACMG classifications from variant page (only for classifications with criteria)
+- Events for case CLI events (load case, update case, update individual)
+- Support for loading and displaying local custom IGV tracks
+- MANE IGV track to be used as a local track for igv.js (see scout demo config file)
+- Optional separate MT VCFs, for `nf-core/raredisease`
+### Changed
+- Avoid passing verbs from CaseHandler - functions for case sample and individual in CaseEventHandler
+- Hide mtDNA report and coverage report links on case sidebar for cases with WTS data only
+- Modified OMIM-AUTO gene panel to include genes in both genome builds
+- Moved chanjo code into a dedicated extension
+- Optimise the function that collects "match-safe" genes for an institute by avoiding duplicated genes from different panels
+- Users must actively select "show matching causatives/managed" on a case page to see matching numbers
+- Upgraded python version from 3.8 to 3.11 in Docker images
+### Fixed
+- Fix several tests that relied on number of events after setup to be 0
+- Removed unused load case function
+- Artwork logo sync sketch with png and export svg
+- Clearer exception handling on chanjo-report setup - fail early and visibly
+- mtDNA report crashing when one or more samples from a case is not in the chanjo database
+- Case page crashing on missing phenotype terms
+- ACMG benign modifiers
+- Speed up tests by caching python env correctly in Github action and adding two more test groups
+- Agile issue templates were added globally to the CG-org. Adding custom issue templates to avoid exposing customers
+- PanelApp panel not saving genes with empty `EnsembleGeneIds` list
+- Speed up checking outdated gene panels
+- Do not load research variants automatically when loading a case
+
+## [4.82.2]
+### Fixed
+- Warning icon in case pages for individuals where `confirmed_sex` is false
+- Show allele sizes form ExpansionHunter on STR variantS page again
+
+## [4.82.1]
 ### Fixed
 - Revert the installation of flask-ldapconn to use the version available on PyPI to be able to push new scout releases to PyPI
 

{scout-browser-4.82.1/scout_browser.egg-info → scout-browser-4.83}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: scout-browser
-Version: 4.82.1
+Version: 4.83
 Summary: Clinical DNA variant visualizer and browser.
 Home-page: https://github.com/Clinical-Genomics/scout
 Author: Måns Magnusson

scout-browser-4.83/scout/__version__.py

@@ -0,0 +1 @@
+__version__ = "4.83"

{scout-browser-4.82.1 → scout-browser-4.83}/scout/adapter/client.py

@@ -4,6 +4,7 @@ client.py
 Establish a connection to the database
 
 """
+
 import logging
 
 from pymongo import MongoClient

{scout-browser-4.82.1 → scout-browser-4.83}/scout/adapter/mongo/base.py

@@ -79,7 +79,6 @@ class MongoAdapter(
     PhenoModelHandler,
     RankModelHandler,
 ):
-
     """Adapter for communication with a Mongo database."""
 
     def __init__(self, database=None):

{scout-browser-4.82.1 → scout-browser-4.83}/scout/adapter/mongo/case.py

@@ -10,7 +10,7 @@ import pymongo
 from bson import ObjectId
 
 from scout.build.case import build_case
-from scout.constants import ACMG_MAP, ID_PROJECTION
+from scout.constants import ACMG_MAP, FILE_TYPE_MAP, ID_PROJECTION
 from scout.exceptions import ConfigError, IntegrityError
 from scout.parse.variant.ids import parse_document_id
 from scout.utils.algorithms import ui_score
@@ -883,44 +883,34 @@ class CaseHandler(object):
                 self.evaluated_variants(case_obj["_id"], case_obj["owner"])
             )
 
+        # load from files
         files = [
-            {"file_name": "vcf_snv", "variant_type": "clinical", "category": "snv"},
-            {"file_name": "vcf_sv", "variant_type": "clinical", "category": "sv"},
             {
-                "file_name": "vcf_cancer",
-                "variant_type": "clinical",
-                "category": "cancer",
-            },
-            {
-                "file_name": "vcf_cancer_sv",
-                "variant_type": "clinical",
-                "category": "cancer_sv",
-            },
-            {"file_name": "vcf_str", "variant_type": "clinical", "category": "str"},
-            {"file_name": "vcf_mei", "variant_type": "clinical", "category": "mei"},
-            {
-                "file_name": "vcf_fusion",
-                "variant_type": "clinical",
-                "category": "fusion",
-            },
+                "file_name": file_type,
+                "variant_type": FILE_TYPE_MAP[file_type]["variant_type"],
+                "category": FILE_TYPE_MAP[file_type]["category"],
+            }
+            for file_type in FILE_TYPE_MAP.keys()
+            if FILE_TYPE_MAP[file_type]["variant_type"] != "research"
         ]
 
+        # (type, category) tuples are not unique - eg SNV, SNV_MT
+        load_variants = set()
         try:
             for vcf_file in files:
-                # Check if file exists
+                # Check if any file of this kind is configured for case
                 if not case_obj["vcf_files"].get(vcf_file["file_name"]):
                     LOG.debug("didn't find {}, skipping".format(vcf_file["file_name"]))
                     continue
+                load_variants.add((vcf_file["variant_type"], vcf_file["category"]))
 
-                variant_type = vcf_file["variant_type"]
-                category = vcf_file["category"]
+            for variant_type, category in load_variants:
                 if update:
                     self.delete_variants(
                         case_id=case_obj["_id"],
                         variant_type=variant_type,
                         category=category,
                     )
-
                 # add variants
                 self.load_variants(
                     case_obj=case_obj,
@@ -948,7 +938,7 @@ class CaseHandler(object):
                 force_update_case=True,
             )
 
-            self.update_case(case_obj)
+            self.update_case_cli(case_obj, institute_obj)
             # update Sanger status for the new inserted variants
             self.update_case_sanger_variants(institute_obj, case_obj, old_sanger_variants)
 
@@ -957,7 +947,7 @@ class CaseHandler(object):
 
         else:
             LOG.info("Loading case %s into database", case_obj["display_name"])
-            self._add_case(case_obj)
+            self.add_case(case_obj, institute_obj)
 
         return case_obj
 
@@ -972,18 +962,6 @@ class CaseHandler(object):
                 "custom_images"
             ].get(variant_category)
 
-    def _add_case(self, case_obj):
-        """Add a case to the database
-        If the case already exists exception is raised
-
-         Args:
-             case_obj(Case)
-        """
-        if self.case(case_obj["_id"], projection=ID_PROJECTION):
-            raise IntegrityError("Case %s already exists in database" % case_obj["_id"])
-
-        return self.case_collection.insert_one(case_obj)
-
     def update_case(self, case_obj, keep_date=False):
         """Update a case in the database.
         While updating the case, it compares the date of the latest analysis (case_obj["analysis_date"]) against

{scout-browser-4.82.1 → scout-browser-4.83}/scout/adapter/mongo/case_events.py

@@ -1,10 +1,12 @@
 import logging
 from collections import Counter
+from os import getlogin
 from typing import Dict, List, Optional
 
 import pymongo
 
-from scout.constants import CASE_STATUSES, CASE_TAGS
+from scout.constants import CASE_STATUSES, CASE_TAGS, ID_PROJECTION
+from scout.exceptions import IntegrityError
 
 LOG = logging.getLogger(__name__)
 
@@ -12,6 +14,100 @@ LOG = logging.getLogger(__name__)
 class CaseEventHandler(object):
     """Class to handle case events for the mongo adapter"""
 
+    def get_cli_user(self) -> dict:
+        """
+        Return a faux CLI user with a login username from OS CLI if it is available.
+        """
+        try:
+            cli_user_name = getlogin()
+        except OSError:
+            # no controlling terminal
+            cli_user_name = "CLI user"
+
+        return {"_id": "CLI", "name": cli_user_name}
+
+    def add_case(self, case_obj: dict, institute_obj: dict):
+        """Add a case to the database
+        If the case already exists exception is raised.
+        Add case will only be called from CLI, or tests, so the user will be the faux CLI user with
+        a login username from OS CLI if available.
+        """
+        if self.case(case_obj["_id"], projection=ID_PROJECTION):
+            raise IntegrityError("Case %s already exists in database" % case_obj["_id"])
+        link = f"/{case_obj['owner']}/{case_obj['display_name']}"
+
+        self.create_event(
+            institute=institute_obj,
+            case=case_obj,
+            user=self.get_cli_user(),
+            link=link,
+            category="case",
+            verb="add_case",
+            subject=case_obj["display_name"],
+        )
+
+        return self.case_collection.insert_one(case_obj)
+
+    def update_case_individual(
+        self, case_obj: dict, user_obj: dict, institute_obj: dict, link: str, keep_date: bool = True
+    ):
+        """Update case with new individual data (age and/or Tissue type) for a case
+        and create an associated event"""
+        self._update_case_component(
+            case_obj, user_obj, institute_obj, link, verb="update_individual", keep_date=keep_date
+        )
+
+    def update_case_sample(
+        self, case_obj: dict, user_obj: dict, institute_obj: dict, link: str, keep_date=True
+    ):
+        """Handle update of sample data data (tissue, tumor_type, tumor_purity) for a cancer case
+        and create an associated event"""
+        self._update_case_component(
+            case_obj, user_obj, institute_obj, link, verb="update_sample", keep_date=keep_date
+        )
+
+    def _update_case_component(
+        self,
+        case_obj: dict,
+        user_obj: Optional[dict],
+        institute_obj: dict,
+        link: str,
+        verb: str,
+        keep_date: bool = True,
+    ):
+        """Update case with new sample data, and create an associated event"""
+        self.update_case(case_obj, keep_date)
+
+        if not user_obj:
+            user_obj = self.get_cli_user()
+
+        self.create_event(
+            institute=institute_obj,
+            case=case_obj,
+            user=user_obj,
+            link=link,
+            category="case",
+            verb=verb,
+            subject=case_obj["display_name"],
+        )
+
+    def update_case_cli(self, case_obj: dict, institute_obj: dict):
+        """Update case with new case obj, and create an associated CLI user event."""
+
+        link = f"/{case_obj['owner']}/{case_obj['display_name']}"
+
+        self.create_event(
+            institute=institute_obj,
+            case=case_obj,
+            user=self.get_cli_user(),
+            link=link,
+            category="case",
+            verb="update_case",
+            subject=case_obj["display_name"],
+        )
+
+        self.update_case(case_obj)
+
     def assign(self, institute, case, user, link):
         """Assign a user to a case.
 
@@ -550,7 +646,7 @@ class CaseEventHandler(object):
         updated_diagnoses = []
         case_diagnoses = case.get("diagnosis_phenotypes") or []
 
-        if remove is True:  # Remove term from case diagnoses list
+        if remove:  # Remove term from case diagnoses list
             for case_dia in case_diagnoses:
                 if case_dia.get("disease_id") == disease_id:
                     continue

{scout-browser-4.82.1 → scout-browser-4.83}/scout/adapter/mongo/hgnc.py

@@ -1,4 +1,5 @@
 import logging
+from typing import Dict
 
 import intervaltree
 from pymongo.errors import BulkWriteError, DuplicateKeyError
@@ -186,11 +187,11 @@ class GeneHandler(object):
         if build == "GRCh38":
             build = "38"
 
-        LOG.info("Fetching all genes")
+        LOG.debug("Fetching all genes")
 
         hgnc_tx = {}
         if add_transcripts:
-            LOG.info("Adding transcripts")
+            LOG.debug("Adding transcripts")
             for tx in self.transcripts(build=str(build)):
                 hgnc_id = tx["hgnc_id"]
                 if not hgnc_id in hgnc_tx:
@@ -318,7 +319,7 @@ class GeneHandler(object):
         res = self.hgnc_collection.find({"aliases": symbol, "build": str(build)})
         return res
 
-    def genes_by_alias(self, build="37", genes=None):
+    def genes_by_alias(self, build=None, genes=None):
         """Return a dictionary with hgnc symbols as keys and a list of hgnc ids
              as value.
 
@@ -333,45 +334,61 @@ class GeneHandler(object):
         Returns:
             alias_genes(dict): {<hgnc_alias>: {'true': <hgnc_id>, 'ids': {<hgnc_id_1>, <hgnc_id_2>, ...}}}
         """
-        LOG.info("Fetching all genes by alias")
+        LOG.debug("Fetching all genes by alias")
         # Collect one entry for each alias symbol that exists
         alias_genes = {}
-        # Loop over all genes
-        if not genes:
-            genes = self.hgnc_collection.find({"build": str(build)})
+
+        if genes is None:
+            genes_query = {"build": str(build)} if build else {}
+            genes = self.hgnc_collection.find(
+                genes_query, projection={"hgnc_id": 1, "hgnc_symbol": 1, "aliases": 1}
+            )
 
         for gene in genes:
-            # Collect the hgnc_id
             hgnc_id = gene["hgnc_id"]
-            # Collect the true symbol given by hgnc
             hgnc_symbol = gene["hgnc_symbol"]
-            # Loop aver all aliases
+
             for alias in gene["aliases"]:
-                true_id = None
-                # If the alias is the same as hgnc symbol we know the true id
+                if alias not in alias_genes:
+                    alias_genes[alias] = {"true": None, "ids": set()}
+
+                alias_genes[alias]["ids"].add(hgnc_id)
                 if alias == hgnc_symbol:
-                    true_id = hgnc_id
-                # If the alias is already in the list we add the id
-                if alias in alias_genes:
-                    alias_genes[alias]["ids"].add(hgnc_id)
-                    if true_id:
-                        alias_genes[alias]["true"] = hgnc_id
-                else:
-                    alias_genes[alias] = {"true": hgnc_id, "ids": set([hgnc_id])}
+                    alias_genes[alias]["true"] = hgnc_id
 
         return alias_genes
 
-    def ensembl_to_hgnc_mapping(self):
+    def ensembl_to_hgnc_id_mapping(self) -> Dict[str, int]:
         """Return a dictionary with Ensembl ids as keys and hgnc_ids as values
 
         Returns:
-            mapping(dict): {"ENSG00000121410":"A1BG", ...}
+            mapping(dict): {"ENSG00000121410": 5, ...}
         """
         pipeline = [{"$group": {"_id": {"ensembl_id": "$ensembl_id", "hgnc_id": "$hgnc_id"}}}]
         result = self.hgnc_collection.aggregate(pipeline)
         mapping = {res["_id"]["ensembl_id"]: res["_id"]["hgnc_id"] for res in result}
         return mapping
 
+    def hgnc_symbol_ensembl_id_mapping(self) -> Dict[str, str]:
+        """Return a dictionary with HGNC symbols as keys and Ensembl ids as values.
+
+        Returns:
+           mapping(dict): {"A1BG": "ENSG00000121410".}
+        """
+        pipeline = [
+            {
+                "$group": {
+                    "_id": {
+                        "hgnc_symbol": "$hgnc_symbol",
+                        "ensembl_id": "$ensembl_id",
+                    }
+                }
+            }
+        ]
+        result = self.hgnc_collection.aggregate(pipeline)
+        mapping = {res["_id"]["hgnc_symbol"]: res["_id"]["ensembl_id"] for res in result}
+        return mapping
+
     def ensembl_genes(self, build=None, add_transcripts=False, id_transcripts=False):
         """Return a dictionary with ensembl ids as keys and gene objects as value.
 

{scout-browser-4.82.1 → scout-browser-4.83}/scout/adapter/mongo/institute.py

@@ -158,15 +158,9 @@ class InstituteHandler(object):
 
         return institute_obj
 
-    def safe_genes_filter(self, institute_id):
+    def safe_genes_filter(self, institute_id: str) -> List[int]:
         """Returns a list of "safe" HGNC IDs to filter variants with. These genes are retrieved from the institute.gene_panels_matching
-        Can be used to limit secondary findings when retrieving other causatives or matching managed variants
-
-        Args:
-            institute_id(str): _id of an institute
-
-        Returns:
-            safe_genes(list of HGNC ids)
+        Can be used to limit secondary findings when retrieving other causatives or matching managed variants.
         """
         safe_genes = []
         institute_obj = self.institute(institute_id)
@@ -174,7 +168,7 @@ class InstituteHandler(object):
             return safe_genes  # return an empty list
         for panel_name in institute_obj.get("gene_panels_matching", {}).keys():
             safe_genes += self.panel_to_genes(panel_name=panel_name, gene_format="hgnc_id")
-        return safe_genes
+        return list(set(safe_genes))
 
     def institutes(self, institute_ids=None):
         """Fetch all institutes.

{scout-browser-4.82.1 → scout-browser-4.83}/scout/adapter/mongo/panel.py

@@ -1,4 +1,5 @@
 """Code to handle panels in the mongo database"""
+
 import datetime as dt
 import logging
 import math
@@ -244,7 +245,7 @@ class PanelHandler:
         for panel in res:
             return panel
 
-        LOG.info("No gene panel found")
+        LOG.warning("Gene panel not found")
 
         return None
 

{scout-browser-4.82.1 → scout-browser-4.83}/scout/adapter/mongo/variant.py

@@ -542,7 +542,8 @@ class VariantHandler(VariantLoader):
                 "institute": case_obj["owner"],
                 "verb": {"$in": ["mark_causative", "mark_partial_causative"]},
                 "category": "variant",
-            }
+            },
+            {"case": 1, "link": 1, "subject": 1},
         )
 
         positional_variant_ids = set()
@@ -553,7 +554,7 @@ class VariantHandler(VariantLoader):
 
             other_case = self.case(var_event["case"], CASE_CAUSATIVES_PROJECTION)
             if other_case is None:
-                # Other variant belongs to a case that   doesn't exist any more
+                # Other variant belongs to a case that doesn't exist anymore
                 continue
             other_link = var_event["link"]
             # link contains other variant ID