sbcli-dev 17.0.2__tar.gz → 17.0.4__tar.gz

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sbcli-dev
-Version: 17.0.2
+Version: 17.0.4
 Summary: CLI for managing SimplyBlock cluster
 Home-page: https://www.simplyblock.io/
 Author: Hamdy

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/pyproject.toml

@@ -1,3 +1,3 @@
 [build-system]
 requires = ['setuptools>=42']
-build-backend = 'setuptools.build_meta'
+build-backend = 'setuptools.build_meta'

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/sbcli_dev.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sbcli-dev
-Version: 17.0.2
+Version: 17.0.4
 Summary: CLI for managing SimplyBlock cluster
 Home-page: https://www.simplyblock.io/
 Author: Hamdy

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/setup.py

@@ -87,6 +87,7 @@ data_files.append(('', ["requirements.txt"]))
 setup(
     name=COMMAND_NAME,
     version=VERSION,
+    requires_python='>= 3.9',
     packages=find_packages(exclude=["e2e*"]),
     url='https://www.simplyblock.io/',
     author='Hamdy',

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_cli/cli.py

@@ -347,8 +347,6 @@ class CLIWrapper(CLIWrapperBase):
         argument = subcommand.add_argument('--log-del-interval', help='Logging retention period, default: 3d', type=str, default='3d', dest='log_del_interval', required=False)
         argument = subcommand.add_argument('--metrics-retention-period', help='Retention period for I/O statistics (Prometheus), default: 7d', type=str, default='7d', dest='metrics_retention_period', required=False)
         argument = subcommand.add_argument('--contact-point', help='Email or slack webhook url to be used for alerting', type=str, default='', dest='contact_point', required=False)
-        if self.developer_mode:
-            argument = subcommand.add_argument('--grafana-endpoint', help='Endpoint url for Grafana', type=str, default='', dest='grafana_endpoint', required=False)
         if self.developer_mode:
             argument = subcommand.add_argument('--distr-bs', help='(Dev) distrb bdev block size, default: 4096', type=int, default=4096, dest='distr_bs', required=False)
         argument = subcommand.add_argument('--chunk-size-in-bytes', help='(Dev) distrb bdev chunk block size, default: 4096', type=int, default=4096, dest='distr_chunk_bs', required=False)
@@ -405,25 +403,10 @@ class CLIWrapper(CLIWrapperBase):
         argument = subcommand.add_argument('--host-id', help='Primary storage node id or hostname', type=str, dest='host_id', required=False)
         if self.developer_mode:
             argument = subcommand.add_argument('--encrypt', help='Use inline data encryption and decryption on the logical volume', dest='encrypt', required=False, action='store_true')
-        if self.developer_mode:
-            argument = subcommand.add_argument('--crypto-key1', help='Hex value of key1 to be used for logical volume encryption', type=str, dest='crypto_key1', required=False)
-        if self.developer_mode:
-            argument = subcommand.add_argument('--crypto-key2', help='Hex value of key2 to be used for logical volume encryption', type=str, dest='crypto_key2', required=False)
-        if self.developer_mode:
-            argument = subcommand.add_argument('--max-rw-iops', help='Maximum Read Write IO Per Second', type=int, dest='max_rw_iops', required=False)
-        if self.developer_mode:
-            argument = subcommand.add_argument('--max-rw-mbytes', help='Maximum Read Write Megabytes Per Second', type=int, dest='max_rw_mbytes', required=False)
-        if self.developer_mode:
-            argument = subcommand.add_argument('--max-r-mbytes', help='Maximum Read Megabytes Per Second', type=int, dest='max_r_mbytes', required=False)
-        if self.developer_mode:
-            argument = subcommand.add_argument('--max-w-mbytes', help='Maximum Write Megabytes Per Second', type=int, dest='max_w_mbytes', required=False)
         if self.developer_mode:
             argument = subcommand.add_argument('--distr-vuid', help='(Dev) set vuid manually, default: random (1-99999)', type=int, dest='distr_vuid', required=False)
         if self.developer_mode:
             argument = subcommand.add_argument('--lvol-ha-type', help='Logical volume HA type (single, ha), default is cluster HA type', type=str, default='ha', dest='lvol_ha_type', required=False, choices=['single','default','ha',])
-        argument = subcommand.add_argument('--lvol-priority-class', help='Logical volume priority class', type=int, default=0, dest='lvol_priority_class', required=False)
-        if self.developer_mode:
-            argument = subcommand.add_argument('--fstype', help='Filesystem type for testing (ext4, xfs)', type=str, default='xfs', dest='fstype', required=False, choices=['ext4','xfs',])
 
     def init_cluster__create(self, subparser):
         subcommand = self.add_sub_command(subparser, 'create', 'Creates a new cluster')
@@ -465,8 +448,8 @@ class CLIWrapper(CLIWrapperBase):
         argument = subcommand.add_argument('--cap-crit', help='Capacity critical level in percent, default: 99', type=int, default=99, dest='cap_crit', required=False)
         argument = subcommand.add_argument('--prov-cap-warn', help='Capacity warning level in percent, default: 250', type=int, default=250, dest='prov_cap_warn', required=False)
         argument = subcommand.add_argument('--prov-cap-crit', help='Capacity critical level in percent, default: 500', type=int, default=500, dest='prov_cap_crit', required=False)
-        argument = subcommand.add_argument('--data-chunks-per-stripe', help='Erasure coding schema parameter k (distributed raid), default: 1', type=int, default=0, dest='distr_ndcs', required=False)
-        argument = subcommand.add_argument('--parity-chunks-per-stripe', help='Erasure coding schema parameter n (distributed raid), default: 1', type=int, default=0, dest='distr_npcs', required=False)
+        argument = subcommand.add_argument('--data-chunks-per-stripe', help='Erasure coding schema parameter k (distributed raid), default: 1', type=int, default=1, dest='distr_ndcs', required=False)
+        argument = subcommand.add_argument('--parity-chunks-per-stripe', help='Erasure coding schema parameter n (distributed raid), default: 1', type=int, default=1, dest='distr_npcs', required=False)
         if self.developer_mode:
             argument = subcommand.add_argument('--distr-bs', help='(Dev) distrb bdev block size, default: 4096', type=int, default=4096, dest='distr_bs', required=False)
         if self.developer_mode:
@@ -1018,7 +1001,6 @@ class CLIWrapper(CLIWrapperBase):
                     args.blk_size = 512
                     args.page_size = 2097152
                     args.CLI_PASS = None
-                    args.grafana_endpoint = ''
                     args.distr_bs = 4096
                     args.max_queue_size = 128
                     args.inflight_io_threshold = 4
@@ -1039,16 +1021,9 @@ class CLIWrapper(CLIWrapperBase):
                     args.pool_max = '25G'
                     args.snapshot = False
                     args.max_size = '1000G'
-                    args.encrypt = False
-                    args.crypto_key1 = None
-                    args.crypto_key2 = None
-                    args.max_rw_iops = None
-                    args.max_rw_mbytes = None
-                    args.max_r_mbytes = None
-                    args.max_w_mbytes = None
+                    args.encrypt = None
                     args.distr_vuid = None
                     args.lvol_ha_type = 'ha'
-                    args.fstype = 'xfs'
                 ret = self.cluster__deploy(sub_command, args)
             elif sub_command in ['create']:
                 if not self.developer_mode:

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_cli/clibase.py

@@ -648,7 +648,27 @@ class CLIWrapperBase:
 
 
     def cluster_deploy(self,args):
-        
+        grafana_endpoint = ""
+        secondary_nodes = False
+        namespace = None
+        lvol_name = "lvol01"
+        lvol_size = self.parse_size("10G")
+        pool_max = self.parse_size("25G")
+        max_size = self.parse_size("1000G")
+        pool_name = "pool01"
+        with_snapshot = False
+        host_id = None
+        crypto = False
+        crypto_key1 = None
+        crypto_key2 = None
+        max_rw_iops = None
+        max_rw_mbytes = None
+        max_r_mbytes = None
+        max_w_mbytes = None
+        lvol_priority_class = 0
+        id_device_by_nqn = False
+        fstype = "xfs"
+
         storage_nodes = args.storage_nodes
         test = args.test
         ha_type = args.ha_type
@@ -669,7 +689,6 @@ class CLIWrapperBase:
         log_del_interval = args.log_del_interval
         metrics_retention_period = args.metrics_retention_period
         contact_point = args.contact_point
-        grafana_endpoint = args.grafana_endpoint
         enable_node_affinity = args.enable_node_affinity
         qpair_count = args.qpair_count
         max_queue_size = args.max_queue_size
@@ -712,17 +731,7 @@ class CLIWrapperBase:
         pool_max = utils.parse_size(args.pool_max)
         host_id = args.host_id
         comp = None
-        crypto = args.encrypt
         distr_vuid = args.distr_vuid
-        with_snapshot = args.snapshot
-        lvol_priority_class = args.lvol_priority_class
-        max_rw_iops = args.max_rw_iops
-        max_rw_mbytes = args.max_rw_mbytes
-        max_r_mbytes = args.max_r_mbytes
-        max_w_mbytes = args.max_w_mbytes
-        crypto_key1 = args.crypto_key1
-        crypto_key2 = args.crypto_key2
-        fstype = args.fstype
 
         return cluster_ops.deploy_cluster(
             storage_nodes,test,ha_type,distr_ndcs,distr_npcs,enable_qos,ifname,
@@ -732,8 +741,8 @@ class CLIWrapperBase:
             qpair_count, max_queue_size, inflight_io_threshold, strict_node_anti_affinity,data_nics,
             spdk_image,spdk_debug,small_bufsize,large_bufsize,num_partitions_per_dev,jm_percent,spdk_cpu_mask,max_lvol,
             max_snap,max_prov,number_of_devices,enable_test_device,enable_ha_jm,ha_jm_count,number_of_distribs,namespace,secondary_nodes,partition_size,
-            lvol_name, lvol_size, lvol_ha_type, pool_name, pool_max, host_id, comp, crypto, distr_vuid, max_rw_iops, max_rw_mbytes, max_r_mbytes, max_w_mbytes, 
-            with_snapshot, max_size, crypto_key1, crypto_key2, lvol_priority_class, fstype)
+            lvol_name, lvol_size, lvol_ha_type, pool_name, pool_max, host_id, comp, crypto, distr_vuid, max_rw_iops, max_rw_mbytes, max_r_mbytes, max_w_mbytes,
+            with_snapshot, max_size, crypto_key1, crypto_key2, lvol_priority_class, id_device_by_nqn, fstype)
 
     def cluster_create(self, args):
         page_size_in_blocks = args.page_size

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_core/cluster_ops.py

@@ -203,8 +203,8 @@ def create_cluster(blk_size, page_size_in_blocks, cli_pass,
     if prov_cap_crit and prov_cap_crit > 0:
         c.prov_cap_crit = prov_cap_crit
     if distr_ndcs == 0 and distr_npcs == 0:
-        c.distr_ndcs = 1
-        c.distr_npcs = 1
+        logger.error("both distr_ndcs and distr_npcs cannot be 0")
+        return False
     else:
         c.distr_ndcs = distr_ndcs
         c.distr_npcs = distr_npcs
@@ -380,7 +380,7 @@ def deploy_cluster(storage_nodes,test,ha_type,distr_ndcs,distr_npcs,enable_qos,i
                    ha_jm_count, number_of_distribs,namespace,secondary_nodes,partition_size,
                    lvol_name, lvol_size, lvol_ha_type, pool_name, pool_max, host_id, comp, crypto, distr_vuid, max_rw_iops,
                    max_rw_mbytes, max_r_mbytes, max_w_mbytes, with_snapshot, max_size, crypto_key1, crypto_key2,
-                   lvol_priority_class, fstype):
+                   lvol_priority_class, id_device_by_nqn, fstype):
     logger.info("run deploy-cleaner")
     
     storage_node_ops.deploy_cleaner()
@@ -401,7 +401,7 @@ def deploy_cluster(storage_nodes,test,ha_type,distr_ndcs,distr_npcs,enable_qos,i
         dev_ip=f"{node_ip}:5000"
         add_node_status=storage_node_ops.add_node(cluster_uuid,dev_ip,ifname,data_nics,max_lvol,max_snap,max_prov,spdk_image,spdk_debug,
                                   small_bufsize,large_bufsize,spdk_cpu_mask,num_partitions_per_dev,jm_percent,number_of_devices,
-                                  enable_test_device,namespace,number_of_distribs,enable_ha_jm,False,False,partition_size,ha_jm_count)
+                                  enable_test_device,namespace,number_of_distribs,enable_ha_jm,False,id_device_by_nqn,partition_size,ha_jm_count)
         
         
         if not add_node_status:
@@ -417,7 +417,7 @@ def deploy_cluster(storage_nodes,test,ha_type,distr_ndcs,distr_npcs,enable_qos,i
             dev_ip=f"{node_ip}:5000"
             add_node_status=storage_node_ops.add_node(cluster_uuid,dev_ip,ifname,data_nics,max_lvol,max_snap,max_prov,spdk_image,spdk_debug,
                                     small_bufsize,large_bufsize,spdk_cpu_mask,num_partitions_per_dev,jm_percent,number_of_devices,
-                                    enable_test_device,namespace,number_of_distribs,enable_ha_jm,True,False,partition_size,ha_jm_count)
+                                    enable_test_device,namespace,number_of_distribs,enable_ha_jm,True,id_device_by_nqn,partition_size,ha_jm_count)
                     
             if not add_node_status:
                 logger.error("Could not add storage node successfully")
@@ -537,11 +537,11 @@ def add_cluster(blk_size, page_size_in_blocks, cap_warn, cap_crit, prov_cap_warn
     _create_update_user(cluster.uuid, cluster.grafana_endpoint, cluster.grafana_secret, cluster.secret)
 
     if distr_ndcs == 0 and distr_npcs == 0:
-        cluster.distr_ndcs = 2
-        cluster.distr_npcs = 1
-    else:
-        cluster.distr_ndcs = distr_ndcs
-        cluster.distr_npcs = distr_npcs
+        logger.error("both distr_ndcs and distr_npcs cannot be 0")
+        return False
+
+    cluster.distr_ndcs = distr_ndcs
+    cluster.distr_npcs = distr_npcs
     cluster.distr_bs = distr_bs
     cluster.distr_chunk_bs = distr_chunk_bs
     cluster.ha_type = ha_type

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_core/env_var

@@ -1,5 +1,5 @@
 SIMPLY_BLOCK_COMMAND_NAME=sbcli-dev
-SIMPLY_BLOCK_VERSION=17.0.2
+SIMPLY_BLOCK_VERSION=17.0.4
 
 SIMPLY_BLOCK_DOCKER_IMAGE=public.ecr.aws/simply-block/simplyblock:main
 SIMPLY_BLOCK_SPDK_ULTRA_IMAGE=public.ecr.aws/simply-block/ultra:main-latest

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_core/models/caching_node.py

@@ -41,12 +41,12 @@ class CachingNode(BaseNodeObject):
     multipathing: bool = True
     node_lvs: str = "lvs"
     nvme_devices: List[NVMeDevice] = []
-    partitions_count: int = 0
+    partitions_count: int = 0  # Unused
     remote_devices: List[NVMeDevice] = []
     rpc_password: str = ""
     rpc_port: int = -1
     rpc_username: str = ""
-    sequential_number: int = 0
+    sequential_number: int = 0  # Unused
     services: List[str] = []
     subsystem: str = ""
     system_uuid: str = ""

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_core/models/nvme_device.py

@@ -46,19 +46,19 @@ class NVMeDevice(BaseModel):
     nvmf_ip: str = ""
     nvmf_nqn: str = ""
     nvmf_port: int = 0
-    overload_percentage: int = 0
-    partition_jm_bdev: str = ""
-    partition_jm_size: int = 0
-    partition_main_bdev: str = ""
-    partition_main_size: int = 0
-    partitions_count: int = 0
+    overload_percentage: int = 0  # Unused
+    partition_jm_bdev: str = ""  # Unused
+    partition_jm_size: int = 0  # Unused
+    partition_main_bdev: str = ""  # Unused
+    partition_main_size: int = 0  # Unused
+    partitions_count: int = 0  # Unused
     pcie_address: str = ""
     physical_label: int = 0
     pt_bdev: str = ""
     qos_bdev: str = ""
     remote_bdev: str = ""
     retries_exhausted: bool = False
-    sequential_number: int = 0
+    sequential_number: int = 0  # Unused
     serial_number: str = ""
     size: int = -1
     testing_bdev: str = ""
@@ -70,4 +70,3 @@ class JMDevice(NVMeDevice):
     jm_bdev: str = ""
     jm_nvme_bdev_list: List[str] = []
     raid_bdev: str = ""
-

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_core/models/storage_node.py

@@ -66,7 +66,7 @@ class StorageNode(BaseNodeObject):
     number_of_distribs: int = 4
     nvme_devices: List[NVMeDevice] = []
     online_since: str = ""
-    partitions_count: int = 0
+    partitions_count: int = 0  # Unused
     poller_cpu_cores: List[int] = []
     ssd_pcie: List = []
     pollers_mask: str = ""
@@ -78,7 +78,7 @@ class StorageNode(BaseNodeObject):
     rpc_port: int = -1
     rpc_username: str = ""
     secondary_node_id: str = ""
-    sequential_number: int = 0
+    sequential_number: int = 0  # Unused
     jm_ids: List[str] = []
     spdk_cpu_mask: str = ""
     spdk_debug: bool = False

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_core/rpc_client.py

@@ -792,13 +792,6 @@ class RPCClient:
         params = {"name": name, "vuid": vuid}
         return self._request("bdev_jm_unmap_vuid", params)
 
-    def sock_impl_set_options(self):
-        method = "sock_impl_set_options"
-        params = {"impl_name": "posix", "enable_quickack": True,
-                  "enable_zerocopy_send_server": True,
-                  "enable_zerocopy_send_client": True}
-        return self._request(method, params)
-
     def nvmf_set_config(self, poll_groups_mask):
         params = {"poll_groups_mask": poll_groups_mask}
         return self._request("nvmf_set_config", params)

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_core/services/lvol_monitor.py

@@ -99,6 +99,9 @@ while True:
                         logger.debug(f"Skipping LVol health check because of io_error {lvol.get_id()}")
                         continue
 
+                    if lvol.status == LVol.STATUS_IN_CREATION:
+                        continue
+
                     if lvol.status == lvol.STATUS_IN_DELETION:
                         ret = rpc_client.bdev_lvol_get_lvol_delete_status(f"{lvol.lvs_name}/{lvol.lvol_bdev}")
                         if ret == 0: # delete complete
@@ -119,13 +122,10 @@ while True:
                         continue
 
                     passed = True
-
-                    if lvol.ha_type == 'single':
-                        ret = health_controller.check_lvol_on_node(
-                            lvol.get_id(), lvol.node_id, node_bdev_names, node_lvols_nqns)
-                        if not ret:
-                            passed = False
-
+                    ret = health_controller.check_lvol_on_node(
+                        lvol.get_id(), lvol.node_id, node_bdev_names, node_lvols_nqns)
+                    if not ret:
+                        passed = False
 
                     if lvol.ha_type == "ha":
                         sec_node = db_controller.get_storage_node_by_id(snode.secondary_node_id)

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_core/storage_node_ops.py

@@ -30,59 +30,6 @@ from simplyblock_core.snode_client import SNodeClient
 logger = utils.get_logger(__name__)
 
 
-class StorageOpsException(Exception):
-    def __init__(self, message):
-        self.message = message
-
-
-def _get_data_nics(data_nics):
-    if not data_nics:
-        return
-    out, _, _ = shell_utils.run_command("ip -j address show")
-    data = json.loads(out)
-    logger.debug("ifaces")
-    logger.debug(pprint.pformat(data))
-
-    def _get_ip4_address(list_of_addr):
-        if list_of_addr:
-            for data in list_of_addr:
-                if data['family'] == 'inet':
-                    return data['local']
-        return ""
-
-    devices = {i["ifname"]: i for i in data}
-    iface_list = []
-    for nic in data_nics:
-        if nic not in devices:
-            continue
-        device = devices[nic]
-        iface = IFace({
-            'uuid': str(uuid.uuid4()),
-            'if_name': device['ifname'],
-            'ip4_address': _get_ip4_address(device['addr_info']),
-            'port_number': 1,  # TODO: check this value
-            'status': device['operstate'],
-            'net_type': device['link_type']})
-        iface_list.append(iface)
-
-    return iface_list
-
-
-def _get_if_ip_address(ifname):
-    out, _, _ = shell_utils.run_command("ip -j address show %s" % ifname)
-    data = json.loads(out)
-    logger.debug(pprint.pformat(data))
-    if data:
-        data = data[0]
-        if 'addr_info' in data and data['addr_info']:
-            address_info = data['addr_info']
-            for adr in address_info:
-                if adr['family'] == 'inet':
-                    return adr['local']
-    logger.error("IP not found for interface %s", ifname)
-    exit(1)
-
-
 def addNvmeDevices(snode, devs):
     rpc_client = RPCClient(
         snode.mgmt_ip, snode.rpc_port,
@@ -149,70 +96,6 @@ def addNvmeDevices(snode, devs):
     return devices
 
 
-def _get_nvme_list(cluster):
-    out, err, _ = shell_utils.run_command("sudo nvme list -v -o json")
-    data = json.loads(out)
-    logger.debug("nvme list:")
-    logger.debug(pprint.pformat(data))
-
-    def _get_pcie_controller(ctrl_list):
-        if ctrl_list:
-            for item in ctrl_list:
-                if 'Transport' in item and item['Transport'] == 'pcie':
-                    return item
-
-    def _get_size_from_namespaces(namespaces):
-        size = 0
-        if namespaces:
-            for ns in namespaces:
-                size += ns['PhysicalSize']
-        return size
-
-    sequential_number = 0
-    devices = []
-    if data and 'Devices' in data:
-        for dev in data['Devices'][0]['Subsystems']:
-            controller = _get_pcie_controller(dev['Controllers'])
-            if not controller:
-                continue
-
-            if controller['ModelNumber'] not in cluster.model_ids:
-                logger.info("Device model ID is not recognized: %s, skipping device: %s",
-                            controller['ModelNumber'], controller['Controller'])
-                continue
-
-            size = _get_size_from_namespaces(controller['Namespaces'])
-            device_partitions_count = int(size / (cluster.blk_size * cluster.page_size_in_blocks))
-            devices.append(
-                NVMeDevice({
-                    'device_name': controller['Controller'],
-                    'sequential_number': sequential_number,
-                    'partitions_count': device_partitions_count,
-                    'capacity': size,
-                    'size': size,
-                    'pcie_address': controller['Address'],
-                    'model_id': controller['ModelNumber'],
-                    'serial_number': controller['SerialNumber'],
-                    # 'status': controller['State']
-                }))
-            sequential_number += device_partitions_count
-    return devices
-
-
-def _run_nvme_smart_log(dev_name):
-    out, _, _ = shell_utils.run_command("sudo nvme smart-log /dev/%s -o json" % dev_name)
-    data = json.loads(out)
-    logger.debug(out)
-    return data
-
-
-def _run_nvme_smart_log_add(dev_name):
-    out, _, _ = shell_utils.run_command("sudo nvme intel smart-log-add /dev/%s --json" % dev_name)
-    data = json.loads(out)
-    logger.debug(out)
-    return data
-
-
 def get_next_cluster_device_order(db_controller, cluster_id):
     max_order = 0
     found = False

{sbcli_dev-17.0.2 → sbcli_dev-17.0.4}/simplyblock_core/utils.py

@@ -333,40 +333,6 @@ def get_random_vuid():
     return r
 
 
-def calculate_core_allocation(cpu_count):
-    '''
-    If number of cpu cores >= 8, tune cpu core mask
-        1. Never use core 0 for spdk.
-        2. Core 1 is for app_thread
-        3. Core 2 for Journal manager
-        4. Poller cpu cores are 30% of Available cores
-        5. Alceml cpu cores are 30% of Available cores
-        6. Distribs cpu cores are 40% of Available cores
-    JIRA ticket link/s
-    https://simplyblock.atlassian.net/browse/SFAM-885
-    '''
-
-    if cpu_count > 64:
-        cpu_count = 64
-
-    all_cores = list(range(0, cpu_count))
-    app_thread_core = all_cores[1:2]
-    jm_cpu_core = all_cores[2:3]
-
-    # Calculate available cores
-    available_cores_count = cpu_count - 3
-
-    # Calculate cpus counts
-    poller_cpus_count = int(available_cores_count * 0.3)
-    alceml_cpus_cout = int(available_cores_count * 0.3)
-
-    # Calculate cpus cores
-    poller_cpu_cores = all_cores[3:poller_cpus_count+3]
-    alceml_cpu_cores = all_cores[3+poller_cpus_count:poller_cpus_count+alceml_cpus_cout+3]
-    distrib_cpu_cores = all_cores[3+poller_cpus_count+alceml_cpus_cout:]
-
-    return app_thread_core, jm_cpu_core, poller_cpu_cores, alceml_cpu_cores, distrib_cpu_cores
-
 def hexa_to_cpu_list(cpu_mask):
     # Convert the hex string to an integer
     mask_int = int(cpu_mask, 16)