sase-github 0.1.4__tar.gz → 0.1.6__tar.gz

sase_github-0.1.6/.release-please-manifest.json

@@ -0,0 +1,3 @@
+{
+  ".": "0.1.6"
+}

{sase_github-0.1.4 → sase_github-0.1.6}/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## [0.1.6](https://github.com/sase-org/sase-github/compare/v0.1.5...v0.1.6) (2026-07-02)
+
+
+### Bug Fixes
+
+* report closed GitHub PRs in submitted checks ([5ad2168](https://github.com/sase-org/sase-github/commit/5ad2168c1e36cca4b39e4435fff3076f3492dfb5))
+
+
+### Documentation
+
+* drop `--python 3.12` pin from install commands ([4ecc344](https://github.com/sase-org/sase-github/commit/4ecc344987dd7609996d8ee9040a31e4adb7bb96))
+
+## [0.1.5](https://github.com/sase-org/sase-github/compare/v0.1.4...v0.1.5) (2026-07-01)
+
+
+### Features
+
+* support GitHub Enterprise hosts ([e1f3b02](https://github.com/sase-org/sase-github/commit/e1f3b02f469cbcbea9711697ffa3d7f5d0115597))
+
+
+### Documentation
+
+* document managed Enterprise setup ([baf704a](https://github.com/sase-org/sase-github/commit/baf704a8859a081a7d42ed6639504c3ee6354872))
+
 ## [0.1.4](https://github.com/sase-org/sase-github/compare/v0.1.3...v0.1.4) (2026-06-30)
 
 

{sase_github-0.1.4 → sase_github-0.1.6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: sase-github
-Version: 0.1.4
+Version: 0.1.6
 Summary: GitHub VCS plugin for sase
 License-Expression: MIT
 License-File: LICENSE

{sase_github-0.1.4 → sase_github-0.1.6}/README.md

@@ -8,23 +8,45 @@
 ## Overview
 
 **sase-github** is a plugin for [sase](https://github.com/sase-org/sase) that adds GitHub-specific VCS and workspace
-support. It provides the `GitHubPlugin` VCS provider and `GitHubWorkspacePlugin` workspace provider for GitHub-hosted
-repositories, integrating with the `gh` CLI for pull request creation, management, and submission, along with
-GitHub-specific xprompt workflows.
+support. It provides the `GitHubPlugin` VCS provider and `GitHubWorkspacePlugin` workspace provider for repositories
+hosted on `github.com` or configured GitHub Enterprise hosts, integrating with the `gh` CLI for pull request creation,
+management, and submission, along with GitHub-specific xprompt workflows.
 
 ## Installation
 
+For a managed SASE install, install `sase-github` into the same `uv tool` environment as `sase` so its entry points are
+discovered by the `sase` command.
+
+### Recommended: SASE Admin Center Updates tab
+
+If SASE is already installed with `uv tool install sase`, open `sase ace`, press `#` for the SASE Admin Center, then go
+to the **Updates** tab (`5`, or `[` / `]`). Highlight `sase-github` in the plugin list (`j` / `k`, or `/` to filter),
+press `i` to install, and confirm the preview modal. The preview shows the exact `uv` command and resolved package set;
+the install runs as a tracked background task and is discovered on the next `sase` run.
+
+See the core SASE docs for the [Updates tab](https://github.com/sase-org/sase/blob/master/docs/configuration.md#updates-tab)
+and [`sase plugin` commands](https://github.com/sase-org/sase/blob/master/docs/plugins.md).
+
+### Alternative: install SASE and the plugin together
+
 ```bash
-pip install sase-github
+uv tool install sase --with sase-github
 ```
 
-Or with [uv](https://docs.astral.sh/uv/):
+Repeat `--with` for additional plugins, for example `--with sase-github --with sase-telegram`. Add `--force` to replace
+an existing tool install.
+
+### Equivalent CLI for an existing install
 
 ```bash
-uv pip install sase-github
+sase plugin install github
 ```
 
-Requires `sase>=0.1.3` as a dependency (installed automatically).
+`pip install sase-github` is only an escape hatch for non-managed or library-style environments. It is not the normal
+path for a `uv tool`-managed SASE command.
+
+Requires `sase>=0.1.3` as a dependency. For GitHub Enterprise Server or self-hosted GitHub, follow the
+[GitHub Enterprise setup walkthrough](docs/configuration.md#github-enterprise-setup).
 
 ## What's Included
 
@@ -41,6 +63,8 @@ Requires `sase>=0.1.3` as a dependency (installed automatically).
 
 ### Configuration
 
+- **`get_github_hosts()` / `get_default_github_host()`** — Read `github_hosts` from sase config to recognize GitHub
+  Enterprise hosts and choose the default host for `#gh(owner/repo)` clone refs
 - **`get_github_orgs()`** — Reads `github_orgs` from sase config to determine SSH vs HTTPS clone URLs for
   organizations/users with push access
 
@@ -61,15 +85,19 @@ itself with sase core:
 - **`sase_workspace`** — Registers `GitHubWorkspacePlugin` as the `github` workspace provider
 - **`sase_xprompts`** — Makes GitHub xprompts discoverable via plugin discovery
 
-When sase detects a GitHub-hosted repository (via `gh` CLI), it automatically loads `GitHubPlugin` and
-`GitHubWorkspacePlugin` to handle VCS operations like PR creation, branch management, commit workflows, and PR
-submission.
+When sase detects a repository whose remote origin host is in the configured GitHub host set, it automatically loads
+`GitHubPlugin` and `GitHubWorkspacePlugin` to handle VCS operations like PR creation, branch management, commit
+workflows, and PR submission.
 
 ## Requirements
 
 - Python 3.12+
 - [sase](https://github.com/sase-org/sase) >= 0.1.3
-- [gh](https://cli.github.com/) CLI (for GitHub API operations)
+- [gh](https://cli.github.com/) CLI (for GitHub API operations). For GitHub Enterprise, run
+  `gh auth login --hostname <host>` for each configured Enterprise host.
+
+See [Configuration](docs/configuration.md) for `github_hosts`, `github_orgs`, workspace layout, and the ordered GitHub
+Enterprise setup flow.
 
 ## Development
 
@@ -93,7 +121,7 @@ src/sase_github/
 ├── __init__.py              # Package exports
 ├── plugin.py                # GitHubPlugin VCS implementation
 ├── workspace_plugin.py      # GitHubWorkspacePlugin workspace implementation
-├── config.py                # GitHub config helpers (org/user list)
+├── config.py                # GitHub config helpers (host and org/user lists)
 ├── scripts/
 │   ├── gh_setup.py                 # Setup step for #gh workflow
 │   └── new_pr_desc_get_context.py  # Context retrieval for PR description generation

{sase_github-0.1.4 → sase_github-0.1.6}/docs/architecture.md

@@ -23,7 +23,7 @@ Extends `GitCommon` from sase core. Handles low-level VCS operations by wrapping
 
 | Hook                        | Behavior                                                                              |
 | --------------------------- | ------------------------------------------------------------------------------------- |
-| `vcs_classify_repo()`       | Claims repos with `github.com` in their origin URL                                    |
+| `vcs_classify_repo()`       | Claims repos whose origin host is in the configured GitHub host set                   |
 | `vcs_get_change_url()`      | Returns PR URL via `gh pr view --json url`                                            |
 | `vcs_get_cl_number()`       | Returns PR number via `gh pr view --json number`                                      |
 | `vcs_mail()`                | Pushes branch (`git push -u origin`) and creates PR if needed (`gh pr create --fill`) |
@@ -57,8 +57,9 @@ The `resolve_gh_ref()` function supports three dispatch modes for `#gh` referenc
 
 When the ref contains `/`, it's treated as a GitHub repo path:
 
-- Derives workspace from `~/projects/github/<user>/<project>/`
-- Clones the repo if it doesn't exist (SSH for orgs in `github_orgs`, HTTPS otherwise)
+- Derives workspace from `~/projects/github/<user>/<project>/` for `github.com`, or
+  `~/projects/github/<host>/<user>/<project>/` for other default hosts
+- Clones the repo from the default GitHub host if it doesn't exist (SSH for orgs in `github_orgs`, HTTPS otherwise)
 - Reuses an existing SASE ProjectSpec whose normalized `WORKSPACE_DIR` already points at that workspace
 - Otherwise creates a canonical project name from the repo identity, normally `gh_<user>__<project>`
 - Adds a deterministic suffix such as `-2` only if that canonical project name is already occupied by a different
@@ -104,5 +105,6 @@ When submitting a GitHub ChangeSpec (`ws_submit`):
 
 ## Config Helper
 
-`config.py` provides `get_github_orgs()` which reads the `github_orgs` list from the merged sase config. This determines
-whether repos are cloned via SSH (for orgs the user has push access to) or HTTPS.
+`config.py` provides `get_github_hosts()` and `get_default_github_host()` for host matching and bare `#gh(owner/repo)`
+clone refs. Configured hosts are normalized, and `github.com` is always included implicitly. It also provides
+`get_github_orgs()`, which determines whether repos are cloned via SSH (for orgs the user has push access to) or HTTPS.

sase_github-0.1.6/docs/configuration.md

@@ -0,0 +1,114 @@
+# Configuration
+
+## GitHub Enterprise setup
+
+Use this checklist for GitHub Enterprise Server or another self-hosted GitHub host:
+
+1. **Install SASE and `sase-github`.** Use the
+   [README installation routes](../README.md#installation): the SASE Admin Center Updates tab is the recommended path
+   for an existing managed install, while `uv tool install sase --with sase-github` installs SASE and the
+   plugin together. The core SASE [plugin docs](https://github.com/sase-org/sase/blob/master/docs/plugins.md) also cover
+   `sase plugin install github` for existing installs.
+2. **Authenticate `gh` to the Enterprise host.**
+
+   ```bash
+   gh auth login --hostname github.mycompany.com
+   ```
+
+   Repo-scoped `gh` commands auto-detect the host from the git remote, so this host-specific login is enough for PR
+   operations once the repo is cloned.
+3. **Set `github_hosts` in `~/.config/sase/sase.yml`.** **Put your Enterprise host first** if you want bare
+   `#gh(owner/repo)` refs to clone from Enterprise. `github.com` is always included implicitly, but the first configured
+   host is the default for bare refs; listing `github.com` first means bare refs default there instead. See
+   [`github_hosts`](#github_hosts).
+4. **Optionally enable SSH clones.** Add owners to [`github_orgs`](#github_orgs) when you have an SSH key registered on
+   that GitHub host and want SASE to clone those repos with `git@<host>:owner/repo.git`. Owners not listed in
+   `github_orgs` use HTTPS.
+5. **Verify and resolve a repo.** Run:
+
+   ```bash
+   sase doctor -C plugins.github
+   ```
+
+   Then resolve a repo with `#gh(owner/repo)`. Enterprise workspaces are namespaced by host under
+   `~/projects/github/<host>/<user>/<project>/`; see [Workspace Layout](#workspace-layout).
+
+## `github_hosts`
+
+The `github_hosts` setting controls which GitHub hosts sase-github recognizes. Add it to your sase config file
+(`~/.config/sase/sase.yml`) when you use GitHub Enterprise Server or another self-hosted GitHub instance:
+
+```yaml
+github_hosts:
+  - github.mycompany.com
+  - github.com
+```
+
+**Effect:** sase-github claims repositories whose remote origin host matches one of these hosts. `github.com` is always
+included implicitly, so public GitHub keeps working even if you only configure an Enterprise host.
+
+The first configured host is the default for bare `#gh(owner/repo)` refs. With the example above,
+`#gh(my-org/my-repo)` clones from `github.mycompany.com`. If `github_hosts` is unset, the default host is `github.com`.
+
+Host entries are normalized, so pasted values such as `https://github.mycompany.com/` are accepted.
+
+## `github_orgs`
+
+The `github_orgs` setting controls how sase-github clones repositories. Add it to your sase config file
+(`~/.config/sase/sase.yml`):
+
+```yaml
+github_orgs:
+  - your-username
+  - your-org
+```
+
+**Effect:** When cloning a repo whose owner is in this list, sase-github uses SSH
+(`git@<github-host>:user/project.git`). For all other repos, it uses HTTPS
+(`https://<github-host>/user/project.git`).
+
+This matters because SSH URLs require an SSH key configured with GitHub, while HTTPS URLs work for public repos without
+authentication (but require a token for push access).
+
+## Default Config
+
+sase-github contributes a `default_config.yml` via the `sase_config` entry point. This is merged into the sase config
+chain between sase core defaults and your user config.
+
+Currently the default config defines:
+
+- `xprompts.pr_diff` — an xprompt that expands to the diff of the current PR's changes
+
+## Requirements
+
+- **`gh` CLI** — Required for all PR operations. Install from https://cli.github.com/ and authenticate with
+  `gh auth login`. For GitHub Enterprise, authenticate to the configured host with
+  `gh auth login --hostname github.mycompany.com`.
+- **Git** — Standard git CLI for repository operations.
+
+## Workspace Layout
+
+Primary GitHub workspaces are stored under `~/projects/github/<user>/<project>/` when first resolved from a
+`#gh(user/project)` reference and the default host is `github.com`. For other default hosts, workspaces are namespaced
+by host at `~/projects/github/<host>/<user>/<project>/` to avoid collisions between same-named repos on different
+GitHub installations.
+
+Numbered parallel-work checkouts follow SASE's shared `workspace.root` policy: by default they live under the platform
+state-root namespace, while explicit `workspace.root: adjacent` keeps the legacy
+`~/projects/github/<user>/<project>_<N>/` sibling layout for `github.com` projects.
+
+## Project Files
+
+Project metadata is stored in `~/.sase/projects/<project>/<project>.sase`; legacy `.gp` files remain readable as a
+fallback. The key field is `WORKSPACE_DIR`, which points to the primary workspace directory and is set automatically
+when you first use an `#gh:<user>/<project>` ref.
+
+For new `owner/repo` refs, the project name is based on the full GitHub identity, normally `gh_<user>__<project>`, so
+two owners can have repositories with the same basename. If that canonical name is already occupied by a different
+project, `PROJECT_NAME`, or alias, sase-github adds a deterministic suffix such as `-2`.
+
+sase-github also writes `PROJECT_NAME` to the repo basename when it is valid and useful. The first `owner/foo` repo can
+get `PROJECT_NAME: foo`; a second `owner/foo` repo gets the next available display name such as `foo_1`. Existing
+basename ProjectSpecs are reused when their `WORKSPACE_DIR` already matches the GitHub workspace, so no automatic
+migration or rename is required. Existing auto-aliased GitHub projects are also left unchanged and keep resolving via
+their `PROJECT_ALIASES` entry.

{sase_github-0.1.4 → sase_github-0.1.6}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "sase-github"
-version = "0.1.4"
+version = "0.1.6"
 description = "GitHub VCS plugin for sase"
 requires-python = ">=3.12"
 license = "MIT"

sase_github-0.1.6/src/sase_github/config.py

@@ -0,0 +1,88 @@
+"""GitHub configuration helpers."""
+
+import re
+from collections.abc import Iterable
+from urllib.parse import urlparse
+
+from sase.config import load_merged_config
+
+DEFAULT_GITHUB_HOST = "github.com"
+
+
+def normalize_github_host(value: object) -> str | None:
+    """Normalize a configured GitHub host or pasted GitHub URL."""
+    if value is None:
+        return None
+
+    raw = str(value).strip().lower().rstrip("/")
+    if not raw:
+        return None
+
+    # Accept pasted scp-style remotes such as git@github.example.com:org/repo.git.
+    scp_match = re.match(r"^(?:[^@/]+@)?([^:/]+):[^/]+/.+", raw)
+    if "://" not in raw and scp_match:
+        return scp_match.group(1)
+
+    if "://" in raw:
+        parsed = urlparse(raw)
+        host = parsed.netloc.rsplit("@", 1)[-1]
+    else:
+        host = raw.split("/", 1)[0].rsplit("@", 1)[-1]
+
+    return host or None
+
+
+def _config_list(value: object) -> list[object]:
+    if isinstance(value, list):
+        return value
+    if isinstance(value, tuple):
+        return list(value)
+    if isinstance(value, Iterable) and not isinstance(value, str):
+        return list(value)
+    if value:
+        return [value]
+    return []
+
+
+def _dedupe_hosts(hosts: Iterable[str]) -> list[str]:
+    deduped: list[str] = []
+    for host in hosts:
+        if host not in deduped:
+            deduped.append(host)
+    return deduped
+
+
+def get_github_orgs() -> list[str]:
+    """Read ``github_orgs`` from the merged sase config.
+
+    Returns:
+        A list of GitHub org/user names the user has push access to.
+    """
+    config = load_merged_config()
+    value = config.get("github_orgs")
+    if isinstance(value, list):
+        return [str(v) for v in value if v]
+    if value:
+        return [str(value)]
+    return []
+
+
+def get_github_hosts() -> list[str]:
+    """Read configured GitHub hosts, always including ``github.com``."""
+    config = load_merged_config()
+    configured_hosts = [
+        host
+        for item in _config_list(config.get("github_hosts"))
+        if (host := normalize_github_host(item)) is not None
+    ]
+    return _dedupe_hosts([*configured_hosts, DEFAULT_GITHUB_HOST])
+
+
+def get_default_github_host() -> str:
+    """Return the host used for bare ``#gh(owner/repo)`` clone refs."""
+    config = load_merged_config()
+    for item in _config_list(config.get("github_hosts")):
+        host = normalize_github_host(item)
+        if host:
+            return host
+    return DEFAULT_GITHUB_HOST

{sase_github-0.1.4 → sase_github-0.1.6}/src/sase_github/plugin.py

@@ -10,6 +10,7 @@ import subprocess
 
 from sase.vcs_provider._hookspec import hookimpl
 from sase.vcs_provider.plugins._git_common import GitCommon
+from sase_github.config import get_github_hosts, normalize_github_host
 
 
 class GitHubPlugin(GitCommon):
@@ -17,7 +18,7 @@ class GitHubPlugin(GitCommon):
 
     @hookimpl
     def vcs_classify_repo(self, git_dir: str) -> str | None:
-        """Claim repos with ``github.com`` in their origin URL."""
+        """Claim repos whose origin host is a configured GitHub host."""
         try:
             result = subprocess.run(
                 ["git", "config", "--get", "remote.origin.url"],
@@ -34,7 +35,8 @@ class GitHubPlugin(GitCommon):
             return None
 
         url = result.stdout.strip()
-        if "github.com" in url:
+        host = normalize_github_host(url)
+        if host in get_github_hosts():
             return "github"
         return None
 
@@ -65,9 +67,7 @@ class GitHubPlugin(GitCommon):
         return (True, None)
 
     @hookimpl
-    def vcs_get_change_body(
-        self, change_ref: str, cwd: str
-    ) -> tuple[bool, str | None]:
+    def vcs_get_change_body(self, change_ref: str, cwd: str) -> tuple[bool, str | None]:
         out = self._run(
             ["gh", "pr", "view", change_ref, "--json", "body", "-q", ".body"], cwd
         )

{sase_github-0.1.4 → sase_github-0.1.6}/src/sase_github/workspace_plugin.py

@@ -25,6 +25,9 @@ from sase.workspace_provider.utils import (
 if TYPE_CHECKING:
     from sase.core.project_lifecycle_wire import ProjectRecordWire
 
+_PR_URL_RE = re.compile(r"https?://[^/]+/.+?/pull/(\d+)")
+_HOSTED_URL_RE = re.compile(r"https?://[^/]+/")
+
 
 class GitHubWorkspacePlugin:
     """Workspace provider plugin for GitHub-hosted projects."""
@@ -96,7 +99,7 @@ class GitHubWorkspacePlugin:
     @hookimpl
     def ws_extract_change_identifier(self, cl_url: str) -> tuple[str, str] | None:
         """Extract PR number from a GitHub PR URL."""
-        match = re.match(r"https?://github\.com/.+/pull/(\d+)", cl_url)
+        match = _PR_URL_RE.match(cl_url)
         if match:
             return (match.group(1), "git")
         return None
@@ -105,18 +108,24 @@ class GitHubWorkspacePlugin:
     def ws_generate_submitted_check_script(
         self, identifier: str, vcs_type: str
     ) -> str | None:
-        """Generate script to check if a GitHub PR is merged."""
+        """Generate script to check if a GitHub PR is merged or closed."""
         if vcs_type != "git":
             return None
         return (
             f"state=$(gh pr view {identifier} --json state -q '.state' 2>/dev/null)\n"
-            f'[ "$state" = "MERGED" ]'
+            'echo "PR state: ${state:-<unavailable>}"\n'
+            'case "$state" in\n'
+            "  MERGED) true ;;\n"
+            "  # Keep this literal in sync with SUBMITTED_CHECK_EXIT_CODE_CLOSED.\n"
+            "  CLOSED) (exit 20) ;;\n"
+            "  *) false ;;\n"
+            "esac"
         )
 
     @hookimpl
     def ws_supports_reviewer_comments(self, cl_url: str) -> bool | None:
         """GitHub does not support reviewer comments via critique_comments."""
-        if re.match(r"https?://github\.com/", cl_url):
+        if _HOSTED_URL_RE.match(cl_url):
             return False
         return None
 
@@ -314,8 +323,7 @@ class GitHubWorkspacePlugin:
                 return _submit_via_pr_merge(changespec, ws_dir, rich_console)
             return (
                 False,
-                "GitHub project has no PR for this branch. "
-                "Create a PR first with #pr.",
+                "GitHub project has no PR for this branch. Create a PR first with #pr.",
             )
         finally:
             release_workspace(
@@ -331,15 +339,25 @@ class GitHubWorkspacePlugin:
 # ── Private helpers ─────────────────────────────────────────────────
 
 
-def _clone_gh_repo(user: str, project: str, target_dir: str) -> None:
+def _clone_gh_repo(
+    user: str,
+    project: str,
+    target_dir: str,
+    *,
+    host: str | None = None,
+) -> None:
     """Clone a GitHub repo to the target directory."""
-    from sase_github.config import get_github_orgs
+    from sase_github.config import get_default_github_host, get_github_orgs
 
+    github_host = host or get_default_github_host()
     gh_orgs = get_github_orgs()
     if user in gh_orgs:
-        url = f"git@github.com:{user}/{project}.git"
+        if ":" in github_host:
+            url = f"ssh://git@{github_host}/{user}/{project}.git"
+        else:
+            url = f"git@{github_host}:{user}/{project}.git"
     else:
-        url = f"https://github.com/{user}/{project}.git"
+        url = f"https://{github_host}/{user}/{project}.git"
     parent = os.path.dirname(target_dir.rstrip("/"))
     os.makedirs(parent, exist_ok=True)
 
@@ -361,8 +379,14 @@ def _projects_base() -> Path:
     return Path.home() / ".sase" / "projects"
 
 
-def _github_workspace_dir(user: str, project: str) -> str:
-    return str(Path.home() / "projects" / "github" / user / project) + "/"
+def _github_workspace_dir(user: str, project: str, host: str | None = None) -> str:
+    from sase_github.config import DEFAULT_GITHUB_HOST, get_default_github_host
+
+    github_host = host or get_default_github_host()
+    base = Path.home() / "projects" / "github"
+    if github_host == DEFAULT_GITHUB_HOST:
+        return str(base / user / project) + "/"
+    return str(base / github_host / user / project) + "/"
 
 
 def _normalized_workspace_dir(workspace_dir: str | None) -> str | None:
@@ -506,8 +530,11 @@ def _resolved_ref_for_record(
 
 
 def _resolve_repo_path_ref(user: str, project: str) -> ResolvedRef:
+    from sase_github.config import get_default_github_host
+
     projects_base = _projects_base()
-    primary_workspace_dir = _github_workspace_dir(user, project)
+    github_host = get_default_github_host()
+    primary_workspace_dir = _github_workspace_dir(user, project, host=github_host)
     records = _list_project_records(projects_base)
     existing_record = _find_project_record_for_workspace(
         records,
@@ -515,7 +542,7 @@ def _resolve_repo_path_ref(user: str, project: str) -> ResolvedRef:
     )
 
     if not os.path.isdir(primary_workspace_dir.rstrip("/")):
-        _clone_gh_repo(user, project, primary_workspace_dir)
+        _clone_gh_repo(user, project, primary_workspace_dir, host=github_host)
 
     if existing_record is None:
         project_name = _allocate_canonical_project_name(user, project, records)
@@ -612,7 +639,7 @@ def _extract_pr_number(cl_url: str | None) -> str | None:
     """Extract a PR number from a GitHub PR URL, or return ``None``."""
     if not cl_url:
         return None
-    match = re.match(r"https?://github\.com/.+/pull/(\d+)", cl_url)
+    match = _PR_URL_RE.match(cl_url)
     return match.group(1) if match else None
 
 

sase_github-0.1.6/tests/test_config.py

@@ -0,0 +1,50 @@
+"""Tests for GitHub configuration helpers."""
+
+from unittest.mock import patch
+
+from sase_github.config import (
+    get_default_github_host,
+    get_github_hosts,
+    normalize_github_host,
+)
+
+
+def test_get_github_hosts_defaults_to_github_com() -> None:
+    with patch("sase_github.config.load_merged_config", return_value={}):
+        assert get_github_hosts() == ["github.com"]
+        assert get_default_github_host() == "github.com"
+
+
+def test_get_github_hosts_normalizes_and_adds_github_com() -> None:
+    with patch(
+        "sase_github.config.load_merged_config",
+        return_value={
+            "github_hosts": [
+                " https://GITHUB.ENTERPRISE.TEST/ ",
+                "https://github.enterprise.test/org/repo",
+                "github.com",
+            ],
+        },
+    ):
+        assert get_github_hosts() == ["github.enterprise.test", "github.com"]
+
+
+def test_get_default_github_host_uses_first_configured_host() -> None:
+    with patch(
+        "sase_github.config.load_merged_config",
+        return_value={"github_hosts": ["github.enterprise.test", "github.com"]},
+    ):
+        assert get_default_github_host() == "github.enterprise.test"
+
+
+def test_normalize_github_host_accepts_urls_and_remotes() -> None:
+    assert normalize_github_host("https://GITHUB.ENTERPRISE.TEST/org/repo") == (
+        "github.enterprise.test"
+    )
+    assert normalize_github_host("git@github.enterprise.test:org/repo.git") == (
+        "github.enterprise.test"
+    )
+    assert normalize_github_host("ssh://git@github.enterprise.test/org/repo.git") == (
+        "github.enterprise.test"
+    )
+    assert normalize_github_host("") is None

{sase_github-0.1.4 → sase_github-0.1.6}/tests/test_github_plugin.py

@@ -42,6 +42,65 @@ def test_github_plugin_is_command_runner() -> None:
     assert isinstance(plugin, CommandRunner)
 
 
+# === Tests for repository classification ===
+
+
+def _classify_origin_url(url: str, hosts: list[str]) -> str | None:
+    plugin = GitHubPlugin()
+    with (
+        patch("sase_github.plugin.get_github_hosts", return_value=hosts),
+        patch("sase_github.plugin.subprocess.run") as mock_run,
+    ):
+        mock_run.return_value = MagicMock(returncode=0, stdout=f"{url}\n", stderr="")
+        return plugin.vcs_classify_repo("/workspace")
+
+
+@pytest.mark.parametrize(
+    "url",
+    [
+        "https://github.com/user/repo.git",
+        "git@github.com:user/repo.git",
+        "ssh://git@github.com/user/repo.git",
+    ],
+)
+def test_vcs_classify_repo_github_com_url_forms(url: str) -> None:
+    assert _classify_origin_url(url, ["github.com"]) == "github"
+
+
+@pytest.mark.parametrize(
+    "url",
+    [
+        "https://github.enterprise.test/user/repo.git",
+        "git@github.enterprise.test:user/repo.git",
+        "ssh://git@github.enterprise.test/user/repo.git",
+    ],
+)
+def test_vcs_classify_repo_configured_enterprise_url_forms(url: str) -> None:
+    assert _classify_origin_url(url, ["github.enterprise.test", "github.com"]) == (
+        "github"
+    )
+
+
+def test_vcs_classify_repo_unconfigured_host_returns_none() -> None:
+    assert (
+        _classify_origin_url(
+            "https://github.other.test/user/repo.git",
+            ["github.enterprise.test", "github.com"],
+        )
+        is None
+    )
+
+
+def test_vcs_classify_repo_uses_host_equality_not_substring() -> None:
+    assert (
+        _classify_origin_url(
+            "https://example.test/github.com/user/repo.git",
+            ["github.com"],
+        )
+        is None
+    )
+
+
 # === Tests for core git operations via plugin ===
 
 
@@ -118,9 +177,7 @@ def test_plugin_abandon_change_already_closed(
     mock_run: MagicMock, github_provider: VCSPluginManager
 ) -> None:
     """abandon_change succeeds when PR is already closed."""
-    mock_run.return_value = MagicMock(
-        returncode=1, stdout="", stderr="already closed"
-    )
+    mock_run.return_value = MagicMock(returncode=1, stdout="", stderr="already closed")
     success, error = github_provider.abandon_change(
         "https://github.com/user/repo/pull/42", "feature-branch", "/workspace"
     )
@@ -134,9 +191,7 @@ def test_plugin_abandon_change_not_found(
     mock_run: MagicMock, github_provider: VCSPluginManager
 ) -> None:
     """abandon_change succeeds when PR is not found."""
-    mock_run.return_value = MagicMock(
-        returncode=1, stdout="", stderr="not found"
-    )
+    mock_run.return_value = MagicMock(returncode=1, stdout="", stderr="not found")
     success, error = github_provider.abandon_change(
         "https://github.com/user/repo/pull/42", "feature-branch", "/workspace"
     )
@@ -150,9 +205,7 @@ def test_plugin_abandon_change_failure(
     mock_run: MagicMock, github_provider: VCSPluginManager
 ) -> None:
     """abandon_change returns error on unexpected failure."""
-    mock_run.return_value = MagicMock(
-        returncode=1, stdout="", stderr="network error"
-    )
+    mock_run.return_value = MagicMock(returncode=1, stdout="", stderr="network error")
     success, error = github_provider.abandon_change(
         "https://github.com/user/repo/pull/42", "feature-branch", "/workspace"
     )
@@ -520,9 +573,7 @@ def test_direct_abandon_change_success(mock_run: MagicMock) -> None:
 @patch(_MOCK_TARGET)
 def test_direct_abandon_change_already_closed(mock_run: MagicMock) -> None:
     """Test GitHubPlugin.vcs_abandon_change when PR is already closed."""
-    mock_run.return_value = MagicMock(
-        returncode=1, stdout="", stderr="already closed"
-    )
+    mock_run.return_value = MagicMock(returncode=1, stdout="", stderr="already closed")
 
     plugin = GitHubPlugin()
     success, error = plugin.vcs_abandon_change(

{sase_github-0.1.4 → sase_github-0.1.6}/tests/test_submit_with_recorded_pr.py

@@ -23,6 +23,12 @@ def test_extract_pr_number_from_url() -> None:
     assert _extract_pr_number("https://github.com/org/repo/pull/42") == "42"
 
 
+def test_extract_pr_number_from_enterprise_url() -> None:
+    assert _extract_pr_number("https://github.enterprise.test/org/repo/pull/42") == (
+        "42"
+    )
+
+
 def test_extract_pr_number_none() -> None:
     assert _extract_pr_number(None) is None
 

{sase_github-0.1.4 → sase_github-0.1.6}/tests/test_workspace_plugin.py

@@ -1,14 +1,19 @@
 """Tests for sase_github.workspace_plugin module (GitHub-specific functions)."""
 
 import os
+import subprocess
 import tempfile
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
 import pytest
+from sase.workspace_provider import SUBMITTED_CHECK_EXIT_CODE_CLOSED
 
 from sase_github.workspace_plugin import (
     GitHubWorkspacePlugin,
+    _clone_gh_repo,
+    _extract_pr_number,
+    _github_workspace_dir,
     resolve_gh_ref,
 )
 
@@ -34,6 +39,191 @@ def _home_patches(home: Path) -> tuple[object, object]:
     )
 
 
+def _run_submitted_check_script(
+    tmp_path: Path, gh_body: str
+) -> subprocess.CompletedProcess[str]:
+    bin_dir = tmp_path / "bin"
+    bin_dir.mkdir()
+    gh = bin_dir / "gh"
+    gh.write_text(f"#!/bin/bash\n{gh_body}\n", encoding="utf-8")
+    gh.chmod(0o755)
+
+    script = GitHubWorkspacePlugin().ws_generate_submitted_check_script("42", "git")
+    assert script is not None
+
+    script_path = tmp_path / "check.sh"
+    script_path.write_text(f"#!/bin/bash\n{script}\n", encoding="utf-8")
+    script_path.chmod(0o755)
+
+    env = {
+        **os.environ,
+        "PATH": f"{bin_dir}:{os.environ['PATH']}",
+    }
+    return subprocess.run(
+        [str(script_path)],
+        capture_output=True,
+        text=True,
+        check=False,
+        env=env,
+    )
+
+
+@pytest.fixture(autouse=True)
+def _default_github_host() -> object:
+    with patch("sase_github.config.get_default_github_host", return_value="github.com"):
+        yield
+
+
+@pytest.mark.parametrize(
+    ("gh_body", "expected_code", "expected_state"),
+    [
+        ("printf 'MERGED\\n'", 0, "MERGED"),
+        ("printf 'CLOSED\\n'", SUBMITTED_CHECK_EXIT_CODE_CLOSED, "CLOSED"),
+        ("printf 'OPEN\\n'", 1, "OPEN"),
+        ("exit 2", 1, "<unavailable>"),
+    ],
+)
+def test_submitted_check_script_reports_pr_state(
+    tmp_path: Path,
+    gh_body: str,
+    expected_code: int,
+    expected_state: str,
+) -> None:
+    result = _run_submitted_check_script(tmp_path, gh_body)
+
+    assert result.returncode == expected_code
+    assert f"PR state: {expected_state}" in result.stdout
+
+
+def test_submitted_check_script_has_no_bare_exit_statement() -> None:
+    script = GitHubWorkspacePlugin().ws_generate_submitted_check_script("42", "git")
+    assert script is not None
+
+    for line in script.splitlines():
+        stripped = line.strip()
+        assert stripped != "exit"
+        assert not stripped.startswith("exit ")
+
+
+def test_submitted_check_closed_literal_matches_sase_contract() -> None:
+    script = GitHubWorkspacePlugin().ws_generate_submitted_check_script("42", "git")
+    assert script is not None
+    assert f"(exit {SUBMITTED_CHECK_EXIT_CODE_CLOSED})" in script
+
+
+class TestHostAwareWorkspace:
+    def test_github_com_workspace_path_is_unchanged(self) -> None:
+        with tempfile.TemporaryDirectory() as d:
+            home = Path(d)
+            with patch("sase_github.workspace_plugin.Path.home", return_value=home):
+                assert _github_workspace_dir("alice", "repo", host="github.com") == (
+                    str(home / "projects" / "github" / "alice" / "repo") + "/"
+                )
+
+    def test_enterprise_workspace_path_is_namespaced_by_host(self) -> None:
+        with tempfile.TemporaryDirectory() as d:
+            home = Path(d)
+            with patch("sase_github.workspace_plugin.Path.home", return_value=home):
+                assert _github_workspace_dir(
+                    "alice",
+                    "repo",
+                    host="github.enterprise.test",
+                ) == (
+                    str(
+                        home
+                        / "projects"
+                        / "github"
+                        / "github.enterprise.test"
+                        / "alice"
+                        / "repo"
+                    )
+                    + "/"
+                )
+
+    def test_clone_uses_enterprise_https_url(self) -> None:
+        with tempfile.TemporaryDirectory() as d:
+            target = str(Path(d) / "repo")
+            with (
+                patch("sase_github.config.get_github_orgs", return_value=[]),
+                patch("sase_github.workspace_plugin.subprocess.run") as mock_run,
+            ):
+                _clone_gh_repo(
+                    "alice",
+                    "repo",
+                    target,
+                    host="github.enterprise.test",
+                )
+
+        assert mock_run.call_args[0][0] == [
+            "git",
+            "clone",
+            "https://github.enterprise.test/alice/repo.git",
+            target,
+        ]
+
+    def test_clone_uses_enterprise_ssh_url_for_configured_org(self) -> None:
+        with tempfile.TemporaryDirectory() as d:
+            target = str(Path(d) / "repo")
+            with (
+                patch("sase_github.config.get_github_orgs", return_value=["alice"]),
+                patch("sase_github.workspace_plugin.subprocess.run") as mock_run,
+            ):
+                _clone_gh_repo(
+                    "alice",
+                    "repo",
+                    target,
+                    host="github.enterprise.test",
+                )
+
+        assert mock_run.call_args[0][0] == [
+            "git",
+            "clone",
+            "git@github.enterprise.test:alice/repo.git",
+            target,
+        ]
+
+    @patch(
+        "sase_github.workspace_plugin.get_default_branch", return_value="origin/main"
+    )
+    def test_repo_path_uses_default_enterprise_host(
+        self,
+        mock_branch: MagicMock,
+    ) -> None:
+        with tempfile.TemporaryDirectory() as d:
+            home = Path(d)
+            path_patch, env_patch = _home_patches(home)
+            with (
+                path_patch,
+                env_patch,
+                patch(
+                    "sase_github.config.get_default_github_host",
+                    return_value="github.enterprise.test",
+                ),
+                patch("sase_github.config.get_github_orgs", return_value=[]),
+                patch("sase_github.workspace_plugin.subprocess.run") as mock_run,
+            ):
+                result = resolve_gh_ref("alice/repo")
+
+        expected = (
+            str(
+                home
+                / "projects"
+                / "github"
+                / "github.enterprise.test"
+                / "alice"
+                / "repo"
+            )
+            + "/"
+        )
+        assert result.primary_workspace_dir == expected
+        assert mock_run.call_args[0][0] == [
+            "git",
+            "clone",
+            "https://github.enterprise.test/alice/repo.git",
+            expected.rstrip("/"),
+        ]
+
+
 class TestResolveGhRef:
     @patch(
         "sase_github.workspace_plugin.get_default_branch", return_value="origin/main"
@@ -360,3 +550,28 @@ class TestDetectWorkflowTypeForProject:
             with open(spec, "w") as f:
                 f.write(f"WORKSPACE_DIR: {workspace}\nNAME: cl\n")
             assert plugin.ws_detect_workflow_type(project_file=spec) == "gh"
+
+
+class TestPrUrlParsing:
+    def test_extract_change_identifier_accepts_enterprise_pr_url(self) -> None:
+        plugin = GitHubWorkspacePlugin()
+
+        assert plugin.ws_extract_change_identifier(
+            "https://github.enterprise.test/user/repo/pull/42"
+        ) == ("42", "git")
+
+    def test_extract_pr_number_accepts_enterprise_pr_url(self) -> None:
+        assert (
+            _extract_pr_number("https://github.enterprise.test/user/repo/pull/42")
+            == "42"
+        )
+
+    def test_supports_reviewer_comments_accepts_enterprise_url(self) -> None:
+        plugin = GitHubWorkspacePlugin()
+
+        assert (
+            plugin.ws_supports_reviewer_comments(
+                "https://github.enterprise.test/user/repo/pull/42"
+            )
+            is False
+        )

sase_github-0.1.4/.release-please-manifest.json

@@ -1,3 +0,0 @@
-{
-  ".": "0.1.4"
-}

sase_github-0.1.4/docs/configuration.md

@@ -1,56 +0,0 @@
-# Configuration
-
-## `github_orgs`
-
-The `github_orgs` setting controls how sase-github clones repositories. Add it to your sase config file
-(`~/.config/sase/sase.yml`):
-
-```yaml
-github_orgs:
-  - your-username
-  - your-org
-```
-
-**Effect:** When cloning a repo whose owner is in this list, sase-github uses SSH (`git@github.com:user/project.git`).
-For all other repos, it uses HTTPS (`https://github.com/user/project.git`).
-
-This matters because SSH URLs require an SSH key configured with GitHub, while HTTPS URLs work for public repos without
-authentication (but require a token for push access).
-
-## Default Config
-
-sase-github contributes a `default_config.yml` via the `sase_config` entry point. This is merged into the sase config
-chain between sase core defaults and your user config.
-
-Currently the default config defines:
-
-- `xprompts.pr_diff` — an xprompt that expands to the diff of the current PR's changes
-
-## Requirements
-
-- **`gh` CLI** — Required for all PR operations. Install from https://cli.github.com/ and authenticate with
-  `gh auth login`.
-- **Git** — Standard git CLI for repository operations.
-
-## Workspace Layout
-
-Primary GitHub workspaces are stored under `~/projects/github/<user>/<project>/` when first resolved from a
-`#gh(user/project)` reference. Numbered parallel-work checkouts follow SASE's shared `workspace.root` policy: by default
-they live under the platform state-root namespace, while explicit `workspace.root: adjacent` keeps the legacy
-`~/projects/github/<user>/<project>_<N>/` sibling layout.
-
-## Project Files
-
-Project metadata is stored in `~/.sase/projects/<project>/<project>.sase`; legacy `.gp` files remain readable as a
-fallback. The key field is `WORKSPACE_DIR`, which points to the primary workspace directory and is set automatically
-when you first use an `#gh:<user>/<project>` ref.
-
-For new `owner/repo` refs, the project name is based on the full GitHub identity, normally `gh_<user>__<project>`, so
-two owners can have repositories with the same basename. If that canonical name is already occupied by a different
-project, `PROJECT_NAME`, or alias, sase-github adds a deterministic suffix such as `-2`.
-
-sase-github also writes `PROJECT_NAME` to the repo basename when it is valid and useful. The first `owner/foo` repo can
-get `PROJECT_NAME: foo`; a second `owner/foo` repo gets the next available display name such as `foo_1`. Existing
-basename ProjectSpecs are reused when their `WORKSPACE_DIR` already matches the GitHub workspace, so no automatic
-migration or rename is required. Existing auto-aliased GitHub projects are also left unchanged and keep resolving via
-their `PROJECT_ALIASES` entry.

sase_github-0.1.4/src/sase_github/config.py

@@ -1,18 +0,0 @@
-"""GitHub configuration helpers."""
-
-from sase.config import load_merged_config
-
-
-def get_github_orgs() -> list[str]:
-    """Read ``github_orgs`` from the merged sase config.
-
-    Returns:
-        A list of GitHub org/user names the user has push access to.
-    """
-    config = load_merged_config()
-    value = config.get("github_orgs")
-    if isinstance(value, list):
-        return [str(v) for v in value if v]
-    if value:
-        return [str(value)]
-    return []