sarj-python-lint 1.7.6__tar.gz → 1.7.8__tar.gz

{sarj_python_lint-1.7.6 → sarj_python_lint-1.7.8}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: sarj-python-lint
-Version: 1.7.6
+Version: 1.7.8
 Summary: Custom Python lint rules — AST-based, pre-commit-friendly, hypermodern defaults
 Project-URL: Homepage, https://code-standards.sarj.ai/rules/python/
 Project-URL: Documentation, https://code-standards.sarj.ai/rules/python/

{sarj_python_lint-1.7.6 → sarj_python_lint-1.7.8}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "sarj-python-lint"
-version = "1.7.6"
+version = "1.7.8"
 description = "Custom Python lint rules — AST-based, pre-commit-friendly, hypermodern defaults"
 readme = "README.md"
 authors = [{ name = "sarj-ai" }]

{sarj_python_lint-1.7.6 → sarj_python_lint-1.7.8}/src/sarj_python_lint/rules/_registry.py

@@ -9,6 +9,7 @@ from sarj_python_lint.rules.complex_postgres_query_requires_architecture_review
     ComplexPostgresQueryRequiresArchitectureReview,
 )
 from sarj_python_lint.rules.defect_xfail_requires_explicit_strict import DefectXfailRequiresExplicitStrict
+from sarj_python_lint.rules.discourage_nullable_constructor_parameters import DiscourageNullableConstructorParameters
 from sarj_python_lint.rules.docstring_args_restate_signature import (
     DocstringArgsRestateSignature,
 )
@@ -192,6 +193,7 @@ if TYPE_CHECKING:
 REGISTRY: Mapping[str, type[Rule]] = MappingProxyType(
     {
         RequireExplicitContractImplementation.id: RequireExplicitContractImplementation,
+        DiscourageNullableConstructorParameters.id: DiscourageNullableConstructorParameters,
         RequirePublicDependencyContract.id: RequirePublicDependencyContract,
         RequireExplicitServiceContract.id: RequireExplicitServiceContract,
         AsyncCleanupRegisteredSynchronously.id: AsyncCleanupRegisteredSynchronously,

sarj_python_lint-1.7.8/src/sarj_python_lint/rules/discourage_nullable_constructor_parameters.py

@@ -0,0 +1,122 @@
+from __future__ import annotations
+
+import ast
+from pathlib import PurePosixPath
+from typing import TYPE_CHECKING, ClassVar, final, override
+
+from sarj_python_lint.rule_base import (
+    AutofixPolicy,
+    Diagnostic,
+    ExampleFile,
+    ExampleOutcome,
+    Rule,
+    RuleCategory,
+    RuleDocumentation,
+    RuleExample,
+    Severity,
+)
+from sarj_python_lint.rules._paths import is_test_path
+
+
+if TYPE_CHECKING:
+    from sarj_python_lint._file_context import PythonFileContext
+
+
+@final
+class DiscourageNullableConstructorParameters(Rule):
+    id = "discourage-nullable-constructor-parameters"
+    code = "SARJ468"
+    documentation: ClassVar[RuleDocumentation | None] = RuleDocumentation(
+        default_level=Severity.WARNING,
+        summary="Avoid nullable constructor parameters when a non-nullable interface can express the choice.",
+        rationale=(
+            "Nullable constructor parameters allow partially configured objects and force callers and implementations "
+            "to handle an absent value. Required nullable parameters still permit this state."
+        ),
+        remediation="Prefer a non-nullable dependency or a separate constructor for the absent case; suppress deliberate nullable values with a reason.",
+        category=RuleCategory.ARCHITECTURE,
+        autofix=AutofixPolicy.NONE,
+        limitations=(
+            "Only explicitly annotated `__init__` parameters using PEP 604 unions containing None are checked.",
+            "Tests and generated files are excluded; genuinely absent domain values may justify a suppression.",
+        ),
+        examples=(
+            RuleExample(
+                example_id="nullable-dependency",
+                title="Constructor permits a missing dependency",
+                outcome=ExampleOutcome.MATCH,
+                files=(
+                    ExampleFile.python(
+                        "app/service.py",
+                        "class Service:\n    def __init__(self, store: Store | None = None) -> None:\n"
+                        "        self.store = store\n",
+                    ),
+                ),
+                focus_path=PurePosixPath("app/service.py"),
+                expected_count=1,
+                public=True,
+            ),
+            RuleExample(
+                example_id="non-nullable-dependency",
+                title="Constructor requires a usable dependency",
+                outcome=ExampleOutcome.NO_MATCH,
+                files=(
+                    ExampleFile.python(
+                        "app/service.py",
+                        "class Service:\n    def __init__(self, store: Store) -> None:\n        self.store = store\n",
+                    ),
+                ),
+                focus_path=PurePosixPath("app/service.py"),
+                expected_count=0,
+                public=True,
+            ),
+        ),
+    )
+    description = documentation.summary
+
+    @override
+    def check_context(self, context: PythonFileContext) -> list[Diagnostic]:
+        if context.generated or context.tree is None or is_test_path(context.path):
+            return []
+        findings: list[Diagnostic] = []
+        for node in ast.walk(context.tree):
+            if not isinstance(node, ast.ClassDef):
+                continue
+            for method in node.body:
+                if not isinstance(method, ast.FunctionDef | ast.AsyncFunctionDef) or method.name != "__init__":
+                    continue
+                positional = method.args.posonlyargs + method.args.args
+                for parameter in (*positional, *method.args.kwonlyargs):
+                    self._append_if_nullable(context, parameter, findings)
+        return findings
+
+    def _append_if_nullable(
+        self,
+        context: PythonFileContext,
+        parameter: ast.arg,
+        findings: list[Diagnostic],
+    ) -> None:
+        if parameter.annotation is None or not _is_nullable_union(parameter.annotation):
+            return
+        findings.append(
+            Diagnostic(
+                path=context.path,
+                line=parameter.lineno,
+                col=parameter.col_offset + 1,
+                code=self.code,
+                severity=Severity.WARNING,
+                message=f"Constructor parameter `{parameter.arg}` accepts None; prefer a non-nullable interface.",
+            )
+        )
+
+
+def _is_nullable_union(annotation: ast.expr) -> bool:
+    if not isinstance(annotation, ast.BinOp) or not isinstance(annotation.op, ast.BitOr):
+        return False
+    return _is_none_union_member(annotation.left) or _is_none_union_member(annotation.right)
+
+
+def _is_none_union_member(annotation: ast.expr) -> bool:
+    if isinstance(annotation, ast.BinOp) and isinstance(annotation.op, ast.BitOr):
+        return _is_none_union_member(annotation.left) or _is_none_union_member(annotation.right)
+    return isinstance(annotation, ast.Constant) and annotation.value is None

{sarj_python_lint-1.7.6 → sarj_python_lint-1.7.8}/src/sarj_python_lint/rules/no_psycopg_execution_outside_injected_owner.py

@@ -20,7 +20,6 @@ from sarj_python_lint.rule_base import (
 )
 from sarj_python_lint.rules._ast_index import walk as walk_ast
 from sarj_python_lint.rules._imports import ImportIndex
-from sarj_python_lint.rules._paths import is_test_path, is_test_support_path
 
 
 if TYPE_CHECKING:
@@ -38,7 +37,7 @@ _EXECUTE_METHODS = frozenset({"execute", "executemany"})
 _REFLECTIVE_WRITE_ARG_COUNT = 2
 _LANGUAGE_ROOT_PATH_DEPTH = 2
 _PACKAGE_ROOT_PATH_DEPTH = 3
-_OPERATIONAL_ROOTS = frozenset({"backfill", "backfills", "bin", "scripts", "test_support", "tools"})
+_OPERATIONAL_ROOTS = frozenset({"backfill", "backfills", "bin", "scripts", "tools"})
 
 
 class _Origin(StrEnum):
@@ -87,7 +86,7 @@ class NoPsycopgExecutionOutsideInjectedOwner(Rule):
         limitations=(
             "Only import-proven psycopg Connection or AsyncConnection and psycopg_pool ConnectionPool or AsyncConnectionPool flows are classified.",
             "Straightforward constructor injection, connection and cursor context managers, aliases, rebindings, and conservative control-flow joins are followed; interprocedural flows remain unreported.",
-            "Tests, test support, migrations, generated files, conventional operational-script roots, and literal SELECT 1 probes are excluded.",
+            "Collected test modules, conftest.py, migrations, generated files, conventional operational-script roots, and literal SELECT 1 probes are excluded. Shared test-support helpers must use an injected owner.",
         ),
         examples=(
             RuleExample(
@@ -126,10 +125,10 @@ class NoPsycopgExecutionOutsideInjectedOwner(Rule):
     def check_context(self, context: PythonFileContext) -> list[Diagnostic]:
         path = context.path
         path_parts = {part.lower() for part in path.parts}
+        collected_test = path.name == "conftest.py" or path.name.startswith("test_") or path.name.endswith("_test.py")
         if (
             context.generated
-            or is_test_path(path)
-            or is_test_support_path(path)
+            or collected_test
             or not path_parts.isdisjoint({"migration", "migrations"})
             or _is_operational_path(path)
         ):