sarj-python-lint 1.27.0__tar.gz → 1.27.2__tar.gz

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: sarj-python-lint
-Version: 1.27.0
+Version: 1.27.2
 Summary: Custom Python lint rules — AST-based, pre-commit-friendly, hypermodern defaults
 Project-URL: Homepage, https://code-standards.sarj.ai/rules/python/
 Project-URL: Documentation, https://code-standards.sarj.ai/rules/python/
@@ -19,7 +19,7 @@ Classifier: Topic :: Software Development :: Quality Assurance
 Requires-Python: >=3.14
 Requires-Dist: packaging==26.3
 Requires-Dist: ruff>=0.16.10
-Requires-Dist: sarj-rule-contracts==0.2.1
+Requires-Dist: sarj-rule-contracts==0.2.2
 Requires-Dist: sqlglot==30.19.0
 Requires-Dist: typer==0.27.2
 Description-Content-Type: text/markdown

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "sarj-python-lint"
-version = "1.27.0"
+version = "1.27.2"
 description = "Custom Python lint rules — AST-based, pre-commit-friendly, hypermodern defaults"
 readme = "README.md"
 authors = [{ name = "sarj-ai" }]
@@ -15,7 +15,7 @@ classifiers = [
   "Programming Language :: Python :: 3.14",
   "Topic :: Software Development :: Quality Assurance",
 ]
-dependencies = ["sarj-rule-contracts==0.2.1", "packaging==26.3", "ruff>=0.16.10", "sqlglot==30.19.0", "typer==0.27.2"]
+dependencies = ["sarj-rule-contracts==0.2.2", "packaging==26.3", "ruff>=0.16.10", "sqlglot==30.19.0", "typer==0.27.2"]
 
 [project.scripts]
 sarj-python-lint = "sarj_python_lint.__main__:main"

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/__init__.py

@@ -1,2 +1,3 @@
 from sarj_python_lint._ratchet_cli import run_ratchet as run_ratchet
+from sarj_python_lint._source import python_source_encoding as python_source_encoding
 from sarj_python_lint._version import __version__ as __version__

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/__main__.py

@@ -434,7 +434,7 @@ def _apply_baseline(
 def _run_check(rule: list[str], files: list[Path], baseline: Path | None, update_baseline: Path | None) -> int:
     try:
         diags = analyze(rule, files)
-    except (OSError, ValueError) as exc:
+    except (OSError, ValueError, SyntaxError) as exc:
         sys.stderr.write(f"error: {exc}\n")
         return 2
     if update_baseline is not None:

sarj_python_lint-1.27.2/src/sarj_python_lint/_source.py

@@ -0,0 +1,18 @@
+from __future__ import annotations
+
+from io import BytesIO
+import tokenize
+from typing import TYPE_CHECKING
+
+
+if TYPE_CHECKING:
+    from pathlib import Path
+
+
+def python_source_encoding(data: bytes) -> str:
+    return tokenize.detect_encoding(BytesIO(data).readline)[0]
+
+
+def read_python_source(path: Path) -> str:
+    with tokenize.open(path) as stream:
+        return stream.read()

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/ratchet.py

@@ -9,7 +9,7 @@ import tokenize
 from types import MappingProxyType
 from typing import TYPE_CHECKING, Final, NamedTuple, TypeGuard
 
-from sarj_python_lint._source import PYTHON_SOURCE_ENCODING
+from sarj_python_lint._source import read_python_source
 from sarj_python_lint.json_boundary import is_object_mapping, parse_json
 
 
@@ -330,8 +330,8 @@ def _python_files(root: Path, excluded_dir_names: frozenset[str]) -> Iterator[Pa
 
 def _read(path: Path) -> str:
     try:
-        return path.read_text(encoding=PYTHON_SOURCE_ENCODING)
-    except UnicodeDecodeError, OSError:
+        return read_python_source(path)
+    except UnicodeError, OSError, SyntaxError:
         return ""
 
 

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/rules/_fastapi.py

@@ -841,7 +841,7 @@ def _read_module(path: Path, cache: dict[Path, ast.Module | None]) -> ast.Module
             tree = None
         else:
             tree = ast.parse(read_python_source(path), filename=str(path))
-    except OSError, SyntaxError:
+    except OSError, SyntaxError, UnicodeError:
         tree = None
     cache[path] = tree
     return tree

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/rules/_local_source.py

@@ -5,7 +5,7 @@ from dataclasses import dataclass
 from pathlib import Path
 from typing import TYPE_CHECKING, final
 
-from sarj_python_lint._source import PYTHON_SOURCE_ENCODING
+from sarj_python_lint._source import python_source_encoding
 from sarj_python_lint.rules._imports import ImportIndex
 
 
@@ -114,7 +114,7 @@ def _read_module(path: Path) -> LocalModule | None:
             data = stream.read(_MAX_MODULE_BYTES + 1)
         if len(data) > _MAX_MODULE_BYTES:
             return None
-        source = data.decode(PYTHON_SOURCE_ENCODING)
+        source = data.decode(python_source_encoding(data))
         tree = ast.parse(source, filename=str(path))
     except OSError, UnicodeError, SyntaxError:
         return None

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/rules/_nominal_project.py

@@ -11,7 +11,7 @@ from typing import TYPE_CHECKING, TypeGuard, final
 from packaging.requirements import InvalidRequirement, Requirement
 from packaging.utils import canonicalize_name
 
-from sarj_python_lint._source import PYTHON_SOURCE_ENCODING
+from sarj_python_lint._source import read_python_source
 from sarj_python_lint.rules._first_party import distribution_root
 from sarj_python_lint.rules._imports import ImportIndex
 from sarj_python_lint.rules._paths import is_generated
@@ -265,10 +265,10 @@ def _source(path: Path) -> NominalSource | None:
     try:
         if path.is_symlink() or path.stat().st_size > _MAX_BYTES:
             return None
-        text = path.read_text(encoding=PYTHON_SOURCE_ENCODING)
+        text = read_python_source(path)
         if is_generated(path, text):
             return None
-    except OSError, UnicodeError:
+    except OSError, UnicodeError, SyntaxError:
         return None
     return NominalSource(path, text)
 

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/rules/_project_index.py

@@ -534,7 +534,7 @@ def _read_bounded_source(root: Path, path: Path) -> LoadedSource | None:
         resolved = path.resolve()
         resolved.relative_to(root.resolve())
         return LoadedSource(resolved, read_python_source(resolved))
-    except OSError, ValueError:
+    except OSError, ValueError, SyntaxError:
         return None
 
 

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/rules/invalid_pydantic_field_default.py

@@ -690,7 +690,7 @@ def _read_module(path: Path) -> ast.Module | None:
         if path.stat().st_size > _MAX_IMPORTED_MODULE_BYTES:
             return None
         tree = ast.parse(read_python_source(path), filename=str(path))
-    except OSError, SyntaxError:
+    except OSError, SyntaxError, UnicodeError:
         return None
     return tree
 

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/rules/no_hidden_constructor_fallback.py

@@ -720,7 +720,7 @@ def _read_module(path: Path, facts: RuntimeConfigFacts) -> ast.Module:
         return cached
     try:
         tree = ast.parse(read_python_source(path), filename=str(path))
-    except OSError, SyntaxError:
+    except OSError, SyntaxError, UnicodeError:
         tree = ast.Module(body=[], type_ignores=[])
     facts.modules[path] = tree
     return tree
@@ -783,7 +783,7 @@ def _candidate_calls_class(
         return False
     try:
         source = read_python_source(candidate)
-    except OSError:
+    except OSError, SyntaxError, UnicodeError:
         return False
     if class_name not in source or is_generated(candidate, source):
         return False

{sarj_python_lint-1.27.0 → sarj_python_lint-1.27.2}/src/sarj_python_lint/rules/require_injectable_retry_sleep.py

@@ -29,7 +29,7 @@ _POLICIES: Final = frozenset(
 )
 _WAIT_MODULES: Final = frozenset({"tenacity", "tenacity.wait"})
 _WALL_CLOCK_SLEEPS: Final = frozenset(
-    {"asyncio.sleep", "anyio.sleep", "trio.sleep", "time.sleep", "tenacity.nap.sleep"}
+    {"asyncio.sleep", "anyio.sleep", "trio.sleep", "time.sleep", "tenacity.sleep", "tenacity.nap.sleep"}
 )
 _MESSAGE: Final = (
     "this tenacity policy waits between attempts on the wall clock without a sleep= seam; pass an injected sleep "
@@ -58,8 +58,8 @@ class RequireInjectableRetrySleep(Rule):
         autofix=AutofixPolicy.NONE,
         limitations=(
             "Only calls to tenacity.retry, tenacity.Retrying, and tenacity.AsyncRetrying resolved through imports are inspected; bare @retry, positional arguments, and **kwargs expansion abstain.",
-            "A wait is reported only when it is built inline from tenacity wait_* calls, optionally combined with +; wait_none() and wait_fixed(0) do not wait. A wait read from a name, attribute, or other call is treated as injected.",
-            "Any sleep= argument other than a wall-clock sleep imported from asyncio, anyio, trio, time, or tenacity.nap counts as a seam; the rule does not prove that tests replace it.",
+            "A wait is reported only when it is built inline from tenacity wait_* calls, optionally combined with +; wait_none(), literal-zero wait_fixed and wait_random calls, and known zero-only wait_combine or wait_chain calls do not wait. A wait read from a name, attribute, or other call is treated as injected.",
+            "Any sleep= argument other than a wall-clock sleep imported from asyncio, anyio, trio, time, tenacity, or tenacity.nap counts as a seam; the rule does not prove that tests replace it.",
             "The backoff library has no sleep parameter, so its decorators are not inspected. Test modules, test directories, conftest.py, test-support paths, and generated files are excluded.",
         ),
         examples=(
@@ -143,20 +143,55 @@ def _waits_without_seam(call: ast.Call, imports: ImportIndex) -> bool:
 def _wait_strategy(node: ast.expr, imports: ImportIndex) -> bool | None:
     match node:
         case ast.BinOp(left=left, op=ast.Add(), right=right):
-            parts = (_wait_strategy(left, imports), _wait_strategy(right, imports))
-            return None if None in parts else any(parts)
+            return _combined_waits((left, right), imports)
         case ast.Call(func=func, args=args, keywords=keywords):
             module, _, strategy = (imports.resolved_qualified_name(func) or "").rpartition(".")
             if module not in _WAIT_MODULES or not strategy.startswith("wait_"):
                 return None
-            match strategy, args, keywords:
-                case "wait_none", [], []:
-                    return False
-                case "wait_fixed", [ast.Constant(value=0)], []:
-                    return False
-                case "wait_fixed", [], [ast.keyword(arg="wait", value=ast.Constant(value=0))]:
-                    return False
-                case _:
-                    return True
+            return _wait_constructor(strategy, args, keywords, imports)
         case _:
             return None
+
+
+def _wait_constructor(
+    strategy: str, args: list[ast.expr], keywords: list[ast.keyword], imports: ImportIndex
+) -> bool | None:
+    match strategy, args, keywords:
+        case "wait_none", [], []:
+            return False
+        case ("wait_fixed", [value], []) | ("wait_fixed", [], [ast.keyword(arg="wait", value=value)]):
+            return not _literal_zero(value)
+        case "wait_random", _, _:
+            return _random_waits(args, keywords)
+        case "wait_combine" | "wait_chain", _, _:
+            if keywords or any(isinstance(argument, ast.Starred) for argument in args):
+                return None
+            if strategy == "wait_chain" and not args:
+                return None
+            return _combined_waits(tuple(args), imports)
+        case _:
+            return True
+
+
+def _combined_waits(nodes: tuple[ast.expr, ...], imports: ImportIndex) -> bool | None:
+    parts = tuple(_wait_strategy(node, imports) for node in nodes)
+    return None if None in parts else any(parts)
+
+
+def _random_waits(args: list[ast.expr], keywords: list[ast.keyword]) -> bool | None:
+    names = ("min", "max")
+    if len(args) > len(names) or any(isinstance(argument, ast.Starred) for argument in args):
+        return None
+    values = dict(zip(names, args, strict=False))
+    for keyword in keywords:
+        if keyword.arg not in names or keyword.arg in values:
+            return None
+        values[keyword.arg] = keyword.value
+    return not (("min" not in values or _literal_zero(values["min"])) and _literal_zero(values.get("max")))
+
+
+def _literal_zero(node: ast.expr | None) -> bool:
+    if isinstance(node, ast.UnaryOp) and isinstance(node.op, (ast.UAdd, ast.USub)):
+        operand = node.operand
+        return isinstance(operand, ast.Constant) and isinstance(operand.value, (int, float)) and operand.value == 0
+    return isinstance(node, ast.Constant) and node.value == 0

sarj_python_lint-1.27.0/src/sarj_python_lint/_source.py

@@ -1,14 +0,0 @@
-from __future__ import annotations
-
-from typing import TYPE_CHECKING, Final
-
-
-if TYPE_CHECKING:
-    from pathlib import Path
-
-
-PYTHON_SOURCE_ENCODING: Final = "utf-8-sig"
-
-
-def read_python_source(path: Path) -> str:
-    return path.read_text(encoding=PYTHON_SOURCE_ENCODING, errors="replace")