sarj-python-lint 1.25.1__tar.gz → 1.25.3__tar.gz

{sarj_python_lint-1.25.1 → sarj_python_lint-1.25.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: sarj-python-lint
-Version: 1.25.1
+Version: 1.25.3
 Summary: Custom Python lint rules — AST-based, pre-commit-friendly, hypermodern defaults
 Project-URL: Homepage, https://code-standards.sarj.ai/rules/python/
 Project-URL: Documentation, https://code-standards.sarj.ai/rules/python/

{sarj_python_lint-1.25.1 → sarj_python_lint-1.25.3}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "sarj-python-lint"
-version = "1.25.1"
+version = "1.25.3"
 description = "Custom Python lint rules — AST-based, pre-commit-friendly, hypermodern defaults"
 readme = "README.md"
 authors = [{ name = "sarj-ai" }]

{sarj_python_lint-1.25.1 → sarj_python_lint-1.25.3}/src/sarj_python_lint/rules/prefer_collection_comprehension.py

@@ -113,7 +113,8 @@ class PreferCollectionComprehension(Rule):
                 "Comments, loop-target leakage, try blocks, aliases, complex projections, and replacements that "
                 "do not fit a 120-column line or a simple formatter-style multiline comprehension are excluded. "
                 "Namespace observers, explicit inspect/sys frame access, and collections referenced by nested functions "
-                "are excluded. No autofix is offered because dict key/value evaluation order can differ."
+                "are excluded. Dynamic function aliases and helper-hidden frame reads are not resolved. "
+                "No autofix is offered because dict key/value evaluation order can differ."
             ),
             (
                 "Attribute projections can invoke properties or descriptors, so reviewers should keep the loop "
@@ -675,7 +676,7 @@ def _owner_bindings(owner: _Callable, namespace_observers: frozenset[int]) -> _O
 def _namespace_observer_calls(context: PythonFileContext) -> frozenset[int]:
     observers = {
         "builtins": {"locals", "vars", "eval", "exec"},
-        "inspect": {"currentframe"},
+        "inspect": {"currentframe", "stack", "trace", "getouterframes", "getinnerframes", "getargvalues"},
         "sys": {"_getframe"},
     }
     # Explicit aliases remain conservative exclusions even when another scope shadows them.
@@ -686,14 +687,21 @@ def _namespace_observer_calls(context: PythonFileContext) -> frozenset[int]:
             if alias.name in observers:
                 modules[alias.asname or alias.name].update(observers[alias.name])
     for node in context.nodes(ast.ImportFrom):
-        if node.module not in observers:
-            continue
-        symbols.update(alias.asname or alias.name for alias in node.names if alias.name in observers[node.module])
+        symbols.update(_observer_import_symbols(node, observers))
     return frozenset(
         id(call) for call in context.nodes(ast.Call) if _is_namespace_observer(call.func, symbols, modules)
     )
 
 
+def _observer_import_symbols(node: ast.ImportFrom, observers: dict[str, set[str]]) -> set[str]:
+    if node.level or node.module not in observers:
+        return set()
+    # These inspect observers are public wildcard exports; sys._getframe is not.
+    if node.module == "inspect" and any(alias.name == "*" for alias in node.names):
+        return observers["inspect"]
+    return {alias.asname or alias.name for alias in node.names if alias.name in observers[node.module]}
+
+
 def _is_namespace_observer(function: ast.expr, symbols: set[str], modules: dict[str, set[str]]) -> bool:
     match function:
         case ast.Name(id=name):

{sarj_python_lint-1.25.1 → sarj_python_lint-1.25.3}/src/sarj_python_lint/rules/require_port_for_service.py

@@ -369,7 +369,7 @@ class RequirePortForService(ProjectRule):
         source_lines = context.source_lines
         data_names = {node.name for node in classes if is_data_type(node)}
         local_class_names = {node.name for node in classes}
-        local_port_names = _local_port_names(classes)
+        local_port_names = _local_port_names(classes, imports)
         factory_facts = _factory_class_facts(tree, classes, context.module_imports)
 
         diags: list[Diagnostic] = []
@@ -823,7 +823,9 @@ def _factory_class_identity(node: ast.ClassDef, imports: ImportIndex) -> bool:
 
 def _factory_interface(node: ast.ClassDef, imports: ImportIndex) -> bool:
     return any(
-        imports.resolves(base, sources=TYPING_SOURCES, symbol="Protocol")
+        imports.resolves(
+            base.value if isinstance(base, ast.Subscript) else base, sources=TYPING_SOURCES, symbol="Protocol"
+        )
         or imports.resolves(base, sources=ABC_SOURCES, symbol="ABC")
         for base in node.bases
     ) or any(
@@ -1246,12 +1248,17 @@ def _dotted_tail(node: ast.expr) -> str | None:
             return None
 
 
-def _local_port_names(classes: list[ast.ClassDef]) -> set[str]:
+def _local_port_names(classes: list[ast.ClassDef], imports: ImportIndex) -> set[str]:
     local_port_names = {
         node.name
         for node in classes
         if _BASE_NAME_RE.match(node.name)
         or _declares_interface(node)
+        or _factory_interface(node, imports)
+        or any(
+            keyword.arg == "metaclass" and imports.resolves(keyword.value, sources=ABC_SOURCES, symbol="ABCMeta")
+            for keyword in node.keywords
+        )
         or any(_dotted_tail(base) in {"ABC", "Protocol"} for base in node.bases)
         or any(keyword.arg == "metaclass" and _dotted_tail(keyword.value) == "ABCMeta" for keyword in node.keywords)
     }