sanka-cli 0.2.5__tar.gz → 0.2.6__tar.gz

{sanka_cli-0.2.5 → sanka_cli-0.2.6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: sanka-cli
-Version: 0.2.5
+Version: 0.2.6
 Summary: Sanka command-line interface and migration runtime
 Project-URL: Repository, https://github.com/sankaHQ/sanka
 Project-URL: Issues, https://github.com/sankaHQ/sanka/issues

{sanka_cli-0.2.5 → sanka_cli-0.2.6}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "sanka-cli"
-version = "0.2.5"
+version = "0.2.6"
 description = "Sanka command-line interface and migration runtime"
 readme = "README.md"
 requires-python = ">=3.12"

{sanka_cli-0.2.5 → sanka_cli-0.2.6}/src/sanka/runtime/execution/report_codec.py

@@ -207,6 +207,15 @@ def canonical_route_manifest(raw: Any) -> MappingRouteManifest:
                 code="SANKA_MIGRATE_ROUTE_MANIFEST_INVALID",
             )
         seen.add(route_key)
+        identity_fields = item.get("identityFields", [])
+        if not isinstance(identity_fields, list) or any(
+            not isinstance(value, str) or not value.strip() or value != value.strip()
+            for value in identity_fields
+        ):
+            raise ExecutionFault(
+                "The saved Sanka route manifest contains invalid identity fields.",
+                code="SANKA_MIGRATE_ROUTE_MANIFEST_INVALID",
+            )
         normalized.append(
             {
                 "routeKey": route_key,
@@ -215,6 +224,7 @@ def canonical_route_manifest(raw: Any) -> MappingRouteManifest:
                 "sourceFilter": (
                     _source_filter_payload(source_filter) if source_filter is not None else None
                 ),
+                **({"identityFields": sorted(set(identity_fields))} if identity_fields else {}),
             }
         )
     return sorted(normalized, key=lambda row: str(row["routeKey"]))

{sanka_cli-0.2.5 → sanka_cli-0.2.6}/src/sanka_cli/__init__.py

@@ -1,4 +1,4 @@
 # SPDX-License-Identifier: Apache-2.0
 __all__ = ["__version__"]
 
-__version__ = "0.2.5"
+__version__ = "0.2.6"

{sanka_cli-0.2.5 → sanka_cli-0.2.6}/tests/test_cli.py

@@ -617,7 +617,7 @@ def test_research_client_uses_public_branded_base_and_unwraps_data() -> None:
         "after": ["2027-01"],
         "locale": ["ja"],
     }
-    assert request.get_header("User-agent") == "sanka-cli/0.2.5"
+    assert request.get_header("User-agent") == "sanka-cli/0.2.6"
     assert timeout == 10.0
 
 

{sanka_cli-0.2.5 → sanka_cli-0.2.6}/tests/test_execution_report_codec.py

@@ -604,7 +604,7 @@ def test_route_progress_keys_are_validated_by_the_remap() -> None:
 
 def test_canonical_route_manifest_sorts_rows_and_drops_extra_keys() -> None:
     rows = list(reversed(_filtered_manifest()))
-    rows[0] = {**rows[0], "identityFields": ["email"]}  # v0 manifest extra key
+    rows[0] = {**rows[0], "unusedMetadata": "ignored"}
     normalized = canonical_route_manifest(rows)
     assert [row["routeKey"] for row in normalized] == [FILTERED_ROUTE, "contacts|contacts"]
     assert all(
@@ -713,6 +713,60 @@ def test_execution_route_manifest_reads_the_saved_manifest() -> None:
     assert excinfo.value.code == "SANKA_MIGRATE_ROUTE_MANIFEST_MISSING"
 
 
+def test_identity_manifest_survives_mapping_validation_and_journal_round_trip() -> None:
+    from sanka.runtime.mapping.record_mapping import mapping_route_manifest
+
+    field = MigrationMappingField(
+        source_field="accounts.Domain",
+        target_object="companies",
+        target_field="domain",
+        identity=True,
+    )
+    groups: list[MappingGroup] = [("accounts", "companies", None, [field])]
+    saved = mapping_route_manifest(groups)
+    assert saved[0]["identityFields"] == ["domain"]
+    validated = require_matching_route_manifest(groups, saved)
+    assert validated == saved
+    report = _queued_report()
+    report["execution"]["routeManifest"] = validated
+    restored = _round_trip(report)
+    assert restored["execution"]["routeManifest"] == saved
+
+
+@pytest.mark.parametrize("identities", [["email"], [], None])
+def test_changed_or_removed_identities_reject_a_previously_reviewed_manifest(
+    identities: list[str] | None,
+) -> None:
+    field = MigrationMappingField(
+        source_field="accounts.Domain",
+        target_object="companies",
+        target_field="domain",
+        identity=True,
+    )
+    groups: list[MappingGroup] = [("accounts", "companies", None, [field])]
+    saved = _manifest()
+    if identities is not None:
+        saved[0]["identityFields"] = identities
+    with pytest.raises(ExecutionFault) as excinfo:
+        require_matching_route_manifest(groups, saved)
+    assert excinfo.value.code == "SANKA_MIGRATE_ROUTE_MANIFEST_CHANGED"
+
+
+@pytest.mark.parametrize("identities", [None, "email", [1], [""], [" email"], {}])
+def test_invalid_identity_fields_fail_closed(identities: Any) -> None:
+    saved = _manifest()
+    saved[0]["identityFields"] = identities
+    with pytest.raises(ExecutionFault) as excinfo:
+        canonical_route_manifest(saved)
+    assert excinfo.value.code == "SANKA_MIGRATE_ROUTE_MANIFEST_INVALID"
+
+
+def test_identity_order_and_duplicates_are_canonical() -> None:
+    saved = _manifest()
+    saved[0]["identityFields"] = ["external_id", "email", "email"]
+    assert canonical_route_manifest(saved)[0]["identityFields"] == ["email", "external_id"]
+
+
 # -- route selection -----------------------------------------------------------
 
 

{sanka_cli-0.2.5 → sanka_cli-0.2.6}/tests/test_mcp.py

@@ -21,7 +21,7 @@ def test_root_version_uses_unified_public_version(runner: CliRunner) -> None:
     result = runner.invoke(cli, ["--version"])
 
     assert result.exit_code == 0
-    assert result.output == "sanka, version 0.2.5\n"
+    assert result.output == "sanka, version 0.2.6\n"
 
 
 def test_mcp_client_uses_the_cli_version_in_its_user_agent() -> None:
@@ -29,7 +29,7 @@ def test_mcp_client_uses_the_cli_version_in_its_user_agent() -> None:
 
     client = SankaMigrateApiClient()
 
-    assert client._client.headers["User-Agent"] == "sanka-cli/0.2.5"
+    assert client._client.headers["User-Agent"] == "sanka-cli/0.2.6"
 
 
 def test_mcp_without_extra_has_install_hint(

{sanka_cli-0.2.5 → sanka_cli-0.2.6}/tests/test_sanka_facade.py

@@ -35,7 +35,7 @@ def test_public_facade_version_matches_unified_distribution() -> None:
         == sanka_cli.__version__
         == sanka_cli.mcp.__version__
         == distribution_version("sanka-cli")
-        == "0.2.5"
+        == "0.2.6"
     )